That makes sense. I'll do that with automatic refactoring in Netbeans. Do you
want me to send another webrev afterwards?
Thanks,
Sasha
- Original Message -
From: xuelei@oracle.com
To: alexandre.boulga...@oracle.com
Cc: joe.da...@oracle.com, core-libs-dev@openjdk.java.net
Sent: Monday
On 8/9/2011 3:55 PM, Alexandre Boulgakov wrote:
> That makes sense. I'll do that with automatic refactoring in Netbeans. Do you
> want me to send another webrev afterwards?
>
Just to confirm, you will change LdapNameClassPairEnumeration back to
LdapNamingEnumeration, and will not change the name
A few months back there was a bug report [1] pointing out that it's
possible to continue writing to a BufferedWriter after invoking its
close method and the close fails. A similar issue arises with
BufferedOutputStream and other classes. At issue is whether a stream (or
more generally a resou
Hi,
This test creates temporary directories in the scratch area with spaces
in their names. It fails on Cygwin because jtreg cannot cleanup after
it. Easiest to just have the test cleanup (minimally) after itself.
Webrev:
http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/
Thanks,
On 08/09/2011 01:43 PM, Alan Bateman wrote:
A few months back there was a bug report [1] pointing out that it's
possible to continue writing to a BufferedWriter after invoking its
close method and the close fails. A similar issue arises with
BufferedOutputStream and other classes. At issue is
Sorry, should have cc'ed serviceability-...@openjdk.java.net too.
-Chris.
Original Message
Subject: Code Review 7073295: TEST_BUG:
test/java/lang/instrument/ManifestTest.sh causing havoc (win)
Date: Tue, 09 Aug 2011 14:05:08 +0100
From: Chris Hegarty
To: core-libs-dev ,
"al
Hi Dan, Alan,
This is a trivial change to use /dev/null instead of NUL for Windows
test with Cygwin.
http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/
Thanks,
-Chris.
Chris Hegarty wrote:
Hi Dan, Alan,
This is a trivial change to use /dev/null instead of NUL for Windows
test with Cygwin.
http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/
Thanks,
-Chris.
Looks okay although it might be slightly cleaner to set devnull
consistently, ie:
case Win
Looks good.
Mandy
On 8/9/11 6:05 AM, Chris Hegarty wrote:
Hi,
This test creates temporary directories in the scratch area with
spaces in their names. It fails on Cygwin because jtreg cannot cleanup
after it. Easiest to just have the test cleanup (minimally) after itself.
Webrev:
http://c
Changeset: 26fe74aa48ef
Author:chegar
Date: 2011-08-09 16:39 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/26fe74aa48ef
7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win)
Reviewed-by: mchung
! test/java/lang/instrument/ManifestTest.sh
On 8/9/11 8:52 AM, Chris Hegarty wrote:
Hi Dan, Alan,
This is a trivial change to use /dev/null instead of NUL for Windows
test with Cygwin.
http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/
Thanks,
-Chris.
I'm good with the change, but the bug report itself is less than clear.
Sorry Dan, I'll put a more complete description in the bug report.
This issue, from what I can tell only happens with very recent Cygwin
versions. I'm running 1.7.9. When running the com/sun/jdi tests in a
batch, in samevm mode, this test leave behind a file, NUL, in the
scratch directory that
Changeset: cf203f293b4e
Author:chegar
Date: 2011-08-09 16:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf203f293b4e
7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in
Cygwin
Reviewed-by: alanb, dcubed
! test/com/sun/jdi/ShellScaffold.sh
On 8/9/11 8:29 AM, Chris Hegarty wrote:
Sorry, should have cc'ed serviceability-...@openjdk.java.net too.
-Chris.
Original Message
Subject: Code Review 7073295: TEST_BUG:
test/java/lang/instrument/ManifestTest.sh causing havoc (win)
Date: Tue, 09 Aug 2011 14:05:08 +0100
From
Yes, "/dev/null" works with the "1.5.X" version of Cygwin.
1.5.X is considered the "legacy" version of Cygwin and I
believe the VM/SQE is still using it in the nightly testing
infrastructure.
Dan
547 2011.08.09 10:22:32 $ uname -a
CYGWIN_NT-5.1 oliver-lt 1.5.25(0.156/4/2) 2008-06-12 19:34 i686 C
Will this work on older versions of cygwin? Or do we have a spec someplace that says cygwin
versions older than aren't supported?
- jjh
On 8/9/2011 8:56 AM, Chris Hegarty wrote:
Sorry Dan, I'll put a more complete description in the bug report.
This issue, from what I can tell only happ
On 08/ 9/11 05:18 PM, Jim Holmlund wrote:
Will this work on older versions of cygwin? Or do we have a spec
someplace that says cygwin versions older than aren't supported?
I have not seen any docs/spec anywhere for support of /dev/null in
specific Cygwin releases, but I did test on 1.5 a
Yes, "/dev/null" works with the "1.5.X" version of Cygwin.
1.5.X is considered the "legacy" version of Cygwin and I
believe the VM/SQE is still using it in the nightly testing
infrastructure.
Dan
Ok thanks Chris and Dan. When I created ShellScaffold.sh long ago and far away, it must have bee
This change looks good. I don't believe a compatibility switch for the
FilterOutputStream is warranted.
On Aug 9 2011, at 04:43 , Alan Bateman wrote:
>
> A few months back there was a bug report [1] pointing out that it's possible
> to continue writing to a BufferedWriter after invoking its cl
On 08/ 9/11 05:11 PM, Daniel D. Daugherty wrote:
On 8/9/11 8:29 AM, Chris Hegarty wrote:
Sorry, should have cc'ed serviceability-...@openjdk.java.net too.
-Chris.
Original Message
Subject: Code Review 7073295: TEST_BUG:
test/java/lang/instrument/ManifestTest.sh causing havoc
Thanks for closing the loop. The changes are good as is.
Dan
On 8/9/11 2:02 PM, Chris Hegarty wrote:
On 08/ 9/11 05:11 PM, Daniel D. Daugherty wrote:
On 8/9/11 8:29 AM, Chris Hegarty wrote:
Sorry, should have cc'ed serviceability-...@openjdk.java.net too.
-Chris.
Original Message
Hi David,
it would be nice to have some help on this.
I started fixing InternalError yesterday [1] and discovered that this
job is for someone with much industrousness (hope the translation is
somewhat correct).
First of all a quick look at [1] would be good.
And most imported someone of the
Sebastian Sickelmann wrote:
Hi David,
it would be nice to have some help on this.
I started fixing InternalError yesterday [1] and discovered that this
job is for someone with much industrousness (hope the translation is
somewhat correct).
First of all a quick look at [1] would be good.
And
On 8/9/2011 2:53 AM, Xuelei Fan wrote:
On 8/9/2011 3:55 PM, Alexandre Boulgakov wrote:
That makes sense. I'll do that with automatic refactoring in Netbeans. Do you
want me to send another webrev afterwards?
Just to confirm, you will change LdapNameClassPairEnumeration back to
LdapNamingEnum
24 matches
Mail list logo
