hg: jdk8/tl/jdk: 7123582: (launcher) display the -version and -XshowSettings

2012-01-03 Thread kumar . x . srinivasan
Changeset: 8952a5f494f9 Author:ksrini Date: 2012-01-03 08:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8952a5f494f9 7123582: (launcher) display the -version and -XshowSettings Reviewed-by: alanb ! src/share/bin/java.c ! test/tools/launcher/Settings.java

hg: jdk8/tl/jdk: 7124443: (launcher) test DefaultsLocaleTest fails with Windows shells.

2012-01-03 Thread kumar . x . srinivasan
Changeset: 5e34726cb4bb Author:ksrini Date: 2012-01-03 08:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e34726cb4bb 7124443: (launcher) test DefaultsLocaleTest fails with Windows shells. Reviewed-by: darcy ! test/tools/launcher/DefaultLocaleTest.java - test/tools/launch

Review request for #6783209

2012-01-03 Thread Brandon Passanisi
Hello core-libs-dev. Can someone please do a code review of the following proposed fix for 6783209 : (fmt)Formatter doesn't support width for %%. Webrev : http://cr.openjdk.java.net/~bpassani/6783209/0/webrev/ Bug URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6783209 The fix i

Re: 7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo

2012-01-03 Thread Kelly O'Hair
So you have a review from me. I think you need to send this CR/webrev and request for approval to the jdk7u-...@openjdk.java.net alias for 7u4 Or did you do that already? Hopefully we can fix this drop stuff before 12/12/12 and the end of the world. 8^{ -kto On Dec 30, 2011, at 10:11 AM, J

Re: Known issue? java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java

2012-01-03 Thread Kelly O'Hair
On Dec 31, 2011, at 2:31 AM, Alan Bateman wrote: > On 31/12/2011 01:31, Kelly O'Hair wrote: >> Just wondering if anyone has seen this testcase failure. >> I'm using Fedora 9 x86. >> >> -kto >> : >> >> Test DatagramChannel to INET socket >> join 225.4.5.6 @ virbr0 >> Send message from 192.168.12

hg: jdk8/tl/langtools: 4881269: improve diagnostic for ill-formed tokens

2012-01-03 Thread jonathan . gibbons
Changeset: 7a836147b266 Author:jjg Date: 2012-01-03 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a836147b266 4881269: improve diagnostic for ill-formed tokens Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/shar

Re: 7121110 : JAXP 1.4.5 update 1 for 7u4 & jaxp source in jdk7 repo

2012-01-03 Thread Joe Wang
If you meant this: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2011-December/001130.html Yes, I've gotten the approval from Edvard. Note that, the jaxp update itself (without the build change) was approved for 7u2. On 1/3/2012 11:16 AM, Kelly O'Hair wrote: So you have a review from me.

RE: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2012-01-03 Thread Robert Ottenhag
Adding to the review of jmm.h, that is modified in both the jdk part and the hotspot part, these files should be identical, without any differences in whitespace. Also, regarding whitespace and indentation, the use TAB characters in many files in the jdk patch makes jcheck complain (when trying

Re: JEP 103: Parallel Array Sorting - proposal, reaction to Mr. Harned post

2012-01-03 Thread Andrew Thompson
Both JEP 103 and JEP 108 are interesting to me because they remind me of something I've discussed a couple of times with one of the engineers working on the JDK at Apple. (I'll not name him solely because his input was a casual 'that sounds interesting' and I don't want to imply he endorses this

Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-03 Thread Kurt Miller
On 11/09/11 03:01, Jonathan Lu wrote: > On 11/04/2011 01:26 PM, David Holmes wrote: >> On 4/11/2011 2:53 PM, David Holmes wrote: >>> On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. >>

Re: webrevs.2 for macosx changes to jdk7u-osx

2012-01-03 Thread Henri Gomez
Where is the Mercurial URL for jdk7u-osx ? 2011/12/2 David Holmes : > > > > On 2/12/2011 11:30 AM, Paul Hohensee wrote: >> >> I agree. Be a good idea to ask for review from all the affected teams. >> I _think_ core libs is the only one we missed, though. > > > My concern is that there are a numbe

Warnings Cleanup in java.util. (more from hack day)

2012-01-03 Thread Michael Barker
Hi, We had some late submissions from our hack day participants. 2 more patches. One (j.u.z.ZipEntry) is possibly a little more involved for a warnings fix. It removes a usage of deprecated Date APIs in favour of Calendar. However, the fix results in code that is very similar to Apache Harmony

Re: webrevs.2 for macosx changes to jdk7u-osx

2012-01-03 Thread Henri Gomez
>> Where is the Mercurial URL for jdk7u-osx ? > > > Same place as all the other repos :) > > http://hg.openjdk.java.net/jdk7u/jdk7u-osx/ Nice, I'll try to build this one also :) Cheers

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2012-01-03 Thread Michael Barker
Hi Stuart, Thanks for picking up the review. >  - java/util/jar/JarFile.java >  - java/util/jar/Manifest.java [patch4] >  - java/util/logging/LogManager.java [patch2] >  - java/util/prefs/Preferences.java >  - java/util/prefs/XmlSupport.java >  - java/util/zip/ZipEntry.java [patch2] > > Did I get

Re: Request for Review (XXL): 7104647: Adding a diagnostic command framework

2012-01-03 Thread serguei.spit...@oracle.com
Hi Frederik, Your fix is already in a good shape! src/share/vm/services/management.cpp: It is better to have different diagnostic messages at lines 2181 and 2186 so that it is easy to find out what of the two lines caused an exception. The messages would be better to be more specific. T

Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-03 Thread Kurt Miller
On Monday 14 November 2011 03:40:01 am Jonathan Lu wrote: > Hi Kurt, > > On 11/10/2011 11:09 AM, Kurt Miller wrote: > > On 11/09/11 03:01, Jonathan Lu wrote: > >> On 11/04/2011 01:26 PM, David Holmes wrote: > >>> On 4/11/2011 2:53 PM, David Holmes wrote: > On 4/11/2011 2:13 PM, Masayoshi Okut

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2012-01-03 Thread Michael Barker
Hi, Attached is the latest LJC warnings patch. I've merged all of the changes into a single patch. The one I'm unsure of the comments on the @SuppressWarnings("deprecation") in the ZipEntry.java. I've been fairly terse and just mentioned that it's using the date methods/constructor. Regards, M

Re: 7116954: Misc warnings in java.beans/java.beans.context

2012-01-03 Thread Andrey Pikalev
Typically JavaBeans changes went into Swing (now AWT) gate. I don't think this really matter where to push this time assuming the changes will be propagated to AWT repo in a few weeks. Thanks, Andrey. On 12/1/2011 9:04 PM, Alan Bateman wrote: On 01/12/2011 16:33, Maurizio Cimadamore w

Re: Add Look&Feel support for AIX platform

2012-01-03 Thread neugens.limasoftw...@gmail.com
The change looks good to me as well. Cheers, Mario Inviato da HTC - Reply message - Da: "Deven" Data: mar, nov 29, 2011 02:55 Oggetto: Add Look&Feel support for AIX platform A: "Neil Richards" Cc: "Java Core Libs" , , On 10/20/2011 11:10 PM, Neil Richards wrote: > On Tue, 2011-10-

hg: jdk8/tl/corba: 7046238: new InitialContext(); hangs

2012-01-03 Thread dmitry . degrave
Changeset: 052dda3b5ce3 Author:dmeetry Date: 2011-12-18 22:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/052dda3b5ce3 7046238: new InitialContext(); hangs Summary: Synchronization on a single monitor for contactInfo parameters with identical hashCode() Reviewed-by: rob

RE: Request for Review: Warnings cleanup in java.lang.*, java.util.**

2012-01-03 Thread Xiomara Jayasena
Omair / Danesh, Here are the bug IDs: 7117605 Danesh 7117612 Omair Wiki has been updated. http://wikis.sun.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29 -Xiomara > -Original Message- > From: Omair Majid [mailto:oma...@redhat.com] > Sent: Friday, December 02, 2011 9:00

Re: Request for Review: Warnings cleanup in java.lang.*, java.util.**

2012-01-03 Thread Martijn Verburg
FYI - The London JUG did have java.util.regex listed, but we didn't have time to produce a patch for that area, so no clash there - Cheers, M On 2 December 2011 12:18, Alan Bateman wrote: > > cc'ing core-libs-dev as that is the place to discuss these changes. I see on > the sign-up sheet [1] that

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2012-01-03 Thread Michael Barker
> There is a rawtypes warning on the "new ArrayList()".  I can put a > specific type as the return value should match > "jv.getManifestDigests()", which is public so shouldn't be changed.  I Sorry that should read "I can't put a specific type...

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2012-01-03 Thread Michael Barker
>> I looked at the updated patch and it looks fine to me. There are other >> classes >> in j.u.jar and j.u.logging that also have warnings but fixing the warnings I only submitted the ones that we managed to work on during the hack day. If the team is happy to continue accepting fresh patches for

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2012-01-03 Thread Michael Barker
Hi, > scan of the webrev. There are still a couple of raw type warnings in JarFile > and several more in other classes in these packages so it's possible you > don't have everything (I wasn't following that thread closely on jdk8-dev). Question on a rawtypes fix. In one case there is method defi

100218: BigInteger staticRandom field

2012-01-03 Thread Paul Ciprich
All, I've created a bug report to address a scalability problem with BigInteger's staticRandom field. The problem is that the shared staticRandom field causes bottlenecks with parallel code. The proposed solution is to change the staticRandom field to a ThreadLocal and eliminate the bottleneck by

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2012-01-03 Thread Michael Barker
> Michael - the Contributed-by line is usually the individual's name (+ mail > address) or a list of names (and their mail addresses). I think Stuart is > suggesting that this would be better than "London Java Community". Okay, no problem: Contributed-by: Prasannaa , Martijn Verburg , Goerge_Albr

RE: Review request for #6783209

2012-01-03 Thread Iris Clark
Hi, Brandon. I am not a jdk8 Reviewer (http://openjdk.java.net/census#jdk8), but I am the original author. No time to check the spec now, but is precision ever applicable when the flag '%' is provided? If it is, then old line 2726 should probably just be changed to "print("%')". Rather than

Re: Review request for #6783209

2012-01-03 Thread Brandon Passanisi
Hi Iris. Answers below: On 1/3/2012 1:27 PM, Iris Clark wrote: Hi, Brandon. I am not a jdk8 Reviewer (http://openjdk.java.net/census#jdk8), but I am the original author. No time to check the spec now, but is precision ever applicable when the flag '%' is provided? If it is, then old line 2

Re: 100218: BigInteger staticRandom field

2012-01-03 Thread David Holmes
Hi Paul, For some reason this email, despite being dated Dec 14, only just appeared in my inbox on Jan 3! On 14/12/2011 12:44 AM, Paul Ciprich wrote: All, I've created a bug report to address a scalability problem with BigInteger's staticRandom field. The problem is that the shared staticRan

Re: 100218: BigInteger staticRandom field

2012-01-03 Thread David Holmes
On 4/01/2012 10:08 AM, David Holmes wrote: Hi Paul, For some reason this email, despite being dated Dec 14, only just appeared in my inbox on Jan 3! Oops! I missed the fact a copy of this email also turned up on Dec 15 and that I already replied to it. Comments still apply. Need to understa

hg: jdk8/tl/langtools: 7046929: tools/javac/api/T6397104.java fails

2012-01-03 Thread jim . holmlund
Changeset: a07eef109532 Author:jjh Date: 2012-01-03 17:18 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a07eef109532 7046929: tools/javac/api/T6397104.java fails Reviewed-by: jjg ! test/tools/javac/api/T6397104.java