Re: RFR [9]: 8050142: Optimize java.util.Formatter

2014-09-16 Thread Marcus Lagergren
I am reviewer and they look good to me too. ~30% better performance for random indata- Do you pass the JCK? If so you have my blessing. /M On 16 Sep 2014, at 01:52, Brent Christian wrote: > Hi, Claes > > I've looked over the latest changes, and they look good to me. I can sponsor > this. N

RFR JDK-8044627: Update JNDI to work with modules

2014-09-16 Thread Pavel Rappo
Hi everyone, Could you please review my change for JDK-8044627? http://cr.openjdk.java.net/~prappo/8044627/webrev.00/ -Pavel

Re: Missing clarity in TimerTask doc

2014-09-16 Thread Ulf Zibis
Am 16.09.2014 um 00:47 schrieb Martin Buchholz: Maybe it could be extentend to: IllegalStateException - if task was already scheduled, cancelled or already done, timer was cancelled, or timer thread terminated. ... as I assume a TimerTask instance is never reusable. It's alrea

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-09-16 Thread Daniel Fuchs
On 9/16/14 1:12 PM, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8044627? http://cr.openjdk.java.net/~prappo/8044627/webrev.00/ -Pavel Hi Pavel, Given that helper.loadClass uses the context class loader, Should you also simply use ServiceLoader loader =

Re: RFR [9]: 8050142: Optimize java.util.Formatter

2014-09-16 Thread Claes Redestad
Brent, Marcus, thank you for reviewing! JCK 9 tests for api/java_util api/java_lang either pass or fail with or without this patch on my machine. Also reran relevant jtreg tests (jdk/test/java/util/Formatter jdk/test/java/util/Formattable jdk/test/java/lang/String jdk/test/java/lang/System)

Re: RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

2014-09-16 Thread Alan Bateman
On 15/09/2014 17:03, Daniel Fuchs wrote: : Here is a new webrev - with updated test case: http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.05/ I think this quite good now. Just on this wording: "If a listener terminates with an uncaught error or exception thenthe first exception t

Re: [9] RFR (S): 8058291: Missing some checks during parameter validation

2014-09-16 Thread Vladimir Ivanov
Thank you, John. Best regards, Vladimir Ivanov On 9/16/14, 12:01 AM, John Rose wrote: Reviewed. Nice tuning of the asserts. — John On Sep 15, 2014, at 9:03 AM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8058291/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058291

Re: [9] RFR (S): 8058293: Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is broken

2014-09-16 Thread Vladimir Ivanov
Thank you, John. I did an adhoc test run with BIT_LIMIT=0 set, but I don't think it worth a separate parameter in the code. Best regards, Vladimir Ivanov On 9/15/14, 11:44 PM, John Rose wrote: On Sep 15, 2014, at 9:48 AM, Vladimir Ivanov wrote: https://bugs.openjdk.java.net/browse/JDK-80

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-09-16 Thread Pavel Rappo
Daniel, > Given that helper.loadClass uses the context class loader, > Should you also simply use > ServiceLoader loader = > ServiceLoader.load(InitialContextFactory.class); > at lines 680-681 ? It needs to be the system class loader to allow for JNDI providers that might be

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-09-16 Thread Alan Bateman
On 16/09/2014 15:14, Pavel Rappo wrote: Daniel, Given that helper.loadClass uses the context class loader, Should you also simply use ServiceLoader loader = ServiceLoader.load(InitialContextFactory.class); at lines 680-681 ? It needs to be the system class loader to allo

Re: RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

2014-09-16 Thread Daniel Fuchs
Done. http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.06 On 9/16/14 3:56 PM, Alan Bateman wrote: On 15/09/2014 17:03, Daniel Fuchs wrote: : Here is a new webrev - with updated test case: http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.05/ I think this quite good now. Ju

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-09-16 Thread Daniel Fuchs
On 9/16/14 4:14 PM, Pavel Rappo wrote: Daniel, Given that helper.loadClass uses the context class loader, Should you also simply use ServiceLoader loader = ServiceLoader.load(InitialContextFactory.class); at lines 680-681 ? It needs to be the system class loader to allo

RFR 8058569: Update java/lang/invoke/lambda tests to eliminate dependency on sun.tools.jar.Main

2014-09-16 Thread Amy Lu
Some java/lang/invoke/lambda tests have dependency on sun.tools.jar.Main This fix is to remove above internal JDK API dependency from the tests. bug: https://bugs.openjdk.java.net/browse/JDK-8058569 webrev: http://cr.openjdk.java.net/~tyan/amylu/8058569/webrev.01/ Thanks, Amy

Re: RFR: 8058520: jar xf does not work on zip files with leading garbage.

2014-09-16 Thread Xueming Shen
On 9/15/14 6:40 PM, Martin Buchholz wrote: Hi Alan, Xueming, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8058520 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jar-leadingGarbage/

Re: [9] RFR (L): 8057042: LambdaFormEditor: derive new LFs from a base LF

2014-09-16 Thread Vladimir Ivanov
Peter, thank you very much for experimenting with that! It looks really promising. I do believe we need to purge LambdaForm cache, until there's no upper limit on a possible number of LambdaForm instance. I'll gather some data how efficient a cache with weak keys is and get back to you. Be

Re: RFR JDK-8044627: Update JNDI to work with modules

2014-09-16 Thread Pavel Rappo
Daniel, > So is it expected that modules (e.g. java.corba) will register > their own service provider for the InitialContextFactory > (I mean - using META-INF/services/)? Alan's already answered this point. TCCL is the way to go. You are right. > The difference however is that in this two case

[9] RFR (XS): 8058584: Ignore java/lang/invoke/LFCaching/LFGarbageCollectedTest until 8057020 is fixed

2014-09-16 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8058584/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058584 Exclude java/lang/invoke/LFCaching/LFGarbageCollectedTest from test runs until 8057020 is fixed. Thanks! Best regards, Vladimir Ivanov

Re: [9] RFR (XS): 8058584: Ignore java/lang/invoke/LFCaching/LFGarbageCollectedTest until 8057020 is fixed

2014-09-16 Thread Joe Darcy
Looks good; approved to go back, Thanks Vladimir, -Joe On 9/16/2014 11:43 AM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8058584/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058584 Exclude java/lang/invoke/LFCaching/LFGarbageCollectedTest from test runs until 8057020

Re: [9] RFR (XS): 8058584: Ignore java/lang/invoke/LFCaching/LFGarbageCollectedTest until 8057020 is fixed

2014-09-16 Thread Alan Bateman
On 16/09/2014 19:43, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8058584/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058584 Exclude java/lang/invoke/LFCaching/LFGarbageCollectedTest from test runs until 8057020 is fixed. We usually use jdk/test/ProblemList.txt to excl

Re: [9] RFR (XS): 8058584: Ignore java/lang/invoke/LFCaching/LFGarbageCollectedTest until 8057020 is fixed

2014-09-16 Thread Vladimir Ivanov
Joe, Alan, thanks for review. Best regards, Vladimir Ivanov On 9/16/14, 10:55 PM, Alan Bateman wrote: On 16/09/2014 19:43, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8058584/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058584 Exclude java/lang/invoke/LFCaching/LFGarba

Re: RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

2014-09-16 Thread Mandy Chung
On 9/16/14 8:31 AM, Daniel Fuchs wrote: Done. http://cr.openjdk.java.net/~dfuchs/webrev_8043306/webrev.06 Looks good. Mandy On 9/16/14 3:56 PM, Alan Bateman wrote: On 15/09/2014 17:03, Daniel Fuchs wrote: : Here is a new webrev - with updated test case: http://cr.openjdk.java.net/~dfu

RFR JDK-8058204 stream tests timeout, intermittently but more likely to happen after JDK-8056248

2014-09-16 Thread Paul Sandoz
Hi, Please see below for a patch to disable concurrent execution of the stream tests by jtreg. Due to recent f/j changes some stream tests are now timing out. This is because the tests are running concurrently and parallel stream execution in one process is competing for resources with paralle

Re: RFR 8058569: Update java/lang/invoke/lambda tests to eliminate dependency on sun.tools.jar.Main

2014-09-16 Thread David Holmes
Hi Amy, On 17/09/2014 1:49 AM, Amy Lu wrote: Some java/lang/invoke/lambda tests have dependency on sun.tools.jar.Main This fix is to remove above internal JDK API dependency from the tests. bug: https://bugs.openjdk.java.net/browse/JDK-8058569 webrev: http://cr.openjdk.java.net/~tyan/amylu/8058

Re: RFR JDK-8058204 stream tests timeout, intermittently but more likely to happen after JDK-8056248

2014-09-16 Thread David Holmes
On 17/09/2014 7:45 AM, Paul Sandoz wrote: Hi, Please see below for a patch to disable concurrent execution of the stream tests by jtreg. A number of our smaller systems may not be able to handle running these tests concurrently regardless, so I think removing the concurrency is a good thing

Re: RFR JDK-8058204 stream tests timeout, intermittently but more likely to happen after JDK-8056248

2014-09-16 Thread Alan Bateman
On 16/09/2014 22:45, Paul Sandoz wrote: Hi, Please see below for a patch to disable concurrent execution of the stream tests by jtreg. Looks good to me too, we should know soon enough if it helps with the timeout issues (just in case there is something else going on). -Alan