Hi Alexander,
On 04/08/15 19:34, Alexander Stepanov wrote:
Hello Daniel,
The review was re-uploaded as specdiff indeed discovered a couple of
unwanted changes (in 'InitialContext' and 'ReferralException'), so your
and Pavel's recommendations were very useful, thanks.
webrev (please update the
Hi Joe
Thank you very much! Really good advice! I have adjusted as it, please
re-check at:
http://cr.openjdk.java.net/~fyuan/8132660/webrev.01/
Btw, I only applied this practice on unit test, not for functional test
because Tristan still has a functional suite pending, I would unify the
Thanks!
On 8/5/2015 11:14 AM, Daniel Fuchs wrote:
Hi Alexander,
On 04/08/15 19:34, Alexander Stepanov wrote:
Hello Daniel,
The review was re-uploaded as specdiff indeed discovered a couple of
unwanted changes (in 'InitialContext' and 'ReferralException'), so your
and Pavel's recommendations
Hello Stuart,
Please see the final version of File.java (please update the page) -
just replacing tt with code in the mentioned places:
http://cr.openjdk.java.net/~avstepan/8132468/webrev.01/src/java.base/share/classes/java/io/File.java.udiff.html
The specdiff reports for lang and io:
On 04/08/15 13:53, Alexander Fomin wrote:
Hi Chris
On 04.08.2015 13:29, Chris Hegarty wrote:
Alexander,
Wow, that's a lot of boiler plate for a manual test. Surely a
README.txt, or similar would be sufficient?
I noticed that with your changes, now this test has a dependency on
the
Hello,
Could you please review the following fix:
http://cr.openjdk.java.net/~avstepan/8133040/webrev.00
for
https://bugs.openjdk.java.net/browse/JDK-8133040
specdiffs:
java.lang.management - no changes detected:
javax.management - one (expected) change in TabularDataSupport:
(full package diff:
http://cr.openjdk.java.net/~avstepan/8133040/javax.management/overview-summary.html)
On 8/5/2015 8:22 PM, Alexander Stepanov wrote:
Hello,
Could you please review the following fix:
Hi Crhis
On 05.08.2015 17:54, Chris Hegarty wrote:
What is the problem with dependency on the jdk.desktop module?
The problem is that you must have a java runtime image with the
java.desktop module installed, to be able to run a core networking
test that has got nothing to do with
Hi,
Would you please help review the proposed change for JDK-804.
issue: https://bugs.openjdk.java.net/browse/JDK-804
webrev: http://cr.openjdk.java.net/~sherman/804/
The fix for this particular problem is at ln#135-#137. The rest is the
clean to remove unused the code (was for
The change looks ok to me Sherman.
Should the bug synopsis be updated? It looks like a test bug rather than a
product one.
-Chris
On 5 Aug 2015, at 20:04, Xueming Shen xueming.s...@oracle.com wrote:
Hi,
Would you please help review the proposed change for JDK-804.
issue:
Hi Alexander,
The changes to File.java look good. Thanks for doing the specdiffs as well; it's
a good way to verify that even with all these markup changes, specdiff didn't
detect any changes to java.io.File at all.
(I didn't look at other files; I'm presuming that others have.)
s'marks
On
Hi,
so here's the webrev which implements the new Info.commandLine()
method (I chose 'commandLine() ' instead of 'cmdline()' or
'commandline()' because the other getters are camel case as well):
http://cr.openjdk.java.net/~simonis/webrevs/2015/8131168.v4/
From the JavaDoc of the new method:
*
-Original Message-
From: Xueming Shen [mailto:xueming.s...@oracle.com]
Sent: Monday, July 20, 2015 11:50 AM
On 07/20/2015 10:22 AM, Kirk Shoop wrote:
So when default system locale differs from the active one, we have
different behavior on Linux and Windows. The new options allow a
On Wed, Aug 5, 2015 at 12:29 PM, Chris Hegarty chris.hega...@oracle.com
wrote:
The change looks ok to me Sherman.
Should the bug synopsis be updated? It looks like a test bug rather than a
product one.
Why do you say that? The JISAutoDetect charset is being fixed here, no?
Sherman: Thanks
Hi Frank,
This looks good to me.
Best,
Joe
On 8/5/2015 3:04 AM, Frank Yuan wrote:
Hi Joe
Thank you very much! Really good advice! I have adjusted as it, please
re-check at:
http://cr.openjdk.java.net/~fyuan/8132660/webrev.01/
http://cr.openjdk.java.net/%7Efyuan/8132660/webrev.01/
Btw,
15 matches
Mail list logo
