Hi Mandy,
On 10/18/2016 04:14 PM, Peter Levart wrote:
I have tried to capture the precise behavior in the changed javadocs
that I present here:
http://cr.openjdk.java.net/~plevart/jdk9-dev/Class.getMethods.new/webrev.06/
On 11/02/2016 04:12 AM, Mandy Chung wrote:
1786 *(
Hi Volker,
I removed the two exceptions:
http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/jdk-wr.02
Thanks for reviewing!
Best regards,
Goetz
> -Original Message-
> From: Volker Simonis [mailto:volker.simo...@gmail.com]
> Sent: Mittwoch, 2. November 2016 15:22
> To: Lindenm
Hi Mandy,
Thank you. This really helpful.
--
With best regards,
Sergei
02.11.16 21:05, Mandy Chung wrote:
jdeps now has a new option [1] to make it easy to analyze the test dependency;
—-list-deps and —-list-reduced-deps
$ jdeps --list-deps -cp testng.jar
JTwork/classes/java/io/Serializ
Looks good!
Thanks,
Volker
On Thu, Nov 3, 2016 at 10:03 AM, Lindenmaier, Goetz
wrote:
> Hi Volker,
>
> I removed the two exceptions:
> http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/jdk-wr.02
>
> Thanks for reviewing!
>
> Best regards,
> Goetz
>
>> -Original Message-
>> Fr
CCC for CommandInfo changes is now approved
(http://ccc.us.oracle.com/8047773), you can find new webrev here:
http://cr.openjdk.java.net/~aefimov/8164479/03/
Is there anything else to be solved?
Thanks,
Roman
On 09/27/2016 05:52 PM, Roman Grigoriadi wrote:
Thanks for pointing Mandy,
this pa
On 11/02/2016 11:27 AM, David Holmes wrote:
Moving discussion to core-libs-dev. Please follow-up there.
Thanks,
David
On 3/11/2016 1:20 AM, Dmitry Zhikharev wrote:
Hi!
ForkJoinPool class documentation says nothing about it using daemon
threads since Java 8
(https://docs.oracle.com/javase/8/do
Please review the patch for test
sun/rmi/runtime/Log/6409194/NoConsoleOutput.java
bug: https://bugs.openjdk.java.net/browse/JDK-8037278
webrev: http://cr.openjdk.java.net/~amlu/8037278/webrev.00/
This test fails whenever there’s extra output from System.out (from the
test application DoRMIStuff
What happens if you're using large pages? Are the direct buffers always
allocated off of small pages?
On 11/02/2016 06:34 PM, Lu, Yingqi wrote:
Hi All,
Our most recent DirectIO patch is available at
http://cr.openjdk.java.net/~igraves/8164900-3/
In this version, we made following changes:
Hi Amy,
I think it might still be useful to see what the subprocess
prints on System.out in case of failure.
I would leave lines 83, 86 and 87 unchanged.
best regards,
-- daniel
On 03/11/16 11:58, Amy Lu wrote:
Please review the patch for test
sun/rmi/runtime/Log/6409194/NoConsoleOutput.java
Thank you Daniel for your review.
Yes, agree and reverted those three lines.
webrev updated:
http://cr.openjdk.java.net/~amlu/8037278/webrev.01
Thanks,
Amy
On 11/3/16 8:37 PM, Daniel Fuchs wrote:
Hi Amy,
I think it might still be useful to see what the subprocess
prints on System.out in case
Hi,
I've done some rework accordingly to Alan's and Shura's comments:
1) removed overlapped tests from JImageToolTest.java;
2) added new tests JImageVerifyTest.java for jimage verify;
3) reorganized jtreg's tags;
The new WEBREV can be found here:
http://cr.openjdk.java.net/~dkononenko/816724
Nice work. +1
> On Nov 3, 2016, at 10:29 AM, Denis Kononenko
> wrote:
>
> Hi,
>
> I've done some rework accordingly to Alan's and Shura's comments:
>
> 1) removed overlapped tests from JImageToolTest.java;
>
> 2) added new tests JImageVerifyTest.java for jimage verify;
>
> 3) reorganized
Hi Amy,
Looks good to me.
-- daniel
On 03/11/16 13:22, Amy Lu wrote:
Thank you Daniel for your review.
Yes, agree and reverted those three lines.
webrev updated:
http://cr.openjdk.java.net/~amlu/8037278/webrev.01
Thanks,
Amy
On 11/3/16 8:37 PM, Daniel Fuchs wrote:
Hi Amy,
I think it migh
On 03/11/16 13:35, Daniel Fuchs wrote:
Hi Amy,
Looks good to me.
Maybe a followup should be logged to try
and no longer call TestLibrary.getUnusedRandomPort(),
as this the method that is causing the rogue
output (and I see that it might print things
to System.err as well).
best regards,
-- d
Thank you Daniel.
I'll push webrev.01
Thanks,
Amy
On 11/3/16 9:35 PM, Daniel Fuchs wrote:
Hi Amy,
Looks good to me.
-- daniel
On 03/11/16 13:22, Amy Lu wrote:
Thank you Daniel for your review.
Yes, agree and reverted those three lines.
webrev updated:
http://cr.openjdk.java.net/~amlu/8037
On 11/3/16 9:42 PM, Daniel Fuchs wrote:
On 03/11/16 13:35, Daniel Fuchs wrote:
Hi Amy,
Looks good to me.
Maybe a followup should be logged to try
and no longer call TestLibrary.getUnusedRandomPort(),
as this the method that is causing the rogue
output (and I see that it might print things
to
Any information you can give on this?
On 29/10/2016 19:10, Brunoais wrote:
Here's my try on going async.
On my tests on my local windows 10 machine (I don't have access to the
linux one without a VM ATM) , now with 1GB file, I noticed:
~2s of speed improvement from BufferedInputStream to
B
We tried to minimize the changes to native C code and put alignment at Java
level. We borrow the same approach being used for VM.isDirectMemoryPageAligned
here for DirectByteBuffer alignment.
Thanks,
Lucy
From: Jon V. [mailto:sybersn...@gmail.com]
Sent: Thursday, November 03, 2016 5:23 AM
To: D
I think DirectByteBuffer do not use large page. Please refer to
https://bugs.openjdk.java.net/browse/JDK-8021829 for more details.
Our code changes are done for alignment. I think they should not impact the
usage of either small pages or large pages.
Thanks,
Lucy
>-Original Message-
>
Denis,
I can see that you have switched to the top level test library with this
change. With that you are getting more module dependencies than just
java.base. First of all, it would probably make sense to build only the classes
you needed (which would be jdk.test.lib.process.ProcessTools, I
Hi Lucy,
Did you know that in JDK 9 the following two methods have been added to
java.nio.ByteBuffer:
/** @return The indexed byte's memory address modulus the unit size
*/
public final int alignmentOffset(int index, int unitSize);
/** @return new byte buffer whose content is a shared and
Hi Peter,
Thanks for pointing this out, you beat me to it :-)
Note that the alignment for a unit size corresponding to page size will only be
stable for direct byte buffers, since for heap byte buffers the GC can move the
underlying byte array and the alignment properties may change.
Paul.
>
Hi Paul and Peter,
Thank you very much for pointing this out. We did not know about it :)
We will modify the patch accordingly and will send it here for review.
Thanks,
Lucy
From: Paul Sandoz [mailto:paul.san...@oracle.com]
Sent: Thursday, November 03, 2016 12:46 PM
To: Peter Levart
Cc: Lu, Yi
> On Nov 3, 2016, at 4:53 AM, Roman Grigoriadi
> wrote:
>
> CCC for CommandInfo changes is now approved
> (http://ccc.us.oracle.com/8047773), you can find new webrev here:
>
> http://cr.openjdk.java.net/~aefimov/8164479/03/
>
javax/activation/CommandInfo.java
92 * When java.beans.Bean
Hi,
Please review these specification clarifications for multi-release JARs. They
are small and two are closely interrelated so though it would be best to
aggregate them in one email.
Thanks,
Paul.
8166914 URLClassLoader spec needs to mention that it's MR-aware
diff -r 52d732262bfa src/java.
Looks fine overall. I think it’s useful to add a section header “Multi-Release
JAR File” in JarFile class specification that URLClassLoader can link to
directly when referring “multi-release JAR file” and other specs can make use
of too.
Then the following statement is not needed.
> (See {@li
Hi all,
Please review this small set of changes to the immutable collections to make the
zero-size instances singletons. (JDK-8156079)
This also includes a couple other small optimizations (JDK-8169222) to change
the expansion factor from floating point to integer, and also to avoid creating
> On Nov 3, 2016, at 1:32 AM, Peter Levart wrote:
>
>
> Here is a webrev incorporating your suggestions:
>
> http://cr.openjdk.java.net/~plevart/jdk9-dev/Class.getMethods.new/webrev.07/
This looks really good. I went through the test output and the expected result
looks right to me as far a
28 matches
Mail list logo
