RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set

Dear All, May I ask your help to review this tiny fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8241638 Webrev: http://cr.openjdk.java.net/~lzang/8241638/webrev01/ Thanks! BRs, Lin

RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi All, Could you review this change? Additionally, I'd like to ask a sponsor for it, since I'm not a committer. Bug: https://bugs.openjdk.java.net/browse/JDK-8232846 Webrev: http://cr.openjdk.java.net/~tnakamura/8232846/webrev.00 Under Windows environments, ProcessHandle.Info.command shows qu

Re: [PATCH] Trivial improvement for j.l.Character.toString() - 8241649: Optimize Character.toString

Filed and pushed: https://bugs.openjdk.java.net/browse/JDK-8241649 /Claes On 2020-03-26 00:12, Roger Riggs wrote: Agreed,  +1 On 3/25/20 5:53 PM, Claes Redestad wrote: Looks good and trivial, including the drive-by cleanups. I can sponsor. /Claes On 2020-03-25 22:18, Сергей Цыпанов wrote:

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi Toshio, looks good to me. Cheers, Thomas On Thu, Mar 26, 2020 at 9:58 AM Toshio 5 Nakamura wrote: > > Hi All, > > Could you review this change? Additionally, I'd like to ask a sponsor for > it, since I'm not a committer. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8232846 > Webrev: ht

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi Nakamura-san, Your change almost looks good, but I have one question. Length of exeName (1024) is enough? According to Microsoft Doc [1], exeName might not be null-terminated if it failed. I concern buffer overrun might occur when QueryFullProcessImageNameW failed. Thanks, Yasumasa [1]

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi, If the call fails, the command field in the info will not be set (and therefore null). I agree that a length of 512 (characters) is probably too small. Roger On 3/26/20 6:37 AM, Yasumasa Suenaga wrote: Hi Nakamura-san, Your change almost looks good, but I have one question. Length of

RFR: JDK-8241400: [macos] jpackageapplauncher/main.m built using CXXFLAGS_JDKEXE

Please review the fix to issue [1] at [2]. Simple makefile fix. /Andy [1]: https://bugs.openjdk.java.net/browse/JDK-8241400 [2]: http://cr.openjdk.java.net/~herrick/8241400/webrev.01/

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi Thomas, Suenaga-san, Roger, Thank you for reviewing and comments. I checked behaviors by a small program and debugger. If QueryFullProcessImageNameW failed by not enough buffer, the API didn't change the buffer. It just set ERROR_INSUFFICIENT_BUFFER(0x7a) to LastError. The buffer size becom

Re: RFR: JDK-8241400: [macos] jpackageapplauncher/main.m built using CXXFLAGS_JDKEXE

Looks good. /Erik On 2020-03-26 06:58, Andy Herrick wrote: Please review the fix to issue [1] at [2]. Simple makefile fix. /Andy [1]: https://bugs.openjdk.java.net/browse/JDK-8241400 [2]: http://cr.openjdk.java.net/~herrick/8241400/webrev.01/

jpackage Are the RPM Requires necessary?

Running jpackage to build an RPM will add some Requires to the package. It comes from the Template file: https://github.com/openjdk/jdk/blob/jdk-14%2B36/src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/resources/template.spec Autoprov: 0 Autoreq: 0 %if "xPACKAGE_DEFAULT_DE

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi, Reading further down the reference to the section: "Enable Long Paths in Windows 10, Version 1607, and Later" might suggest the code be more resilient to long paths. The stack allocated buffer (1024) is fine, but I'd suggest adding code to retry in the case of INSUFFICIENT BUFFER with a mal

Re: jpackage Are the RPM Requires necessary?

On 3/26/2020 11:17 AM, Sverre Moe wrote: Running jpackage to build an RPM will add some Requires to the package. It comes from the Template file: https://github.com/openjdk/jdk/blob/jdk-14%2B36/src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/resources/template.spec A

Re: jpackage Are the RPM Requires necessary?

tor. 26. mar. 2020 kl. 20:41 skrev Alexey Semenyuk < alexey.semen...@oracle.com>: > > > On 3/26/2020 11:17 AM, Sverre Moe wrote: > > Running jpackage to build an RPM will add some Requires to the package. > > > > It comes from the Template file: > > > https://github.com/openjdk/jdk/blob/jdk-14%2B3

Re: jpackage Are the RPM Requires necessary?

On 3/26/2020 4:13 PM, Sverre Moe wrote: tor. 26. mar. 2020 kl. 20:41 skrev Alexey Semenyuk mailto:alexey.semen...@oracle.com>>: On 3/26/2020 11:17 AM, Sverre Moe wrote: > Running jpackage to build an RPM will add some Requires to the package. > > It comes from the Templ

Re: [15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

Hi Chris, The changes don't appear incorrect, but at least from a cursory inspection, they don't appear as precise as they could be. Usually generifying a classes like this will next yield a round of redundant "cast" warnings; in my cleanup efforts, getting cast warnings was usually a sign th

Re: RFR: 8241055: Regex Grapheme Matcher Performance Depends too much on Total Input Sequence Size

Hi Philipp, I looked at the patch, and it looks good to me. As to the test case, since it is measuring the performance, I would make it in a JMH test. Maybe you would want to put it similar to open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java Minor suggestion: I would rathe

Re: jpackage Are the RPM Requires necessary?

tor. 26. mar. 2020 kl. 21:29 skrev Alexey Semenyuk < alexey.semen...@oracle.com>: > > > On 3/26/2020 4:13 PM, Sverre Moe wrote: > > tor. 26. mar. 2020 kl. 20:41 skrev Alexey Semenyuk < > alexey.semen...@oracle.com>: > >> >> >> On 3/26/2020 11:17 AM, Sverre Moe wrote: >> > Running jpackage to build

Re: jpackage Are the RPM Requires necessary?

tor. 26. mar. 2020 kl. 23:21 skrev Sverre Moe : > tor. 26. mar. 2020 kl. 21:29 skrev Alexey Semenyuk < > alexey.semen...@oracle.com>: > >> >> >> On 3/26/2020 4:13 PM, Sverre Moe wrote: >> >> tor. 26. mar. 2020 kl. 20:41 skrev Alexey Semenyuk < >> alexey.semen...@oracle.com>: >> >>> >>> >>> On 3/26

Re: jpackage Are the RPM Requires necessary?

On 3/26/2020 6:23 PM, Sverre Moe wrote: tor. 26. mar. 2020 kl. 23:21 skrev Sverre Moe >: tor. 26. mar. 2020 kl. 21:29 skrev Alexey Semenyuk mailto:alexey.semen...@oracle.com>>: On 3/26/2020 4:13 PM, Sverre Moe wrote: tor. 26. mar. 2020

Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Please review the implementation of JEP 371: Hidden Classes. The main changes are in core-libs and hotspot runtime area.  Small changes are made in javac, VM compiler (intrinsification of Class::isHiddenClass), JFR, JDI, and jcmd.  CSR [1]has been reviewed and is in the finalized state (see spe

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi, Please don't throw an exception. It would abort being able to provide any information. And who would expect or handle such an exception? Degrading the info or omitting it provides better service overall. There is no point to throwing an exception. Regards, Roger On 3/26/20 7:55 PM, Yasuma

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

On 2020/03/27 0:35, Roger Riggs wrote: Hi, Reading further down the reference to the section: "Enable Long Paths in Windows 10, Version 1607, and Later" might suggest the code be more resilient to long paths. The stack allocated buffer (1024) is fine, but I'd suggest adding code to retry in th

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

On 2020/03/27 9:01, Roger Riggs wrote: Hi, Please don't throw an exception. It would abort being able to provide any information. And who would expect or handle such an exception? Degrading the info or omitting it provides better service overall. There is no point to throwing an exception. hP

Re: [15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

Hi Chris, I have one question to you, is there is any specific reason for using wildcard(?) ?. In your change we can avoid "?" at most of the places. Please see the below methods signatures. ### public NamingEnumeration listBind

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi Roger, Suenaga-san, Thank you for your comments and discussion for the issue. I've updated webrev. Could you review it again? tier1 tests passed. webrev.01: http://cr.openjdk.java.net/~tnakamura/8232846/webrev.01 Best regards, Toshio Nakamura Yasumasa Suenaga wrote on 2020/03/27 09:10:15:

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

Hi Toshio, did you test the malloc path? Since https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-queryfullprocessimagenamew#return-value does not mention ERROR_INSUFFICIENT_BUFFER as return code, would like to see this working. It does however mention that it returns the number