Hello Alan,
On 28/06/21 1:00 pm, Alan Bateman wrote:
I didn't study the test too closely but just to mention that tests with zip
entries > 2GB can be problematic to test. The test will probably need the
@requires tag to limit it to 64-bit systems and maybe some minimum memory size. It
may
The documentation of the String.regionMatches method contains this fragment:
this.substring(toffset, len).codePoints(), but String.substring method takes
index, not the length, as the second argument.
-
Commit messages:
- Update javadoc
Changes:
> Can I please get a review for this proposed fix for the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8190753?
>
> The commit here checks for the size of the zip entry before trying to create
> a `ByteArrayOutputStream` for that entry's content. A new jtreg test has been
>
On Mon, 28 Jun 2021 12:28:06 GMT, Jim Laskey wrote:
> The documentation of the String.regionMatches method contains this fragment:
> this.substring(toffset, len).codePoints(), but String.substring method takes
> index, not the length, as the second argument.
Marked as reviewed by rriggs
Hi,
please review this small fix. The test case uses a custom launcher and before
launching the JVM, it adds the "lib" and "lib/server" directories to the
environment variable which controls the native library search path. For non
server variants, the second directory is not called
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote:
> Prefer using ByteOrder to compute byte order for StringUTF16 to determining
> byte order by native method StringUTF16.isBigEndian.
Hi Yi Yang,
This is more complex than it seems. The general policy is not to change boot
order if at all
On Fri, 25 Jun 2021 22:41:10 GMT, Alexey Semenyuk wrote:
> jpackage app launcher randomly crashes JVM at termination in EMS enabled JDK
> builds.
> Until the root cause of the issue is understood and fixed let's add a
> workaround to jpackage tests to run test app few more times if the first
On Sat, 26 Jun 2021 23:55:46 GMT, Weijun Wang wrote:
>> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
>> line 53:
>>
>>> 51: private static final long CURRENT_PID =
>>> AccessController.doPrivileged(
>>> 52: (PrivilegedAction)
>>>
On Mon, 28 Jun 2021 12:20:38 GMT, Daniel Fuchs wrote:
>> This cast is only to tell the compiler which overloaded method to call, and
>> I don't think there will be a real cast at runtime. It might look a little
>> ugly but extracting it into a variable declaration/definition plus a new
>>
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote:
>> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>>
>> Sometimes I introduce new methods. Please feel free to suggest method names
>> you like to use.
>
> Weijun Wang has updated the pull request incrementally with
A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java
from ProblemList.txt
-
Commit messages:
- 8269534: Remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java from
ProblemList.txt
Changes: https://git.openjdk.java.net/jdk17/pull/164/files
Webrev:
On Mon, 28 Jun 2021 17:05:49 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java
> from ProblemList.txt
This pull request has now been integrated.
Changeset: 20640a57
Author:Daniel D. Daugherty
URL:
On Mon, 28 Jun 2021 12:28:06 GMT, Jim Laskey wrote:
> The documentation of the String.regionMatches method contains this fragment:
> this.substring(toffset, len).codePoints(), but String.substring method takes
> index, not the length, as the second argument.
This pull request has now been
`test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
There are several tests under `` directory. As the tests under
`test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
`Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to the
parent
On Mon, 28 Jun 2021 17:05:49 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java
> from ProblemList.txt
Lgtm and trivial.
-
Marked as reviewed by tschatzl (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/164
On Mon, 28 Jun 2021 17:05:49 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to remove java/util/concurrent/locks/Lock/TimedAcquireLeak.java
> from ProblemList.txt
Marked as reviewed by iignatyev (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/164
On Mon, 28 Jun 2021 17:15:23 GMT, Igor Ignatyev wrote:
>> A trivial fix to remove
>> java/util/concurrent/locks/Lock/TimedAcquireLeak.java from ProblemList.txt
>
> Marked as reviewed by iignatyev (Reviewer).
@iignatev and @tschatzl - Thanks for the fast reviews.
-
PR:
On Mon, 28 Jun 2021 13:14:51 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small fix. The test case uses a custom launcher and before
> launching the JVM, it adds the "lib" and "lib/server" directories to the
> environment variable which controls the native library search
On Mon, 28 Jun 2021 13:44:41 GMT, David Holmes wrote:
>> Christoph Göttschkes has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Renames serverDir to vmDir.
>
> test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java line 53:
> Hi,
>
> please review this small fix. The test case uses a custom launcher and before
> launching the JVM, it adds the "lib" and "lib/server" directories to the
> environment variable which controls the native library search path. For non
> server variants, the second directory is not called
On Fri, 25 Jun 2021 22:41:10 GMT, Alexey Semenyuk wrote:
> jpackage app launcher randomly crashes JVM at termination in EMS enabled JDK
> builds.
> Until the root cause of the issue is understood and fixed let's add a
> workaround to jpackage tests to run test app few more times if the first
Please review this small doc change to the system property. Accompanying CSR
has also been created.
-
Commit messages:
- 8269513: Clarify the spec wrt `useOldISOCodes` system property
Changes: https://git.openjdk.java.net/jdk17/pull/163/files
Webrev:
On Mon, 28 Jun 2021 13:14:51 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small fix. The test case uses a custom launcher and before
> launching the JVM, it adds the "lib" and "lib/server" directories to the
> environment variable which controls the native library search
On Mon, 28 Jun 2021 12:28:06 GMT, Jim Laskey wrote:
> The documentation of the String.regionMatches method contains this fragment:
> this.substring(toffset, len).codePoints(), but String.substring method takes
> index, not the length, as the second argument.
Marked as reviewed by dfuchs
On Mon, 28 Jun 2021 03:25:09 GMT, Yi Yang wrote:
>> Prefer using ByteOrder to compute byte order for StringUTF16 to determining
>> byte order by native method StringUTF16.isBigEndian.
>
> Hi Aleksey, do you have a concrete issue/discussion about bootstrapping
> problems? I don't see it because
On Mon, 28 Jun 2021 13:14:51 GMT, Christoph Göttschkes wrote:
> Hi,
>
> please review this small fix. The test case uses a custom launcher and before
> launching the JVM, it adds the "lib" and "lib/server" directories to the
> environment variable which controls the native library search
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
one more
On Fri, 25 Jun 2021 18:53:59 GMT, Jim Laskey wrote:
> The wording of the @implSpec referred to internal methods in the description.
> The patch rewords the @implSpec to be more descriptive of the algorithm than
> the methods used.
On Mon, 28 Jun 2021 15:26:45 GMT, Roger Riggs wrote:
>> The wording of the @implSpec referred to internal methods in the
>> description. The patch rewords the @implSpec to be more descriptive of the
>> algorithm than the methods used.
>
>
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote:
> Prefer using ByteOrder to compute byte order for StringUTF16 to determining
> byte order by native method StringUTF16.isBigEndian.
This pull request has been closed without being integrated.
-
PR:
On Tue, 29 Jun 2021 04:39:28 GMT, Jonathan Gibbons wrote:
> Please review a trivial `noreg-doc` fix for some javadoc tags for
> `java.lang.Runtime` for JDK17
LGTM
-
Marked as reviewed by sundar (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/167
On 29/06/2021 12:52 am, Christoph Göttschkes wrote:
On Mon, 28 Jun 2021 13:14:51 GMT, Christoph Göttschkes wrote:
Hi,
please review this small fix. The test case uses a custom launcher and before launching the JVM, it adds the
"lib" and "lib/server" directories to the environment variable
On Tue, 29 Jun 2021 04:39:28 GMT, Jonathan Gibbons wrote:
> Please review a trivial `noreg-doc` fix for some javadoc tags for
> `java.lang.Runtime` for JDK17
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/167
On Mon, 28 Jun 2021 19:45:34 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote:
> Prefer using ByteOrder to compute byte order for StringUTF16 to determining
> byte order by native method StringUTF16.isBigEndian.
Thanks for the detailed clarification!
The purpose of this PR is to skip the native call and use ByteOrder. Now
Please review a trivial `noreg-doc` fix for some javadoc tags for
`java.lang.Runtime` for JDK17
-
Commit messages:
- JDK-8249646: Runtime.exec(String, String[], File) documentation contains
literal {@link ...}
Changes: https://git.openjdk.java.net/jdk17/pull/167/files
Webrev:
On Sun, 30 May 2021 17:30:56 GMT, Markus KARG
wrote:
> This PR-*draft* is **work in progress** and an invitation to discuss a
> possible solution for issue
> [JDK-8265891](https://bugs.openjdk.java.net/browse/JDK-8265891). It is *not
> yet* intended for a final review.
>
> As proposed in
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
- 8267952: async logging supports to dynamically change tags and decorators
- 8269534: Remove
On Mon, 28 Jun 2021 21:58:36 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: 03d54e6e
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/03d54e6ef1a40ee78b0cc65ca0aea276fbdbc7b7
Stats: 224
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 103 commits:
- Merge
- 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
Reviewed-by: lancea, naoto
-
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the SecurityManager scenario.
>
> Reviewer request: @valeriepeng
Hello Lance,
Please take your time.
-Jaikiran
On 29/06/21 4:17 am, Lance Andersen wrote:
Hi Jaikiran,
This is on my list to look at but did not get to today.
Best
Lance
On Jun 27, 2021, at 11:52 PM, Jaikiran Pai
mailto:j...@openjdk.java.net>> wrote:
Can I please get a review for this
Hi Jaikiran,
This is on my list to look at but did not get to today.
Best
Lance
On Jun 27, 2021, at 11:52 PM, Jaikiran Pai
mailto:j...@openjdk.java.net>> wrote:
Can I please get a review for this proposed fix for the issue reported in
https://bugs.openjdk.java.net/browse/JDK-8190753?
The
Hi Valerie,
many thanks for the thorough review. I've taken all your feedback on
board with the latest push. Some of the test anomalies were a result of
previous iterations of test edits I had been making.
Regarding the extra edits in
"src/java.base/share/lib/security/default.policy", I had
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
> Add java.util.Objects.newIdentity to supply a unique object with identity.
> This is a replacement code can be used today for the traditional new Object()
> idiom, which will be deprecated under Project Valhalla.
> Refer to [JEP 401: Primitive Objects
>
This patch rewrites the prologue and epilogue of panama upcalls, in order to
fix the test failure from the title.
Previously, we did a call to potentially attach the current thread to the VM,
and then afterwards did the same suspend and stack reguard checks that we do on
the back-edge of a
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
Note: this is copied from https://github.com/openjdk/jdk17/pull/152.
-
Commit messages:
- copy all code change from
On Mon, 14 Jun 2021 15:42:03 GMT, Maurizio Cimadamore
wrote:
> This patch contains another minor tweak to TestResourceScope as we have seen
> this test timing out at least once (on arm64).
>
> I realized that some of the logic recently introduced in the test could lead
> to the test waiting
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined wording.
-
Changes:
- all:
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from
On Mon, 28 Jun 2021 19:13:45 GMT, Mandy Chung wrote:
>> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
>> There are several tests under `` directory. As the tests under
>> `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
>> `Lookup::accessClass` and
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung wrote:
> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
> There are several tests under `` directory. As the tests under
> `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
> `Lookup::accessClass` and
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
8199594: Add doc describing how (?x) ignores spaces in character classes
-
Commit messages:
- Updating documentation on comments mode and character class whitespace
Changes: https://git.openjdk.java.net/jdk/pull/4618/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4618=00
On Mon, 28 Jun 2021 14:52:41 GMT, Christoph Göttschkes wrote:
>> Hi,
>>
>> please review this small fix. The test case uses a custom launcher and
>> before launching the JVM, it adds the "lib" and "lib/server" directories to
>> the environment variable which controls the native library search
On Mon, 28 Jun 2021 18:56:24 GMT, Mandy Chung wrote:
> That's a fair point. I personally prefer using a descriptive directory name
> rather than bug ID since that can give the reader what the tests are intended
> for. What about renaming t8150782 to accessClassAndFindClass?
Me too! That
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refined wording #2.
-
Changes:
- all:
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
This pull request has been closed without being integrated.
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung wrote:
> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
> There are several tests under `` directory. As the tests under
> `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
> `Lookup::accessClass` and
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
> There are several tests under `` directory. As the tests under
> `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
> `Lookup::accessClass` and `Lookup::findClass`, they can simply be moved to
> the
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung wrote:
> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
> There are several tests under `` directory. As the tests under
> `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
> `Lookup::accessClass` and
> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
> `read(byte[],int,int)` to return zero per the `InputStream` specification
> when the byte array actual or specified length is zero.
Brian Burkhalter has updated the pull request incrementally with two additional
commits since
On Wed, 23 Jun 2021 19:21:02 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Mon, 28 Jun 2021 16:09:36 GMT, Mandy Chung wrote:
> `test/jdk/java/lang/invoke/t8150782` is the only one using that convention.
> There are several tests under `` directory. As the tests under
> `test/jdk/java/lang/invoke/t8150782` are mostly unit tests for
> `Lookup::accessClass` and
On Mon, 28 Jun 2021 18:12:34 GMT, Jim Laskey wrote:
>> The wording of the @implSpec referred to internal methods in the
>> description. The patch rewords the @implSpec to be more descriptive of the
>> algorithm than the methods used.
>
> Jim Laskey has updated the pull request incrementally
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Missed one.
-
Changes:
- all:
On Fri, 25 Jun 2021 17:38:32 GMT, Jorn Vernee wrote:
> This patch rewrites the prologue and epilogue of panama upcalls, in order to
> fix the test failure from the title.
>
> Previously, we did a call to potentially attach the current thread to the VM,
> and then afterwards did the same
On Mon, 28 Jun 2021 16:57:15 GMT, Naoto Sato wrote:
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Looks good Naoto
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/163
> The wording of the @implSpec referred to internal methods in the description.
> The patch rewords the @implSpec to be more descriptive of the algorithm than
> the methods used.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Not
On Mon, 28 Jun 2021 15:57:21 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/util/random/RandomGenerator.java line 648:
>>
>>> 646: * power of two then limiting is a simple masking operation.
>>> Otherwise, a
>>> 647: * new result is re-calculated by averaging the previous
On Mon, 28 Jun 2021 14:52:41 GMT, Christoph Göttschkes wrote:
>> Hi,
>>
>> please review this small fix. The test case uses a custom launcher and
>> before launching the JVM, it adds the "lib" and "lib/server" directories to
>> the environment variable which controls the native library search
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from
On Mon, 28 Jun 2021 19:45:34 GMT, Roger Riggs wrote:
>> Add java.util.Objects.newIdentity to supply a unique object with identity.
>> This is a replacement code can be used today for the traditional new
>> Object() idiom, which will be deprecated under Project Valhalla.
>> Refer to [JEP 401:
On Mon, 28 Jun 2021 18:45:31 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refined wording.
>
> src/java.base/share/classes/java/util/Locale.java line 460:
>
>> 458: * back to that of before
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Fri, 29 Jan 2021 05:53:57 GMT, Bo Zhang
wrote:
> Previously, `ImageBufferCache` contains a ThreadLocal field which holds
> strong reference to `ImageBufferCache$BufferReference.class`. When loaded
> from `jrt-fs.jar`, this will keep `JrtFileSystemProvider$JrtFsLoader`
> in memory forever and
On Wed, 3 Feb 2021 01:29:02 GMT, Bo Zhang
wrote:
>> Previously, `ImageBufferCache` contains a ThreadLocal field which holds
>> strong reference to `ImageBufferCache$BufferReference.class`. When loaded
>> from `jrt-fs.jar`, this will keep `JrtFileSystemProvider$JrtFsLoader`
>> in memory forever
On Mon, 28 Jun 2021 03:41:20 GMT, Jaikiran Pai wrote:
> Can I please get a review for this proposed fix for the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8190753?
>
> The commit here checks for the size of the zip entry before trying to create
> a `ByteArrayOutputStream`
84 matches
Mail list logo
