On Wed, 2 Mar 2022 14:06:10 GMT, Claes Redestad wrote:
>> Claes Redestad has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - Resolve merge conflict
>> - Fix TestCountPositives to correctly allow 0 return when
On 3/03/2022 10:47 pm, Julian Waters wrote:
Hi David,
I did not create the PR, I'm instead asking for others to review it
before I help the author create the issue on the JBS. Should I just go
ahead and create the issue for them?
The best thing would be for the PR creator to discuss the
I understand, I'll notify the author about this. I'm not sure if they'll be
alright with discussing on the mailing lists though, since they have
expressed that they prefer discussing it on the PR itself
best regards,
Julian Waters
On Thu, Mar 3, 2022 at 8:57 PM David Holmes wrote:
> On
On Wed, 2 Mar 2022 20:28:45 GMT, Joe Darcy wrote:
> Refactoring of Method and Constructor to share a single empty array for
> parameters and exceptions as well as type variables.
>
> Existing core reflection regression tests pass with the change.
On Thu, 3 Mar 2022 13:21:36 GMT, Lutz Schmidt wrote:
> Well, it just didn't build. With the annotation being present, you also need
> an intrinsic implementation. That's what the error message is saying...
Doh, I had no idea the presence of `@IntrinsicCandidate` was mandating the VM
has an
Sorry Julian, I see now you were the person aiding the person who
created the PR.
David
On 3/03/2022 10:45 pm, David Holmes wrote:
Hi Julian,
On 3/03/2022 10:33 pm, Jules W. wrote:
Hi all,
A new PR that adds methods to PriorityQueue was created some time ago at
On Thu, 3 Mar 2022 12:45:51 GMT, Claes Redestad wrote:
>>> * There are a few minor regressions (~5%) in the x86 implementation on
>>> `encode-/decodeLatin1Short`. Those regressions disappear when mixing
>>> inputs, for example `encode-/decodeShortMixed` even see a minor
>>> improvement,
Hi all,
A new PR that adds methods to PriorityQueue was created some time ago at
https://github.com/openjdk/jdk/pull/6938 but has no corresponding issue. As
I'm not too familiar with this part of the JDK I'm querying this mailing
list for anyone to properly review the PR before I create an issue
> I'm requesting comments and, hopefully, some help with this patch to replace
> `StringCoding.hasNegatives` with `countPositives`. The new method does a very
> similar pass, but alters the intrinsic to return the number of leading bytes
> in the `byte[]` range which only has positive bytes.
Hi David,
No worries :)
regards,
Julian
On Thu, Mar 3, 2022 at 8:47 PM David Holmes wrote:
> Sorry Julian, I see now you were the person aiding the person who
> created the PR.
>
> David
>
> On 3/03/2022 10:45 pm, David Holmes wrote:
> > Hi Julian,
> >
> > On 3/03/2022 10:33 pm, Jules W.
Hi David,
I did not create the PR, I'm instead asking for others to review it before
I help the author create the issue on the JBS. Should I just go ahead and
create the issue for them?
best regards,
Julian
On Thu, Mar 3, 2022 at 8:45 PM David Holmes wrote:
> Hi Julian,
>
> On 3/03/2022 10:33
Hi Julian,
On 3/03/2022 10:33 pm, Jules W. wrote:
Hi all,
A new PR that adds methods to PriorityQueue was created some time ago at
https://github.com/openjdk/jdk/pull/6938 but has no corresponding issue. As
I'm not too familiar with this part of the JDK I'm querying this mailing
list for
On Wed, 2 Mar 2022 20:28:45 GMT, Joe Darcy wrote:
> Refactoring of Method and Constructor to share a single empty array for
> parameters and exceptions as well as type variables.
>
> Existing core reflection regression tests pass with the change.
On Thu, 3 Mar 2022 11:19:12 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR addresses an issue where an unexpected exception is thrown when the
> CEN file entry comment length is not correct.
>
> Mach5 tiers 1 - 3 run clean with this change.
On Thu, 3 Mar 2022 12:04:47 GMT, Claes Redestad wrote:
>> I'm requesting comments and, hopefully, some help with this patch to replace
>> `StringCoding.hasNegatives` with `countPositives`. The new method does a
>> very similar pass, but alters the intrinsic to return the number of leading
>>
Hi all,
This PR addresses an issue where an unexpected exception is thrown when the CEN
file entry comment length is not correct.
Mach5 tiers 1 - 3 run clean with this change.
-
Commit messages:
- Correct bug number in test
- Validate comment if it exists when processing the CEN
On Thu, 3 Mar 2022 12:30:29 GMT, Andrew Haley wrote:
> > ```
> > * There are a few minor regressions (~5%) in the x86 implementation on
> > `encode-/decodeLatin1Short`. Those regressions disappear when mixing
> > inputs, for example `encode-/decodeShortMixed` even see a minor
> > improvement,
On Wed, 2 Mar 2022 22:21:03 GMT, Mandy Chung wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggested changes
>
> test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle/exeNullCallerResourceBundle.c
>
On Thu, 3 Mar 2022 02:36:58 GMT, Xin Liu wrote:
> If AbstractStringBuilder only grow, the inflated value which has been encoded
> in UTF16 can't be compressed.
> toString() can skip compression in this case. This can save an
> ArrayAllocation in StringUTF16::compress().
>
>
On Wed, 2 Mar 2022 02:50:27 GMT, Xiaohong Gong wrote:
> The vector `"test"` api is implemented with vector `"compare"`. And the
> masked `"test" `is implemented with `"test(op).and(m)"` which means
> `"compare().and(m)"` finally. Since the masked vector `"compare"` has been
> optimized with
On Thu, 3 Mar 2022 02:36:58 GMT, Xin Liu wrote:
> If AbstractStringBuilder only grow, the inflated value which has been encoded
> in UTF16 can't be compressed.
> toString() can skip compression in this case. This can save an
> ArrayAllocation in StringUTF16::compress().
>
>
> The vector `"test"` api is implemented with vector `"compare"`. And the
> masked `"test" `is implemented with `"test(op).and(m)"` which means
> `"compare().and(m)"` finally. Since the masked vector `"compare"` has been
> optimized with predicated instruction for archituctures that support the
JDK-8238048 (fixed in jdk15) moved major_version, minor_version,
generic_signature_index and source_file_name_index from InstanceKlass to
ConstantPool.
We still have some incorrect code in CP merge during class redefinition.
rewrite_cp_refs(scratch_class) updates generic_signature_index and
> Hi all,
>
> This PR addresses an issue where an unexpected exception is thrown when the
> CEN file entry comment length is not correct.
>
> Mach5 tiers 1 - 3 run clean with this change.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
cast several float to double before calculation
-
Changes:
- all:
Hi all,
A new PR that adds methods to PriorityQueue was created some time ago at
https://github.com/openjdk/jdk/pull/6938 but has no corresponding issue. As
I'm not too familiar with this part of the JDK I'm querying this mailing
list for anyone to properly review the PR before I create an issue
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what module represents the caller with no stack frame is
On Thu, 10 Feb 2022 04:22:34 GMT, Tagir F. Valeev wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Benchmark to demonstrate the patch usefulness
>
> I added a microbenchmark to demonstrate the speed improvement
On Thu, 3 Mar 2022 14:43:52 GMT, Lutz Schmidt wrote:
> I don't think the intrinsic has to be implemented on every target, but AFAICR
> it does have to be declared as an intrinsic in HotSpot.
Yeah, I got confused. To me it looks like a declaration of intent, and thought
the only strict
> This fix made equal processing of strings such as ""C:\\Program
> Files\\Git\\"" before and after JDK-8250568.
>
> For example, it's needed to execute the following command on Windows:
> `C:\Windows\SysWOW64\WScript.exe "MyVB.vbs" "C:\Program Files\Git" "Test"`
> it's equal to:
> `new
On Thu, 3 Mar 2022 08:12:46 GMT, Xiaohong Gong wrote:
>> The vector `"test"` api is implemented with vector `"compare"`. And the
>> masked `"test" `is implemented with `"test(op).and(m)"` which means
>> `"compare().and(m)"` finally. Since the masked vector `"compare"` has been
>> optimized
On Wed, 2 Mar 2022 20:28:45 GMT, Joe Darcy wrote:
> Refactoring of Method and Constructor to share a single empty array for
> parameters and exceptions as well as type variables.
>
> Existing core reflection regression tests pass with the change.
This is also only a partial solution, since
On Thu, 3 Mar 2022 13:31:35 GMT, Claes Redestad wrote:
> > Well, it just didn't build. With the annotation being present, you also
> > need an intrinsic implementation. That's what the error message is saying...
>
> Doh, I had no idea the presence of `@IntrinsicCandidate` was mandating the VM
On Thu, 3 Mar 2022 14:37:34 GMT, Andrew Haley wrote:
> > > Well, it just didn't build. With the annotation being present, you also
> > > need an intrinsic implementation. That's what the error message is
> > > saying...
> >
> >
> > Doh, I had no idea the presence of `@IntrinsicCandidate` was
On Fri, 18 Feb 2022 18:32:31 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - migrate to junit
>> - change threshold
>
> Sigh. (I'm sighing at the author of the
>
Update BCEL md to include the copyright notice.
-
Commit messages:
- 8282583: Update BCEL md to include the copyright notice
Changes: https://git.openjdk.java.net/jdk/pull/7681/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7681=00
Issue:
On Thu, 3 Mar 2022 22:14:15 GMT, Maurizio Cimadamore
wrote:
>> This fixes a bug in JDK-8282515 that `NativeLibraries::findEntry0` reads the
>> handle from the given native library instance with the field ID for
>> `NativeLibraryImpl::handle` which is wrong for `RawNativeLibraryImpl`. The
>>
Hi Julian,
Modifying the priorities of elements in the PriorityQueue violates the
invariants of the PriorityQueue established at insertion and maintained
at removal by the Comparator.
To maintain the invariant the element should be removed, its priority
modified,
and re-inserted.
An API to
On Thu, 3 Mar 2022 08:07:53 GMT, Daniel Jeliński wrote:
>> If AbstractStringBuilder only grow, the inflated value which has been
>> encoded in UTF16 can't be compressed.
>> toString() can skip compression in this case. This can save an
>> ArrayAllocation in StringUTF16::compress().
>>
>>
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
Looks fine. I assume the 2020 vs 2022 is intentional?
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7681
Supporting `IsoFields` temporal fields in chronologies that are similar to ISO
chronology. Corresponding CSR has also been drafted.
-
Commit messages:
- 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate
Changes:
> Update BCEL md to include the copyright notice.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove the section that's no longer in the notice file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7681/files
On Thu, 3 Mar 2022 18:35:05 GMT, Joe Wang wrote:
> Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text
> comes from the NOTICE.txt file in the BCEL 6.5.0 release.
Thank you for the confirmation Joe!
-
PR: https://git.openjdk.java.net/jdk/pull/7681
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text comes
from the NOTICE.txt file in the BCEL 6.5.0 release.
-
PR: https://git.openjdk.java.net/jdk/pull/7681
On Thu, 3 Mar 2022 18:36:32 GMT, Lance Andersen wrote:
> > Yes, it's 2020. The latest release, 6.5.0, was released in 2020. The text
> > comes from the NOTICE.txt file in the BCEL 6.5.0 release.
>
> Thank you for the confirmation Joe!
Thanks Lance, and Iris!
-
PR:
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
Confirm 2020, not 2022. Otherwise, looks good.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7681
On Wed, 2 Mar 2022 00:13:41 GMT, Valerie Peng wrote:
> It's been several years since we increased the default key sizes. Before
> shifting to PQC, NSA replaced its Suite B cryptography recommendations with
> the Commercial National Security Algorithm Suite which suggests:
>
> - SHA-384 for
This fixes a bug in JDK-8282515 that `NativeLibraries::findEntry0` reads the
handle from the given native library instance with the field ID for
`NativeLibraryImpl::handle` which is wrong for `RawNativeLibraryImpl`. The
`NativeLibraries::findEntry0` now takes the handle of the library instead
On Thu, 3 Mar 2022 21:57:19 GMT, Mandy Chung wrote:
> This fixes a bug in JDK-8282515 that `NativeLibraries::findEntry0` reads the
> handle from the given native library instance with the field ID for
> `NativeLibraryImpl::handle` which is wrong for `RawNativeLibraryImpl`. The
>
On Thu, 3 Mar 2022 16:55:46 GMT, Tim Prinzing wrote:
>> The caller class returned by Reflection::getCallerClass was used to gain
>> access to it's module in most cases and class loader in one case. I added a
>> method to translate the caller class to caller module so that the decision
>> of
On Thu, 3 Mar 2022 08:11:19 GMT, Daniel Jeliński wrote:
>> If AbstractStringBuilder only grow, the inflated value which has been
>> encoded in UTF16 can't be compressed.
>> toString() can skip compression in this case. This can save an
>> ArrayAllocation in StringUTF16::compress().
>>
>>
On Thu, 10 Feb 2022 04:30:34 GMT, Tagir F. Valeev wrote:
>> See the bug description for details.
>>
>> I propose a simple solution. Let's allow ArraySpliterator to be non-SIZED
>> and report artificial estimatedSize(), much bigger than the real one. This
>> will allow AbstractSpliterator and
On Thu, 3 Mar 2022 23:29:31 GMT, Mandy Chung wrote:
>> This fixes a bug in JDK-8282515 that `NativeLibraries::findEntry0` reads the
>> handle from the given native library instance with the field ID for
>> `NativeLibraryImpl::handle` which is wrong for `RawNativeLibraryImpl`. The
>>
On Thu, 3 Mar 2022 15:46:37 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> cast several float to double before calculation
OK, I
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote:
>> Update BCEL md to include the copyright notice.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove the section that's no longer in the notice file
Marked as reviewed by
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote:
>> Update BCEL md to include the copyright notice.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove the section that's no longer in the notice file
Marked as reviewed by
On 3/03/2022 11:02 pm, Julian Waters wrote:
I understand, I'll notify the author about this. I'm not sure if they'll
be alright with discussing on the mailing lists though, since they have
expressed that they prefer discussing it on the PR itself
That's not the way OpenJDK works, and anything
On Thu, 3 Mar 2022 15:46:37 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> cast several float to double before calculation
On Thu, 3 Mar 2022 17:51:31 GMT, Joe Wang wrote:
> Update BCEL md to include the copyright notice.
This pull request has now been integrated.
Changeset: 8478173d
Author:Joe Wang
URL:
https://git.openjdk.java.net/jdk/commit/8478173d837113bf603aadb614badd461f474250
Stats: 8 lines
On Thu, 3 Mar 2022 22:34:43 GMT, Joe Wang wrote:
>> Update BCEL md to include the copyright notice.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove the section that's no longer in the notice file
Marked as reviewed by
> This fixes a bug in JDK-8282515 that `NativeLibraries::findEntry0` reads the
> handle from the given native library instance with the field ID for
> `NativeLibraryImpl::handle` which is wrong for `RawNativeLibraryImpl`. The
> `NativeLibraries::findEntry0` now takes the handle of the library
On Thu, 3 Mar 2022 21:57:19 GMT, Mandy Chung wrote:
> This fixes a bug in JDK-8282515 that `NativeLibraries::findEntry0` reads the
> handle from the given native library instance with the field ID for
> `NativeLibraryImpl::handle` which is wrong for `RawNativeLibraryImpl`. The
>
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
copyright year fix
-
Changes:
-
I agree with Roger. Let me amplify this.
The general rule for collections that use hashes and comparison methods (such as
HashMap and TreeMap, as well as PriorityQueue) is that one mustn't mutate any
element that resides in such a collection in any way that changes the results of
hashCode,
Hi all,
I apologize for the confusion, it seems like something went awry on my end
with the mailing lists, since there are apparently now 2 copies of the same
thread with different names. I guess I'll just go with this one, since the
technical discussion is going on here.
To clarify, I wasn't
On Tue, 1 Mar 2022 06:17:06 GMT, Joe Darcy wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Adding descriptive comments.
>
> test/jdk/java/lang/Math/RoundTests.java line 32:
>
>> 30: public static
On Thu, 3 Mar 2022 14:30:34 GMT, Claes Redestad wrote:
> This is also only a partial solution, since the initial array is created and
> injected by the VM on a "root" Constructor/Method, see for example the code
> for new method:
>
>
67 matches
Mail list logo
