On Fri, 27 May 2022 22:09:22 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
On Fri, 27 May 2022 19:52:30 GMT, Claes Redestad wrote:
>> In preparation of #8855 this PR refactors the conversions from `List` to
>> array and array to `List`, reducing the number of conversions when calling
>> `MethodHandles.dropArguments` in particular. This remove about ~5% of
>>
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
Looks good to
On Thu, 2 Jun 2022 14:25:55 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 5462:
>>
>>> 5460: Objects.requireNonNull(target);
>>> 5461: Objects.requireNonNull(newTypes);
>>> 5462: return dropArgumentsToMatch(target, skip,
On Sat, 28 May 2022 11:50:19 GMT, Tim Prinzing wrote:
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c to make it
>
On Thu, 2 Jun 2022 15:19:44 GMT, Сергей Цыпанов wrote:
>> The clone is needed - as the `List>` may be a custom implementation
>> of List - so you cannot make any assumption on the concrete implementation
>> of `toArray`.
>
> But we can make an assumption on the behavior of particular method
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 40 additional commits since the
last revision:
> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>
> This is a non-final API that provides a gentle on-ramp to structure a task as
> a family of concurrent subtasks, and to coordinate the subtasks as a unit.
Alan Bateman has updated the pull request with a new target
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are
On Fri, 27 May 2022 03:12:39 GMT, Alexander Matveev
wrote:
> Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app
> image. Un-signing takes time since we enumerating all files and un-signing
> binaries one by one. Average increase 2-3 minutes for tests which generates
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote:
> - Added support for signing predefined application image.
> - Following command can be used to sign predefined application images:
> jpackage --type app-image --app-image Test.app --mac-sign [additional signing
> options]
> - Main
On Wed, 1 Jun 2022 13:32:36 GMT, Gaurav Chaudhari wrote:
>> This fix ensures that when a lookup for a custom TZ code fails, and an
>> attempt is made to find the GMT offset in order to get the current time,
>> Daylight savings rules are applied correctly.
>
> Gaurav Chaudhari has updated the
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote:
> - Added support for signing predefined application image.
> - Following command can be used to sign predefined application images:
> jpackage --type app-image --app-image Test.app --mac-sign [additional signing
> options]
> - Main
On Thu, 2 Jun 2022 18:07:39 GMT, Naoto Sato wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8285838: Cleanup of trailing whitespace
>> - 8285838: Corrected month comparison check for TZ DST
>
> I tried
On Wed, 1 Jun 2022 13:52:46 GMT, Adam Sotona wrote:
> LauncherCommon.gmk is unfortunately defining JAVA_ARGS with `-J-ms8m` option
> for all JDK launchers, including java launcher.
> JAVA_ARGS should not be defined for java launcher (in contrast to the other
> JDK launchers), and the command
On Wed, 1 Jun 2022 06:26:23 GMT, David Holmes wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - Fixed another typo in comment
>> - Merge
>> - Fix typos in comments
>> - Allowing
On Thu, 2 Jun 2022 13:59:50 GMT, Сергей Цыпанов wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
>
This adds a regression test for a recent fix (JDK-8287073). I've restructured
the linux specific JDK code to call a separate static function to enable this
test. It'll help future tests too.
Testing:
- [x] Container tests continue to pass + GHA
- [x] New regression test fails prior the code fix
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf wrote:
> This adds a regression test for a recent fix (JDK-8287073). I've restructured
> the linux specific JDK code to call a separate static function to enable this
> test. It'll help future tests too.
>
> Testing:
> - [x] Container tests
Thank you.
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Changes to `net` and `http` look good.
-
Marked as reviewed by dfuchs
> When generating `MethodHandle`-based concatenation expressions in
> `StringConcatFactory` we can reduce the number of classes generated at
> runtime by creating small batches of prependers and mixers before binding
> them into the root expression tree.
>
> Improvements on one-off tests are
On Wed, 1 Jun 2022 06:04:14 GMT, Alan Bateman wrote:
>> This patch adds an alternative virtual thread implementation where each
>> virtual thread is backed by an OS thread. It doesn't scale but it can be
>> used by ports that don't have continuations support in the VM. Aside from
>>
On Wed, 1 Jun 2022 08:39:44 GMT, Raffaello Giulietti
wrote:
> not just ties
Plz. disregard this 3 words
-
PR: https://git.openjdk.java.net/jdk/pull/8876
On Sun, 29 May 2022 14:46:39 GMT, Alan Bateman wrote:
> This patch adds an alternative virtual thread implementation where each
> virtual thread is backed by an OS thread. It doesn't scale but it can be used
> by ports that don't have continuations support in the VM. Aside from
> scalability,
On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Thu, 2 Jun 2022 10:57:37 GMT, Claes Redestad wrote:
>> When generating `MethodHandle`-based concatenation expressions in
>> `StringConcatFactory` we can reduce the number of classes generated at
>> runtime by creating small batches of prependers and mixers before binding
>> them into the
8287746: ProblemList jni/nullCaller/NullCallerTest.java
-
Commit messages:
- 8287746: ProblemList jni/nullCaller/NullCallerTest.java
Changes: https://git.openjdk.java.net/jdk/pull/9002/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9002=00
Issue:
On Thu, 2 Jun 2022 18:14:55 GMT, Gaurav Chaudhari wrote:
> Is the suggestion here to substitute the setting of the TZ environment
> variable, and simply getting a date based off this `SimpleTimeZone` , so as
> to bypass the process creation and just have it as a more simpler test?
No. The
On Thu, 2 Jun 2022 18:49:13 GMT, ExE Boss wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> We now don't need big Species classes for shorter concats, so on some
>> tests the improvements meant more Species class
This patch fixes a couple of issues in the package-level javadoc of the foreign
API.
I've also dropped uses of `var`, which I think are confusing so early in the
game.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.java.net/jdk/pull/9005/files
Webrev:
On Thu, 2 Jun 2022 19:12:18 GMT, Daniel D. Daugherty wrote:
>> 8287746: ProblemList jni/nullCaller/NullCallerTest.java
>
> test/jdk/ProblemList.txt line 500:
>
>> 498: java/lang/invoke/lambda/LambdaFileEncodingSerialization.java8249079
>> linux-x64
>> 499:
On Thu, 2 Jun 2022 18:57:36 GMT, Mandy Chung wrote:
> 8287746: ProblemList jni/nullCaller/NullCallerTest.java
This pull request has now been integrated.
Changeset: 37e1835b
Author:Mandy Chung
URL:
https://git.openjdk.java.net/jdk/commit/37e1835be76f5f141ba0dc067578bfe767ca94ed
On Thu, 2 Jun 2022 18:57:36 GMT, Mandy Chung wrote:
> 8287746: ProblemList jni/nullCaller/NullCallerTest.java
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/9002
On Thu, 2 Jun 2022 18:57:36 GMT, Mandy Chung wrote:
> 8287746: ProblemList jni/nullCaller/NullCallerTest.java
Marked as reviewed by dcubed (Reviewer).
test/jdk/ProblemList.txt line 500:
> 498: java/lang/invoke/lambda/LambdaFileEncodingSerialization.java8249079
> linux-x64
> 499:
On Thu, 2 Jun 2022 20:41:39 GMT, Maurizio Cimadamore
wrote:
> This patch fixes a couple of issues in the package-level javadoc of the
> foreign API.
> I've also dropped uses of `var`, which I think are confusing so early in the
> game.
Marked as reviewed by jvernee (Reviewer).
-
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull
On Fri, 27 May 2022 03:12:39 GMT, Alexander Matveev
wrote:
> Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app
> image. Un-signing takes time since we enumerating all files and un-signing
> binaries one by one. Average increase 2-3 minutes for tests which generates
On Thu, 2 Jun 2022 03:27:59 GMT, Xiaohong Gong wrote:
>> Currently the vector load with mask when the given index happens out of the
>> array boundary is implemented with pure java scalar code to avoid the IOOBE
>> (IndexOutOfBoundaryException). This is necessary for architectures that do
>>
On Thu, 2 Jun 2022 03:24:07 GMT, Xiaohong Gong wrote:
>>> @XiaohongGong Could you please rebase the branch and resolve conflicts?
>>
>> Sure, I'm working on this now. The patch will be updated soon. Thanks.
>
>> > @XiaohongGong Could you please rebase the branch and resolve conflicts?
>>
>>
On Thu, 2 Jun 2022 20:41:39 GMT, Maurizio Cimadamore
wrote:
> This patch fixes a couple of issues in the package-level javadoc of the
> foreign API.
> I've also dropped uses of `var`, which I think are confusing so early in the
> game.
This pull request has now been integrated.
Changeset:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader. The test for 8281006 was enhanced to test for this
>
> - Added support for signing predefined application image.
> - Following command can be used to sign predefined application images:
> jpackage --type app-image --app-image Test.app --mac-sign [additional signing
> options]
> - Main class and if --mac-app-store was specified will be saved in
On Fri, 3 Jun 2022 01:56:01 GMT, Alexander Matveev wrote:
>> - Added support for signing predefined application image.
>> - Following command can be used to sign predefined application images:
>> jpackage --type app-image --app-image Test.app --mac-sign [additional
>> signing options]
>> -
> - Added support for signing predefined application image.
> - Following command can be used to sign predefined application images:
> jpackage --type app-image --app-image Test.app --mac-sign [additional signing
> options]
> - Main class and if --mac-app-store was specified will be saved in
45 matches
Mail list logo
