Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

Hi Volker, Hi Volker et. al., Was a bug opened to track this ? I still see these files around http://hg.openjdk.java.net/jdk9/dev/jdk/file/ff45c582ca8a/src/java.base/aix/native/libjli Hi Kumar, no, as far as I know there's no bug for this issue until now. Have created a bug for you: https

Re: RFR JDK-8167328: jar -d m.jar hangs

> On Dec 1, 2016, at 2:47 PM, Xueming Shen wrote: > > Mandy, > > webrev has been updated accordingly. > > http://cr.openjdk.java.net/~sherman/8167328/ +1 Mandy

Re: RFR JDK-8167328: jar -d m.jar hangs

Mandy, webrev has been updated accordingly. http://cr.openjdk.java.net/~sherman/8167328/ Thanks, Sherman On 12/01/2016 11:58 AM, Mandy Chung wrote: On Nov 30, 2016, at 4:48 PM, Xueming Shen wrote: Hi, Please help review the change for #8167328 issue: https://bugs.openjdk.java.net/browse/J

On what issues could I help clean up for JDK 9

Hi there, I wanted to ask if there is a simple JBS query to find small clean up parts to help with? Seems to me a good starting point for some „hacking-on-the-OpenJDK-sessions“ -Patrick

Re: RFR: 8170595: Optimize Class.isAnonymousClass

On 12/01/2016 10:21 AM, Mandy Chung wrote: On Dec 1, 2016, at 9:52 AM, Claes Redestad wrote: Hi, good suggestion, this tidies up a bit while not affecting score: http://cr.openjdk.java.net/~redestad/8170595/webrev.02 I like this better. It may be useful to add a private isTopLevel Class() f

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

On 12/01/2016 12:05 PM, Paul Sandoz wrote: On 1 Dec 2016, at 11:17, Xueming Shen wrote: On 11/28/2016 11:27 AM, Paul Sandoz wrote: On 25 Nov 2016, at 02:47, Tobias Hartmann wrote: I'm not sure if it is still desired to do the same boundary check in case of LATIN1 for the benefit of consis

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

> On 1 Dec 2016, at 11:17, Xueming Shen wrote: > > On 11/28/2016 11:27 AM, Paul Sandoz wrote: >>> On 25 Nov 2016, at 02:47, Tobias Hartmann >>> wrote: >>> I'm not sure if it is still desired to do the same boundary check in case of LATIN1 for the benefit of consistency. Assum

Re: RFR JDK-8167328: jar -d m.jar hangs

> On Nov 30, 2016, at 4:48 PM, Xueming Shen wrote: > > Hi, > > Please help review the change for #8167328 > > issue: https://bugs.openjdk.java.net/browse/JDK-8167328 > webrev: http://cr.openjdk.java.net/~sherman/8167328 > > It appears the desired behavior is to throw the error + help msg if t

Re: RFR 8170155: StringBuffer and StringBuilder stream methods are not late-binding

On 11/28/2016 11:27 AM, Paul Sandoz wrote: On 25 Nov 2016, at 02:47, Tobias Hartmann wrote: I'm not sure if it is still desired to do the same boundary check in case of LATIN1 for the benefit of consistency. Assume there might be concurrent access/operation between val = this.value and coun

Re: RFR: 8170595: Optimize Class.isAnonymousClass

> On Dec 1, 2016, at 9:52 AM, Claes Redestad wrote: > > Hi, > > good suggestion, this tidies up a bit while not affecting score: > > http://cr.openjdk.java.net/~redestad/8170595/webrev.02 I like this better. It may be useful to add a private isTopLevel Class() for getSimpleBinaryName to ca

Re: RFR: 8170595: Optimize Class.isAnonymousClass

Hi, good suggestion, this tidies up a bit while not affecting score: http://cr.openjdk.java.net/~redestad/8170595/webrev.02 Thanks! /Claes On 2016-12-01 17:58, christoph.dr...@freenet.de wrote: Hey, since I created the original mail I hope you don't mind my interest/comments. What

Re: RFR: 8170595: Optimize Class.isAnonymousClass

Hi, sadly, avoiding getSimpleBinaryName is where most of the gain comes from, avoiding getSimpleName only improves marginally on the baseline: Benchmark Mode CntScoreError Units Clazz.isAnonymousClass_Anon avgt 10 192.522 ± 33.214 ns/op Clazz.isAnonymous

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Thanks Christoph, Daniel! I've updated the test, removing the comments. As for 80 chars line limit, or slightly longer than that is fine with me. Given our codebase, it would be an enormous undertaking. I'm therefore fine with taking care of only the extremely long ones or any that impedes the

Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

On 2016-12-01 18:10, Alan Bateman wrote: On 01/12/2016 15:33, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency.

Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

On 01/12/2016 15:33, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this parti

Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

Roger, thanks for reviewing! /Claes On 2016-12-01 17:13, Roger Riggs wrote: Looks fine, very straight-forward. On 12/1/2016 10:33 AM, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and

RE: RFR: 8170595: Optimize Class.isAnonymousClass

Hey, since I created the original mail I hope you don't mind my interest/comments. What about using !isArray() && isLocalOrAnonymousClass() &&getSimpleBinaryName0() == null;to increase readability a bit? Thanks for investigating my initial interest on that level! Cheers, Christoph >

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Thanks Lance! I've re-created the webrev with the one-line change: webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/ I'll use https://bugs.openjdk.java.net/browse/JDK-8170556 for the cleanup, will expand to cover the str

Re: RFR: 8170595: Optimize Class.isAnonymousClass

Hi Claes, What is the performance difference if this method calls getSimpleBinaryName? Your patch exposes the implementation details and sensitive to the change there, if any. Mandy > On Dec 1, 2016, at 5:38 AM, Claes Redestad wrote: > > Hi, > > due to recent interest to optimize Class.isA

Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

Looks fine, very straight-forward. On 12/1/2016 10:33 AM, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Ther

RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection

Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java

Re: RFR JDK-8167328: jar -d m.jar hangs

Thank you Sherman, this looks good. -Chris. > On 1 Dec 2016, at 00:48, Xueming Shen wrote: > > Hi, > > Please help review the change for #8167328 > > issue: https://bugs.openjdk.java.net/browse/JDK-8167328 > webrev: http://cr.openjdk.java.net/~sherman/8167328 > > It appears the desired behav

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

On 01/12/16 14:40, Felix Yang wrote: Hi Daniel, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8162521/webrev.01/ Looks good Felix! -- daniel Thanks, Felix On 2016/12/1 18:58, Daniel Fuchs wrote: Hi Felix, Good to see one more script converted to java. I wonder i

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

Hi Daniel, please review the new webrev: http://cr.openjdk.java.net/~xiaofeya/8162521/webrev.01/ Thanks, Felix On 2016/12/1 18:58, Daniel Fuchs wrote: Hi Felix, Good to see one more script converted to java. I wonder if the fact that the test use to run two separate JVMs was significant.

Re: RFR 8170559, Incorrect bug id in problem list

Looks fine On 11/30/2016 8:40 PM, Felix Yang wrote: Hi there, please review the change to correct a mistake. An incorrect bug id was incidentally used in problem list. Bug: https://bugs.openjdk.java.net/browse/JDK-8170559 Thanks, Felix diff -r a563aaa85446 test/ProblemList.txt --- a/

RFR: 8170595: Optimize Class.isAnonymousClass

Hi, due to recent interest to optimize Class.isAnonymousClass[1] I took a look at the implementation and found that we can further improve performance of this method, especially when asking non-anonymous classes[2]. As such calls are a common occurrence during startup and bootstrap of lambdas th

Re: Enhancements to Java Collections API

Hi John, I'm not sure about most of the suggestions you've made, especially the Bidi* ones, but I understand that something like your suggestion for an enhanced `Optional getIfPresent(K key)` is (or was) being investigated by Mr. Goetz himself and other people over at Project Valhalla

Re: RFR: JDK-8075577: java.time does not support HOST provider

Hi Roger, Thanks for the review. Updated patch is : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.02/ Please find some of my comments inlined. On 30/11/16 10:17 PM, Roger Riggs wrote: Hi Rachna, macosx//HostLocaleProviderAdapterImpl.java: - line 172-177, might be a good place t

Re: RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

Hi Felix, Good to see one more script converted to java. I wonder if the fact that the test use to run two separate JVMs was significant. Hopefully it's not. The changes in TestHttpServer seem OK - this class is shared by many other tests - so any modifications here is to be taken with care. I

Re: [NEW BUG]: Small enhancement for Class.isAnonymousClass()

Hi Christoph, nothing wrong with tiny code changes when they actually matter (and Class.isAnonymousClass is rather widely used internally and in reflection libraries, so I'd say any significant improvement is worth considering). I'm a bit surprised by the large improvement from your suggested ch

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Hi Joe, I agree with Christoph's comments below. +1 best regards, -- daniel On 01/12/16 07:40, Langer, Christoph wrote: Hi Joe, to me this looks good. Did you already remove the cleanups from http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/ ? I can't see a lot of them any more...

RFR 8162521, java/net/Authenticator/B4933582.sh fails intermittently with BindException

Hi, please review the following patch. The code was converted from shell script to plain Java. Since it is by-design to bind on a prior-used port, add a few of re-tries for possible BindException. Bug: https://bugs.openjdk.java.net/browse/JDK-8162521 Webrev: http://cr.openjdk.j