Re: RFC: Make test failed because of the locale LANG

Hi Jing, On 28/03/2019 3:22 pm, Jing Tian wrote: Hi, When I am doing the 'make test'.If the local LANG is set as 'zh_CN.UTF-8', Test cases will have a lot of error messages. == Test summary ==    TEST   

Re: Review Request: 8221530: Caller sensitive methods not handling caller = null when invoked by JNI code with no java frames on stack

Hi Mandy, This sounds quite reasonable to me. If there is no calling context then only public entities of publicly accessible packages should be accessible. JNI itself does not apply access checks so JNI code should be using direct field access, and not core reflection, if it needs to bypass

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

On 3/27/19 4:56 PM, Lance Andersen wrote: Hi Mandy, On Mar 27, 2019, at 7:23 PM, Mandy Chung > wrote: Hi Lance, Do you understand what takes so long for this test to run? Well it is executing a lot of jar commands.  I did not see anything that sticks out

Re: Review Request: 8221530: Caller sensitive methods not handling caller = null when invoked by JNI code with no java frames on stack

Looks good. -Sundar On 28/03/19, 4:47 AM, Mandy Chung wrote: This is to fix a regression introduced in JDK 12 by JDK-8206240. This impacts only native application that creates JVM via JNI and also invokes Field::getField (or other reflection API) via JNI that triggers reflection access check

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

Hi Mandy, > On Mar 27, 2019, at 7:23 PM, Mandy Chung wrote: > > Hi Lance, > > Do you understand what takes so long for this test to run? Well it is executing a lot of jar commands. I did not see anything that sticks out in the failed logs that point to anything obvious. > Is it running

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

Hello, I agree it would be preferable to understand why the test times out rather than just upping its timeout value. Thanks, -Joe On 3/27/2019 4:23 PM, Mandy Chung wrote: Hi Lance, Do you understand what takes so long for this test to run? Is it running fastdebug and -Xcomp or other

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

Hi Lance, Do you understand what takes so long for this test to run? Is it running fastdebug and -Xcomp or other flag? Mandy On 3/27/19 1:55 PM, Lance Andersen wrote: Hi all , Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 which increases the timeout value for

Re: RFR: JDK-8215241: Permissions are not set correctly on sub-folders in /Applications

fix looks good /Andy On 3/27/2019 4:43 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8215241 webrev: http://cr.openjdk.java.net/~ssadetsky/8215241/webrev.00/ The fix adds

Review Request: 8221530: Caller sensitive methods not handling caller = null when invoked by JNI code with no java frames on stack

This is to fix a regression introduced in JDK 12 by JDK-8206240. This impacts only native application that creates JVM via JNI and also invokes Field::getField (or other reflection API) via JNI that triggers reflection access check against the caller class. The regression happens only when there

Re: RFR: JDK-8215241: Permissions are not set correctly on sub-folders in /Applications

Hi Semyon, Looks good. Thanks, Alexander On 3/27/2019 1:43 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8215241 webrev: http://cr.openjdk.java.net/~ssadetsky/8215241/webrev.00/ The fix adds

Re: RFR: JDK-8221565: Linux build broken after merge with default branch

Hi Andy, Changes looks fine, but do we really need such try/catch block? I think this code needs to be modify, so we do not need such try/catch or handle this error as real error. Probably another bug can be filed to do this. Thanks, Alexander On 3/27/2019 12:33 PM, Andy Herrick wrote:

Re: RFR (JDK 13) 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java

Thanks Lance, Brian! -Joe On 3/27/19, 1:37 PM, Lance Andersen wrote: +1 On Mar 27, 2019, at 3:51 PM, Joe Wang > wrote: Please review a trivial fix for the missing commas in three class files. hg diff diff --git

Re: 8221568: DataOutputStream/WriteUTF.java fails due to "OutOfMemoryError: Java heap space"

On 3/27/19 10:17 PM, Brian Burkhalter wrote: > https://bugs.openjdk.java.net/browse/JDK-8221568 > > Require 64-bit arch and increase heap size to 3 GB [0]. Without this patch, > the test failed on macosx-x64 and solaris-sparcv9. With the patch, it passed > on those systems as well as linux-x64

8221568: DataOutputStream/WriteUTF.java fails due to "OutOfMemoryError: Java heap space"

https://bugs.openjdk.java.net/browse/JDK-8221568 Require 64-bit arch and increase heap size to 3 GB [0]. Without this patch, the test failed on macosx-x64 and solaris-sparcv9. With the patch, it passed on those systems as well as linux-x64 and windows-x64. Thanks, Brian [0] Patch ---

Re: RFR: 8216539: tools/jar/modularJar/Basic.java timed out

Seems reasonable. [1] Brian > On Mar 27, 2019, at 1:55 PM, Lance Andersen wrote: > > Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 > which increases the > timeout value for this test which fails once in a blue

RFR: 8216539: tools/jar/modularJar/Basic.java timed out

Hi all , Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8216539 which increases the timeout value for this test which fails once in a blue moon on windows. ——— $ hg diff diff -r dc66ada06693 test/jdk/tools/jar/modularJar/Basic.java ---

RFR: JDK-8215241: Permissions are not set correctly on sub-folders in /Applications

bug: https://bugs.openjdk.java.net/browse/JDK-8215241 webrev: http://cr.openjdk.java.net/~ssadetsky/8215241/webrev.00/ The fix adds preinstall/postinstall scripts to the created package which ensure that installation dir is created

Re: RFR (JDK 13) 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java

+1 > On Mar 27, 2019, at 3:51 PM, Joe Wang wrote: > > Please review a trivial fix for the missing commas in three class files. > > hg diff > diff --git > a/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationDayTimeImpl.java > >

Re: RFR (JDK 13) 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java

+1 , > On Mar 27, 2019, at 12:51 PM, Joe Wang wrote: > > Please review a trivial fix for the missing commas in three class files.

RFR (JDK 13) 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java

Please review a trivial fix for the missing commas in three class files. hg diff diff --git a/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationDayTimeImpl.java

RFR: JDK-8221565: Linux build broken after merge with default branch

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] - https://bugs.openjdk.java.net/browse/JDK-8221565 [2] - http://cr.openjdk.java.net/~herrick/8221565 /Andy

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

Hi Thomas, Will do and appreciate the support! Cheers, Martijn On Wed, 27 Mar 2019 at 11:13, Thomas Stüfe wrote: > > > On Wed, Mar 27, 2019 at 11:08 AM Martijn Verburg > wrote: > >> Hi Thomas, >> >> Release only (we've only created debug builds for x64), >> > > Okay. A number of those

RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

Hello could you please look into it ? Best regards, Matthias > -Original Message- > From: Baesken, Matthias > Sent: Montag, 25. März 2019 18:05 > To: Langer, Christoph > Cc: 'core-libs-dev@openjdk.java.net' ; > 'Alan Bateman' > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows

Re: Formatting rules for exception messages

2019/3/25 5:24:37 -0700, Florian Weimer : > Are there any guidelines for formatting exception messages? > > In particular, I'm interested in the case when the exception message > is a (clipped) sentence. Is it supposed to start with a capital > letter? > > If the message refers to a parameter

Re: Request for sponsor: JDK-8221430: StringBuffer(CharSequence) constructor truncates when -XX:-CompactStrings specified

Anyone who does String coder hacking should meditate on the wisdom at: https://shipilev.net/#string-catechism

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, >and also the cases when it requires to look at its caller > frame. > > Never. Only the method that was executed when the exception is > thrown is needed. I only mention the backtrace because it happens to > store the top method and the corresponding

Re: Request for sponsor: JDK-8221430: StringBuffer(CharSequence) constructor truncates when -XX:-CompactStrings specified

Hi Ivan, On 03/26/2019 07:30 PM, Ivan Gerasimov wrote: The main source of confusion here seems to be due to that the coder is passed in as an argument, so it either needs to be trusted or has to be verified in the constructor. The design for coder is that it *is* trusted in all

Re: RFR: JDK-8221525: jpackage fails with non-ASCII characters in --copyright

change looks good. /Andy On 3/26/2019 10:57 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - .properties file was written in default encoding

Re: Request for sponsor: JDK-8221430: StringBuffer(CharSequence) constructor truncates when -XX:-CompactStrings specified

I like your change Ivan, i've just reviewed it all and it works nicely for me, it puts all the key logic in one place. Roger what do you think? Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email:

Re: RFR: 8221473: Configuration::reads can use Set.copyOf

Hi, On 3/26/19 7:44 PM, Daniel Fuchs wrote: Hi Peter, On 26/03/2019 18:01, Peter Levart wrote: Would such method addition be worth it? Here is the impl of Set.copyOf:     static Set copyOf(Collection coll) {     if (coll instanceof ImmutableCollections.AbstractImmutableSet) {  

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

On Wed, Mar 27, 2019 at 11:08 AM Martijn Verburg wrote: > Hi Thomas, > > Release only (we've only created debug builds for x64), > Okay. A number of those errors were debug only. > we do use the treat errors as warnings flag. > Other way around, I hope ;) > > You can look at all of our

Re: RFR (XS) 8221524: java/util/Base64/TestEncodingDecodingLength.java should be disabled on 32-bit platforms

On 26/03/2019 23:00, Aleksey Shipilev wrote: - * @requires os.maxMemory >= 10g + * @requires (sun.arch.data.model == "64" & os.maxMemory >= 10g) Looks okay to me. -Alan

Re: RFR (XS) 8221524: java/util/Base64/TestEncodingDecodingLength.java should be disabled on 32-bit platforms

Good & trivial. ..Thomas On Wed, Mar 27, 2019 at 12:00 AM Aleksey Shipilev wrote: > Bug: > https://bugs.openjdk.java.net/browse/JDK-8221524 > > It currently requests -Xmx8g, which is above the max representable memory > for 32-bit VM. The test > allocates byte[Integer.MAX_VALUE - C], which

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

Hi Thomas, Release only (we've only created debug builds for x64), we do use the treat errors as warnings flag. You can look at all of our build configurations and build histories at ci.adoptopenjdk.net - and I've copied in Ali Ince who's working for jClarity on Windows 32/64 builds amongst