Hello,
Next step in the serialization warnings pre-cleanup is java.sql.*
modules. Please review the proposed changes:
JDK-8231442 : Suppress warnings on non-serializable instance fields
in java.sql.* modules
http://cr.openjdk.java.net/~darcy/8231442.0/
Several of the writeObject
Hello all,
*TLDR: Why doesn't RandomAccess interface extend List?*
I'm maintaining a framework that lets developers build plugins, and
developers implement a `put(List thingList)` in their plugins.
However, I want to guarantee to the implementer that their List will
support RandomAccess. I see
Build fails on my CI Window Server 2008 & 2012 agents.
I am only able to get it to build on a Windows 10 system.
[12:49:04][Step 1/1] ERROR: Build failed for target 'jdk' in configuration
'windows-x86-server-release' (exit code 2)
[12:49:05][Step 1/1]
[12:49:05][Step 1/1] === Output from failing
Hi Andy,
Looks good.
Do you think it would be better to write CLI arguments in some internal
format instead of just raw dump? It might be better in case if we plan
to change CLI between versions and at same time supporting generation of
installers for app image using different jpackage
Looks good.
On 9/24/2019 11:08 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 9/24/2019 1:24 PM, Andy Herrick wrote:
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings
with the CLIOptions id's, and adds unit
Frederic, could you figure out how to resolve
8231031: runtime/ReservedStack/ReservedStackTest.java fails after jsr166
refresh
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/ReservedStackTest/index.html
https://bugs.openjdk.java.net/browse/JDK-8231031
On Mon, Sep 23, 2019 at
Milan,
I satisfied myself by running the final version of the test some 8k times and
then pushed the change. Thanks for your patience and persistence.
I saw your question on the net-dev and nio-dev mailing lists. Thanks.
-Pavel
> On 24 Sep 2019, at 13:41, Milan Mimica wrote:
>
> Pavel,
>
>
Hi,
I'd like this community to help me pushing a new spec and the
accompanying implementation of Double.toString(double) and
Float.toString(float) into the OpenJDK 14 release.
All material has already been submitted to this mailing list months ago
[2] and passes tier 1 tests. Yet, there
On 9/24/19 1:01 PM, Brent Christian wrote:
http://cr.openjdk.java.net/~bchristi/8221623/webrev11/
Looks okay. Thanks for doing this.
Mandy
On 9/23/19 4:48 PM, Mandy Chung wrote:
I think doing the measurement for one of these would be adequate.
StackWalkBench.forEach_AllOpts
StackWalkBench.forEach_DefaultOpts
StackWalkBench.forEach_HiddenAndReflectFrames
OK, reduced to just DefaultOpts.
There are a couple of commented
Am 21.09.19 um 00:03 schrieb mark.reinh...@oracle.com:
> To avoid this confusion, a more verbose specification might read:
> * Returns the maximum number of $otype$s that will be produced for each
> * $itype$ of input. This value may be used to compute the worst-case
> size
> *
> On 24 Sep 2019, at 13:41, Milan Mimica wrote:
>
> Pavel,
>
> Deal. Handling early returns too:
> http://cr.openjdk.java.net/~mmimica/8228580/webrev.05/
LGTM
-Chris
Looks good.
- Alexey
On 9/24/2019 1:24 PM, Andy Herrick wrote:
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings
with the CLIOptions id's, and adds unit test to AddLauncherTest.java
[3]
Revision 2 or the webrev ( [3] ) removes the comment about
`--linux-deb-copyright-file` option., replaces the literal strings with
the CLIOptions id's, and adds unit test to AddLauncherTest.java
[3] http://cr.openjdk.java.net/~herrick/8230927/webrev.02/
/Andy
On 9/24/2019 9:19 AM, Alexey
2019/9/24 8:04:55 -0700, alan.bate...@oracle.com:
> Thread.suspend/resume (and the corresponding methods in ThreadGroup)
> have been deprecated since 1.2 (1998). I haven't see anything use these
> methods in many years. Would anyone care if their deprecation is changed
> to forRemoval=true with
On 23/09/2019 21:45, naoto.s...@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8230531
Relevant CSR (in draft) and proposed changeset are located at:
[CSR]: https://bugs.openjdk.java.net/browse/JDK-8231319
[changeset]:
Thread.suspend/resume (and the corresponding methods in ThreadGroup)
have been deprecated since 1.2 (1998). I haven't see anything use these
methods in many years. Would anyone care if their deprecation is changed
to forRemoval=true with a view to really removing them in the future?
Just to
Thanks!
Best regards,
Goetz
> -Original Message-
> From: Roger Riggs
> Sent: Dienstag, 24. September 2019 15:54
> To: Lindenmaier, Goetz ; Hotspot dev runtime
> ; Java Core Libs d...@openjdk.java.net>
> Subject: Re: RFR (L, final): 8218626: Add detailed message to
>
Looks good.
/Andy
On 9/20/19 7:57 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- directory layout of Linux app image adjusted to better comply with
Linux
looks good
/Andy
On 9/23/2019 7:55 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
- remove --linux-deb-copyright option.
- add tests to verify that placing
Hi Goetz,
Looks good.
Count me as a (java) Reviewer.
Thanks, Roger
On 9/24/19 4:13 AM, Lindenmaier, Goetz wrote:
Hi Roger,
thanks for improving the text! Good point to add
@implNote.
This webrev includes the fixed comments:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/19/
Is it
Andy,
Please remove javadoc update about `--linux-deb-copyright-file` option.
It will be dropped in https://bugs.openjdk.java.net/browse/JDK-8231277
patch.
Line 180:
---
if (additional.containsKey("java-optiions")) {
---
Looks like a typo. Should be "java-options", not "java-optiions", I
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix replaces the practice we were using on windows to determine the
application name, and name of additional launchers (by looking for
".cfg"
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This change applies when arguments or java-options are used in an
add-launcher properties file.
In these cases the arguments or java-options from
Pavel,
Deal. Handling early returns too:
http://cr.openjdk.java.net/~mmimica/8228580/webrev.05/
I will ask there about socket timeout semantics.
On Tue, 24 Sep 2019 at 12:51, Pavel Rappo wrote:
>
> Milan,
>
> Thanks for looking into this. I think you should ask a question on the
> expected
Thanks Julia!
It's now pushed.
best regards,
-- daniel
On 24/09/2019 10:50, Julia Boes wrote:
Hi,
Thanks for the review, Lance and Brent!
Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.04/
Regards,
Julia
Hi Goetz,
just one thing:
>> In NullPointerExceptionTest.java:
> >
> > It seems you don't have tests for invokeinterface or invokespecial calls to
> > cause
> > an NPE (e.g. by calling a null interface variable or a private non-static
> > method
> > of a null objects).
> That is because the
Milan,
Thanks for looking into this. I think you should ask a question on the expected
timing semantics and guarantees on net-dev (with maybe a cc to nio-dev).
As for our test. I agree with you that we should simply work a possibility of
early returns into the check.
...
/* The acceptable
Hi,
Thanks for the review, Lance and Brent!
Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8231186/webrev.04/
Regards,
Julia
On 23/09/2019 19:58, Lance Andersen wrote:
Hi Julia,
I made a quick pass and the changes seem OK
On Sep 23, 2019, at 2:17 PM, Julia Boes
Hi Roger,
thanks for improving the text! Good point to add
@implNote.
This webrev includes the fixed comments:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/19/
Is it ok to add you as reviewer (for the java.base part)?
Best regards,
Goetz.
> -Original Message-
> From:
Hi Pavel
Wow, I find this awesome. I don't have a Windows machine to play with,
but I think I may have found something.
The difference is how Java_sun_nio_ch_Net_poll is implemented. On unix
it uses poll(2), on Windows it uses select(2). Regarding timeouts,
poll() has "wait at least" semantics
Hi Remi,
thanks for the heads up, I incorporated it in the
main webrev:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/19/
Best regards,
Goetz.
> -Original Message-
> From: fo...@univ-mlv.fr
> Sent: Montag, 23. September 2019 18:02
> To: Lindenmaier, Goetz
> Cc:
Except when I run it through our test system ReservedStackTest is still
failing :(
I tested it initially when Fred proposed it and that went fine. It also
passes for me locally on Linux.
David
On 24/09/2019 12:20 pm, David Holmes wrote:
Hi Martin,
That all seems fine to me.
Thanks,
David
33 matches
Mail list logo
