Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-30 Thread David Holmes
Hi Doug, On 30/10/2019 10:06 pm, Doug Simon wrote: On 30 Oct 2019, at 05:28, David Holmes wrote: Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test, HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how

Re: RFR: JDK-8232186: Add verification for pkg and dmg tests

2019-10-30 Thread Alexey Semenyuk
Looks good. - Alexey On 10/30/2019 8:37 PM, Alexander Matveev wrote: http://cr.openjdk.java.net/~almatvee/8232186/webrev.04/ - Added trace to Hello.java. - Re-done how FA is excluded for DMG tests. Thanks, Alexander On 10/29/2019 10:42 AM, Alexey Semenyuk wrote:

Re: RFR: JDK-8233138: Error 2343 when using --win-dir-chooser

2019-10-30 Thread Alexey Semenyuk
On 10/30/2019 8:12 PM, Alexander Matveev wrote: Hi Alexey, Looks good. Did you test it by trying to install into existing folder? I remember having issues reading some variables in libwixhelper.cpp. Yes, I did. Without the fix in libwixhelper.cpp it allowed to install in non-empty

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-30 Thread David Holmes
Thanks Serguei! David On 31/10/2019 10:36 am, serguei.spit...@oracle.com wrote: Hi David, The update looks good. Thanks, Serguei On 10/29/19 9:28 PM, David Holmes wrote: Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test,

Re: RFR: JDK-8232186: Add verification for pkg and dmg tests

2019-10-30 Thread Alexander Matveev
http://cr.openjdk.java.net/~almatvee/8232186/webrev.04/ - Added trace to Hello.java. - Re-done how FA is excluded for DMG tests. Thanks, Alexander On 10/29/2019 10:42 AM, Alexey Semenyuk wrote:

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-30 Thread serguei . spitsyn
Hi David, The update looks good. Thanks, Serguei On 10/29/19 9:28 PM, David Holmes wrote: Hi Doug, Your proposed patch wasn't quite right. I made some adjustments but I'm still having issues with the test, HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how to make

Re: RFR: JDK-8233143: RPM errors: rpmbuild: no spec files given for build

2019-10-30 Thread Andy Herrick
looks good. /Andy On 10/30/2019 6:03 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233143 [2]

Re: RFR: JDK-8233143: RPM errors: rpmbuild: no spec files given for build

2019-10-30 Thread Alexander Matveev
Looks good. On 10/30/2019 3:03 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233143 [2]

Re: RFR: JDK-8233218: rpm uninstall errors (xdg-icon-resource: the icon size must be specified with --size)

2019-10-30 Thread Andy Herrick
looks good. /Andy On 10/30/2019 3:48 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233218 [2]

Re: RFR: JDK-8233138: Error 2343 when using --win-dir-chooser

2019-10-30 Thread Andy Herrick
looks good /Andy On 10/30/2019 4:42 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally removed code that adds component to msi package to remove files and

Re: RFR: JDK-8233138: Error 2343 when using --win-dir-chooser

2019-10-30 Thread Alexander Matveev
Hi Alexey, Looks good. Did you test it by trying to install into existing folder? I remember having issues reading some variables in libwixhelper.cpp. Thanks, Alexander On 10/30/2019 1:42 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the

Re: RFR: JDK-8233218: rpm uninstall errors (xdg-icon-resource: the icon size must be specified with --size)

2019-10-30 Thread Alexander Matveev
Looks good. On 10/30/2019 12:48 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233218 [2]

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-30 Thread David Holmes
Hi Alan, Thanks for taking a look at this. On 31/10/2019 1:33 am, Alan Bateman wrote: On 29/10/2019 07:42, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev:

RFR: JDK-8233143: RPM errors: rpmbuild: no spec files given for build

2019-10-30 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233143 [2] http://cr.openjdk.java.net/~asemenyuk/8233143/webrev.00

RFR: JDK-8233138: Error 2343 when using --win-dir-chooser

2019-10-30 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally removed code that adds component to msi package to remove files and directories not managed by the msi package in shortcuts folder

RFR: JDK-8233218: rpm uninstall errors (xdg-icon-resource: the icon size must be specified with --size)

2019-10-30 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8233218 [2] http://cr.openjdk.java.net/~asemenyuk/8233218/webrev.00

Re: RFR: JDK-8229871: Improve performance of Method.copy() and leafCopy()

2019-10-30 Thread Kazunori Ogata
Hi Peter, Thank you very much for your updated fix and sorry to be late to reply. I found that the performance data I posted earlier was wrong because I fetched the latest code before building the JVM with your fix, while I still used older JVM as the base version. The new build picked up

Re: RFR: 8232161 Unexpected 1-way trip conversion entries on MS950 charset

2019-10-30 Thread naoto . sato
Takiguchi-san, Personally I am reluctant to make this change. If we were to introduce this, it will be a different encoding from the existing MS950, so either 1) we need a new encoding, or 2) make some switch between the encoding, possibly a system property. But neither seems worth doing, as

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-30 Thread Alan Bateman
On 29/10/2019 07:42, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229516 CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved) webrev: http://cr.openjdk.java.net/~dholmes/8229516/webrev/ The implNote has "In the JDK Reference Implementation". I think you

Fwd: 8232271: java.io.File.get*Space() should be aligned to updated FileStore analog methods

2019-10-30 Thread Brian Burkhalter
Ping ! > Begin forwarded message: > > From: Brian Burkhalter > Subject: 8232271: java.io.File.get*Space() should be aligned to updated > FileStore analog methods > Date: October 17, 2019 at 10:35:46 AM PDT > To: Core-Libs-Dev > > For issue [1], please review the patch [2]. This change aligns

Re: 14-jpackage+1-64 rpm uninstall errors

2019-10-30 Thread Alexey Semenyuk
Hi Richard, I confirm these issues are reproducible on OL7. Filed https://bugs.openjdk.java.net/browse/JDK-8233218. - Alexey On 10/30/2019 6:49 AM, Richard Evans wrote: Using 14-jpackage+1-64 with file associations including a png icon, I see the RPM includes this in the removal script:

RE: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-30 Thread Langer, Christoph
Sure. Thanks, Alexey. > -Original Message- > From: Alexey Ivanov > Sent: Mittwoch, 30. Oktober 2019 14:22 > To: Langer, Christoph ; David Holmes > ; core-libs ; > hotspot-runtime > Cc: Claes Redestad > Subject: Re: RFR JDK-8232724: Remove indirection with calling >

Re: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-30 Thread Alexey Ivanov
Thank you, David and Christoph, for your reviews. I'll update the copyright year before the push if you don't mind. Regards, Alexey On 30/10/2019 09:05, Langer, Christoph wrote: +1 You'll have to update the copyright years in the jni_util files. Cheers Christoph -Original Message-

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-30 Thread Doug Simon
> On 30 Oct 2019, at 05:28, David Holmes wrote: > > Hi Doug, > > Your proposed patch wasn't quite right. I made some adjustments but I'm still > having issues with the test, > HotSpotMethodSubstitutionTest.testThreadSubstitutions, as I don't see how to > make the test execution

14-jpackage+1-64 rpm uninstall errors

2019-10-30 Thread Richard Evans
Using 14-jpackage+1-64 with file associations including a png icon, I see the RPM includes this in the removal script: ... xdg-icon-resource uninstall application-x-edqlaunch The problem is that the xdg-icon-resource command requires a --size argument: xdg-icon-resource uninstall

RE: RFR JDK-8232724: Remove indirection with calling JNU_NewStringPlatform

2019-10-30 Thread Langer, Christoph
+1 You'll have to update the copyright years in the jni_util files. Cheers Christoph > -Original Message- > From: David Holmes > Sent: Mittwoch, 30. Oktober 2019 05:29 > To: Alexey Ivanov ; core-libs d...@openjdk.java.net>; hotspot-runtime d...@openjdk.java.net>; Langer, Christoph >