Re: DriverManager.isDriverAllowed has an unintentional side-effect?

Hello Lance, On 11/02/20 2:05 am, Lance Andersen wrote: > Hi Jaikiran > > >> >> Should this check in the isDriverAllowed, instead use "false" and not >> trigger the intialization of the class? > > As I mentioned above, this dates back to the very early days of JDBC > and JDK 1.2.  Any changes in

Re: JEP 370 - text example leads to exception

Paul, thank you very much! In the meantime I did more reading about VarHandles and understood better the "philosophy" of coordinates and it made sense (eventually I was able to fix my own issues). Also, thank you for sharing Maurizio's talk - I will refer it in my examples. Speaking of

Re: RFR 8235812 : (regex) Unicode linebreak with quantifier does not match valid input

Thank you Roger for review! I've adjusted the test as you suggested and pushed the fix. With kind regards, Ivan On 2/10/20 1:11 PM, Roger Riggs wrote: Hi Ivan, This look fine. In the test TegExTest: 5074, I would output the failed cases to System.err. That way they get properly

Re: [15] RFR (xs) 8046362 IdentityHashMap.hash comments should be clarified

On 2/10/20 7:52 AM, Martin Buchholz wrote: On Fri, Feb 7, 2020 at 2:47 PM David Holmes wrote: Hi Martin, On 8/02/2020 3:10 am, Martin Buchholz wrote: I explored System.identityHashCode (see below). System.identityHashCode is a VM call that is potentially very expensive. In the

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

Hi Kiran, Thanks for reworking the test. This looks good to me. One small thing: 53 throw new IndexOutOfBoundsException(); This should include the offending index in the IOOBE. This might make Rémi happy. (Then again, it might not.) :-) I think this covers the concerns that

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

Hi Remi, The bug report originally requested that a bunch of different exceptions include a cause. I don't think the cause should be added to all of them. The cases that Kiran is adding are ones where I thought that adding a cause does have value. If someone is using a ListIterator (or a

Re: [15] RFR: 8234347: "Turkey" meta time zone does not generate composed localized names, 8236548: Localized time zone name inconsistency between English and other locales

Drafted a CSR: https://bugs.openjdk.java.net/browse/JDK-8238809 Appreciate the review for this as well. Naoto On 2/10/20 8:52 AM, naoto.s...@oracle.com wrote: Good point. I will file a CSR for the behavioral changes. Naoto On 2/7/20 6:00 PM, Joe Wang wrote: Hi Naoto, I see the existing

Re: 6202130: Need to handle UTF-8 values and break up lines longer than 72 bytes

Hi all, Here is a webrev for the patch that Philipp is proposing which will make it easier to review: http://cr.openjdk.java.net/~lancea/6202130/webrev.00 > On Dec 26, 2019, at 11:50 AM, Philipp Kunz wrote: > > Hi, > The specification

Re: RFR 8235812 : (regex) Unicode linebreak with quantifier does not match valid input

Hi Ivan, This look fine. In the test TegExTest: 5074, I would output the failed cases to System.err. That way they get properly interleaved with the test progress output. No need for another review. Thanks, Roger On 2/5/20 8:22 PM, Ivan Gerasimov wrote: Hello! j.u.regex.Pattern supports

Re: DriverManager.isDriverAllowed has an unintentional side-effect?

Hi Jaikiran > On Feb 10, 2020, at 10:09 AM, Jaikiran Pai wrote: > > Right now within the implementation of APIs in java.sql.DriverManager > there are classloader checks to ensure whether the caller is allowed > access to registered drivers. For example the getDriver(String url) > API[1] calls

Re: JEP 370 - text example leads to exception

Thanks for pointing out the inconsistencies. I modified the JEP with updated code snippets that compile against the latest API in JDK 14 [*]. The handle created “withStride” requires an additional coordinate the is an offset from the base address. You may find Maurizio’s recent talk at Fosdem

Re: New issues in notarization of jpackage-created Mac applications (Scott Palmer)

Thanks for drawing my attention to that related bug, Scott. I would add a comment on it that Apple has updated the notarization process so this symlink is now rejected at that stage, not just by Catalina itself, but I lack standing to do so. (It still strikes me as strange that OpenJDK

Re: [15] RFR: 8234347: "Turkey" meta time zone does not generate composed localized names, 8236548: Localized time zone name inconsistency between English and other locales

Good point. I will file a CSR for the behavioral changes. Naoto On 2/7/20 6:00 PM, Joe Wang wrote: Hi Naoto, I see the existing tests were changed, e.g. the abbreviation / short timezone name, the result of calling getDisplayName. Would you need a CSR to discuss/document the potential

Re: [15] RFR (xs) 8046362 IdentityHashMap.hash comments should be clarified

On Fri, Feb 7, 2020 at 2:47 PM David Holmes wrote: > Hi Martin, > > On 8/02/2020 3:10 am, Martin Buchholz wrote: > > I explored System.identityHashCode (see below). > > System.identityHashCode is a VM call that is potentially very expensive. > In the worst-case it triggers monitor inflation. >

DriverManager.isDriverAllowed has an unintentional side-effect?

Right now within the implementation of APIs in java.sql.DriverManager there are classloader checks to ensure whether the caller is allowed access to registered drivers. For example the getDriver(String url) API[1] calls the isDriverAllowed (private) method[2] to check if the registered driver is

Re: [PATCH] Enhancement proposal for java.util.StringJoiner

Hello Tagir, FYI, there's a full table of results for original/patched benchmarks: Benchmark (count) (latin) (length) OriginalPatched Units stringJoiner 1 true 1 26.9 ± 0.7 48.8 ±

Re: [PATCH] Enhancement proposal for java.util.StringJoiner

Hello! In many tests, I see little or no performance improvements. E.g.: stringJoiner 10010 1768.8 ± 160.6 1760.8 ± 111.4ns/op How would you explain that this code change doesn't improve the performance for given count and length?

Re: RFR: 8237878: Improve ModuleLoaderMap datastructures

On 2020-02-10 12:34, Alan Bateman wrote: On 10/02/2020 09:04, Claes Redestad wrote: : So how about: http://cr.openjdk.java.net/~redestad/8237878/open.02/ Thanks for restoring the use of Function. Changing Module::defineClass to invoke a method on ModuleLoaderMap is okay but the method

Re: RFR: 8237878: Improve ModuleLoaderMap datastructures

On 10/02/2020 09:04, Claes Redestad wrote: : So how about: http://cr.openjdk.java.net/~redestad/8237878/open.02/ Thanks for restoring the use of Function. Changing Module::defineClass to invoke a method on ModuleLoaderMap is okay but the method needs to something like "isBuiltinMapper"

Re: RFR: 8237878: Improve ModuleLoaderMap datastructures

On 2020-02-09 17:49, Alan Bateman wrote: On 06/02/2020 13:48, Claes Redestad wrote: : New webrev: http://cr.openjdk.java.net/~redestad/8237878/open.01/ The archiving looks good but I'd prefer if this patch didn't change the usages of Function to ModuleLoaderMap.Mapper - that's an

Re: [PATCH] Enhancement proposal for java.util.StringJoiner

Hello, I've reworked the code, patch is attached. Could you please review my solution regarding usage of SahredSecrets? P.S. After I've created the patch it came to my mind that instead of checking all Strings when calling StringJoiner.add() we can check them in toString() method and fail-fast