Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Jaikiran Pai
On Wed, 22 Sep 2021 15:20:21 GMT, Julia Boes wrote: > > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > > This being said, I want to make sure we're taking the right decision here > > so

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

2021-09-22 Thread Claes Redestad
On Mon, 13 Sep 2021 11:06:15 GMT, Сергей Цыпанов wrote: > Currently the method is implemented like > > public List> parameterList() { > return Collections.unmodifiableList(Arrays.asList(ptypes.clone())); > } > > This seems to be excessive, as three objects are allocated here. Instead we >

Re: RFR: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

2021-09-22 Thread Phil Race
On Thu, 16 Sep 2021 09:13:15 GMT, Aleksey Shipilev wrote: > This is a GUI test, and it should be `@headful`. > > Additional testing: > - [x] Test still runs in default, and does not run with `!headful` Well .. since our test framework doesn't run whatever test group this is in on headful

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Daniel Fuchs
On Wed, 22 Sep 2021 15:26:33 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main

Re: RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 [v2]

2021-09-22 Thread Naoto Sato
On Wed, 22 Sep 2021 17:41:18 GMT, Roger Riggs wrote: >> The Mac OS specific code to determine the os.version property in >> java_props_macosx.c is updated >> to replace the code extracting the version from the SystemVersion.plist by >> reading the version using t\ >> he hidden link: > > Roger

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v4]

2021-09-22 Thread Iris Clark
On Wed, 22 Sep 2021 15:38:33 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing "the" > > (Spotted by Brian Burkhalter.) Marked as

Re: RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0 [v2]

2021-09-22 Thread Roger Riggs
> The Mac OS specific code to determine the os.version property in > java_props_macosx.c is updated > to replace the code extracting the version from the SystemVersion.plist by > reading the version using t\ > he hidden link: Roger Riggs has updated the pull request incrementally with one

Re: RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

2021-09-22 Thread Naoto Sato
On Wed, 22 Sep 2021 15:00:59 GMT, Roger Riggs wrote: > The Mac OS specific code to determine the os.version property in > java_props_macosx.c is updated > to replace the code extracting the version from the SystemVersion.plist by > reading the version using t\ > he hidden link:

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v4]

2021-09-22 Thread Brian Burkhalter
On Wed, 22 Sep 2021 15:38:33 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing "the" > > (Spotted by Brian Burkhalter.) Marked as

Integrated: 8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family

2021-09-22 Thread Raffaello Giulietti
On Wed, 1 Sep 2021 20:13:38 GMT, Raffaello Giulietti wrote: > This PR ideally continues #5285, which has been closed as a consequence of > inadvertently removing the branch on my repo. See there for initial > discussion. > > Sorry for the mess. This pull request has now been integrated.

Re: RFR: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle [v9]

2021-09-22 Thread Mandy Chung
> This reimplements core reflection with method handles. > > For `Constructor::newInstance` and `Method::invoke`, the new implementation > uses `MethodHandle`. For `Field` accessor, the new implementation uses > `VarHandle`.For the first few invocations of one of these reflective >

Re: Unused HashMap's in ThaiBuddhistChronology

2021-09-22 Thread Naoto Sato
I would think these are some left-overs from the 310 project, as I see the same fields in 310's Hijrah chronology. These should be cleaned up. https://github.com/ThreeTen/threetenbp/blob/master/src/main/java/org/threeten/bp/chrono/HijrahChronology.java BTW, it would be moot once they are gone,

Integrated: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

2021-09-22 Thread Naoto Sato
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote: > Fixing an AIOOBE on normalizing the month value. This pull request has now been integrated. Changeset: d39aad92 Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/commit/d39aad92308fbc28bd2de164e331062ebf62da85 Stats:

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Scott Palmer
> On Sep 22, 2021, at 11:22 AM, Andy Herrick wrote: > > I still don't get the error your report. Is there something else that needs > to be set up for using instrumentation ? Nothing that I’m aware of. Maybe there is something to do with Visual C/C++ runtime libraries that I have

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v4]

2021-09-22 Thread Lance Andersen
On Wed, 22 Sep 2021 15:35:54 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing "the" > > (Spotted by Brian Burkhalter.) Marked as

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v4]

2021-09-22 Thread Pavel Rappo
> 8274075: Fix miscellaneous typos in java.base Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Add missing "the" (Spotted by Brian Burkhalter.) - Changes: - all: https://git.openjdk.java.net/jdk/pull/5610/files

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

2021-09-22 Thread Jorn Vernee
On Mon, 13 Sep 2021 11:06:15 GMT, Сергей Цыпанов wrote: > Currently the method is implemented like > > public List> parameterList() { > return Collections.unmodifiableList(Arrays.asList(ptypes.clone())); > } > > This seems to be excessive, as three objects are allocated here. Instead we >

RFR: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

2021-09-22 Thread Roger Riggs
The Mac OS specific code to determine the os.version property in java_props_macosx.c is updated to replace the code extracting the version from the SystemVersion.plist by reading the version using t\ he hidden link: - Commit messages: - 8269850: Most JDK releases report macOS

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v3]

2021-09-22 Thread Julia Boes
On Fri, 17 Sep 2021 14:11:38 GMT, Julia Boes wrote: > Thanks for sharing your experience on this, it's appreciated. 0.0.0.0 is > common default for Apache httpd [1], Ngnix [2], the Python web server [3]. > This being said, I want to make sure we're taking the right decision here so > let me

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v6]

2021-09-22 Thread Julia Boes
> This change implements a simple web server that can be run on the > command-line with `java -m jdk.httpserver`. > > This is facilitated by adding an entry point for the `jdk.httpserver` module, > an implementation class whose main method is run when the above command is > executed. This is

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Andy Herrick
I still don't get the error your report.  Is there something else that needs to be set up for using instrumentation ? I do get a different error when I have both runtime and jre directories after "cp -r jre runtime" (in FetchURL/build/application/FetchURL dir) As built (before copy): $

Withdrawn: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0

2021-09-22 Thread Roger Riggs
On Tue, 21 Sep 2021 19:33:05 GMT, Roger Riggs wrote: > The Mac OS specific code to determine the os.version property in > java_props_macosx.c is updated > to replace the code extracting the version from the SystemVersion.plist by > reading the version using the hidden link: >

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Scott Palmer
Sorry That last build with the Oracle OpenJDK needed the build file changed to have vendor = JvmVendorSpec.ORACLE as well as the command line property pointing to the path to the jdk, Scott > On Sep 22, 2021, at 10:24 AM, Scott Palmer wrote: > > I reproduced it with the AZUL's

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Scott Palmer
I reproduced it with the AZUL's distribution of OpenJDK (with JavaFX modules bundled) and I just changed: vendor = JvmVendorSpec.ADOPTOPENJDK And get the same error with that build of OpenJDK as well. “OpenJDK Runtime Environment Temurin-17+35 (build 17+35)” You can try that, as

Integrated: 8274003: ProcessHandleImpl.Info toString has an if check which is always true

2021-09-22 Thread Roger Riggs
On Tue, 21 Sep 2021 18:14:17 GMT, Roger Riggs wrote: > Correct the check if any field has been appended to the StringBuilder in > ProcessHandleImpl.Info.toString(). This pull request has now been integrated. Changeset: 33df388a Author:Roger Riggs URL:

Integrated: 8272600: (test) Use native "sleep" in Basic.java

2021-09-22 Thread Roger Riggs
On Tue, 24 Aug 2021 15:55:28 GMT, Roger Riggs wrote: > The intermittent test in java/lang/ProcessBuilder/Basic.java has identified > unexpected messages from a child Java VM > as the cause of the test failure. Attempts to control the output of the > child VM have failed, the VM is unrepentant

Re: RFR: 8272600: (test) Use native "sleep" in Basic.java [v6]

2021-09-22 Thread Roger Riggs
On Wed, 22 Sep 2021 00:03:41 GMT, David Holmes wrote: >> I thought of that too, but notice the parens "()" around that /bin/sleep; >> that creates and extra level of forked processes and its harder to get that >> pid. There probably is a way to traverse the hierarchy but I'll keep it as >> is

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Andy Herrick
I can't seem to get your testcase to work with the Oracle JDK configured. I can build, but then when I run $ ./build/application/FetchURL/FetchURL.exe I get: *** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message c an't find transform methodID at JPLISAgent.c line:

Integrated: 8274071: Clean up java.lang.ref comments and documentation

2021-09-22 Thread Pavel Rappo
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo wrote: > This PR fixes an inline comment typo and reduces "overlinking" in a doc > comment in `java.lang.ref.Reference`. Overlinking happens because the > `reachabilityFence` method: > * Links `package-summary.html#reachability` twice. > * Refers

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

2021-09-22 Thread Claes Redestad
On Wed, 22 Sep 2021 00:21:01 GMT, Claes Redestad wrote: >> Currently the method is implemented like >> >> public List> parameterList() { >> return Collections.unmodifiableList(Arrays.asList(ptypes.clone())); >> } >> >> This seems to be excessive, as three objects are allocated here. Instead

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v3]

2021-09-22 Thread Lance Andersen
On Wed, 22 Sep 2021 13:01:34 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with two additional > commits since the last revision: > > - Fix "non-white space" > >JDK predominantly uses

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

2021-09-22 Thread Pavel Rappo
On Tue, 21 Sep 2021 13:16:02 GMT, Pavel Rappo wrote: >> 8274075: Fix miscellaneous typos in java.base > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Tweak wording for Throwable constructor parameters Please re-review this

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

2021-09-22 Thread Pavel Rappo
On Wed, 22 Sep 2021 10:24:12 GMT, Pavel Rappo wrote: >> Note that we don't throw the "wrapped exception" we throw the exception that >> wraps it. The "wrapped exception" is the original cause. The wording as >> presented now is correct in that regard. You could also say "Throwing a >> wrapper

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v3]

2021-09-22 Thread Pavel Rappo
> 8274075: Fix miscellaneous typos in java.base Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision: - Fix "non-white space" JDK predominantly uses "non-whitespace". There's only one more use of "non-white space", in

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 17:16:08 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

2021-09-22 Thread Jorn Vernee
On Mon, 13 Sep 2021 11:06:15 GMT, Сергей Цыпанов wrote: > Currently the method is implemented like > > public List> parameterList() { > return Collections.unmodifiableList(Arrays.asList(ptypes.clone())); > } > > This seems to be excessive, as three objects are allocated here. Instead we >

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Andy Herrick
Thanks Scott This will help a lot because I couldn't reproduce this using just a splash screen as I expected I could. I will look at this example this morning. /Andy On 9/21/21 7:05 PM, Scott Palmer wrote: I’ve uploaded a project that reproduces the problem to JDK-8274087

Re: RFR: 8231640: (prop) Canonical property storage [v21]

2021-09-22 Thread Jaikiran Pai
On Wed, 22 Sep 2021 10:05:04 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Roger's suggestion to reword the implSpec text > > src/java.base/share/classes/java/lang/System.java line 766: > >>

Re: RFR: 8231640: (prop) Canonical property storage [v22]

2021-09-22 Thread Jaikiran Pai
> The commit in this PR implements the proposal for enhancement that was > discussed in the core-libs-dev mailing list recently[1], for > https://bugs.openjdk.java.net/browse/JDK-8231640 > > At a high level - the `store()` APIs in `Properties` have been modified to > now look for the

Re: RFR: 8274075: Fix miscellaneous typos in java.base [v2]

2021-09-22 Thread Pavel Rappo
On Tue, 21 Sep 2021 22:00:29 GMT, David Holmes wrote: >> Instead of "common case where a wrapped exception is thrown from same >> method" could one write "common case where an enclosing exception is thrown >> from the same method"? > > Note that we don't throw the "wrapped exception" we throw

Re: RFR: 8231640: (prop) Canonical property storage [v21]

2021-09-22 Thread Alan Bateman
On Sat, 18 Sep 2021 03:52:17 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8231640: (prop) Canonical property storage [v21]

2021-09-22 Thread Alan Bateman
On Sat, 18 Sep 2021 03:52:17 GMT, Jaikiran Pai wrote: >> The commit in this PR implements the proposal for enhancement that was >> discussed in the core-libs-dev mailing list recently[1], for >> https://bugs.openjdk.java.net/browse/JDK-8231640 >> >> At a high level - the `store()` APIs in

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 16:04:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Julia Boes
On Tue, 21 Sep 2021 15:23:33 GMT, Michael McMahon wrote: >> Julia Boes has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into simpleserver >> - Merge remote-tracking branch

Re: RFR: 8273656: Improve java.lang.invoke.MethodType.parameterList() and its usage

2021-09-22 Thread Сергей Цыпанов
On Wed, 22 Sep 2021 00:21:01 GMT, Claes Redestad wrote: >> Currently the method is implemented like >> >> public List> parameterList() { >> return Collections.unmodifiableList(Arrays.asList(ptypes.clone())); >> } >> >> This seems to be excessive, as three objects are allocated here. Instead

Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server [v5]

2021-09-22 Thread Chris Hegarty
On Tue, 21 Sep 2021 14:09:54 GMT, Julia Boes wrote: >> This change implements a simple web server that can be run on the >> command-line with `java -m jdk.httpserver`. >> >> This is facilitated by adding an entry point for the `jdk.httpserver` >> module, an implementation class whose main

Re: [External] : Re: What causes java.lang.InternalError: platform encoding not initialized ?

2021-09-22 Thread Alan Bateman
On 21/09/2021 20:49, Scott Palmer wrote: : The agent is needed in my real app only to get an instance of the Instrumentation interface. As a general point, the Instrumentation object should never be leaked to applications or libraries. I have no idea what the agent does here but you should