Re: [External] : Re: jpackage usage problems

2022-04-07 Thread Alexey Semenyuk
(Thread[Daemon worker,5,main]) completed. Took 8.099 secs. I am surprised to see success, so my next step would be to evaluate the content of the .deb file. I doubt jpackage would have created all what was missing just now. However this evaluation will have to wait for a week. Hiran On Thu

Re: RFR: JDK-8236128: Allow jpackage create installers for services [v2]

2022-04-14 Thread Alexey Semenyuk
> Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 121

Re: [External] : Re: jpackage usage problems

2022-04-20 Thread Alexey Semenyuk
On 4/18/2022 7:06 PM, Hiran Chaudhuri wrote: On Mon, 2022-04-18 at 18:41 -0400, Alexey Semenyuk wrote: I've filed [1] and [2] CRs to track the issues. [1] https://bugs.openjdk.java.net/browse/JDK-8284973 [2] https://bugs.openjdk.java.net/browse/JDK-8284974 - Alexey Sounds great. Thank you

Re: [External] : Re: jpackage usage problems

2022-04-18 Thread Alexey Semenyuk
On 4/17/2022 2:22 PM, Hiran Chaudhuri wrote: On Thu, 2022-04-07 at 19:53 -0400, Alexey Semenyuk wrote: I can see two separate issues with jpackage: 1. jpackage reports NPE if it can't figure out the package name from the supplied application image. It should issue a helpful error

Re: RFR: 8287125: [macos] Multiple jpackage tests fail/timeout on same host

2022-06-02 Thread Alexey Semenyuk
On Fri, 27 May 2022 03:12:39 GMT, Alexander Matveev wrote: > Looks like regression from JDK-8277493. JDK-8277493 will always un-sign app > image. Un-signing takes time since we enumerating all files and un-signing > binaries one by one. Average increase 2-3 minutes for tests which generates

Re: RFR: 8286850: [macos] Add support for signing user provided app image

2022-06-02 Thread Alexey Semenyuk
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote: > - Added support for signing predefined application image. > - Following command can be used to sign predefined application images: > jpackage --type app-image --app-image Test.app --mac-sign [additional signing > options] > - Main

Re: RFR: 8286850: [macos] Add support for signing user provided app image

2022-06-02 Thread Alexey Semenyuk
On Thu, 2 Jun 2022 05:17:25 GMT, Alexander Matveev wrote: > - Added support for signing predefined application image. > - Following command can be used to sign predefined application images: > jpackage --type app-image --app-image Test.app --mac-sign [additional signing > options] > - Main

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-11 Thread Alexey Semenyuk
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote: > - No changes to code provided by original fix. > - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute > unsigned code and code should be at least ad hoc signed. > - Signing of app bundle produced by

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

2022-05-13 Thread Alexey Semenyuk
On Fri, 13 May 2022 05:06:21 GMT, Alexander Matveev wrote: >> - No changes to code provided by original fix. >> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute >> unsigned code and code should be at least ad hoc signed. >> - Signing of app bundle produced by

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-11 Thread Alexey Semenyuk
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote: > - No changes to code provided by original fix. > - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute > unsigned code and code should be at least ad hoc signed. > - Signing of app bundle produced by

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev wrote: >> - It is not possible to support native JDK commands such as "java" inside >> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >> JDK-8286122 does not seems to be visible. >> - With proposed fix we will

RFR: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

2022-05-19 Thread Alexey Semenyuk
8281682: Redundant .ico files in Windows app-image cause unnecessary bloat - Commit messages: - Trailing whitespace removed - Drop unused WinIconVerifierException - remove accidentally added space char - jtreg descriptions fixed - 8281682: Redundant .ico files in Windows

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 20:59:53 GMT, Michael Hall wrote: > However, I don't know how the app is supposed to be started without a > launcher... jpackage supplies an alternative launcher that doesn't have plist. - PR: https://git.openjdk.java.net/jdk/pull/8666

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v3]

2022-06-03 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 02:03:35 GMT, Alexander Matveev wrote: >> - Added support for signing predefined application image. >> - Following command can be used to sign predefined application images: >> jpackage --type app-image --app-image Test.app --mac-sign [additional >> signing options] >> -

Integrated: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-06 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote: > 8250950: Allow per-user and system wide configuration of a jpackaged app This pull request has now been integrated. Changeset: c37c8e5d Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8287971: Throw exception for missing values in .jpackage.xml

2022-06-14 Thread Alexey Semenyuk
On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev wrote: > - Error will be thrown if app image is generated with another JDK version or > has malformed .jpackage.xml. > - Re-fixed as Alexey suggested in https://github.com/openjdk/jdk/pull/9098.

Re: RFR: 8287971: Throw exception for missing values in .jpackage.xml

2022-06-14 Thread Alexey Semenyuk
On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev wrote: > - Error will be thrown if app image is generated with another JDK version or > has malformed .jpackage.xml. > - Re-fixed as Alexey suggested in https://github.com/openjdk/jdk/pull/9098.

Re: RFR: 8287971: Throw exception for missing values in .jpackage.xml

2022-06-08 Thread Alexey Semenyuk
On Thu, 9 Jun 2022 01:21:30 GMT, Alexander Matveev wrote: > - Warning will be printed if .jpackage.xml has old version number. > - Error will be thrown if main-class and app-store values are missing from > .jpackage.xml. > - Both main-class and app-store are required values for JDK-8286850

RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-03 Thread Alexey Semenyuk
8250950: Allow per-user and system wide configuration of a jpackaged app - Commit messages: - Trailing white space removed - EOLs converted - Trailing white space removed - 8250950: Allow per-user and system wide configuration of a jpackaged app Changes:

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-04 Thread Alexey Semenyuk
On Sat, 4 Jun 2022 01:45:21 GMT, Alexander Matveev wrote: >> 8250950: Allow per-user and system wide configuration of a jpackaged app > > test/jdk/tools/jpackage/share/PerUserCfgTest.java line 174: > >> 172: action.accept(cmd); >> 173: } finally { >> 174:

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

2022-06-06 Thread Alexey Semenyuk
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote: > 8250950: Allow per-user and system wide configuration of a jpackaged app @sashamatveev please resume the review - PR: https://git.openjdk.java.net/jdk/pull/9025

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app [v2]

2022-06-06 Thread Alexey Semenyuk
> 8250950: Allow per-user and system wide configuration of a jpackaged app Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Add TKit.createDirectories() method that will delete created nonexistent director

Integrated: 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat

2022-05-24 Thread Alexey Semenyuk
On Thu, 19 May 2022 19:13:12 GMT, Alexey Semenyuk wrote: > 8281682: Redundant .ico files in Windows app-image cause unnecessary bloat This pull request has now been integrated. Changeset: 45180633 Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

Integrated: JDK-8236128: Allow jpackage create installers for services

2022-04-27 Thread Alexey Semenyuk
On Fri, 11 Mar 2022 23:37:06 GMT, Alexey Semenyuk wrote: > Implementation of [JDK-8275062: "Allow jpackage create installers for > services"](https://bugs.openjdk.java.net/browse/JDK-8275062) > CSR This pull request has now been integrated. Changeset: b675c597 Author:A

RFR: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexey Semenyuk
8282351: jpackage does not work if class file has `$$` in the name on windows - Commit messages: - Fix regression - 8282351: jpackage does not work if class file has `$$` in the name on windows Changes: https://git.openjdk.java.net/jdk/pull/8613/files Webrev:

Integrated: 8282351: jpackage does not work if class file has `$$` in the name on windows

2022-05-09 Thread Alexey Semenyuk
On Mon, 9 May 2022 21:25:37 GMT, Alexey Semenyuk wrote: > 8282351: jpackage does not work if class file has `$$` in the name on windows This pull request has now been integrated. Changeset: 29395534 Author: Alexey Semenyuk URL: https://git.openjdk.java.net/jdk/com

RFR: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

2022-05-05 Thread Alexey Semenyuk
- Replace `System.getProperty("java.io.tmpdir")` call with hardcoded `/tmp` string to get root folder for test files. - Fix test cleanup - the test didn't delete test files upon completion - Commit messages: - 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

Integrated: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file

2022-05-05 Thread Alexey Semenyuk
On Thu, 5 May 2022 20:00:54 GMT, Alexey Semenyuk wrote: > - Replace `System.getProperty("java.io.tmpdir")` call with hardcoded `/tmp` > string to get root folder for test files. > - Fix test cleanup - the test didn't delete test files upon completion This pull request has

Re: Integrated: 8285736: JDK-8236128 causes validate-source failures

2022-04-27 Thread Alexey Semenyuk
On Wed, 27 Apr 2022 16:53:44 GMT, Daniel D. Daugherty wrote: > A trivial fix for JDK-8236128 causes validate-source failures. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8429

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexey Semenyuk
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexey Semenyuk
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will

<    2   3   4   5   6   7