On Aug 13, 2015, at 9:38 AM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
3. void JLI_InitArgProcessing(jboolean isJava, jboolean disableArgFile) {
// No expansion for relaunch
The launcher might re-exec itself, this might happen under certain
circumstances on *nix, is
On Aug 12, 2015, at 7:55 AM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
Henry,
Generally looks good here are some comments, on my initial
pass, I am not fully done with args.c I will look at this some
more later today or tomorrow.
4.)
expectingNoDash is expectingMain
Hi,
Another update for argument file support, this version we added a couple
measures to ensure compatibility,
1) Compile time directive ENABLE_ARG_FILES is needed to enable the feature,
only java is enabled with this webrev.
2) Escape @argument if so desired: Additional prefixes of @ to a @
, at 7:51 AM, Mandy Chung mandy.ch...@oracle.com wrote:
On Jul 10, 2015, at 11:48 AM, Henry Jen henry@oracle.com wrote:
Hi,
Please review proposed patch for JDK-8027634[1]. This patch is to enable
java support command line argument file like javac does. The implementation
use
Sigh, forgot the link to the webrev again.
http://cr.openjdk.java.net/~henryjen/jdk9/8027634/webrev/
Cheers,
Henry
On Jul 9, 2015, at 8:48 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review proposed patch for JDK-8027634[1]. This patch is to enable java
support command line
Hi,
Please review proposed patch for JDK-8027634[1]. This patch is to enable java
support command line argument file like javac does. The implementation use the
same syntax rule, which is implemented in CommandLine.java[3] with
java.io.StreamTokenizer.
Some early comment is that we probably
Looks fine to me, thanks for taking care of it.
Cheers,
Henry
On 04/03/2015 02:57 AM, Chris Hegarty wrote:
This is a request for review for a small change to address 8076442 [1].
Seems to be a day one bug in the internal BitSetIterator, for a boundary
condition when the Integer.MAX_VALUE bit
Hi Micoslav,
What do you think about the webrev[1]? Does it make sense for upstream
maintainers?
[1] http://cr.openjdk.java.net/~henryjen/jdk9/8047724/0/webrev/
Cheers,
Henry
On 06/30/2014 03:14 PM, Alan Bateman wrote:
On 30/06/2014 02:30, Henry Jen wrote:
Ping.
Cheers,
Henry
Henry
, and a combobox contains only Files. I
suggest to try
to genereficate this correctly and look where it brings us.
Also I didn't look at the KeychainStore.java as I know nothing about this code.
With best regards. Petr.
On 09 июля 2014 г., at 7:30, Henry Jen henry@oracle.com wrote:
Hi
Thanks Joe for the review. Would someone from deploy team have a quick
look so we can push this?
Cheers,
Henry
On 06/23/2014 06:03 PM, Joe Darcy wrote:
Hi Henry,
The changes look good to me; thanks,
-Joe
On 06/23/2014 05:31 PM, Henry Jen wrote:
Hi,
Please review another webrev to clean
there was an issue using
wildcards in AquaComboBoxButton.java).
Thanks,
-Joe
On 06/27/2014 02:45 PM, Henry Jen wrote:
Hi,
Please review a webrev for fixing rawtypes and unchecked lint warning
for macosx specific java code, this webrev is depending on
JDK-8043548[1] where some of the override
Hi,
Related to JDK-8023276[1] where we added two packages to JDK 9, we
should update @since to have 1.9 value as well.
http://cr.openjdk.java.net/~henryjen/jdk9/8049109/0/webrev/
[1] https://bugs.openjdk.java.net/browse/JDK-8023276
Cheers,
Henry
to users since they've been using them since JDK 1.5
[1]
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@since
-Joe
On 7/2/2014 3:43 PM, Joe Darcy wrote:
Looks good Henry; cheers,
-Joe
On 07/02/2014 02:45 PM, Henry Jen wrote:
Hi,
Related to JDK-8023276[1] where we
On 06/30/2014 12:26 PM, Lance Andersen wrote:
On Jun 30, 2014, at 3:22 PM, huizhe wang huizhe.w...@oracle.com
wrote:
On 6/30/2014 12:20 PM, Lance Andersen wrote:
Looks OK Joe, noticed the @since changed as well?
Thanks for review.
Yes. The support for DOM L3 was since JDK 1.5.
Ping.
Cheers,
Henry
On 06/20/2014 02:28 PM, Henry Jen wrote:
Hi,
Please review a trivial webrev for jdk9/corba that do the same @since
tag normalization as in jdk9/jdk.
http://cr.openjdk.java.net/~henryjen/jdk9/8047722/0/webrev/
Cheers,
Henry
Ping.
Cheers,
Henry
On 06/20/2014 02:41 PM, Henry Jen wrote:
Hi,
Please review a trivial webrev for jdk9/jaxws that do the same @since
tag normalization as in jdk9/jdk.
http://cr.openjdk.java.net/~henryjen/jdk9/8047724/0/webrev/
I am not sure if there is another mailing list thatis more
Hi,
Please review a webrev for fixing rawtypes and unchecked lint warning
for macosx specific java code, this webrev is depending on
JDK-8043548[1] where some of the override methods are defined,
Also as the src/macosx/classes/apple/launcher/JavaAppLauncher.java to be
removed from
Thanks,
-Joe
On 06/27/2014 02:45 PM, Henry Jen wrote:
Hi,
Please review a webrev for fixing rawtypes and unchecked lint warning
for macosx specific java code, this webrev is depending on
JDK-8043548[1] where some of the override methods are defined,
Also as the src/macosx
in .properties files also those @version tags with
specific version information.
Cheers,
Henry
On 06/20/2014 05:24 PM, Henry Jen wrote:
Looks like it's pretty easy to do a find and replace in files in jaxp
folder. If this is desired, we can do it in a separate webrev to be
clear on changeset history
completely in the Cipher*
classes. I will be sending you a separate note about JCE logistics.
Thanks for doing this cleanup.
Brad
On 6/20/2014 11:46 AM, Henry Jen wrote:
Hi,
Please review a trivial webrev to add JDK version to @since in a format
as Mark suggested[1].
http://cr.openjdk.java.net
Hi,
Please review another webrev to clean up rawtypes and unchecked warning,
this time for sun.applet.
The webrev applied to both jdk9/dev and jdk9/client cleanly, I am not
sure which repo should the webrev go once pass review.
Webrev can be found at
Hi,
Please review a trivial webrev to add JDK version to @since in a format
as Mark suggested[1].
http://cr.openjdk.java.net/~henryjen/jdk9/8047721/0/webrev/
[1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2014-June/000806.html
Appened is the diff as in the webrev.
Cheers,
Henry
diff
You are absolutely right, I should have fixed it as I did for the rest.
Updated webrev can be found at
http://cr.openjdk.java.net/~henryjen/jdk9/8047721/1/webrev/
Cheers,
Henry
On 06/20/2014 01:01 PM, Paul Benedict wrote:
Henry,
I think JCE1.2 should get the space to be JCE 1.2 so it
}Stream classes, the class itself was added
in 1.4 so it seems redundant to have the @since information on each
method too. In other words, is preserving the @since JCE 1.2 information
useful at this point?
Thanmks,
-Joe
On 06/20/2014 01:20 PM, Henry Jen wrote:
You are absolutely right, I should
Hi,
Please review a trivial webrev for jdk9/corba that do the same @since
tag normalization as in jdk9/jdk.
http://cr.openjdk.java.net/~henryjen/jdk9/8047722/0/webrev/
Cheers,
Henry
Hi,
Please review a trivial webrev for jdk9/jaxp that do the same @since tag
normalization as in jdk9/jdk.
http://cr.openjdk.java.net/~henryjen/jdk9/8047723/0/webrev/
I am not sure if there is another mailing list thatis more appropriate
for this, if so, please direct me to the right ml.
Hi,
Please review a trivial webrev for jdk9/jaxws that do the same @since
tag normalization as in jdk9/jdk.
http://cr.openjdk.java.net/~henryjen/jdk9/8047724/0/webrev/
I am not sure if there is another mailing list thatis more appropriate
for this, if so, please direct me to the right ml.
$
This is also true in packages not in the webrevs (ones that have proper
@since tag), for example
http://docs.oracle.com/javase/8/docs/api/javax/xml/datatype/DatatypeFactory.html
$Revision: 1.13 $, $Date: 2010/03/11 23:10:53 $
It looks good otherwise.
Thanks,
Joe
On 6/20/2014 2:39 PM, Henry Jen
Thanks, Alexander.
Cheers,
Henry
On 06/18/2014 03:44 AM, Alexander Scherbatiy wrote:
The fix looks good for me.
Thanks,
Alexandr.
On 6/11/2014 4:00 AM, Henry Jen wrote:
Hi,
Please review a trivial webrev that provides missing @since tag for
elements under javax.swing
.
On 6/18/2014 9:16 AM, Henry Jen wrote:
Thanks, Alexander.
Cheers,
Henry
On 06/18/2014 03:44 AM, Alexander Scherbatiy wrote:
The fix looks good for me.
Thanks,
Alexandr.
On 6/11/2014 4:00 AM, Henry Jen wrote:
Hi,
Please review a trivial webrev that provides missing @since tag
generated javax.swing.*BeanInfo.
Cheers,
Henry
-phil.
On 6/18/2014 11:11 AM, Henry Jen wrote:
On 06/18/2014 10:44 AM, Phil Race wrote:
Hello,
You say under javax.swing but you don't seem to be touching
any sub-packages.
No, sub-packages has @since in correponding package.html. I use * to
mean
is yes, then I'm OK. If no, then I'm OK
too although at least then we'd know you still had to do those
packages ..
-phil.
On 6/18/2014 11:11 AM, Henry Jen wrote:
On 06/18/2014 10:44 AM, Phil Race wrote:
Hello,
You say under javax.swing but you don't seem to be touching
any sub-packages.
No, sub
Network Drive x-apple-data-detectors://34/0
Burlington, MA 01803 x-apple-data-detectors://34/0
lance.ander...@oracle.com mailto:lance.ander...@oracle.com
Sent from my iPad
On Jun 9, 2014, at 5:39 PM, Henry Jen henry@oracle.com
mailto:henry@oracle.com wrote:
Hi,
Please review a trivial
Hi,
Please review a trivial webrev that provides missing @since tag for
elements under javax.swing,
Essentially it's simply add @since 1.2 for all
classes/interfaces/exception that are missing @since tag, as JDK 1.2
package.html has @since tag but was removed in 1.3.
The @since tag is
Hi,
Please review a trivial webrev that provides missing @since tag for
elements under javax.sql,
javax.sql.CommonDataSource was extracted out since 1.6, methods have
@since 1.4 tag because those methods existed in origins since then.
not obvious are simply remove tailing space, a (positive)
side effect of the tools I use so I kept them.
Cheers,
Henry
[1]
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-June/027113.html
On 06/03/2014 06:22 PM, Henry Jen wrote:
Hi,
In an effort to determine APIs availability in a given
Hi,
Please review a trivial webrev that provides missing @since tag for
elements under java.beans,
This version is determined based on javadoc of 1.0.2, 1.1.8 and 1.2.2.
http://cr.openjdk.java.net/~henryjen/jdk9/8044855/0/webrev
Cheers,
Henry
Hi,
In an effort to determine APIs availability in a given version, it
became obvious that a consistent way to express @since tag would be
beneficial.
So started with the most obvious ones, where we have various expression
for JDK version, this webrev make sure we use @since 1.n[.n] for JDK
On 02/12/2014 07:05 AM, Wang Weijun wrote:
This line does not compile
Files.list(Paths.get(/secret)).forEach(x - Files.write(x, new
byte[Files.size(x)]);
because Files.write() and Files.size() throw IOE. Then what's the best way to
make it work?
(I find some old threads on this on
Hi,
Please review a simple bug fix that loosen the generic type, the
original proposed CCC for JDK-8009736 and webrev/specdiff has a
discrepancy, I am not sure if another CCC is needed.
https://bugs.openjdk.java.net/browse/JDK-8033590
http://cr.openjdk.java.net/~henryjen/tl/8033590.0/webrev/
Changeset: 7534523b4174
Author:henryjen
Date: 2014-02-06 10:30 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7534523b4174
8033590: java.util.Comparator::thenComparing has unnecessary type restriction
Reviewed-by: psandoz
! src/share/classes/java/util/Comparator.java
!
+1.
Cheers,
Henry
On 02/03/2014 10:09 PM, Joe Darcy wrote:
Hello,
Please review this small fix to address
JDK-803352: Fix raw type lint warning in sun.nio.ch
--- a/src/share/classes/sun/nio/ch/Reflect.javaMon Feb 03 16:58:02
2014 -0500
+++
On 01/27/2014 12:31 PM, Philip Hodges wrote:
I did not predict that it would be a sprintf. It's not going to be
consistently misused anything like so frequently.
I compared it to the unescaped XML generation antipattern.
I have not seen any technical justifications whatsoever so far, just
I haven't tried this, but Tim Bell mentioned this in an email inquiry I
had earlier,
This will be cured when the fix for 8021266 is pushed to JDK 9 (see
attached).
In the meantime, the workaround in JPRT is to submit your JDK 9 jobs
with '-bootproduct jdk7u7' since the 7u51 release can not
Changeset: 6d583b9d99e1
Author:henryjen
Date: 2013-12-04 08:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d583b9d99e1
8029434: Spliterator of Stream returned by BufferedReader.lines() should have
NONNULL characteristic
Reviewed-by: mduigou
!
Hi,
Please review a small fix that add missing NONNULL characteristic and
cleanup in javadoc.
Thanks Anthony Vanelverdinghe for reporting of this bug.
http://cr.openjdk.java.net/~henryjen/tl/8029434/0/webrev/
Cheers,
Henry
Changeset: 1061f4d085b5
Author:henryjen
Date: 2013-12-03 11:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1061f4d085b5
8029483: BufferedReader.lines() javadoc typo should be fixed
Reviewed-by: mduigou
! src/share/classes/java/io/BufferedReader.java
.
Cheers,
Henry
On 12/03/2013 10:52 AM, Mike Duigou wrote:
Looks good to me.
Mike
On Dec 3 2013, at 10:36 , Henry Jen henry@oracle.com wrote:
Hi,
Please review a small fix that add missing NONNULL characteristic and cleanup
in javadoc.
Thanks Anthony Vanelverdinghe for reporting of this bug
On 11/21/2013 06:33 PM, David Holmes wrote:
On 22/11/2013 5:02 AM, Louis Wasserman wrote:
While I agree that case should be specified, I'm not certain I follow why
that's what's going on here.
The weird condition is that if oldValue is null, not value; oldValue
is the
old result of
in ConcurrentMap's merge().
Mike
On Nov 22 2013, at 16:01 , Henry Jen henry@oracle.com wrote:
On 11/21/2013 06:33 PM, David Holmes wrote:
On 22/11/2013 5:02 AM, Louis Wasserman wrote:
While I agree that case should be specified, I'm not certain I follow why
that's what's going on here
Change looks good to me(not a reviewer).
Cheers,
Henry
On 11/01/2013 10:57 AM, Paul Sandoz wrote:
Hi,
This is a eating humble pie and should of correctly listened to Henry in
review kind of email :-)
The changes to DistinctOpTest recently committed result in a test failure,
since one of
Looks good to me.
In the test,
Integer one = Stream.iterate(1, i - i +
1).unordered().parallel().distinct().findAny().get();
assertEquals(one.intValue(), 1);
The implementation is probably make sure this will return 1, but is that what
we spec to do? I sort of think it can have various
Hi,
Please review the updated revision at
http://cr.openjdk.java.net/~henryjen/ccc/8025909/1/webrev
- Rewording {Iterable|Map}::forEach from ordering constraint so that
implementation class is allowed to process in parallel ignoring the order.
- fixed typo in Collector as Paul pointed out
:32 , Henry Jen henry@oracle.com wrote:
Hi,
Please review the updated revision at
http://cr.openjdk.java.net/~henryjen/ccc/8025909/1/webrev
- Rewording {Iterable|Map}::forEach from ordering constraint so that
implementation class is allowed to process in parallel ignoring the order
Changeset: 0913c3bab168
Author:henryjen
Date: 2013-10-22 15:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0913c3bab168
8025909: Lambda Library Spec Updates
8024179: Document limitations and performance characteristics of stream sources
and operations
8024138: (Spec
Apologize for the multiple copies, Thunderbird had issue with network,
and resulting several copies sent.
Sorry for the incident.
Cheers,
Henry
On 10/15/2013 10:53 PM, Henry Jen wrote:
On 10/15/2013 04:05 PM, Mike Duigou wrote:
Where is the null handling for methods like
Hi,
A simple webrev to add missing @since 1.8 tag.
Cheers,
Henry
On 10/16/2013 08:18 PM, Henry Jen wrote:
Hi,
A simple webrev to add missing @since 1.8 tag.
Sigh,
http://cr.openjdk.java.net/~henryjen/tl/8026768/0/webrev/
Cheers,
Henry
Changeset: e2e3c2c249e2
Author:henryjen
Date: 2013-10-16 21:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2e3c2c249e2
8026768: java.util.Map.Entry comparingBy methods missing @since 1.8
Reviewed-by: dholmes
! src/share/classes/java/util/Map.java
Hi,
Please kindly review the latest update on lambda library spec, and a few
minor code clean up.
Webrev and specdiff can be found at,
http://cr.openjdk.java.net/~henryjen/ccc/8025909/0/webrev
http://cr.openjdk.java.net/~henryjen/ccc/8025909/0/specdiff
This webrev also covers update that
15 2013, at 15:34 , Henry Jen henry@oracle.com wrote:
Hi,
Please kindly review the latest update on lambda library spec, and
a few minor code clean up.
Webrev and specdiff can be found at,
http://cr.openjdk.java.net/~henryjen/ccc/8025909/0/webrev
http://cr.openjdk.java.net
On Oct 15 2013, at 15:34 , Henry Jen henry@oracle.com wrote:
Hi,
Please kindly review the latest update on lambda library spec, and
a few minor code clean up.
Webrev and specdiff can be found at,
http://cr.openjdk.java.net/~henryjen/ccc/8025909/0/webrev
http://cr.openjdk.java.net
Hi,
Please review a quick one line fix for the test, we simply
pass(ignore) the test instead of skip the test.
Ignore the test is the intention. It would be ideal if we know it's
skipped intentionally, but currently jtreg consider a skipped test
with a throwable failed test for other scenarios,
Changeset: c070001c4f60
Author:henryjen
Date: 2013-10-09 09:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c070001c4f60
8023524: Mechanism to dump generated lambda classes / log lambda code generation
Reviewed-by: plevart, mchung, forax, jjb
Contributed-by:
Thanks Mandy, and all others have reviewed and commented.
Cheers,
Henry
On 10/09/2013 02:47 AM, Mandy Chung wrote:
Hi Henry,
On 10/8/2013 10:57 PM, Henry Jen wrote:
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
ProxyClassesDumper looks
Hi,
Please review updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/6/webrev
In this update,
- Check the specified directory once, disable dumping if it is invalid.
This address the comment of unnecessary complexity, as this is a debug
feature and most likely developer would
Changeset: f0ad3e2918b4
Author:henryjen
Date: 2013-10-07 11:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0ad3e2918b4
8025968: Integrate test improvements made in lambda repo
Reviewed-by: psandoz
! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
!
Hi,
May I have a quick review on this left-out change to fix broken test?
Apology for the inconvenience.
http://cr.openjdk.java.net/~henryjen/tl/8026009/0/webrev/
Following is all it is,
diff --git a/test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
Changeset: 0cffe1dab0bf
Author:henryjen
Date: 2013-10-07 15:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cffe1dab0bf
8026009: Changes for 8025968 break all stream tests
Reviewed-by: mduigou
! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java
Hi,
Please review a port from lambda repo to tl, it contains a refactoring
of OpTestCase and a small addition to fill test gap.
http://cr.openjdk.java.net/~henryjen/tl/8025968/0/webrev/
Cheers,
Henry
OK, hopefully we are close to the end here on comments, unless there are
security related issues. We still need +1 from a jdk8 reviewer,
http://cr.openjdk.java.net/~henryjen/ccc/8023524/5/webrev
This update include what Peter's latest suggestion, and since we don't
have a reliable way to create
On Oct 2, 2013, at 7:21 AM, Remi Forax fo...@univ-mlv.fr wrote:
On 10/02/2013 04:12 PM, Peter Levart wrote:
On 10/02/2013 12:19 PM, Remi Forax wrote:
final class ProxyClassesDumper {
...
private final Path dumpDir; // null if invalid
public static ProxyClassesDumper create(String
Hi,
Please review update of the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/4/webrev
This update address comments from Remi and Peter,
- Remove the unnecessary static field, also take out not needed
singleton behavior of ProxyClassesDumper
- Ensure InvalidPathException won't stop
Hi,
Please review the updated webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/3/webrev/
This update addressed comments from Mandy with following,
- call doPrivileged with specific file permission, ALL FILES, write.
- Use nio package to write deal with FS, also create directory
Looks good to me.
Cheers,
Henry
On Sep 30, 2013, at 2:27 PM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
This changeset fixes a small corner case where Arrays.parallelPrefix (all
variants) failed to throw NPE if the operation was null. If the array or
range was empty then op
-8025067/1/webrev/
Mike
On Sep 30 2013, at 15:00 , Henry Jen wrote:
Looks good to me.
Cheers,
Henry
On Sep 30, 2013, at 2:27 PM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
This changeset fixes a small corner case where Arrays.parallelPrefix (all
variants) failed
On Sep 26, 2013, at 4:01 PM, Mandy Chung mandy.ch...@oracle.com wrote:
Hi Henry,
On 9/25/2013 12:37 AM, Henry Jen wrote:
Hi,
Please review the update webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/2/webrev/
The doPrivileged block looks okay. It'd be good to limit
On 09/24/2013 11:28 PM, Peter Levart wrote:
On 09/25/2013 07:56 AM, Peter Levart wrote:
Just a thought. How does URLClassLoader do the class name - path to
resource translation? Perhaps there's already some code that does this
correctly and in a platform-specific way (haven't looked)...
Hi,
:+TraceClassLoading).
I also fixed two type as Jon brought to my attention.
Cheers,
Henry
On 09/24/2013 02:59 PM, Henry Jen wrote:
Hi,
Please review the new webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/1/webrev/
The updated code will attempt to escape potentially bad characters(based
Hi,
I had reported this issue with attached test with behavior I observed, Brian
and me agreed that SuppressWarnings on either one as in this test case should
be sufficient.
Cheers,
Henry
On Sep 24, 2013, at 10:14 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
There is a new
));
}
}
On Sep 24, 2013, at 11:11 AM, Henry Jen henry@oracle.com wrote:
Hi,
I had reported this issue with attached test with behavior I observed, Brian
and me agreed that SuppressWarnings on either one as in this test case should
be sufficient.
Cheers,
Henry
wrote:
On 09/19/2013 01:00 AM, Henry Jen wrote:
Class names can contain '\' and other characters which are problematic
on Windows.
Thanks for reviewing, I suspect you are pointing out a potential issue
to look at, not that the problem exists in current implementation.
According to JLS 3.8
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/0/webrev/
This webrev enable writing generated classes for lambda to disk at a
directory specified with -Djdk.internal.lambda.dumpProxyClasses.
The directory has to be an existing writable directory, otherwise, a
Looks good to me.
Cheers,
Henry
On Sep 18, 2013, at 11:27 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
Please review a fix for CharSequence.codePoints:
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/e040a0dda7e4
(That change set should apply cleanly to tl.)
The incorrect
On 09/18/2013 04:56 AM, Florian Weimer wrote:
On 09/18/2013 08:18 AM, Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/0/webrev/
This webrev enable writing generated classes for lambda to disk at a
directory specified
Changeset: 86aa8e7503e9
Author:henryjen
Date: 2013-09-16 10:28 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86aa8e7503e9
8024874: Copy-paste typo in the spec for j.u.Comparator.thenComparing(Function,
Comparator)
Reviewed-by: mduigou
!
Hi,
Please kindly review webrev at
http://cr.openjdk.java.net/~henryjen/tl/8024825/0/webrev/
This webrev is a typo fix + the cleanup made in lambda repo in following
changeset.
http://hg.openjdk.java.net/lambda/lambda/jdk/rev/a4babe938c8c
Summary of the changeset,
- Typo fix, Short-circuting
Changeset: a7980b099af1
Author:henryjen
Date: 2013-09-06 15:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a7980b099af1
8024825: Some fixes are missing from java.util.stream spec update
Reviewed-by: mduigou
! src/share/classes/java/util/stream/ReferencePipeline.java
!
Changeset: be6f5f027bc2
Author:henryjen
Date: 2013-09-06 22:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be6f5f027bc2
8011916: Spec update for java.util.stream
8024339: j.u.s.Stream.reduce(BinaryOperator) throws unexpected NPE
Reviewed-by: mduigou
Contributed-by:
Yes, the alignment is off, will fix.
Cheers,
Henry
On Sep 11, 2013, at 7:36 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 11/09/2013 06:03, Henry Jen wrote:
Sorry I forgot it again. Copied but not pasted. :(
http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/
Thanks
, Henry Jen wrote:
Sorry I forgot it again. Copied but not pasted. :(
http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/
Thanks for reviewing.
Cheers,
Henry
On Sep 10, 2013, at 8:47 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review a simple webrev that adds
Changeset: 70aab3db56de
Author:henryjen
Date: 2013-09-11 11:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70aab3db56de
8024500: Missing API coverage for java.util.function.BiFunction andThen
Reviewed-by: mduigou, alanb
+ test/java/util/Collections/SingletonIterator.java
Hi,
Please review a simple webrev that adds two tests, one for
java.util.function.BiFunction.andThen() another to cover
java.util.Collections.SingletonIterator.
Cheers,
Henry
Sorry I forgot it again. Copied but not pasted. :(
http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/
Thanks for reviewing.
Cheers,
Henry
On Sep 10, 2013, at 8:47 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review a simple webrev that adds two tests, one
Hi,
Please kindly review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8011916/0/webrev/
The webrev brings over the latest javadoc overhaul occurred in lambda
repo. The specdiff can be found at
http://cr.openjdk.java.net/~henryjen/ccc/8011916/0/specdiff/overview-summary.html
There is also
On 09/04/2013 12:17 AM, Alan Bateman wrote:
On 03/09/2013 20:02, Henry Jen wrote:
Updated webrev is at
http://cr.openjdk.java.net/~henryjen/ccc/8017513/2/webrev/
Addressed comments from Alan and catch IOExpression when close on
exception in Files method.
Thanks for sorting out
Updated webrev is at
http://cr.openjdk.java.net/~henryjen/ccc/8017513/2/webrev/
Addressed comments from Alan and catch IOExpression when close on
exception in Files method.
Cheers,
Henry
On 08/29/2013 02:15 AM, Alan Bateman wrote:
On 29/08/2013 09:51, Paul Sandoz wrote:
On Aug 29, 2013, at
Hi,
Please review a simple webrev at
http://cr.openjdk.java.net/~henryjen/tl/8024178/0/webrev/
The reverted change was included as part of JDK-8015318 fix at late
stage, after more thoughts, it is not needed.
As a collector? super T, A, R returns a R can be assigned to ? super
R, so we don't
Changeset: 3db3ae4e0853
Author:henryjen
Date: 2013-09-03 11:44 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3db3ae4e0853
8024178: Difference in Stream.collect(Collector) methods located in jdk8 and
jdk8-lambda repos
Reviewed-by: mduigou
!
Changeset: 77a8c4ad516c
Author:henryjen
Date: 2013-08-28 14:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77a8c4ad516c
8022176: Weaken contract of java.lang.AutoCloseable
Reviewed-by: alanb, martin, mduigou, psandoz
Contributed-by: brian.go...@oracle.com
!
101 - 200 of 315 matches
Mail list logo
