On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Hello Stuart,
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
>
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
The test failures caught by GitHub Actions jobs look related to the area of
this change:
2022-03-29T02:21:21.2187570Zat CheckCSMs.main(CheckCSMs.java:98)
2022-03-29T02:21:21.2188140Zat
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Marked as reviewed by jpai (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/8009
On Mon, 28 Mar 2022 10:55:30 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Mon, 28 Mar 2022 10:55:30 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too https://bugs.openjdk.java
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too https://bugs.openjdk.java
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too https://bugs.openjdk.java
On Fri, 25 Mar 2022 13:32:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which marks the `ThreadLocalRandom`
> class as `final`? Related JBS issue
> https://bugs.openjdk.java.net/browse/JDK-8283683.
>
> A CSR has been filed too https://bugs.openjdk.java
Can I please get a review of this change which marks the `ThreadLocalRandom`
class as `final`? Related JBS issue
https://bugs.openjdk.java.net/browse/JDK-8283683.
A CSR has been filed too https://bugs.openjdk.java.net/browse/JDK-8283688.
tier1, tier2 and tier3 tests have been run with this
On Fri, 25 Mar 2022 04:17:57 GMT, Joe Darcy wrote:
> Working down the list of candidates to be sealed, this time
> IllegalFormatException.
>
> Please also review the companion CSR:
> https://bugs.openjdk.java.net/browse/JDK-8283669
Marked as reviewed by jpai (Committer).
-
PR:
On Sun, 20 Mar 2022 04:24:07 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which handles
> https://bugs.openjdk.java.net/browse/JDK-8283411?
>
> The commit here moves the temporary byte array from being a member of the
> class to a local variable within th
On Sun, 20 Mar 2022 14:05:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which handles
>> https://bugs.openjdk.java.net/browse/JDK-8283411?
>>
>> The commit here moves the temporary byte array from being a member of the
>> class to a l
On Sun, 20 Mar 2022 14:01:50 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 206:
>>
>>> 204: int max = (int)Math.min(n, Integer.MAX_VALUE);
>>> 205: int total = 0;
>>> 206:
; where it is used as a temporary buffer.
>
> tier1, tier2, tier3 tests have been run successfully with this change.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Use Alan's suggestion and allocate less than 512 bytes if possible.
On Sun, 20 Mar 2022 13:53:34 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use Alan's suggestion and allocate less than 512 bytes if possible. Plus
>> copyrig
Hello Bernd,
On 20/03/22 5:00 pm, Bernd Eckenfels wrote:
Hello,
Not sure how often skip is actually used so it might not matter, but this
change would increase allocations if skip is called regularly.
I had given this a thought before changing it. The skip doesn't get
called in a regular
Can I please get a review of this change which handles
https://bugs.openjdk.java.net/browse/JDK-8283411?
The commit here moves the temporary byte array from being a member of the class
to a local variable within the `skip` method which is the only place where it
is used as a temporary buffer.
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal
On Fri, 11 Mar 2022 09:04:23 GMT, Athijegannathan Sundararajan
wrote:
>> Can I please get a review of this change which proposes to implement the
>> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>>
>> The (public) `EnumSet` class has 2 package private (JDK)
On Thu, 10 Mar 2022 18:34:27 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>>
On Fri, 11 Mar 2022 10:16:33 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 192:
>>
>>> 190:
>>> 191: /**
>>> 192: * {@return locale used to create this instance}
>>
>> Hello Jim, the opening and closing `{`, I think aren't needed for a
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal
On Thu, 10 Mar 2022 18:34:27 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>>
On Tue, 8 Mar 2022 10:50:35 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to implement the
> enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
>
> The (public) `EnumSet` class has 2 package private (JDK) internal
Can I please get a review of this change which proposes to implement the
enhancement requested in https://bugs.openjdk.java.net/browse/JDK-8282572?
The (public) `EnumSet` class has 2 package private (JDK) internal sub-classes -
the `JumboEnumSet` and `RegularEnumSet`. These 2 classes don't have
On Mon, 7 Mar 2022 20:36:36 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Tue, 8 Mar 2022 04:20:17 GMT, Ian Graves wrote:
>> test/jdk/java/util/regex/RegExTest.java line 4568:
>>
>>> 4566:
>>> 4567: var matcher1 = Pattern.compile(pat1).matcher(testInput);
>>> 4568: var matcher2 = Pattern.compile(pat2).matcher(testInput);
>>
>> Hello Ian,
>> The
On Mon, 7 Mar 2022 22:29:29 GMT, Ian Graves wrote:
>> Fixing a bug in `NFCCharProperty` where code falling through an if-statement
>> can prematurely set the matcher's `hitEnd` field to true.
>
> Ian Graves has updated the pull request with a new target base due to a merge
> or a rebase. The
On Sat, 5 Mar 2022 14:20:40 GMT, Jaikiran Pai wrote:
> will now try and update/use this cached class level static state DFS. That
> would thus require some kind of thread safety semantics to be implemented for
> this new getDecimalFormatSymbols(Locale) method, isn't it?
A bit more cl
On Fri, 4 Mar 2022 21:17:50 GMT, Jim Laskey wrote:
>> Several attempts have been made to improve Formatter's numeric performance
>> by caching the current Locale zero. Such fixes, however, ignore the real
>> issue, which is the slowness of fetching DecimalFormatSymbols. By directly
>> caching
On Mon, 21 Feb 2022 14:09:50 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which fixes the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>
> As noted in that JBS issue these tests fail when the default locale under
> wh
On Fri, 25 Feb 2022 08:44:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale und
On Fri, 25 Feb 2022 04:44:45 GMT, Naoto Sato wrote:
>> That's a very good point. I've updated the PR to now explicitly use a
>> mutable `Set` instead of using `Collectors.toSet()`
>
> This is ok, although `Collectors.toCollection(HashSet::new)` is a bit concise.
Hello Naoto, I've updated the
On Fri, 25 Feb 2022 08:44:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale und
r` a
> neutral locale is appropriate on the `DateTimeFormatter` instance. This PR
> thus changes the tests to use `Locale.ROOT` while parsing this date comment.
> Additionally, while I was at it, I updated the `PropertiesStoreTest` to
> automate the use of multiple different
On Thu, 24 Feb 2022 17:15:16 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - use Roger's suggestion of using Stream and Collection based APIs to avoid
>> code du
r` a
> neutral locale is appropriate on the `DateTimeFormatter` instance. This PR
> thus changes the tests to use `Locale.ROOT` while parsing this date comment.
> Additionally, while I was at it, I updated the `PropertiesStoreTest` to
> automate the use of multiple different locales to
On Wed, 23 Feb 2022 18:37:03 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - implement review comments
>> - copyright years
>
> test/jdk/java/util/Propert
On Wed, 23 Feb 2022 18:22:53 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - implement review comments
>> - copyright years
>
> test/jdk/java/util/Propert
r` a
> neutral locale is appropriate on the `DateTimeFormatter` instance. This PR
> thus changes the tests to use `Locale.ROOT` while parsing this date comment.
> Additionally, while I was at it, I updated the `PropertiesStoreTest` to
> automate the use of multiple different locales
On Tue, 22 Feb 2022 17:31:14 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - implement review comments
>> - copyright years
>
> test/jdk/java/util/Propert
r` a
> neutral locale is appropriate on the `DateTimeFormatter` instance. This PR
> thus changes the tests to use `Locale.ROOT` while parsing this date comment.
> Additionally, while I was at it, I updated the `PropertiesStoreTest` to
> automate the use of multiple different
On Mon, 21 Feb 2022 14:09:50 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which fixes the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>
> As noted in that JBS issue these tests fail when the default locale under
> wh
On Mon, 21 Feb 2022 12:42:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change to the javadoc of
> `DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8282190?
This pull request has now been i
On Mon, 21 Feb 2022 12:42:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change to the javadoc of
> `DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8282190?
Thank you everyone for th
Can I please get a review of this test only change which fixes the issue noted
in https://bugs.openjdk.java.net/browse/JDK-8282023?
As noted in that JBS issue these tests fail when the default locale under which
those tests are run isn't `en_US`. Both these tests were introduced as part of
Can I please get a review of this trivial change to the javadoc of
`DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in
https://bugs.openjdk.java.net/browse/JDK-8282190?
-
Commit messages:
- 8282190: Typo in javadoc of
On Mon, 14 Feb 2022 05:27:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8281634?
>
> The commit introduces the missing `err.invalid.filters` key in the jdeps
> resource
On Mon, 14 Feb 2022 05:27:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8281634?
>
> The commit introduces the missing `err.invalid.filters` key in the jdeps
> resource
On Mon, 14 Feb 2022 05:27:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8281634?
>
> The commit introduces the missing `err.invalid.filters` key in the jdeps
> resource
Can I please get a review for this change which proposes to fix the issue noted
in https://bugs.openjdk.java.net/browse/JDK-8281634?
The commit introduces the missing `err.invalid.filters` key in the jdeps
resource bundle. I have run a simple check to make sure this resource bundle
doesn't
On Thu, 10 Feb 2022 22:08:27 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java
>> line 197:
>>
>>> 195: // Predicate above covers enum constants, including
>>> 196: // those with specialized class
On Thu, 10 Feb 2022 05:49:47 GMT, Joe Darcy wrote:
> Two changes to the toString output for annotations to give better source
> fidelity:
>
> 1) For enum constants, call their name method rather than their toString
> method. An enum class can override the toString method to print something
>
it was well worth the investigation.
Unless others on this list disagree, or can suggest other tricks,
I would suggest shelving this work for now.
best regards,
-- daniel
On 18/12/2021 06:00, Jaikiran Pai wrote:
Would there be interest in moving this forward? Enabling that
FILE_SHARE_DELETE
On 03/02/22 7:07 pm, Alan Bateman wrote:
I think it would be useful to hear from Jon Gibbons or someone else
working on javac first. It would be a bit unusual to run the compiler
with a security manager and I thought it was deliberate to not grant
permissions to jdk.compiler in the default
in the default.policy file.
Please file a bug, or if you like I can file one on your behalf.
Thanks,
Sean
On 2/3/22 8:01 AM, Jaikiran Pai wrote:
I'm unsure if core-libs is the right place for this or compiler-dev,
sending this to core-libs for now.
Please consider this trivial Java source file:
public class
I'm unsure if core-libs is the right place for this or compiler-dev,
sending this to core-libs for now.
Please consider this trivial Java source file:
public class HelloWorld {
public static void main(final String[] args) throws Exception {
System.out.println("Hello World");
}
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
>
On Wed, 12 Jan 2022 13:45:00 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8279921?
>
> The change here builds upon the debugging enhancement that was done in
> https://github.com/openjdk/jdk/p
On Wed, 12 Jan 2022 13:45:00 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8279921?
>
> The change here builds upon the debugging enhancement that was done in
> https://github.com/openjdk/jdk/p
Can I please get a review for this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8279921?
The change here builds upon the debugging enhancement that was done in
https://github.com/openjdk/jdk/pull/6696 to try and narrow down the problem
behind intermittent failures on macos
open https://github.com/openjdk/jdk/pull/6477.
-Jaikiran
On 19/11/21 5:10 pm, Jaikiran Pai wrote:
I have been experimenting with
https://bugs.openjdk.java.net/browse/JDK-8224794 and have reached a
stage with my changes where I would like some inputs before I move
ahead or raise a PR for review
On Mon, 6 Dec 2021 16:59:41 GMT, Roger Riggs wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an unconventional exception type,
On Mon, 6 Dec 2021 04:25:37 GMT, Jaikiran Pai wrote:
>> The effects of invalid values of `jdk.serialFilter` and
>> `jdk.serialFilterFactory` properties are
>> incompletely specified. The behavior for invalid values of the properties is
>> different and
>> use an
On Wed, 1 Dec 2021 18:19:05 GMT, Roger Riggs wrote:
> The effects of invalid values of `jdk.serialFilter` and
> `jdk.serialFilterFactory` properties are
> incompletely specified. The behavior for invalid values of the properties is
> different and
> use an unconventional exception type,
On Thu, 2 Dec 2021 19:04:11 GMT, Roger Riggs wrote:
> fyi, with this change the JCK did not flag a failure.
Thank you Roger for running those tests.
-
PR: https://git.openjdk.java.net/jdk/pull/6488
On Wed, 1 Dec 2021 12:21:00 GMT, Athijegannathan Sundararajan
wrote:
>> Can I please get a review of this change which adds `jlink.debug=true`
>> system property while launching `jpackage` tests?
>>
>> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
>> take into
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into a
On Wed, 24 Nov 2021 08:54:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which adds `jlink.debug=true` system
> property while launching `jpackage` tests?
>
> The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
> take into a
On Tue, 30 Nov 2021 14:28:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes a typo in the javadoc
> of `java.util.zip.ZipEntry.setTime()` method?
Thank you everyone for the reviews.
-
PR: https://git.openjdk.java.net/jdk/pull/6615
On Tue, 30 Nov 2021 14:28:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes a typo in the javadoc
> of `java.util.zip.ZipEntry.setTime()` method?
This pull request has now been integrated.
Changeset: 0a01baaf
Author:Jaikiran Pai
URL:
Hello Andrew,
On 30/11/21 7:32 pm, Andrew Leonard wrote:
On Mon, 29 Nov 2021 16:22:30 GMT, Andrew Leonard wrote:
Add a new --source-date (epoch seconds) option to jar and jmod to
allow specification of time to use for created/updated jar/jmod entries. This then
allows the ability to make
Can I please get a review for this change which fixes a typo in the javadoc of
`java.util.zip.ZipEntry.setTime()` method?
-
Commit messages:
- 8277986: Typo in javadoc of java.util.zip.ZipEntry#setTime
Changes: https://git.openjdk.java.net/jdk/pull/6615/files
Webrev:
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
>
On 26/11/21 7:32 am, Mandy Chung wrote:
On Thu, 25 Nov 2021 02:22:20 GMT, Jaikiran Pai wrote:
Mandy Chung has updated the pull request incrementally with one additional
commit since the last revision:
minor fix to avoid casting
Hello Mandy, one small issue - `ClassFileReader
On Wed, 24 Nov 2021 17:06:41 GMT, Mandy Chung wrote:
>> jdeps intends to report an error if there are multiple versions of the same
>> class being parsed. module-info.class should be excluded from such
>> detection.
>>
>> This patch also fixes a data race in `VersionHelper::set` and also
On Wed, 24 Nov 2021 15:04:35 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to k
On Mon, 13 Sep 2021 05:35:23 GMT, Jaikiran Pai wrote:
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last mod
require a bigger change and also a discussion on what kind of
> extending of module-info.class content will require a change to the
> lastmodifiedtime of that entry.
Jaikiran Pai has updated the pull request incrementally with three additional
commits since the last revision:
- revie
Hello Andy,
On 24/11/21 7:23 pm, Andy Herrick wrote:
never mind my previous email, addArgument("--java-option ...") ,
would be for argument to the java launching the app.
you are right to use -J-Djlink.debug=true . It must be interpreted in
the standard launcher used for jpackage, because
On Wed, 24 Nov 2021 14:06:29 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to k
require a bigger change and also a discussion on what kind of
> extending of module-info.class content will require a change to the
> lastmodifiedtime of that entry.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13
Can I please get a review of this change which adds `jlink.debug=true` system
property while launching `jpackage` tests?
The previous fix for this in https://github.com/openjdk/jdk/pull/6491 didn't
take into account the part where the `jpackage` tool gets launched as a
`ToolProvider` from some
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21.
>
> The fix for JDK-8277507 is causing 38 failures per Tier2 job set.
Sorry, I should really have had run that original PR through `tier2` from
someone before merging
On Sun, 21 Nov 2021 12:39:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to add more
> diagnostics when a failure occurs in the jlink tool during the jpackage tests?
>
> As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3
On Tue, 23 Nov 2021 04:57:57 GMT, Alexander Matveev
wrote:
>> Can I please get a review of this change which proposes to add more
>> diagnostics when a failure occurs in the jlink tool during the jpackage
>> tests?
>>
>> As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3
On Mon, 22 Nov 2021 08:14:20 GMT, Alan Bateman wrote:
> It might be that jlink is throwing IAE for cases where another exception is
> more appropriate, but it does suggests something intermittent in the jpackage
> tests to trigger it.
Issue https://bugs.openjdk.java.net/browse/JDK-8277058
On Sun, 21 Nov 2021 12:39:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to add more
> diagnostics when a failure occurs in the jlink tool during the jpackage tests?
>
> As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3
On Mon, 22 Nov 2021 19:57:25 GMT, Roger Riggs wrote:
> The effects of an invalid `jdk.serialFilter` property are not completely
> documented. If the value of the system property jdk.serialFilter is invalid,
> deserialization should not be possible and it should be clear in the
>
require a bigger change and also a discussion on what kind of
> extending of module-info.class content will require a change to the
> lastmodifiedtime of that entry.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
use proper Fi
On Mon, 22 Nov 2021 09:09:37 GMT, Jaikiran Pai wrote:
>> test/jdk/tools/jar/modularJar/JarToolModuleDescriptorReproducibilityTest.java
>> line 60:
>>
>>> 58: private static final String UPDATED_MODULE_VERSION = "1.2.4";
>>> 59: private stat
On Mon, 22 Nov 2021 08:25:38 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
require a bigger change and also a discussion on what kind of
> extending of module-info.class content will require a change to the
> lastmodifiedtime of that entry.
Jaikiran Pai has updated the pull request incrementally with four additional
commits since the last revision:
- rev
Can I please get a review of this change which proposes to add more diagnostics
when a failure occurs in the jlink tool during the jpackage tests?
As noted in https://bugs.openjdk.java.net/browse/JDK-8277507, so far 3 failures
have been reported in jpackage tests (across different test cases)
On Sat, 20 Nov 2021 19:13:43 GMT, Mandy Chung wrote:
> java.lang.reflect.Field::set on static field with invalid argument type
> should throw IAE. But this regression is introduced by JEP 416 throwing NPE
> instead.
>
> `ensureObj` is called as the first check of the `Field::set` method to
Can I please get a review for this change which proposes to fix the issue
reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
The issue notes that this is applicable for `WeakHashMap` which have `null`
keys. However, the issue is even applicable for `WeakHashMap` instances which
On Fri, 5 Nov 2021 13:52:49 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to k
require a bigger change and also a discussion on what kind of
> extending of module-info.class content will require a change to the
> lastmodifiedtime of that entry.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excl
101 - 200 of 584 matches
Mail list logo
