ok to me.
I did notice the \n endings for the messages that Brent pointed out.
Best
Kumar Srinivasan
On May 6, 2020, at 9:43 PM, Mikael Vidstedt
mailto:mikael.vidst...@oracle.com>> wrote:
I have always wondered what “solinux” is supposed to mean - though not enough
to actual
re in Aaarghs.java the modules
related tests for the launcher are at:
https://hg.openjdk.java.net/jdk/jdk13/file/0368f3a073a9/test/jdk/tools/launcher/modules/basic
Using the modules test framework may make the test simpler.
Kumar Srinivasan
On Mon, Dec 2, 2019 at 11:34 AM Nikola Grc
look at this, you are correct, this patch doesn’t
> address the wildcard expansion issue, but only to address the potential
> crash if a main class is not specified as Nikola pointed out.
>
> We definitely need a follow up to fix wildcard expansion. The pointer to
> simplify the test is
odule, which prints its args,
http://hg.openjdk.java.net/jdk/jdk/file/31882abe1494/test/jdk/tools/launcher/TestHelper.java
Kumar Srinivasan
On Fri, Dec 6, 2019 at 2:44 PM Henry Jen wrote:
> Thanks for the work, the test case covers that when —module= is used
> before other options, wh
.errorTo(System.out)
> +.shouldContain("F--help");
> +
> +// java --module-path=mods --module=$TESTMODULE/$MAINCLASS
> <...src/test>/*.java --help
> +// We should be able to see argument expansion happen
> +ProcessTools.execu
Hi Nikola,
Thank you for making the changes. Looks good to me.
Kumar Srinivasan
PS: my new and official email address: kusriniva...@vmware.com
On Wed, Dec 11, 2019 at 10:04 AM Nikola Grcevski <
nikola.grcev...@microsoft.com> wrote:
> Thank you again for reviewing my code Kumar!
&
e test and push it before
> RDP1 if everything is good with Kumar as reviewer.
>
> Cheers,
> Henry
>
>
>> On Dec 11, 2019, at 2:26 PM, Kumar Srinivasan wrote:
>>
>> Hi Nikola,
>>
>> Thank you for making the changes. Looks good to me.
&g
Hey Igor — please read inlined comment below…..
[cc’ed Jon]
On Dec 12, 2019, at 10:46 PM, Igor Ignatyev
mailto:igor.ignat...@oracle.com>> wrote:
On Dec 12, 2019, at 10:21 PM, David Holmes
mailto:david.hol...@oracle.com>> wrote:
Hi Igor,
On 13/12/2019 3:19 pm, Igor Ignatyev wrote:
https://na
Looks good to me - approved.
Thanks
Kumar
Hopefully all interested parties are addressed in the cc lists.
webrev at:
http://cr.openjdk.java.net/~dholmes/7022370/webrev/
The launcher ergonomics (ergo.c) currently relies on per-architecture,
eg ergo_sparc.c, ergo_i586.c, files to define the a
Alan,
http://cr.openjdk.java.net/~ksrini/7031166/webrev.1
Fixed it per your suggestions.
Thanks
Kumar
Kumar Srinivasan wrote:
Hi,
Replaces some old nio code which copies over the test sdk to run
tests against.
http://cr.openjdk.java.net/~ksrini/7031166/webrev.0/
Thanks
Kumar
I see the
Description:
http://cr.openjdk.java.net/~ksrini/7043125/cmt.txt
Webrev:
http://cr.openjdk.java.net/~ksrini/7043125/webrev.0/
Thanks
Kumar
Hi,
Please review ...
http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/
http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt
Thanks
Kumar
rect
line-end on Windows platform.
For example if the result is re-directed into a file, that file
probably can not be displayed in
notepad correctly...
-Sherman
On 06/21/2011 11:23 AM, Kumar Srinivasan wrote:
Hi,
Please review ...
http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/
http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt
Thanks
Kumar
the correct
line-end on Windows platform.
For example if the result is re-directed into a file, that file
probably can not be displayed in
notepad correctly...
-Sherman
On 06/21/2011 11:23 AM, Kumar Srinivasan wrote:
Hi,
Please review ...
http://cr.openjdk.java.net/~ksrini/7046007/webrev.
Hello,
http://cr.openjdk.java.net/~ksrini/7062969/
Thanks
Kumar
Updated the webrev.
http://cr.openjdk.java.net/~ksrini/7062969/webrev/
Thanks
Kumar
On 7/15/2011 11:38 AM, Kumar Srinivasan wrote:
Hello,
http://cr.openjdk.java.net/~ksrini/7062969/
Thanks
Kumar
Approved. However, I note that the new URL is different from what the
old URL gets
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/7067922
Thanks
Kumar
On 7/18/2011 9:45 PM, Alan Bateman wrote:
Kumar Srinivasan wrote:
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/7067922
Thanks
Kumar
Looks okay to me too. Minor nit is the addition of that createJar in
TestHelper means the indention at line 203 it out.
Ah, ok fixed the
Hi,
Sorry for the delay, was on vacation...comment inlined.
Hi, here is a webrev[1] for some cleanup that i want to integrated in
tl-repositories.
Alan Bateman had scanned the changes and gave me some good input[3]
for further discussion here:
The changes to java.util.concurrent should go t
Approved.
Kumar
hi all,
Please find attached a trivial patch to remove an unused variable in
jdk/src/solaris/bin/java_md.c
The present of the variable causes the AIX build to fail since Dl_info
is not supported on AIX.The other use of Dl_info in the file is
safely wrapped with an #if defi
You can file it as follows:
Product: jct_tools
Category: jct_tools
Subcategory: regtest
and for a good measure add jon to the interest list.
Kumar
David,
I'm not sure where we can file bugs on jtreg, probably have to wait
for Jon to come back on line and drop him a mail.
This is even wors
Hi,
This fixes a bug in launcher where showSettings in conjunction with -version
will do both and exit successfully. Thanks to Sean for pointing this out.
Here is the webrev:
http://cr.openjdk.java.net/~ksrini/7123582/
Thanks
Kumar
Hi,
This fixes a perennial problem with the shell test and its interactions
with MKS/Cygwin shells, by eliminating the shell test completely.
http://cr.openjdk.java.net/~ksrini/7124443/webrev.0/
Thanks
Kumar
Alan,
On 23/12/2011 02:22, Kumar Srinivasan wrote:
Hi,
This fixes a bug in launcher where showSettings in conjunction with
-version
will do both and exit successfully. Thanks to Sean for pointing this
out.
Here is the webrev:
http://cr.openjdk.java.net/~ksrini/7123582/
Thanks
Kumar
Vote: yes
Kumar
I hereby nominate David Holmes to membership of the core-libs group.
David doesn't need too much introduction. He is a reviewer on several
OpenJDK projects, including the HotSpot Express project, JDK 7 and JDK
8. He is a prolific reviewer, particularly for library changes
di
Hi,
Please review:
CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442
Webrev:
http://cr.openjdk.java.net/~ksrini/7124443/
Thanks
Kumar
sorry I pasted the wrong webrev in the email,
here is the right one...
http://cr.openjdk.java.net/~ksrini/7125442/
Kumar
Hi,
Please review:
CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442
Webrev:
http://cr.openjdk.java.net/~ksrini/7124443/
Thanks
Kumar
mkdir fails then createJar will throw exception.
Otherwise, looks good.
Thanks
Kumar
Mandy
On 1/10/2012 1:06 PM, Kumar Srinivasan wrote:
sorry I pasted the wrong webrev in the email,
here is the right one...
http://cr.openjdk.java.net/~ksrini/7125442/
Kumar
Hi,
Please review:
CR:
http
Hi,
Fixes spurious test failure noticed on Windows 64, for some
reason the env variable CLASSPATH either is not set in the
child environment or it is wrong.
This solution eliminates the need to depend on the env variable,
instead the classpath (defined by jtreg) is set on the command
line of th
Cool thanks.
Kumar
On 24/01/2012 04:36, Kumar Srinivasan wrote:
Hi,
Fixes spurious test failure noticed on Windows 64, for some
reason the env variable CLASSPATH either is not set in the
child environment or it is wrong.
This solution eliminates the need to depend on the env variable
Hi Joe, Naoto, Sherman,
Here are the highlights of these changes:
1. The TestHelper.java is now extensible, this simplifies the usage of
static variables
and methods, added a couple of convenience methods and some minor
refactoring.
2. Eliminated some shell tests, (few more remaining,
_GB.
Other than that, it looks good to me.
Naoto
On 1/27/12 10:30 AM, Joe Darcy wrote:
Hi Kumar,
Looks fine; good to see the shell code go away!
-Joe
On 01/27/2012 10:03 AM, Kumar Srinivasan wrote:
Hi Joe, Naoto, Sherman,
Here are the highlights of these changes:
1. The TestHelper.jav
Hi Naoto,
Here is the incremental webrev since last revision:
http://cr.openjdk.java.net/~ksrini/7127906/webrev.1/webrev.delta/index.html
Here is the full webrev for reference:
http://cr.openjdk.java.net/~ksrini/7127906/webrev.1/index.html
Thanks
Kumar
On 1/27/12 11:36 AM, Kumar Srinivasan
Hi,
Here are some improvements to the launcher tests, contributed by Sonali
Goel of the SQE team, please review:
http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/
The CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141
Thanks
Kumar
consistent.
Thanks
Kumar
Hello,
On 2/1/2012 1:37 PM, Kumar Srinivasan wrote:
Hi,
Here are some improvements to the launcher tests, contributed by Sonali
Goel of the SQE team, please review:
http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/
The CR:
http://bugs.sun.com/bugdatabase/view_bug.do
Hello,
Please review fix for :
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131266
The gist of the problem being addressed, the specimen jar contains
two versions of class file implementations with the same package names,
this tends to confuse the pack200 mechanism causing it to fire as
Hi,
Please review fix for launcher tests, the JVM requires a higher
stack size for 64bit systems, this fixes increases the stack size
and removes the test from the problem list.
fyi,
The stack size is specified here so that the launcher flag under
test, parses and scales these options for huma
Hi,
Please review fix for launcher tests, the JVM requires a higher
stack size for 64bit systems, this fixes increases the stack size
and removes the test from the problem list.
fyi,
The stack size is specified here so that the launcher flag under
test, parses and scales these options for hu
Hi,
We are adding new test to test the tool functionality of the launcher:
1. verify the options intended for a tool does gets to it intact, Steve
Sides
from SQE has contributed this test, which applies various test
vectors to
a simulated javac launcher.
2. enhanced the version check
Hi,
Please review this simple fix, the check for "openjdk version" was missed
for openjdk builds, here is the correction:
http://cr.openjdk.java.net/~ksrini/7158090/
Thanks
Kumar
Hi Daniel,
It is likely you are running into this issue:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146424
Thanks
Kumar
Hi all,
I've notice a strange java 7 behavior on windows when a "*" is used as
argument:
Here is the test case, just printed out the args (pretty simple as you
Hi All,
This has been a joint effort between John Rose and I to bring the pack200
implementation to support JSR-292 classfile format.
The webrev is large, please let me know if you need extra time.
http://cr.openjdk.java.net/~ksrini/6981776/webrev.0/
Thanks
Kumar
Looks good, I also tested this and it works.
Kumar
Looks fine.
-kto
On Apr 22, 2012, at 8:51 AM, Alan Bateman wrote:
I need a reviewer for a trivial change to get jdk8/tl building on Mac again. Jim's
changes for 7130404 [1] change the os.arch variable to "x86_64" to be
compatible with App
Hi,
Could you please review this, actually the launcher is a 2 line change,
but when I was testing/experimenting with this, it was hard to inspect
the .jtr file for test failure, the test framework is cleanup to help the
reader quickly identify the failing test cases.
http://cr.openjdk.java.net
Hi David, Deven, Alan,
The spec doesn't say anything but the implementation does check for
NULL. I think this is a spec issue rather than a code issue (and I
think hotspot-runtime owns the JNI spec so cc'ed). It is common
practice for API's that take pointers like this to say "if buf is not
NU
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/7166955
Thanks
Kumar
On 07/05/2012 16:45, Kumar Srinivasan wrote:
Hi David, Deven, Alan,
The spec doesn't say anything but the implementation does check for
NULL. I think this is a spec issue rather than a code issue (and I
it check for a (retval != JNI_OK || vm
== null) instead of (retval < 0 || vm == null)?
Regards,
Vitaly
Sent from my phone
On May 7, 2012 4:23 PM, "Kumar Srinivasan"
mailto:kumar.x.sriniva...@oracle.com>>
wrote:
Hi,
Please review
http://cr.openjdk.
Hi Alan, David, Vitaly,
Ok I will make these changes and push.
Thanks
Kumar
On 07/05/2012 21:21, Kumar Srinivasan wrote:
Hi,
Please review
http://cr.openjdk.java.net/~ksrini/7166955
I think the check needs to be:
if (retval < 0 || nVM != 1)
(checking if retval == JNI_OK is okay too
On 5/8/2012 1:28 AM, Alan Bateman wrote:
On 08/05/2012 04:14, David Holmes wrote:
I think it is clear that if there are no VMs then *nVMs is set to
zero and JNI_OK is returned.
I don't think it is clear and it should be made explicit in the spec.
BTW: Did you create a bug for the JNI spec w
Hi,
Fixed CR reference in test.
http://cr.openjdk.java.net/~ksrini/7170087/
The original changset for reference.
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f68c854fa584
Thanks in advance.
Kumar
Hi,
Please review, changes has been internally reviewed by John.
http://cr.openjdk.java.net/~ksrini/7168401/webrev.0/
Thanks
Kumar
Hi,
Please review the following bug, it is not yet available on bugs.sun.com,
there is a discussion thread jdk7u-...@openjdk.java.net
http://cr.openjdk.java.net/~ksrini/7184145/
Thanks
Kumar
Ok took care of it.
Thanks
Kumar
On 14/07/2012 20:32, Kumar Srinivasan wrote:
Hi,
Please review the following bug, it is not yet available on
bugs.sun.com,
there is a discussion thread jdk7u-...@openjdk.java.net
http://cr.openjdk.java.net/~ksrini/7184145/
The change looks good to me
Hi,
Please review the fix
http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/
to address:
7146424: Wildcard expansion for single entry classpath
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146424
and
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7167744
Notes:
a. cmdtoargs.c will
dle
both, and eliminate the scopes.
Kumar
David
-
On 27/07/2012 10:41 PM, Kumar Srinivasan wrote:
Hi,
Please review the fix
http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/
to address:
7146424: Wildcard expansion for single entry classpath
http://bugs.sun.com/bugdatabase/view_bu
o eliminate cpp conditionals.
Any more comments from others ? Please let me know today, I would like
to sew this
up with one more webrev.
Thanks
Kumar
David
On 30/07/2012 10:32 PM, Kumar Srinivasan wrote:
HI David,
I can't comment on the details of the actual expansion logic, nor the
tests
,
I'm always uncomfortable when I see common code that is effectively a
no-op on all but one platform - as it means it isn't really common, we
just factored it that way. But I'm not vehemently opposed. :)
David
On 30/07/2012 10:32 PM, Kumar Srinivasan wrote:
HI David,
I can&#
you can change 117 to not use i
117 margv[i] = NULL;
becomes
margv[margc] = NULL;
Ah!, oh sorry that won't fly this is c code :-( , not c++, MSC does not
allow it.
Kumar
David
On 31/07/2012 6:11 AM, Kumar Srinivasan wrote:
Hi David,
Here are the changes you sugge
Hi,
Please make sure that the jdk/test/tools/* tests are run and validated.
Both the java launcher and the pack200 tools are dependent on zlib
entry points for inflate/deflate and other things.
Kumar
- Original Message -
On 08/06/2012 11:26 AM, Andrew Hughes wrote:
- Original Me
Hi,
In my previous push for
http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/
I missed adding CR number to the regression test Arrrghs.java, also some
minor improvements to TestHelper.java for better diagnosis of failing tests.
http://cr.openjdk.java.net/~ksrini/7189944/webrev.0/
Thanks
K
Hi,
fyi. already reviewed by John Rose.
http://cr.openjdk.java.net/~ksrini/7190750/webrev.0/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7190750
Thanks
Kumar
Hi Sherman, Joe, et. al.
Please review the launcher changes to read the manifest of
a ZIP64 archive.
http://cr.openjdk.java.net/~ksrini/7194005/webrev.0/
Thanks
Kumar
problems, but defaulting to running a
> test that writes multiple gibabytes to disk may have unwanted performance
> costs for general testing. Perhaps that scenario could be included in the
> test code, but only run on an opt-in basis?
>
> -Joe
>
>
> On 9/4/2012 6:
> code) the zip_util/ZIP_Open/FineEntry/ReadEntry instead of having your own
> zip format handling
> code in launcher (source). Not necessary for this patch.
>
> -Sherman
>
> On 09/04/2012 10:05 AM, Kumar Srinivasan wrote:
> Hi Joe,
>
> I was thinki
t; code) the zip_util/ZIP_Open/FineEntry/ReadEntry instead of having
> your own zip format handling
> > code in launcher (source). Not necessary for this patch.
> >
> > -Sherman
> >
> > On 09/04/2012 10:05 AM, Kumar Srinivasan wrote:
>
>
> > Hi Jo
Hi,
Please review removal of a left over file which was introduced during the
early development of pack200 but somehow managed to exist in
the jdk repo for the past 9 years and 3 days :)
http://cr.openjdk.java.net/~ksrini/7199614/
Thanks in advance
Kumar
On 9/24/2012 6:46 AM, Andrew Hughes wrote:
- Original Message -
hi all,
this may seem a strange request but here goes..
IBM ships its runtimes with a javaw launcher on all platforms - not
just Windows.
We do this for consistency reasons so that applications using Java
know tha
e jdk.
Remember that jdk engineers tend not to experience "jar hell"
themselves.
Martin
--
Kumar Srinivasan
Sun Microsystems, Java Software.
408-276-7586
Martin,
CR: 4326573, I have updated this bug with your solution.
Danke
Kumar
On Mon, Jul 6, 2009 at 15:08, Kumar Srinivasan wrote:
Hi Martin,
I take it you want me to integrate this after due diligence ?
Yes.
We are not in any hurry to integrate it,
and we understand that there
Hello All,
This is a long standing issue we have had with the java launcher, please
review.
http://cr.openjdk.java.net/~ksrini/6367077/webrev.00/
Thanks
Kumar
rty("sun.arch.data.model", "32").equals("64");
+static final boolean is32Bit = !is64Bit;
Martin
On Tue, Nov 10, 2009 at 14:55, Kumar Srinivasan
wrote:
Hello All,
This is a long standing issue we have had with the java launcher, please
review.
http://cr.openjdk.java.net/~ksrini/6367077/webrev.00/
Thanks
Kumar
Changeset: de45eac5670e
Author:ksrini
Date: 2009-11-20 11:01 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de45eac5670e
6367077: Purge LD_LIBRARY_PATH usage from the launcher
6899834: (launcher) remove the solaris libjvm.so symlink
Summary: Fixes other related issues as well
testing to see if my oracle id works now.
Please delete and sorry for the spam.
Kumar
Ah yes, I will fix this.
Kumar
Hello Kumar,
I think we should update the comment above the changed line in
PropMap.java too.
Thanks,
Nikolay
Kumar Srinivasan wrote:
Hello,
This is a very simple fix to a long standing issue with pack200, it
changes the
default behavior of pack200 to use
Hello,
This is a very simple fix to a long standing issue with pack200, it
changes the
default behavior of pack200 to use one segment by default, which will
cover most common use cases.
http://cr.openjdk.java.net/~ksrini/6575373/
Thanks
Kumar
On 7/14/2010 8:54 AM, Alan Bateman wrote:
Peter Arrenbrecht wrote:
See
http://hg.openjdk.java.net/jdk7/modules/jdk/file/tip/src/share/classes/java/io/Closeable.java
and compare
http://developer.android.com/reference/java/io/Closeable.html#close()
Cheers,
-parren
The master forest is jdk7
Hi,
These are simple changes to the java.util.jar.pack:
* fixes JCK failures, specifically throwing unexpected exceptions
* minor fixes to the ClassFormatException
* added a new test to catch the JCK type failures up-front, which is
bulk of the code changes.
http://cr.openjdk.java.net
I will look into incorporating all the comments, watch out for the next
version.
Kumar
Kumar Srinivasan wrote:
Hi,
These are simple changes to the java.util.jar.pack:
* fixes JCK failures, specifically throwing unexpected exceptions
* minor fixes to the ClassFormatException
* added a
m/javase/6/docs/api/java/util/jar/Pack200.html
I copied the same verbiage to the interfaces sections as well.
2. moved the exception check into scanJar, per Alan's suggestion where
it is
isolated to catch IllegalStateException and wraps it up into an IOE.
Thanks
Kumar
Kumar S
On 11/4/2010 3:53 AM, Alan Bateman wrote:
Kumar Srinivasan wrote:
Thanks for all the reviews and suggestions!
the new version is at:
http://cr.openjdk.java.net/~ksrini/6985763/webrev.01
In this revision:
1. the input parameter is renamed to "in",
btw. we call out throwing of N
Hi,
Appreciate a review of the pack200 cleanup work, in the following areas:
1. General generification of Collections.
2. fixed worthy findbugs items.
3. fixed worthy Netbeans nags.
4. Elimination of array/generics combination.
The webrev is here:
http://cr.openjdk.java.net/~ksrini/6990106/webr
s
implementation is subject to the hazards outlined in the Effective
Java item "Prefer composition to extension." (For example you
override put() but not putAll(), but this idiom cannot be made to work
without tightly coupling it to the superclass implementation.)
I will see what I can
Hi Alan, Brian,
Thanks! I will look into both your comments.
Kumar - I just scanned this (sorry, I don't have time to do a detailed
review).
- is Attribute.isEmpty right? or rather should ""==null be replaced by
false?
yes, I will redo this.
- in BandStructure.java, can basicCodingIndexes
#x27;d pass on what I saw.
-kto
On Nov 11, 2010, at 9:29 AM, Kumar Srinivasan wrote:
Hi,
Appreciate a review of the pack200 cleanup work, in the following areas:
1. General generification of Collections.
2. fixed worthy findbugs items.
3. fixed worthy Netbeans nags.
4. Elimination of arr
Hi All,
Please review the following:
http://cr.openjdk.java.net/~ksrini/6452854/webrev.00/
This will print all the known settings/properties/locales
supported and known to Java, this has been a long standing request.
A sample output attached below.
Note: the -X option specifically is being
Hi Mandy,
java.c
line 1031: this doesn't catch invalid option if it has the
-XshowSettings prefix e.g. -XshowSettingsJunk.
Will fix it.
line 1032: Perhaps you could store the suboption ("all", "vm", etc)
rather than the entire option string.
I want to keep all the parsing logic as much a
ntLocale(PrintStream ostream) {
Locale locale = Locale.getDefault();
ostream.println();
ostream.println(LOCALE_SETTINGS);
ostream.print(INDENT+"default locale: ");
ostream.print(locale.getDisplayLanguage());
prettyPrintLocales(ostream);
ostream.println();
}
ter
stage. It would be
good to get this in and get more feedback and enhance/evolve it in a
future release.
Thanks
Kumar
David
Kumar Srinivasan said the following on 11/12/10 07:56:
Hi All,
Please review the following:
http://cr.openjdk.java.net/~ksrini/6452854/webrev.00/
This will prin
story together.
We cannot tell our users/support personnel, SQE etc. to use different
flags to get the
Java and VM settings.
Thanks
Kumar
David
Thanks
Kumar
David
Kumar Srinivasan said the following on 11/12/10 07:56:
Hi All,
Please review the following:
http://cr.openjdk.java.net
A sample output attached below.
Fantastic!
- The colons on the path components seem unnecessary if each element is also
going to be separated by line breaks
yes, but I thought I will leave it there to remind users that is the
pathseparator.
- In the output for the property 'line.seperator
e new webrev shortly.
Kumar
...
then pass the fm around and finally dump the sb.toString() to the
out/err. This way you will
have better control of the "spacing", the \n (with "%n") and might
also bring in some "locale"
sensitive benefits (maybe in the future).
-Sher
On 11/12/2010 11:59 AM, David Holmes wrote:
Kumar Srinivasan said the following on 11/13/10 01:16:
- ServerClassMachine() does not take into account -Xint
possibility (and will need updating for Tiered compilation)
Absolutely when that becomes a reality.
You overlooked the -Xint part. I
will not be displayed.
7. In the case of the Max memory not gotten from the launcher
(Estimated) is printed.
8. Removed the option hints -X* and so on in the labels.
9. Renamed Ergonomic Class -> Ergonomic Machine Class.
Thanks
Kumar
On 11/11/2010 16:42, Kumar Srinivasan wrote:
line
t;pretty...", try
to hint only the "Locales"
and "Values" are prettily printed?
I see, you have a problem with the names ?
alright, alright, I will make it consistent with the others.
I think you are working too late on a Friday. ;-)
and I am working too early on
(LocaleCategory.DISPLAY)), and the one for
formatting (Locale.getDefault(LocaleCategory.FORMAT)), so you may want
to show them along with the original default locale.
Naoto
(11/12/10 12:17 PM), Kumar Srinivasan wrote:
Thanks for all the reviews!.
Here are the fixes in this version:
http://cr.openjdk.java.net
position to extension." (For example you
override put() but not putAll(), but this idiom cannot be made to work
without tightly coupling it to the superclass implementation.)
On 11/11/2010 12:29 PM, Kumar Srinivasan wrote:
Hi,
Appreciate a review of the pack200 cleanup work, in the follo
other places too, which needs
ARM'ing, but
talking to Stuart Marks he seems to have the ARM'izing effort on his
agenda.
- FixedList.java : Anything saved by extending AbstractList rather than
implementing List?
Done
Thanks
Kumar
On Nov 15 2010, at 17:24 , Kumar Srinivasa
not O(1) for some collections where isEmpty()
is O(1).
PropMap : could _listeners and theMap be private? Since initialization of
theMap doesn't depend upon any constructor params why not construct it at
declaration?
Mike
On Nov 18 2010, at 14:58 , Kumar Srinivasan wrote:
Hi Mike,
Thanks
Hi,
Could you please review this simple fix, it guards the switch value
from a null.
http://cr.openjdk.java.net/~ksrini/7007157/webrev.00/
Thanks
Kumar
will throw an
NPE.
Kumar
It makes me nervous whenever I see "pretend this never happened" handling for
null.
Mike
On Dec 15 2010, at 14:45 , Kumar Srinivasan wrote:
Hi,
Could you please review this simple fix, it guards the switch value from a
null.
http://cr.openjdk.java.n
1 - 100 of 473 matches
Mail list logo
