On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
This pull request has now been integrated.
Changeset: 3d2d0395
Author: Anthony Vanelverdinghe
Committer: Jaikira
On Sat, 28 May 2022 10:00:50 GMT, Jaikiran Pai wrote:
>> The change is trivial, but I'll need help from someone to create a JBS issue
>> & sponsor this PR.
>
> @anthonyvdotbe, can you also please change the copyright year on that file
> from `Copyright (c) 2021,` to `Copyright (c) 2021, 2022,`
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
Anthony Vanelverdinghe has updated the pull request incrementally with one
additional commit since the last revision:
Correct copyright year
Signed-off-by: Anthony Vane
The change is trivial, but I'll need help from someone to create a JBS issue &
sponsor this PR.
-
Commit messages:
- Copy edit: remove pleonasm
Changes: https://git.openjdk.java.net/jdk/pull/8766/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8766=00
Issue:
On Tue, 24 May 2022 04:50:58 GMT, Jaikiran Pai wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/util/spi/ToolProvider.java
>>
e src/java.base/share/classes/java/util/spi/ToolProvider.java
>
> Co-authored-by: Anthony Vanelverdinghe
src/java.base/share/classes/java/util/spi/ToolProvider.java line 57:
> 55: * reusable and reentrant, or should clearly document any limitations and
> 56: * restrictions. In this
On Sun, 7 Nov 2021 07:51:06 GMT, Michael Bien wrote:
>>> wouldn't this make streams no longer lazy if the collection is empty?
>>>
>>> ```java
>>> List list = new ArrayList<>();
>>> Stream stream = list.stream();
>>>
>>> list.addAll(List.of("one", "two", "three"));
>>>
On Wed, 10 Nov 2021 09:43:58 GMT, Hendrik Schreiber
wrote:
>>> When I see ``, I'm just wondering what those <> type operators are
>>> good for here...
>>
>> What about just replacing `` with `...` then? The `State`
>> constructor and its invocation also have an ellipsis.
>>
>>> BUT, at
On Tue, 9 Nov 2021 08:59:32 GMT, Hendrik Schreiber
wrote:
>> The new example Cleaner instance _is_ shared, though on a pretty small scale
>> (just among instances of CleaningExample). A demonstration of larger scale
>> sharing of a Cleaner instance would be out of scope for this example.
>
>
On Fri, 22 Oct 2021 08:03:34 GMT, Hendrik Schreiber
wrote:
> Trivial improvement.
>
> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
> Repeat (again) in the code example that the `State` `Runnable `should be
> implemented as static class and not reference the
On Thu, 4 Nov 2021 19:28:58 GMT, Mandy Chung wrote:
> The dot graph should print the edges in alphatical order. A simple fix to
> sort the edges before printing them.
src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleDotGraph.java line 336:
> 334: private final String name;
>
On Thu, 13 May 2021 20:52:33 GMT, Stephen Colebourne
wrote:
> 8266846: Add java.time.InstantSource
A nice addition to the JDK, thanks for taking this on.
src/java.base/share/classes/java/time/Clock.java line 114:
> 112: * provides access to the current instant, and does not provide access
Hi Stuart
Will EnumSet also be updated to implement ReversibleSet? Or will it be updated
to implement NavigableSet [1] independently of this enhancement?
I'd also like to propose adding `ReversibleSet::of` factory methods. This is
something I miss having on SortedSet occasionally, but
Hi Rémi
The discussion "new types? or new default methods?" is indeed a valid one. In
fact, I think this choice has already been made once in favor of a default
method, when adding `List::sort` was chosen over adding `SortedList` (though I
imagine that choice was a no-brainer).
In this case I
On Tuesday, April 27, 2021 11:25 CEST, Peter Levart
wrote:
> Now just some of my thoughts about the proposal:
>
> - SortedSet.addFirst/.addLast - I think an operation that would be used
> in situations like: "I know this element should always be greater than
> any existing element in the set and
On Saturday, April 17, 2021 11:48 CEST, Stephen Colebourne
wrote:
> On Fri, 16 Apr 2021 at 18:41, Stuart Marks wrote:
> > This is a proposal to add a ReversibleCollection interface to the
> > Collections
> > Framework. I'm looking for comments on overall design before I work on
> > detailed
Hi Alan
As Marco mentioned, another use case is sub-process stdin/stdout/stderr. In my
particular instance, I'm starting a Process which has its output redirected to
a file. It uses the platform's default encoding for writing to stdout. So when
I want to read its output from the file at some
Hi Julia
Since short-circuiting sounds similar to a Subscriber cancelling its
Subscription, I believe it might be worthwhile to consider the Flow API.
If the argument would be a `Flow.Processor`, then the
implementation would publish instances of T to it, subscribe to receive
instances of R,
, A> transformer() {
return (stream, intermediary) -> {
var accumulator = accumulator();
stream.forEachOrdered(t -> accumulator.accept(intermediary,
t));
};
}
}
Kind regards,
Patrick
On 25 Jun 2020, at 18:12, Anthony Vanelverdinghe wro
Hi
Given the signature of flatMap is:
Stream flatMap(FunctionR>> mapper)
I'd like to propose the following signature for the new method:
Stream builderMap(BiConsumerStream.Builder> mapper)
This way both methods are named "...Map", and the name "builderMap"
follows naturally from the
Hi
I filed 2 bug reports for typos in java.base Javadoc:
https://bugs.openjdk.java.net/browse/JI-9064752 with patch
diff --git
a/src/java.base/share/classes/java/lang/invoke/package-info.java
b/src/java.base/share/classes/java/lang/invoke/package-info.java
index 82600d4866..a0ad09b03e
Hi Abraham
Wouldn’t it have been possible to use Map::isEmpty? Ideally just returning at
the very beginning of your method if `data` is an empty Map. That way you’d
still be able to use computeIfPresent, and use emptyMap() as well.
Kind regards,
Anthony
-April/059783.html
From: Raffaello Giulietti
Sent: Monday, June 17, 2019 4:56:22 PM
To: Anthony Vanelverdinghe; core-libs-dev
Subject: Re: [PATCH] 4511638: Double.toString(double) sometimes produces
incorrect results
Hi Anthony,
On 16/06/2019 19.17, Anthony
Hi Raffaello
While I don't have feedback on the actual math, here's a few suggestions:
- there's some use of non-ASCII characters in the patch. I don't think this is
common in the JDK's Java sources, so you might want to replace them with their
Unicode escapes. The characters are: ≤
Hi
Alan already proposed the following RFEs when NIO2 was introduced: a memory
FileSystemProvider [1], and a virtual FileSystemProvider [2]
With these, the javac use case could work as follows:
1) create a VirtualFileSystem, with all sources mounted under “/src”, a
MemoryFileSystem mounted
Hi Remi, Brian,
What about ‘asInputTo’ or some variant thereof (e.g. using Argument or the
abbreviated Arg instead of Input; or dropping/replacing either of the
prefix/suffix)?
This would give, for example:
`raw html`.asInputTo(HtmlDocument::new)
ks,
> Sherman
>
> [1]
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-February/039070.html
> [2] http://cr.openjdk.java.net/~kshoop/8124977/webrev.05/
> [3]
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-February/039068.html
>
> On 9/12/18, 10
Hi
What is the status of this issue [1]? It addresses some long-standing issues
with Java's Unicode support on Windows and was contributed by a team of
Microsoft engineers. However, it seems to have gone dormant right before the
finish line, and I can't really figure out who's waiting for whom
Hi Peter
I'd say no: it's merely the negation of an existing method, and given
that the bar for adding methods to Optional is set very high (see e.g.
[1] and [2]), I don't see how this one would meet it.
Moreover, I don't see any issues with simply writing:
return
chance the OS really couldn't
allocate a thread for the reason of no main memory available is very
narrow :)
Chris
Am 3/12/2017 um 3:24 PM schrieb Anthony Vanelverdinghe:
Files::readAllBytes is specified to throw an OutOfMemoryError "if
an array of the required size cannot be allocated, for e
Files::readAllBytes is specified to throw an OutOfMemoryError "if an
array of the required size cannot be allocated, for example the file is
larger that 2G". Now in Java 9, InputStream::readAllBytes does the same.
However, this overloads the meaning of OutOfMemoryError: either "the JVM
is out
Hi Yuji, Sherman et al.
PKWARE's "Strong Encryption Specification" [1] indeed warns about
patents, but how/why does this affect Winzip's AE-1 and AE-2 [2]?
I don't mind if decryption support is added for the "Traditional
Encryption". However, I believe it would be wrong to introduce
Hi
Thanks for taking on these challenges.
I would like to be able to associate file types with a Java program [1].
Currently, the Java program doesn't receive the argument (i.e. the path
to the file that was double-clicked) correctly if it contains Unicode
characters. I assume this would be
Hi
I would like to use a Java program for Windows file associations.
However, this doesn't work when the file to be opened contains non-ASCII
Unicode characters in its path.
There are several related issues about Windows Unicode support (e.g.
JDK-4488646, JDK-4519026, JDK-4900150,
Thanks for your clarifications Roger. I'm very much in favor of your
suggestion for naming the method supportsNormalTermination.
Kind regards,
Anthony
On 11/04/2015 20:35, Roger Riggs wrote:
Hi Anthony,
Thanks for the review and comments.
On 4/11/2015 5:00 AM, Anthony Vanelverdinghe wrote
Hi Roger
In my opinion, the method supportsDestroyForcibly is unintuitive, for
the following 2 reasons:
- it's named supportsXxx, where Xxx is the name of a method in the
same class. So as a user of this API, I would intuitively assume that
supportsDestroyForcibly is related to
Hi Roger
This looks great already. My feedback is about process destruction:
Why isn't ProcessHandle::isDestroyForcible a static method?
For ProcessHandle::destroy and Process::destroy, I'd like to propose
replacing
Whether the process represented by this Process object is forcibly
37 matches
Mail list logo
