Re: RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure

+1 Thanks, Chris > On 6 May 2020, at 6:35 PM, Daniel Fuchs wrote: > > Hi Aleksei, > > Looks good to me. > > best regards, > > -- daniel > > On 05/05/2020 18:23, Aleks Efimov wrote: >> "LDAP response read timed out, timeout used:-1ms.": >> https://bugs.openjdk.java.net/browse/JDK-8062947 >>

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you, Vyom Regards, Chris > On 23 Apr 2020, at 4:35 PM, Vyom Tiwari wrote: > > Hi Chris, > change looks good to me. > Vyom > > On Wed, Apr 22, 2020 at 12:59 PM Chris Yin <mailto:xu.y@oracle.com>> wrote: > Hello > > Please review following ch

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you, Daniel. Pushed Regards, Chris > On 23 Apr 2020, at 4:11 PM, Daniel Fuchs wrote: > > On 23/04/2020 01:39, Aleks Efimov wrote: >> Hi Chris, >> The changes look good to me. >> Thank you for extending the LDAP test server functionality. > > +1 > > Reviewed. > > best regards, > > --

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you for reviewing, Aleksei Regards, Chris > On 23 Apr 2020, at 8:39 AM, Aleks Efimov wrote: > > Hi Chris, > > The changes look good to me. > Thank you for extending the LDAP test server functionality. > > With Best Regards, > Aleksei > > On 22/04/2020

[15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Hello Please review following change for enhancement to com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8243138 Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/ There is requirement to test starttls extended op against dummy ldap

Re: [15] RFR: 8242614: cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests

Thank you for reviewing, Aleksei, Vyom, Daniel. Pushed. Regards, Chris > On 21 Apr 2020, at 5:30 PM, Daniel Fuchs wrote: > > Hi Chris, > > Thanks for this cleanup. > The proposed changes look reasonable and worthwhile. > > best regards, > > -- daniel >

[15] RFR: 8242614: cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests

Hello Please review following changes to cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests, thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8242614 Webrev: http://cr.openjdk.java.net/~xyin/8242614/webrev.00/ This is the first part to cleanup straightforward duplicated

Re: [15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

Thank you, Joe Regards, Chris > On 31 Mar 2020, at 11:49 PM, Joe Darcy wrote: > > Hi Chris, > > Revised version looks better; thanks, > > -Joe > > On 3/27/2020 1:30 AM, Chris Yin wrote: >> Hi, Joe >> >> Thank you for reviewing and comments. >

Re: [15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

. > > Thanks, > Vyom > > On Fri, Mar 27, 2020 at 2:48 PM Chris Yin <mailto:xu.y@oracle.com>> wrote: > Hi, Vyom > >> On 27 Mar 2020, at 12:08 PM, Vyom Tiwari > <mailto:vyomm...@gmail.com>> wrote: >> >> Hi Chris, >> >> I have

Re: [15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

String[] attributesToReturn) throws NamingException; > # Thank you for the detailed signatures info, yes, now all fixed in the latest webrev http://cr.openjdk.java.net/~xyin/8214694/webrev.01/ Regards, Chris > > thanks

Re: [15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

ndant "cast" warnings; in my cleanup > efforts, getting cast warnings was usually a sign the right generifiation was > found. > > HTH, > > -Joe > > On 3/25/2020 12:57 AM, Chris Yin wrote: >> Hello >> >> Please review following simple changes to

[15] RFR: 8214694: cleanup rawtypes warnings in open jndi tests

Hello Please review following simple changes to cleanup raw types warning for open jndi tests (under test/jdk/com/sun/jndi and test/jdk/javax/naming), thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8214694 Webrev: http://cr.openjdk.java.net/~xyin/8214694/webrev.00/ The changes should be

Re: [15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

Thank you, Daniel Regards, Chris > On 19 Mar 2020, at 7:54 PM, Daniel Fuchs wrote: > > Hi Chris, > > On 19/03/2020 07:23, Chris Yin wrote: >> [...] Per javadoc from EventContext and EventDirContext interface which >> implemented by LdapCtx that will call EventSuppo

Re: [15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

webrev as below, thanks http://cr.openjdk.java.net/~xyin/8241130/webrev.01/ Regards, Chris > > best regards, > > -- daniel > > On 18/03/2020 08:16, Chris Yin wrote: >> Hello >> Please review following changes to fix corner issue in >> com.sun.jndi.ldap

Re: [15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

Thank you, Daniel, Vyom Pushed. Regards, Chris > On 18 Mar 2020, at 6:03 PM, Daniel Fuchs wrote: > > Hi Chris, > > Thanks for that! > > It looks good to me. > > best regards, > > -- daniel > > On 16/03/2020 07:26, Chris Yin wrote: >> Thanks fo

[15] RFR: 8241130: com.sun.jndi.ldap.EventSupport.removeDeadNotifier: java.lang.NullPointerException

Hello Please review following changes to fix corner issue in com.sun.jndi.ldap.EventSupport, thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8241130 Webrev: http://cr.openjdk.java.net/~xyin/8241130/webrev.00/ This is a follow up item which related to 8202117. When testing the second

Re: [15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

oopback() >.port(server.getLocalPort()) >.path("/o=example") >.build(); > ... > > 59 env.put(Context.PROVIDER_URL, providerURI.toString()); > > best regards, > > -- daniel > > > On 13/03

[15] RFR: 8202117: com/sun/jndi/ldap/RemoveNamingListenerTest.java fails intermittently: Connection reset

Hello, Please review following changes to try to fix intermittent failure of test com/sun/jndi/ldap/RemoveNamingListenerTest.java, thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8202117 Webrev: http://cr.openjdk.java.net/~xyin/8202117/webrev.00/ According to failure logs, test already

Re: RFR(s): 8228580: DnsClient TCP socket timeout

.stopServer()`) because the exception was thrown before it > had reached `runTest()`. I think we must address this, otherwise our > jtreg.SkippedException is only half measure. > > I thought about how to do that. I'm thinking of going the full way up to > TestBase as I believe

Re: RFR [14] 8217606: LdapContext#reconnect always opens a new connection

> On 9 Aug 2019, at 1:59 AM, Roger Riggs wrote: > > ... > Is handling Unbind in the switch needed (as different from the default). Sorry, I forgot this, it’s a placeholder to handle UNBIND_REQUEST further, per ldap protocol, server will close the connection when received unbind request

Re: RFR [14] 8217606: LdapContext#reconnect always opens a new connection

Many thanks Pavel for the changes, and thanks Lance, Roger for the reviewing. Yep, let me try to handle some questions from Roger > On 7 Aug 2019, at 11:52 PM, Roger Riggs wrote: > > BaseLdapServer: > > 158: Is printing the stack trace diagnostic or an error?, the exception is > not rethrown

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

Thank you, Roger Chris > On 19 Oct 2018, at 2:54 AM, Roger Riggs wrote: > > +1, > > On 09/20/2018 04:55 AM, vyom tewari wrote: >> Hi Chris, >> >> tests looks good to me. >> >> Thanks, >> >> >> >> On Tuesday 04 Se

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

l suggest you to >> expand "setContext" as you did for other JNDI tests. >> >> Thanks, >> >> Vyom >> >> >> On Friday 10 August 2018 02:34 PM, Chris Yin wrote: >>> Sorry... another minor revision to handle @Override l

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Thank you, Roger Chris > On 19 Oct 2018, at 2:51 AM, Roger Riggs wrote: > > Hi Chris, > > Sorry, for the delay. I'd lost track of this review. > > Looks fine. > > Roger > > > On 08/20/2018 05:28 AM, Chris Yin wrote: >> Hi, Roger >> >&g

Re: [12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

the same port is being reused, then printing out > the client’s bound port would do that ( since the servers port is > already printed in the logs ). > > If such a change was integrated, then the next observed failure > would confirm or disconfirm your suspicion. > > -Chris

[12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

Loop net-dev since the test is under java/net, thanks > On 20 Sep 2018, at 5:30 PM, Chris Yin wrote: > > Please review below minor change for 8199931, thanks > > A little explanation about the change here, since the failure samples are too > less (seems too hard to repro),

[12] RFR 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

Please review below minor change for 8199931, thanks A little explanation about the change here, since the failure samples are too less (seems too hard to repro), so below scenario which caused the failure is a guess. MultcastSocket constructor set reuse address true by default, when call “new

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

Thank you, Vyom Regards, Chris > On 20 Sep 2018, at 4:55 PM, vyom tewari wrote: > > Hi Chris, > > tests looks good to me. > > Thanks, > > > > On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote: >> Please review the changes to add 10

Re: [12] RFR 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection

+ ") It's ok to get NamingException: " + ne); > 92 // for debug > System.err.println("Caught expected exception: " + > ne); > 93 ne.printStackTrace(); > > If you decide to go this way instead then no need for

Re: [12] RFR 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection

xpected and not considered as error as you commented. Anyway, we could adjust it later if necessary. Regards, Chris > > best regards, > > -- daniel > > > On 13/09/2018 07:59, Chris Yin wrote: >> Please have a review for below new added test to cover JDK-8205330

[12] RFR 8210695: Create test to cover JDK-8205330 InitialDirContext ctor sometimes throws NPE if the server has sent a disconnection

Please have a review for below new added test to cover JDK-8205330, thanks This test used dummy ldap server to simulate the scenario to send “Notice of Disconnection” after binding, it will repeat InitialDirContext() for 1000 times (normally the NPE bug should be hit less than 100 times run,

Re: [12] RFR 8209773: Refactor shell test javax/naming/module/basic.sh to java

Thank you, Alan Regards, Chris > On 10 Sep 2018, at 5:42 PM, Alan Bateman wrote: > > > > On 10/09/2018 10:13, Chris Yin wrote: >> Thank you, Alan >> >> Sure, I modified a little to remove “.” and use Path.of as you suggested to >> improve file ha

Re: [12] RFR 8209773: Refactor shell test javax/naming/module/basic.sh to java

Thank you, Alan Sure, I modified a little to remove “.” and use Path.of as you suggested to improve file handling, minor revision as below, thanks http://cr.openjdk.java.net/~xyin/8209773/webrev.01/ Regards, Chris > On 10 Sep 2018, at 3:20 PM, Alan Bateman wrote: > > On 30/08/2018 10:06,

Re: [12] RFR 8042902: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails intermittently

Thank you, Chris H. :) Regards, Chris Y. > On 6 Sep 2018, at 4:05 PM, Chris Hegarty wrote: > > >> On 6 Sep 2018, at 09:00, Chris Yin wrote: >> >> Please have a review for below minor change to test >> java/net/Inet6Address/serialize/Inet6Addr

[12] RFR 8042902: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails intermittently

Please have a review for below minor change to test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java, thanks The bug has a long history, so a quick summary and explanation here, the issue which caused test failure before 2016 should already been fixed, so this fix change is

[12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

Please review the changes to add 10 JNDI tests to com/sun/jndi/dns/FedTests/ in OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8210339 webrev: http://cr.openjdk.java.net/~xyin/8210339/webrev.00/ Regards, Chris

Re: [12] RFR 8209773: Refactor shell test javax/naming/module/basic.sh to java

Thank you, Vyom Regards, Chris > On 30 Aug 2018, at 5:06 PM, vyom tewari wrote: > > Hi Chris, > > The refactored java class (RunBasic.java) looks good to me. > > Thanks, > > Vyom > > > On Tuesday 28 August 2018 11:20 AM, Chris Yin wrote: >

[12] RFR 8209773: Refactor shell test javax/naming/module/basic.sh to java

Please have a review for below change to refactor shell test javax/naming/module/basic.sh to plain java, no test logic change, old shell script is removed at same time, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8209773 webrev: http://cr.openjdk.java.net/~xyin/8209773/webrev.00/

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

m > > > On Friday 10 August 2018 02:34 PM, Chris Yin wrote: >> Sorry... another minor revision to handle @Override line and imports place, >> new webrev as below, thanks >> >> http://cr.openjdk.java.net/~xyin/8208542/webrev.02/ >> >> Regards,

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

gards, Chris > > Regards, Roger > > > On 8/10/18 5:15 AM, Chris Yin wrote: >> Minor revision to address testbase javadoc, initContext() expansion, >> @Override line and imports place, new webrev as below, thanks >> >> http://cr.openjdk.java.net/~xy

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Minor revision to address testbase javadoc, initContext() expansion, @Override line and imports place, new webrev as below, thanks http://cr.openjdk.java.net/~xyin/8200151/webrev.02/ Regards, Chris > On 30 Jul 2018, at 5:08 PM, Chris Yin wrote: > > Thank you, Vyom > > R

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

Sorry... another minor revision to handle @Override line and imports place, new webrev as below, thanks http://cr.openjdk.java.net/~xyin/8208542/webrev.02/ Regards, Chris > On 8 Aug 2018, at 2:51 PM, Chris Yin wrote: > > Minor revision to address javadoc, initContext() expansion, v

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

Thank you, Roger > On 9 Aug 2018, at 10:01 PM, Roger Riggs wrote: > > Hi Chris, > > looks fine now. +1 > > On 8/8/18 11:35 PM, Chris Yin wrote: >> Hi, Roger >> >> Many thanks for your review and comments, inline and updated new webrev as >> be

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

> The imports should be before the comment with the jtreg test description. Fixed, thanks Regards, Chris > > Thanks, Roger > > On 8/7/18 11:41 PM, Chris Yin wrote: >> Just one more minor revision to expand initContext() into test method for >> easier read, n

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

Thank you, Vyom Regards, Chris > On 8 Aug 2018, at 3:12 PM, vyom tewari wrote: > > Hi Chris, > > Latest code webrev(.03) looks good to me, expending initContext() makes tests > more readable :) . > > Thanks, > > Vyom > > > On Wednesday 08 August

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

Minor revision to address javadoc, initContext() expansion, vararg etc. webrev as below, thanks http://cr.openjdk.java.net/~xyin/8208542/webrev.01/ Regards, Chris > On 31 Jul 2018, at 2:39 PM, Chris Yin wrote: > > Please review the changes to add 4 JNDI tests to com/sun/jndi/dns/

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

Just one more minor revision to expand initContext() into test method for easier read, new webrev as below, thanks http://cr.openjdk.java.net/~xyin/8208483/webrev.04/ Regards, Chris > On 7 Aug 2018, at 5:41 PM, Chris Yin wrote: > > Hi, Vyom > > Thanks a lot for your co

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

thods inline in the test method so the setup and the testing of the > conditions were in the same method, making it easier to read. > > Thanks, Roger > > > On 8/6/2018 11:53 PM, Chris Yin wrote: >> Hi, Roger >> >> Thanks a lot for your review and comments

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

t; in > "LookupFactoryBase" ? as both LookupWithAnyAttrProp & LookupWithAttrProp > inherit "LookupFactoryBase". > > .Thanks, > > Vyom > > > On Monday 06 August 2018 03:02 PM, Chris Yin wrote: >> Hi, Vyom >> >> Many thanks for

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

6 August 2018 03:02 PM, Chris Yin wrote: >> Hi, Vyom >> >> Many thanks for your review and comments, inline and updated webrev as >> below, thanks >> >> http://cr.openjdk.java.net/~xyin/8208483/webrev.01/ >> >>> On 6 Aug 2018, at 4:12 PM

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

t's not the current name). Sure, removed that name > > RemoveInherited.java: for strings that need to be consistent across the test, > they should be defined as > final statics so there is only one declaration. Fixed as your suggested Thanks & Regards, Chris > >

Re: [12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

pecific > exception or list of specific exceptions if possible. Fixed, those generic exception are generated automatically through override method, I removed those unused throws Exception from xxxFactory. Thanks & Regards, Chris > > Thanks, > > Vyom > > > On

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

Thank you, Vyom Regards, Chris > On 6 Aug 2018, at 2:02 PM, vyom tewari wrote: > > Hi Chris, > > Latest webrev looks good to me. > > Thanks, > > Vyom > > > On Friday 03 August 2018 02:46 PM, Chris Yin wrote: >> Hi, Vyom >> >> Thank

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

it is not worth enough. Sure, added one line comment before each “removeFromEnvironment” call as you suggested Thanks, Chris > > Thanks, > > Vyom > > > On Monday 30 July 2018 08:41 AM, Chris Yin wrote: >> Please find the new webrev as below, it addressed some similar

[12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

Please review the changes to add 4 JNDI tests to com/sun/jndi/dns/ListTests/ in OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208542 webrev: http://cr.openjdk.java.net/~xyin/8208542/webrev.00/ Regards, Chris

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Thank you, Vyom Regards, Chris > On 30 Jul 2018, at 5:06 PM, vyom tewari wrote: > > Hi Chris, > > Latest code looks good to me. > > Thanks, > > Vyom > > On Friday 27 July 2018 01:12 PM, Chris Yin wrote: >> Hi, Vyom >> >> Thank a lot

[12] RFR 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/

Please review the changes to add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ in OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208483 webrev: http://cr.openjdk.java.net/~xyin/8208483/webrev.00/

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

Jul 2018, at 3:37 PM, Chris Yin wrote: > > Please review the changes to add another 8 JNDI tests to > com/sun/jndi/dns/EnvTests/ in OpenJDK, thanks > > bug: https://bugs.openjdk.java.net/browse/JDK-8208279 > <https://bugs.openjdk.java.net/browse/JDK-8208279> > webr

Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Thank you, Mandy Regards, Chris > On 28 Jul 2018, at 12:02 AM, mandy chung wrote: > > Looks fine. This test uses JarUtils instead of jar tool and so > it does not depend on jdk.jar. > > Mandy > > On 7/27/18 1:42 AM, Chris Yin wrote: >> Please review below mino

Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Thank you, Lance Regards, Chris > On 27 Jul 2018, at 11:57 PM, Lance Andersen wrote: > > Hi Chris, > > This the change is fine >> On Jul 27, 2018, at 4:42 AM, Chris Yin > <mailto:xu.y@oracle.com>> wrote: >> >> Please review below mi

[12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Please review below minor change to add missing module dependencies declaration, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208363 Changes: diff -r 65fc31d1042b test/jdk/java/lang/Package/PackageFromManifest.java ---

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

est with testbase (actually, its not necessary too, but guess the consistent style and shared base/methods will make the test easy to read and maintain, refactored this test and PortUnreachable.java now) Regards, Chris > > Thanks, > Vyom > > On Wednesday 25 July 2

[12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

Please review the changes to add another 8 JNDI tests to com/sun/jndi/dns/EnvTests/ in OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208279 webrev: http://cr.openjdk.java.net/~xyin/8208279/webrev.00/

[12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Please review the changes to add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ in OpenJDK, due to known issue 7164518, PortUnreachable.java will be problem list for 'macosx-all', thanks bug: https://bugs.openjdk.java.net/browse/JDK-8200151

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

> makes it more natural to read. > > The closing ")" in method calls looks odd to be on a line by itself. > For example, GetAttrBase.java: line 35 > > Please fix these but no further review is needed. > > Thanks, Roger > > > > > On 7/24/18 2:12 AM

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

javadoc to those DNSTestUtils, base sequence in TestBase class description, hope that will be helpful Thanks & Regards, Chris > > Regards, Roger > > > On 7/13/18 2:14 AM, Chris Yin wrote: >> Hi, Vyom >> >> Thank you for the review and comments, update webr

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

Thank you, Vyom Regards, Chris > On 13 Jul 2018, at 5:15 PM, vyom tewari wrote: > > Hi Chris, > > latest webrev looks good to me, thanks for explanation about copyright date. > > Thanks, > > Vyom > > On Friday 13 July 2018 11:44 AM, Chris Yin wr

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

t year + migration copyright year if the 2 year are not same, for dump files (like *.dns) are new added under our new framework so just use current copyright year, hope that explains :), thanks Regards, Chris > > Thanks, > Vyom > > On Thursday 12 July 2018 02:08 PM, Chris Yin w

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

Chris > On 22 Mar 2018, at 11:16 AM, Chris Yin wrote: > > Please review the changes to add 10 JNDI tests to > com/sun/jndi/dns/AttributeTests/, thanks > > bug: https://bugs.openjdk.java.net/browse/JDK-8198882 > <https://bugs.openjdk.java.net/browse/JDK-8198882> >

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Thank you, Daniel Regards, Chris > On 3 Jul 2018, at 4:46 PM, Daniel Fuchs wrote: > > Hi Chris, > > Looks good to me as well. > > best regards, > > -- daniel > > On 29/06/2018 07:48, Chris Yin wrote: >> Thank you, Vyom >> Regards, >>

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Thank you, Vyom Regards, Chris > On 29 Jun 2018, at 11:13 AM, vyom tewari wrote: > > looks good to me. > > Vyom > > On Friday 29 June 2018 06:22 AM, Chris Yin wrote: >> Hi, Vyom >> >> Sure, fixed the tag order as you suggested, thanks >> >>

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

ming.dns/com.sun.jndi.dns > * @requires os.family != "windows" > * @build IPv6NameserverPlatformParsingTest > * @run main/manual Test6991580 > */ > > Thanks, > > Vyom > On Thursday 28 June 2018 07:31 AM, Chris Yin wrote: >> Please review below one line

[JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Please review below one line change for manual test case com/sun/jndi/dns/Test6991580.java to build test class automatically which will be used in manual steps, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8187069 Review change as

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

Thank you, Mandy Regards, Chris > On 12 Jun 2018, at 1:48 AM, mandy chung wrote: > > > > On 6/10/18 10:12 PM, Chris Yin wrote: >> Hi, Mandy >> Thanks lot for your suggestions, update webrev as below and comment inline, >> thanks >> http://cr.o

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

Hi, Mandy Thanks lot for your suggestions, update webrev as below and comment inline, thanks http://cr.openjdk.java.net/~xyin/8201528/webrev.02/ <http://cr.openjdk.java.net/~xyin/8201528/webrev.02/> > On 9 Jun 2018, at 4:22 AM, mandy chung wrote: > > > > On 6/8/1

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

: > > Hi Chris, > > On 6/7/18 1:32 AM, Chris Yin wrote: >> Please review below new added test to check for package versioning >> information which customized in jar(s) manifest, many thanks >> bug: https://bugs.openjdk.java.net/browse/JDK-8201528 webrev: >> http:

[JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

Please review below new added test to check for package versioning information which customized in jar(s) manifest, many thanks bug: https://bugs.openjdk.java.net/browse/JDK-8201528 webrev: http://cr.openjdk.java.net/~xyin/8201528/webrev.00/

Re: RFR 8197418: Move java/util/RandomAccess/ tests into OpenJDK

Thank you, Paul Regards, Chris > On 12 Apr 2018, at 2:10 AM, Paul Sandoz <paul.san...@oracle.com> wrote: > > Hi Chris, > > +1, and thanks for sharing code coverage results. > > Paul. > > >> On Apr 10, 2018, at 11:33 PM, Chris Yin <xu.y@oracle.c

RFR 8197418: Move java/util/RandomAccess/ tests into OpenJDK

Please review the change to move java/util/RandomAccess/Basic.java test into OpenJDK, it increases code coverage of open jdk_util test group per JCov run, the main improvement is on java.util.Collections with %method up 1% and %block up 2%, thanks bug:

Re: RFR 8196668: revisit test SunPackageAccess and GrantedSunPackageAccess

Thank you, Mandy. I just fixed it follow your comments and get it pushed. Regards, Chris > On 29 Mar 2018, at 12:48 PM, mandy chung <mandy.ch...@oracle.com > <mailto:mandy.ch...@oracle.com>> wrote: > > > > On 3/29/18 9:59 AM, Chris Yin wrote: >> Please

RFR 8196668: revisit test SunPackageAccess and GrantedSunPackageAccess

Please review the change to merge 2 package access tests and move to OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8196668 webrev: http://cr.openjdk.java.net/~xyin/8196668/webrev.00/

RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

Please review the changes to add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8198882 webrev: http://cr.openjdk.java.net/~xyin/8198882/webrev.00/

Re: RFR 8198931: remove java.xml.bind module dependency for com/sun/jndi tests

gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 <tel:+1.781.442.2037> > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > > Sent from my iPhone >

RFR 8198931: remove java.xml.bind module dependency for com/sun/jndi tests

Please review the minor changes to remove java.xml.bind module dependency for com/sun/jndi tests, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8198931 webrev: http://cr.openjdk.java.net/~xiaofeya/8198931/webrev.00/

Re: [JDK 11] RFR 8198821: fix test methods access for test java/text/Normalizer/NormalizerAPITest.java

Thank you, Naoto Regards, Chris > On 2 Mar 2018, at 2:26 AM, Naoto Sato <naoto.s...@oracle.com> wrote: > > +1 > > Naoto > > On 2/28/18 6:03 PM, Chris Yin wrote: >> Please review the minor change for test >> java/text/Normalizer/NormalizerAPITest.java,

[JDK 11] RFR 8198821: fix test methods access for test java/text/Normalizer/NormalizerAPITest.java

Please review the minor change for test java/text/Normalizer/NormalizerAPITest.java, thanks Added public access modifier to all “Test_" methods so they can be recognized as test method correctly by util class bug: https://bugs.openjdk.java.net/browse/JDK-8198821

Re: [JDK 11] RFR 8196759: Move two java/text/Normalizer tests into OpenJDK

Thank you, Naoto Regards, Chris > On 28 Feb 2018, at 2:39 AM, Naoto Sato <naoto.s...@oracle.com> wrote: > > Looks good. > > Naoto > > On 2/26/18 10:51 PM, Chris Yin wrote: >> Please review the changes to move two java/text/Normalizer tests to OpenJDK >&g

[JDK 11] RFR 8196759: Move two java/text/Normalizer tests into OpenJDK

Please review the changes to move two java/text/Normalizer tests to OpenJDK jdk_text group, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8196759 webrev: http://cr.openjdk.java.net/~xiaofeya/8196759/webrev.00/

Re: RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Thank you, Roger Regards, Chris > On 13 Feb 2018, at 6:37 AM, Roger Riggs <roger.ri...@oracle.com> wrote: > > Hi Chris, > > I don't know DNS details well enough to validate the test assertions. > Otherwise, the code is fine. > > Regards, Roger > > &g

Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

tive tests planned? > > Thanks, Roger > > On 1/23/2018 5:14 AM, Chris Yin wrote: >> Thank you Alan, I just moved it to com/sun/jndi/dns/ as you suggested and >> removed unused "@modules jdk.naming.dns/com.sun.jndi.dns”, updated webrev as >> below, thanks >&g

RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Please review the added JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java, thanks It’s to verify capability to add a new entry to the directory using the ADD operation. This test will use LDAPServer to playback dump ldap message to simulate test environment. bug:

Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

A reminder that this need a reviewer's approval, many thanks Regards, Chris > On 23 Jan 2018, at 6:14 PM, Chris Yin <xu.y@oracle.com> wrote: > > Thank you Alan, I just moved it to com/sun/jndi/dns/ as you suggested and > removed unused "@modules jdk.naming.dns/com

Re: RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

ards, Chris > On 23 Jan 2018, at 3:53 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 23/01/2018 07:01, Chris Yin wrote: >> Please review the added JNDI test >> javax/naming/dns/AttributeTests/GetAny.java, thanks >> >> &g

RFR: 8195976: Add JNDI test javax/naming/dns/AttributeTests/GetAny.java

Please review the added JNDI test javax/naming/dns/AttributeTests/GetAny.java, thanks It’s to cover the case that we can get the attributes of a DNS entry using special qualifiers. This test will use DNSServer to playback dump dns message (which created by DNSTracer when run test against real