On Wed, 8 Jun 2022 12:09:27 GMT, Severin Gehwolf wrote:
>> Please review this cleanup change in the cgroup subsystem which used to use
>> hard-coded stack allocated
>> buffers for concatenating strings in memory. We can use `stringStream`
>> instead which doesn't have the issue
>> of
On Tue, 7 Jun 2022 12:42:26 GMT, Severin Gehwolf wrote:
>> Please review this cleanup change in the cgroup subsystem which used to use
>> hard-coded stack allocated
>> buffers for concatenating strings in memory. We can use `stringStream`
>> instead which doesn't have the issue
>> of
On Mon, 6 Jun 2022 23:07:06 GMT, Ioi Lam wrote:
> We should try to consolidate these test cases to improve maintainability.
I filed [JDK-8287185](https://bugs.openjdk.org/browse/JDK-8287185)
-
PR: https://git.openjdk.java.net/jdk/pull/8993
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf wrote:
> This adds a regression test for a recent fix (JDK-8287073). I've restructured
> the linux specific JDK code to call a separate static function to enable this
> test. It'll help future tests too.
>
> Testing:
> - [x] Container tests
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf wrote:
> This adds a regression test for a recent fix (JDK-8287073). I've restructured
> the linux specific JDK code to call a separate static function to enable this
> test. It'll help future tests too.
>
> Testing:
> - [x] Container tests
On Thu, 26 May 2022 16:04:17 GMT, Maxim Kartashev
wrote:
>> Following the logic from the comment directly above the changed line, since
>> it doesn't matter which controller we pick, pick any available controller
>> instead of the one called "memory" specifically. This way we are guarded
>>
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
Please rename the RFE title to be less generic. How about "Speed up
On Thu, 26 May 2022 16:04:17 GMT, Maxim Kartashev
wrote:
>> Following the logic from the comment directly above the changed line, since
>> it doesn't matter which controller we pick, pick any available controller
>> instead of the one called "memory" specifically. This way we are guarded
>>
On Thu, 26 May 2022 09:42:22 GMT, Maxim Kartashev
wrote:
>> Following the logic from the comment directly above the changed line, since
>> it doesn't matter which controller we pick, pick any available controller
>> instead of the one called "memory" specifically. This way we are guarded
>>
On Mon, 23 May 2022 22:11:47 GMT, Ioi Lam wrote:
> This PR fixes a bug found on an Ubuntu host that's mostly running with
> cgroupv2, but there's a controller (freezer) that is mounted in cgroupv1 mode.
>
> The container support code in the VM and JDK checks if we have si
On Tue, 24 May 2022 19:36:57 GMT, Severin Gehwolf wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @jerboaa comments
>
> Looks good. Thanks for the thorough analysis.
Thanks @jerboa
he fix is simple -- when we get to `setCgroupV2Path()`, we have already
> decided that the system has not mounted any v1 controllers that we care
> about, so we should just ignore all the v1 controllers (which has a non-empty
> name).
Ioi Lam has updated the pull request increment
On Wed, 25 May 2022 15:50:32 GMT, Severin Gehwolf wrote:
>> It confused me, fwiw. Anyway up to you. It's not super important.
>
> works for me. +1. Note the typo
> `anyCgroupsV1Controller/anyCgroupsV2Controller` not **V1** twice.
Oops, I'll fixed that. Thanks!
-
PR:
he fix is simple -- when we get to `setCgroupV2Path()`, we have already
> decided that the system has not mounted any v1 controllers that we care
> about, so we should just ignore all the v1 controllers (which has a non-empty
> name).
Ioi Lam has updated the pull request i
On Tue, 24 May 2022 19:49:35 GMT, Ioi Lam wrote:
>> My bad. How about `Intentional incomplete switch. There are ...`? Anyway,
>> why is the empty `default` case needed other than for the comment?
>
> To me, the `default:` switch is a clear indication that "everything else
On Tue, 24 May 2022 19:34:16 GMT, Severin Gehwolf wrote:
>> This is not a fall-through because the previous line ends with a `break`.
>
> My bad. How about `Intentional incomplete switch. There are ...`? Anyway, why
> is the empty `default` case needed other than for the comment?
To me, the
On Tue, 24 May 2022 10:12:31 GMT, Severin Gehwolf wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @jerboaa comments
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupSub
he fix is simple -- when we get to `setCgroupV2Path()`, we have already
> decided that the system has not mounted any v1 controllers that we care
> about, so we should just ignore all the v1 controllers (which has a non-empty
> name).
Ioi Lam has updated the pull request incr
This PR fixes a bug found on an Ubuntu host that's mostly running with
cgroupv2, but there's a controller (freezer) that is mounted in cgroupv1 mode.
The container support code in the VM and JDK checks if we have simultaneously
mounted v1 and v2 containers. If so, we revert to "hybrid" mode
On Thu, 19 May 2022 19:59:18 GMT, Ioi Lam wrote:
>>> What happens if cgroup_path is "/foo/bar" and _root is "/fo"?
>>
>> With a mount path of `/bar` this ends up being `/bar/o/bar`. Pretty strange,
>> but then again it's a bit of a contrived examp
On Thu, 19 May 2022 09:06:18 GMT, Severin Gehwolf wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 63:
>>
>>> 61: } else {
>>> 62: char *p = strstr(cgroup_path, _root);
>>> 63: if (p != NULL && p == cgroup_path) {
>>
>> What happens if cgroup_path is
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>>
On Thu, 12 May 2022 18:09:40 GMT, Severin Gehwolf wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>>
On Thu, 12 May 2022 18:09:40 GMT, Severin Gehwolf wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>>
On Sat, 14 May 2022 00:30:00 GMT, Tim Prinzing wrote:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader.
On Thu, 12 May 2022 13:46:11 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam wrote:
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
This pull request has now been integrated.
Changeset: 74eee2
On Thu, 12 May 2022 04:06:44 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments - remove thros IllegalArgumentException clause
>
> Nice cleanup! I chec
On Thu, 12 May 2022 14:08:11 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments - remove thros IllegalArgumentException clause
>
> src/java.base/s
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
@Al
On Tue, 10 May 2022 12:29:10 GMT, Severin Gehwolf wrote:
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
>
The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
used. It should be removed, and all the handling of a specified user name
should be removed.
-
Commit messages:
- more cleanup
- 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()
On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam wrote:
> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
> supported the value `"rw"` since the source code was imported to the openjdk
> repo more than 15 years ago. In fact HotSpot throws
> `IllegalA
On Tue, 10 May 2022 20:03:45 GMT, Alan Bateman wrote:
>> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
>> supported the value `"rw"` since the source code was imported to the openjdk
>> repo more than 15 years ago. In fact HotSpot throws
>> `IllegalArgumentException`
On Tue, 10 May 2022 20:03:45 GMT, Alan Bateman wrote:
> I skimmed through the changes and I think they look okay. In the distant past
> there were tools outside of the JDK that used the jvmstat API directly. It's
> possible that VisualVM still does but it would only compile/run if
>
On Tue, 10 May 2022 19:59:41 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/pro
t; It's unlikely such a mode will be required for future enhancements. Support
> for `"rw"` is removed. The "mode" parameter is also removed, since now `"r"`
> is the only supported mode.
>
> I also cleaned up related code in the JDK and HotSpot.
>
&
On Tue, 10 May 2022 21:43:44 GMT, Claes Redestad wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/hotspot/os/windows/perfMemory_windows.cpp line 1781:
>
&
The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported
the value `"rw"` since the source code was imported to the openjdk repo more
than 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such
a mode is specified.
It's unlikely such a mode will be
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that adds dedicated filler objects to
>> the VM?
>>
>> Currently, when formatting areas of dead objects all gcs use instances of
>> j.l.Object and int-arrays.
>>
>> This has the
On Mon, 18 Apr 2022 09:07:31 GMT, xpbob wrote:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory &
On Mon, 18 Apr 2022 09:07:31 GMT, xpbob wrote:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory &
On Mon, 18 Apr 2022 16:22:27 GMT, Ioi Lam wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
On Mon, 18 Apr 2022 09:07:31 GMT, xpbob wrote:
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory &
On Thu, 7 Apr 2022 22:44:19 GMT, Ioi Lam wrote:
> During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
> usually null. However, if a signed class is loaded, `resourceCache` will
> point to a `java.lang.ref.SoftReference`. Although rare (we have never seen
> thi
On Fri, 8 Apr 2022 07:08:29 GMT, Alan Bateman wrote:
>> During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
>> usually null. However, if a signed class is loaded, `resourceCache` will
>> point to a `java.lang.ref.SoftReference`. Although rare (we have never seen
>> this
On Fri, 8 Apr 2022 08:13:33 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that adds dedicated filler objects to
> the VM?
>
> Currently, when formatting areas of dead objects all gcs use instances of
> j.l.Object and int-arrays.
>
> This has the drawback of
During `java -Xshare:dump`, `ClassLoaders.bootLoader().resourceCache` is
usually null. However, if a signed class is loaded, `resourceCache` will point
to a `java.lang.ref.SoftReference`. Although rare (we have never seen this
during our testing), it's possible for `resourceCache.discovered` to
On Tue, 8 Mar 2022 19:11:02 GMT, Ioi Lam wrote:
> This patch makes the result of "java -Xshare:dump" deterministic:
> - Disabled new Java threads from launching. This is harmless. See comments in
> jvm.cpp
> - Fixed a problem in hashtable ordering in heapShared.cpp
>
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request incrementally with one additional commit
since th
On Mon, 14 Mar 2022 22:07:24 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added helper function CollectedHeap::zap_filler_array_with
>
> test/hotspot/jt
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request with a new target base due to a merge or a
rebase.
On Fri, 11 Mar 2022 07:13:35 GMT, Thomas Stuefe wrote:
> Is reproducibility also a topic for users calling -Xdump with custom JNI
> coding? Or maybe having the VM instrumented somehow? Since it seems such an
> easy fix, I would prevent attaching too. At least the user would get a clear
>
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request incrementally with one additional commit
si
On Fri, 11 Mar 2022 05:59:00 GMT, David Holmes wrote:
> > I ended up changing `os::malloc()` to zero the buffer when running with
> > -Xshare:dump. Hopefully one extra check of `if (DumpSharedSpaces)` doesn't
> > matter too much for regular VM executions because `os::malloc()` already
> > has
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request incrementally with one additional commit
since the l
On Fri, 11 Mar 2022 05:55:20 GMT, Kim Barrett wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> zero GC heap filler arrays
>
> src/hotspot/share/gc/shared/collectedHeap.cpp line 449:
>
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request incrementally with one additional c
On Wed, 9 Mar 2022 07:47:19 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/utilities/hashtable.hpp line 42:
>
>> 40
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request incrementally with one additional commit
sinc
On Thu, 10 Mar 2022 13:51:56 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> I think he already did. I'm quoting:
>
>> However, th
On Wed, 9 Mar 2022 07:51:46 GMT, Thomas Stuefe wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/prims/jvm.cpp line 2887:
>
>> 2885:
On Thu, 10 Mar 2022 13:51:56 GMT, Magnus Ihse Bursie wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> I think he already did. I'm quoting:
>
>> However, th
On Wed, 9 Mar 2022 07:04:56 GMT, David Holmes wrote:
> I have reservations about contorting things this way just to get
> "deterministic output".
>
> The VM needs to fully initialize and then become quiescent before the dump
> occurs, and as I say below if you don't start other threads then
On Wed, 9 Mar 2022 06:49:02 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed zero build
>
> src/hotspot/share/prims/jvm.cpp line 2873:
>
>> 2871: // e
tps://bugs.openjdk.java.net/browse/JDK-8282828).
>
> Testing under way:
> - tier1~tier5
> - Run all *-cmp-baseline jobs 20 times each (linux-aarch64-cmp-baseline,
> windows-x86-cmp-baseline, etc).
Ioi Lam has updated the pull request incrementally with one additional commit
since t
This patch makes the result of "java -Xshare:dump" deterministic:
- Disabled new Java threads from launching. This is harmless. See comments in
jvm.cpp
- Fixed a problem in hashtable ordering in heapShared.cpp
- BasicHashtableEntry has a gap on 64-bit platforms that may contain random
bits.
On Wed, 1 Dec 2021 20:47:20 GMT, Ioi Lam wrote:
> **Background:**
>
> In the Java Language, Enums can be tested for equality, so the constants in
> an Enum type must be unique. Javac compiles an enum declaration like this:
>
>
> public enum
On Thu, 17 Feb 2022 23:20:41 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use InstanceKlass::do_local_static_fields for some field iterations
>
> Looks good. Minor
analyzed the potential problems found by the tool are they are all safe
> (after the current bug is fixed). See cdsHeapVerifier.cpp for gory details.
> An example trace of this tool can be found at
> https://bugs.openjdk.java.net/secure/attachment/97242/enum_warning.txt
>
> **Testing:**
analyzed the potential problems found by the tool are they are all safe
> (after the current bug is fixed). See cdsHeapVerifier.cpp for gory details.
> An example trace of this tool can be found at
> https://bugs.openjdk.java.net/secure/attachment/97242/enum_warning.txt
>
> **Testing:
analyzed the potential problems found by the tool are they are all safe
> (after the current bug is fixed). See cdsHeapVerifier.cpp for gory details.
> An example trace of this tool can be found at
> https://bugs.openjdk.java.net/secure/attachment/97242/enum_warning.txt
>
> **Testing:**
On Wed, 19 Jan 2022 05:50:50 GMT, Ioi Lam wrote:
>> I don't really know this code well enough to do a good code review. I had
>> some comments though.
>
>> I don't really know this code well enough to do a good code review. I had
>> some comments though.
>
On Mon, 17 Jan 2022 19:22:23 GMT, Coleen Phillimore wrote:
> I don't really know this code well enough to do a good code review. I had
> some comments though.
Hi Coleen, thanks for taking a look.
This PR has two major parts:
1. Check for inappropriate reference to static fields. This is
On Mon, 17 Jan 2022 18:36:35 GMT, Coleen Phillimore wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains four
analyzed the potential problems found by the tool are they are all safe
> (after the current bug is fixed). See cdsHeapVerifier.cpp for gory details.
> An example trace of this tool can be found at
> https://bugs.openjdk.java.net/secure/attachment/97242/enum_warning.txt
>
> **Testing:
Still looking for reviewers
Thanks
- Ioi
On 12/1/21 1:02 PM, Ioi Lam wrote:
**Background:**
In the Java Language, Enums can be tested for equality, so the constants in an
Enum type must be unique. Javac compiles an enum declaration like this:
public enum Day { SUNDAY, MONDAY
analyzed the potential problems found by the tool are they are all safe
> (after the current bug is fixed). See cdsHeapVerifier.cpp for gory details.
> An example trace of this tool can be found at
> https://bugs.openjdk.java.net/secure/attachment/97242/enum_warning.txt
>
> **Testing:**
On 11/7/21 9:44 PM, Jaikiran Pai wrote:
Hello Ioi,
On 02/11/21 12:13 am, Ioi Lam wrote:
Hi Jaikiran,
Thanks for writing the test case to explore the problems in this area.
Please see my comments below:
...
Generally speaking, CDS has two levels of archiving:
[1] archiving class metadata
**Background:**
In the Java Language, Enums can be tested for equality, so the constants in an
Enum type must be unique. Javac compiles an enum declaration like this:
public enum Day { SUNDAY, MONDAY ... }
to
public class Day extends java.lang.Enum {
public static final SUNDAY = new
Hi Jaikiran,
Thanks for writing the test case to explore the problems in this area.
Please see my comments below:
On 10/29/21 5:55 AM, Jaikiran Pai wrote:
Hello Ioi (and others),
On 22/10/21 1:39 pm, Jaikiran Pai wrote:
Hello Ioi,
On 22/10/21 12:29 pm, Ioi Lam wrote:
On 10/21/21 9:09 PM
On 10/21/21 9:09 PM, Jaikiran Pai wrote:
Hello Ioi,
This is my initial analysis of the problem.
>>> Can anyone think of similar problems that may happen elsewhere?
The static constructors of enum classes are executed at both CDS dump
time and run time. E.g.,
public enum
program with:
java -Xshare:off EnumEquality
succeeds and the ModuleDescriptor equality check passes.
In short, it looks like there is some general issue with CDS and
equality checks with enums and perhaps deserves a separate JBS issue?
I've asked Ioi Lam to comment on this, off-hand I'm not aware
On Fri, 3 Sep 2021 14:25:53 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is
On Wed, 15 Sep 2021 07:46:34 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Tue, 14 Sep 2021 16:36:24 GMT, Ioi Lam wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplify coding following Severins advice
>
> test/hotspot/jtreg/containers/docker/T
On Tue, 14 Sep 2021 14:27:36 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Sat, 28 Aug 2021 13:18:37 GMT, Claes Redestad wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dfuch comments
>
> Seems OK.
Thanks @cl4es @magicus @dfuch for the rev
On Fri, 27 Aug 2021 23:12:52 GMT, Ioi Lam wrote:
> When the classlist is generated using build.tools.classlist.HelloClasslist,
> its contents may be non-deterministic due to Java thread execution order.
>
> We should sort the generated classlist to make the JDK image's c
tier1, tier2, builds-tier5
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
@dfuch comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5288/files
- new: https://git.openjdk.java.net/jdk/pull/5288/files/dc170e
On Mon, 30 Aug 2021 12:51:43 GMT, Daniel Fuchs wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dfuch comments
>
> make/jdk/src/classes/build/tools/classlist/SortClasslist.java line 58
When the classlist is generated using build.tools.classlist.HelloClasslist, its
contents may be non-deterministic due to Java thread execution order.
We should sort the generated classlist to make the JDK image's contents more
deterministic.
Tested with Mach5 tier1, tier2, builds-tier5
On Wed, 25 Aug 2021 21:45:57 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is
On Tue, 24 Aug 2021 19:15:56 GMT, Roger Riggs wrote:
>> test/jdk/java/lang/ProcessBuilder/Basic.java line 2635:
>>
>>> 2633: List childArgs = null;
>>> 2634: Path sleepExe = TEST_NATIVEPATH.resolve("sleepmillis");
>>> 2635: if (sleepExe.toFile().canExecute()) {
>>
>>
On Tue, 24 Aug 2021 15:55:28 GMT, Roger Riggs wrote:
> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
> unexpected messages from a child Java VM
> as the cause of the test failure. Attempts to control the output of the
> child VM have failed, the VM is unrepentant
On Wed, 28 Jul 2021 05:35:59 GMT, Vladimir Kozlov wrote:
> Backout the following changes due to vector tests failures in tier 2 and
> later:
> [JDK-8266054](https://bugs.openjdk.java.net/browse/JDK-8266054) VectorAPI
> rotate operation optimization
>
> Changes also caused copyright header
On Thu, 8 Jul 2021 01:59:25 GMT, Mikhailo Seledtsov
wrote:
> Now that "JDK-8268212 Build linux-aarch64 natively" added support for default
> CDS archive, time to update test configuration for this platform. This is a
> very small one-line change.
Looks good, but this returns true also for
On Wed, 12 May 2021 05:51:14 GMT, Ioi Lam wrote:
> This bug was discovered during the development of
> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
> would trigger the in
On Thu, 13 May 2021 06:19:47 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleaned up ClassLoaders.setArchivedServicesCatalog
>
> Marked as reviewed by alanb (R
e 3 built-in loaders
> (boot/platform/app).
>
> Testing: tiers1-4 in progress. I also verified that the bug reported by Mandy
> is no longer reproducible after I applied this patch on her branch.
Ioi Lam has updated the pull request with a new target base due to a merge or a
1 - 100 of 250 matches
Mail list logo
