Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Hohensee, Paul
: core-libs-dev On Behalf > Of Hohensee, Paul > Sent: Montag, 23. März 2020 19:29 > To: Doerr, Martin ; core-libs- > d...@openjdk.java.net; jdk-updates-...@openjdk.java.net > Subject: RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: > java.se

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Langer, Christoph
> > By spec part you mean the "@throws SecurityException" sections? Do you > think those should not have been part of the 11u/13u change? Should these > be even rolled back? > > > The spec changes to NetPermission and the protected Socket constructor > should not be in the update releases. If a sec

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Doerr, Martin
est regards, Martin > -Original Message- > From: Alan Bateman > Sent: Dienstag, 24. März 2020 10:53 > To: Langer, Christoph ; Doerr, Martin > ; core-libs-dev@openjdk.java.net; jdk-updates- > d...@openjdk.java.net > Subject: Re: [11u] RFR(S): 8223326: Regression introduced

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Alan Bateman
On 24/03/2020 08:19, Langer, Christoph wrote: Ah, I see... JDK-8218573 is JDK11u/JDK13u specific. Looks like it was derived from JDK-8217997 in jdk/jdk but pushed as a different bug. jdk/jdk was the only place where I was looking for JDK-8218573, so I couldn't find it. I don't have time to dig

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Langer, Christoph
> >> One other thing on this. It looks like the spec changes that were part > >> of JDK-8218573 have been backported to jdk-updates/jdk11u-dev by > >> mistake. Is that part of the issue that you are trying to fix? > > I can't find/access JDK-8218573 and I also struggle to find a changelist > > tha

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Alan Bateman
On 24/03/2020 07:33, Alan Bateman wrote: The spec update for Java SE 13+ that was part of that change have found their way into the jdk11u-dev repo, Sorry, I mean Java SE 14. It seems the spec change was accidentally pushed to 13.0.1 too. -Alan

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-24 Thread Alan Bateman
On 24/03/2020 06:42, Langer, Christoph wrote: Hi Alan, On 23/03/2020 18:07, Doerr, Martin wrote: Hi, I'd like to backport JDK-8223326 from jdk/jdk. One other thing on this. It looks like the spec changes that were part of JDK-8218573 have been backported to jdk-updates/jdk11u-dev by mist

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Langer, Christoph
Hi Alan, > On 23/03/2020 18:07, Doerr, Martin wrote: > > Hi, > > > > I'd like to backport JDK-8223326 from jdk/jdk. > > > One other thing on this. It looks like the spec changes that were part > of JDK-8218573 have been backported to jdk-updates/jdk11u-dev by > mistake. Is that part of the issue t

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Langer, Christoph
Hi Alan, > -Original Message- > From: jdk-updates-dev On > Behalf Of Alan Bateman > Sent: Montag, 23. März 2020 20:19 > To: Doerr, Martin ; core-libs- > d...@openjdk.java.net; jdk-updates-...@openjdk.java.net > Subject: Re: [11u] RFR(S): 8223326: Regression i

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Langer, Christoph
updates-...@openjdk.java.net > Subject: RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: > java.security.AccessControlException: access denied > ("java.net.NetPermission" "setSocketImpl") > > The changeset references JDK-8223326, which is private. If

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Alan Bateman
On 23/03/2020 19:39, Chris Hegarty wrote: On 23 Mar 2020, at 19:18, Alan Bateman > wrote: ... Socket(SocketImpl) is only specified to do a permission check when the impl is non-null. The socket adaptor in JDK 12 and older releases doesn't have a dummy imp

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Alan Bateman
On 23/03/2020 18:07, Doerr, Martin wrote: Hi, I'd like to backport JDK-8223326 from jdk/jdk. One other thing on this. It looks like the spec changes that were part of JDK-8218573 have been backported to jdk-updates/jdk11u-dev by mistake. Is that part of the issue that you are trying to fix

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Chris Hegarty
> On 23 Mar 2020, at 19:18, Alan Bateman wrote: > >> ... >> > Socket(SocketImpl) is only specified to do a permission check when the impl > is non-null. The socket adaptor in JDK 12 and older releases doesn't have a > dummy impl so the change should not be needed. If there is a security > e

Re: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Alan Bateman
On 23/03/2020 18:07, Doerr, Martin wrote: Hi, I'd like to backport JDK-8223326 from jdk/jdk. 11u backport issue: https://bugs.openjdk.java.net/browse/JDK-8241460 Original change: https://hg.openjdk.java.net/jdk/jdk/rev/29624901d8bc 11u backport webrev: http://cr.openjdk.java.net/~mdoerr/82233

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Doerr, Martin
; core-libs- > d...@openjdk.java.net; jdk-updates-...@openjdk.java.net > Subject: RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: > java.security.AccessControlException: access denied > ("java.net.NetPermission" "setSocketImpl") > > The changeset ref

RE: [11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Hohensee, Paul
The changeset references JDK-8223326, which is private. If possible, ask Oracle to make it public so we can do a normal backport rather than file an 11u-specific issue. The backport itself looks fine. Thanks, Paul On 3/23/20, 11:08 AM, "jdk-updates-dev on behalf of Doerr, Martin" wrote:

[11u] RFR(S): 8223326: Regression introduced by CPU sync: java.security.AccessControlException: access denied ("java.net.NetPermission" "setSocketImpl")

2020-03-23 Thread Doerr, Martin
Hi, I'd like to backport JDK-8223326 from jdk/jdk. 11u backport issue: https://bugs.openjdk.java.net/browse/JDK-8241460 Original change: https://hg.openjdk.java.net/jdk/jdk/rev/29624901d8bc 11u backport webrev: http://cr.openjdk.java.net/~mdoerr/8223326_nio_socket_11u/webrev.00/ I had to integ