While having one last look at this Doug and I found some oops how the heck did
that happen miscommits with the mix64/mix32/nextGamma methods that contained
test code for measuring the impact of shifts:
For corrections see:
On Oct 1, 2013, at 6:03 PM, Joe Darcy joe.da...@oracle.com wrote:
On 10/1/2013 4:18 AM, Paul Sandoz wrote:
On Sep 20, 2013, at 5:30 PM, Martin Buchholz marti...@google.com wrote:
Looks good.
Random nitpicks:
I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
On Sep 20, 2013, at 5:30 PM, Martin Buchholz marti...@google.com wrote:
Looks good.
Random nitpicks:
I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
inventing a slightly different meaning for ULP.
I think using hex floating point literals is preferred:
-
On 10/1/2013 4:18 AM, Paul Sandoz wrote:
On Sep 20, 2013, at 5:30 PM, Martin Buchholz marti...@google.com wrote:
Looks good.
Random nitpicks:
I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
inventing a slightly different meaning for ULP.
I think using hex floating
Hi,
As I wrote to Paul.
Only OpenJDK Authors and above can create/edit/comment on bugs.
Might be nice to at least allow people to comment/vote/setup notification
on bugs.
- Kasper
On Sat, Sep 21, 2013 at 1:14 AM, Doug Lea d...@cs.oswego.edu wrote:
On 09/20/2013 11:36 AM, Paul Sandoz wrote:
On Sep 21, 2013, at 12:03 AM, Kasper Nielsen kaspe...@gmail.com wrote:
Hi,
As I wrote to Paul.
Only OpenJDK Authors and above can create/edit/comment on bugs.
Sorry, did not realize that. I mistakenly thought a contributor (OCA signer)
could create issues via bugs.openjdk.java.net.
In the course of writing up a report (coming soon) that includes
discussion of SplittableRandom, we had a chance to further
analyze and test things, resulting in a few small improvements. Plus
some internal renamings to better reflect intent.
Plus now with the same initial seed mechanics
Hi Kasper,
Can you please log a bug [1] (and also note that ThreadLocal/Random does the
same) ?
My preference would be to get this code in and fix the error reporting
separately.
Thanks,
Paul.
[1] https://bugs.openjdk.java.net/
On Sep 20, 2013, at 8:25 AM, Kasper Nielsen kaspe...@gmail.com
Hi,
This is minor, but I hate it when bounds check does not include the
specified parameters.
Makes it much harder to track down a bug, if all you have is a stack trace.
- Kasper
On Fri, Sep 20, 2013 at 4:11 PM, Doug Lea d...@cs.oswego.edu wrote:
In the course of writing up a report (coming
On 09/20/2013 11:36 AM, Paul Sandoz wrote:
Hi Kasper,
Can you please log a bug [1] (and also note that ThreadLocal/Random does the
same) ?
My preference would be to get this code in and fix the error reporting
separately.
Even though a minor nuisance, I agree; it would be a simple
10 matches
Mail list logo
