Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Alan Bateman
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays.

Integrated: 8310929: Optimization for Integer.toString

2023-09-07 Thread 温绍锦
On Wed, 28 Jun 2023 17:06:56 GMT, 温绍锦 wrote: > Optimization for: > Integer.toString > Long.toString > StringBuilder#append(int) > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" >

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-07 Thread 温绍锦
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v2]

2023-09-07 Thread Brian Burkhalter
> In the Windows implementation of java.io.File.getCanonicalPath, strip any > long path or UNC prefix before canonicalizing the remainder of the pathname. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8287843: Handle

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Paul Sandoz
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays.

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v12]

2023-09-07 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-07 Thread Claes Redestad
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Srinivas Vamsi Parasa
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays.

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v3]

2023-09-07 Thread Tim Prinzing
On Tue, 22 Aug 2023 07:18:21 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/net/Socket.java line 1133: >> >>> 1131: return parent.getSoTimeout(); >>> 1132: } catch (Throwable t) { >>> 1133: // ignored - avoiding exceptions in jfr event

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v5]

2023-09-07 Thread Tim Prinzing
> The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static support for event classes. The old instrumentor classes

Integrated: 8268829: Provide an optimized way to walk the stack with Class object only

2023-09-07 Thread Mandy Chung
On Mon, 21 Aug 2023 20:07:20 GMT, Mandy Chung wrote: > 8268829: Provide an optimized way to walk the stack with Class object only > > `StackWalker::walk` creates one `StackFrame` per frame and the current > implementation > allocates one `StackFrameInfo` and one `MemberName` objects per frame.

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-07 Thread Justin Lu
On Thu, 7 Sep 2023 19:35:06 GMT, Naoto Sato wrote: > This should be excluded from the pattern syntax I presume you meant that the syntax should _include_ the required ascending order of limits. Updated to make this apparent, I also adjusted the syntax a little bit to be more accurate. The

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v4]

2023-09-07 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the > `java.text.ChoiceFormat` specification regarding its pattern. > > `j.text.ChoiceFormat` provides an example pattern in the class description, > but beyond that it does not specify

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Paul Sandoz
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays.

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v11]

2023-09-07 Thread Roger Riggs
On Tue, 5 Sep 2023 15:48:21 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-07 Thread Naoto Sato
On Thu, 7 Sep 2023 17:18:33 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/ChoiceFormat.java line 136: >> >>> 134: * Limit Relation Format >>> 135: * Limit: >>> 136: * {@code String} that can be parsed as a {@code double} / >>> "" ({@code U+221E}) / "-"

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

2023-09-07 Thread Daniel Fuchs
On Thu, 7 Sep 2023 19:27:14 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

2023-09-07 Thread Mandy Chung
> 8268829: Provide an optimized way to walk the stack with Class object only > > `StackWalker::walk` creates one `StackFrame` per frame and the current > implementation > allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some > frameworks > like logging may only interest in

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v11]

2023-09-07 Thread Mandy Chung
On Thu, 7 Sep 2023 18:51:44 GMT, Daniel Fuchs wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review feedback > > test/micro/org/openjdk/bench/java/lang/StackWalkBench.java line 60: > >> 58: static StackWalker

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v18]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes

2023-09-07 Thread Rémi Forax
On Thu, 7 Sep 2023 18:05:51 GMT, Stuart Marks wrote: >> Hello, >> In Java, sharing code may have a runtime cost (or not) depending on the >> shape of the code, because the VM may have to speculate on the class of some >> value at runtime. >> Here, in hasNext() and remove(), the VM has to find

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v11]

2023-09-07 Thread Daniel Fuchs
On Thu, 7 Sep 2023 18:22:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per

Re: RFR: 8041488: Locale-Dependent List Patterns [v15]

2023-09-07 Thread Naoto Sato
> Introducing a new formatting class for locale-dependent list patterns. The > class is to provide the functionality from the Unicode Consortium's LDML > specification for [list > patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns). > For example, given a list of

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v11]

2023-09-07 Thread Brent Christian
On Thu, 7 Sep 2023 18:22:40 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v11]

2023-09-07 Thread Mandy Chung
> 8268829: Provide an optimized way to walk the stack with Class object only > > `StackWalker::walk` creates one `StackFrame` per frame and the current > implementation > allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some > frameworks > like logging may only interest in

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes

2023-09-07 Thread Stuart Marks
On Thu, 7 Sep 2023 12:24:58 GMT, Rémi Forax wrote: >> This PR proposes to slightly improve some iterators of `AbstractMap`: >> >> * Code reuse >> * A field declared `final` >> * Add missing `@Override` annotations > > Hello, > In Java, sharing code may have a runtime cost (or not) depending on

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v2]

2023-09-07 Thread Stuart Marks
On Thu, 7 Sep 2023 17:23:20 GMT, Per Minborg wrote: >> This PR proposes to slightly improve some iterators of `AbstractMap`: >> >> * Code reuse >> * A field declared `final` >> * Add missing `@Override` annotations > > Per Minborg has updated the pull request incrementally with one additional

Re: RFR: 8041488: Locale-Dependent List Patterns [v14]

2023-09-07 Thread Roger Riggs
On Tue, 5 Sep 2023 22:47:01 GMT, Naoto Sato wrote: >> Introducing a new formatting class for locale-dependent list patterns. The >> class is to provide the functionality from the Unicode Consortium's LDML >> specification for [list >>

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v2]

2023-09-07 Thread Justin Lu
On Wed, 6 Sep 2023 23:04:59 GMT, Naoto Sato wrote: > Could the first choice be more specific? Updated with a more syntactical definition. Please let me know if you think this is _too_ specific. > Also, do SubPatterns need to be sorted with Limits? If I am interpreting the question right,

Re: RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v3]

2023-09-07 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the > `java.text.ChoiceFormat` specification regarding its pattern. > > `j.text.ChoiceFormat` provides an example pattern in the class description, > but beyond that it does not specify

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v2]

2023-09-07 Thread Per Minborg
> This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Code reuse > * A field declared `final` > * Add missing `@Override` annotations Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Remove @Override

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v11]

2023-09-07 Thread 温绍锦
On Tue, 5 Sep 2023 15:48:21 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Vicente Romero
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8315789: Minor HexFormat performance improvements

2023-09-07 Thread 温绍锦
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote: > This PR seeks to improve formatting of hex digits using `java.util.HexFormat` > somewhat. > > This is achieved getting rid of a couple of lookup tables, caching the result > of `HexFormat.of().withUpperCase()`, and removing tiny

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 14:07:05 GMT, Roger Riggs wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v17]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java [v2]

2023-09-07 Thread Soumadipta Roy
On Thu, 7 Sep 2023 15:58:26 GMT, Martin Buchholz wrote: >> Soumadipta Roy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove extra new line > > test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 45: > >> 43: * @modules

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >>

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v3]

2023-09-07 Thread Aleksey Shipilev
> Similar to other issues in the same area. I have no PPC32 machine to test the > build on, but this matches other fixes for other architectures > (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) > after this fix the PPC32 Zero build completes fine. Aleksey

Re: Question on why sun.management MBeans are not exported?

2023-09-07 Thread mandy . chung
What we're referring to is to remove sun.management.Hotspot*, the internal MBeans which are never exposed and registered in the platform MBeanServer.   The internal metrics in HotSpot VM should be retained as they are exposed through other ways like jstat, GC logs, etc. Mandy On 9/6/23 11:27

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths

2023-09-07 Thread Brian Burkhalter
On Thu, 7 Sep 2023 08:33:39 GMT, Alan Bateman wrote: > Would it be possible to summarise how this behaves when File just represents > a prefix? Baseline: jshell> File f = new File("\\\?\") f ==> \? jshell> f.getCanonicalPath() | Exception java.io.IOException: Bad pathname |at

Re: RFR: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java [v2]

2023-09-07 Thread Martin Buchholz
On Thu, 7 Sep 2023 14:10:20 GMT, Soumadipta Roy wrote: >> This test is running in tier1, and takes about 400 seconds to complete. >> Thus, it drags the execution time of tier1 on large machines. The commit >> includes changing the sequential run of test cases in >>

Re: RFR: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java [v2]

2023-09-07 Thread Martin Buchholz
On Thu, 7 Sep 2023 14:10:20 GMT, Soumadipta Roy wrote: >> This test is running in tier1, and takes about 400 seconds to complete. >> Thus, it drags the execution time of tier1 on large machines. The commit >> includes changing the sequential run of test cases in >>

Re: RFR: 8315410: Undocumented exceptions in java.text.StringCharacterIterator [v3]

2023-09-07 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315558) > which is a conformance change to document some exceptions in the > specification of java.text.StringCharacterIterator. Justin Lu has updated the pull request incrementally with one additional commit since the last

Integrated: 8315444: Convert test/jdk/tools to Classfile API

2023-09-07 Thread Qing Xiao
On Fri, 1 Sep 2023 08:14:26 GMT, Qing Xiao wrote: > `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in > `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`, > `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use on > com.sun.tools.classfile and should be

Re: RFR: JDK-8314272: Improve java.util.prefs.BackingStoreException: Couldn't get file lock. [v4]

2023-09-07 Thread Roger Riggs
On Mon, 4 Sep 2023 11:01:06 GMT, Matthias Baesken wrote: >> We run into some BackingStoreException: Couldn't get file lock. e.g. here : >> >> [JShell] Exception in thread "main" java.lang.IllegalStateException: >> java.util.prefs.BackingStoreException: Couldn't get file lock. >> [JShell] at

Java 21 clinit deadlock

2023-09-07 Thread Simone Bordet
Hello, We switched the Jetty builds to Java 21 a while ago, and they randomly fail with a hard deadlock during class initialization. We tried to understand if we were doing something wrong, but the code compiles fine, and at first glance there seems to be nothing wrong with it, but it may well

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Roger Riggs
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >>

Re: RFR: 8310929: Optimization for Integer.toString [v21]

2023-09-07 Thread Roger Riggs
On Wed, 6 Sep 2023 22:22:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test

RFR: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

2023-09-07 Thread Soumadipta Roy
This test is running in tier1, and takes about 400 seconds to complete. Thus, it drags the execution time of tier1 on large machines. The commit includes changing the sequential run of test cases in java/util/concurrent/tck/JSR166TestCase.java to the best possible combination of

Re: RFR: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java [v2]

2023-09-07 Thread Soumadipta Roy
> This test is running in tier1, and takes about 400 seconds to complete. Thus, > it drags the execution time of tier1 on large machines. The commit includes > changing the sequential run of test cases in > java/util/concurrent/tck/JSR166TestCase.java to the best possible combination > of

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Martin Doerr
On Thu, 7 Sep 2023 13:45:50 GMT, Aleksey Shipilev wrote: >> One might expect `isPPC()` to return true on PPC64 because it technically >> is. This is the only drawback I see. > > I don't have a strong opinion here, so if you want PPC32, you got it in new > commit :) Yeah, at least for the

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Martin Doerr
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >>

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 12:45:14 GMT, Martin Doerr wrote: >> Yeah, we can technically change to `PPC32`. But the current thing follows >> what build system uses as `OPENJDK_TARGET_CPU` (`ppc`) and what would be >> used as `os.arch` because of that. So, choosing which way to deviate: >> towards

Re: RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

2023-09-07 Thread Aleksey Shipilev
> Similar to other issues in the same area. I have no PPC32 machine to test the > build on, but this matches other fixes for other architectures > (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) > after this fix the PPC32 Zero build completes fine. Aleksey

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v16]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v15]

2023-09-07 Thread Jorn Vernee
On Thu, 7 Sep 2023 11:39:30 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign).

Re: RFR: 8315578: PPC builds are broken after JDK-8304913

2023-09-07 Thread Martin Doerr
On Thu, 7 Sep 2023 12:02:02 GMT, Aleksey Shipilev wrote: >> src/java.base/share/classes/jdk/internal/util/Architecture.java line 164: >> >>> 162: public static boolean isPPC() { >>> 163: return PlatformProps.TARGET_ARCH_IS_PPC; >>> 164: } >> >> Maybe `isPPC32()` would be a

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes

2023-09-07 Thread Rémi Forax
On Thu, 7 Sep 2023 11:48:51 GMT, Per Minborg wrote: > This PR proposes to slightly improve some iterators of `AbstractMap`: > > * Code reuse > * A field declared `final` > * Add missing `@Override` annotations Hello, In Java, sharing code may have a runtime cost (or not) depending on the shape

Re: RFR: 8310929: Optimization for Integer.toString [v21]

2023-09-07 Thread 温绍锦
On Wed, 6 Sep 2023 22:22:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test

RFR: 8315850: Improve AbstractMap anonymous Iterator classes

2023-09-07 Thread Per Minborg
This PR proposes to slightly improve some iterators of `AbstractMap`: * Code reuse * A field declared `final` * Add missing `@Override` annotations - Commit messages: - Improve AbstractMap anonymous Iterator classes Changes: https://git.openjdk.org/jdk/pull/15615/files Webrev:

Re: RFR: 8315444: Convert test/jdk/tools to Classfile API [v3]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 16:44:15 GMT, Qing Xiao wrote: >> `/test/jdk/tools/lib/tests/JImageValidator.java`, tests in >> `/test/jdk/tools/jlink`, and `/test/jdk/tools/jimage`, >> `/test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java` use >> on com.sun.tools.classfile and should be

Re: RFR: 8315578: PPC builds are broken after JDK-8304913

2023-09-07 Thread Aleksey Shipilev
On Mon, 4 Sep 2023 19:54:46 GMT, Martin Doerr wrote: >> Similar to other issues in the same area. I have no PPC32 machine to test >> the build on, but this matches other fixes for other architectures >> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) >> after

Integrated: 8314260: Unable to load system libraries on Windows when using a SecurityManager

2023-09-07 Thread Per Minborg
On Tue, 5 Sep 2023 08:52:50 GMT, Per Minborg wrote: > This PR proposes to read the system environment variable "SystemRoot" using a > privileged operation so it will work in the event a default SecurityManager > is in place. > > As the `SecurityManager` is deprecated for removal, no support

Re: RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager [v4]

2023-09-07 Thread Jorn Vernee
On Thu, 7 Sep 2023 07:46:03 GMT, Per Minborg wrote: >> This PR proposes to read the system environment variable "SystemRoot" using >> a privileged operation so it will work in the event a default >> SecurityManager is in place. >> >> As the `SecurityManager` is deprecated for removal, no

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-07 Thread Jorn Vernee
On Wed, 6 Sep 2023 16:03:40 GMT, Paul Sandoz wrote: >> [This SO question](https://stackoverflow.com/a/40348010) points to a gitlab >> repo that seems to have the latest version: >> https://gitlab.com/x86-psABIs/x86-64-ABI But, I'm not sure how stable that >> is, or if that's an authoritative

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v15]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the

Re: RFR: 8310929: Optimization for Integer.toString [v21]

2023-09-07 Thread Claes Redestad
On Wed, 6 Sep 2023 22:22:12 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test

Re: RFR: 8315004: Runtime.halt() debug logging

2023-09-07 Thread Masanori Yano
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote: > I want to add a log output similar to JDK-8301627 to Runtime.halt(). > To avoid double logging of Runtime.exit(), add a flag to indicate whether > logging was done, and fix it so that logging is done only once. > Could someone please

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v12]

2023-09-07 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le

2023-09-07 Thread Lutz Schmidt
On Wed, 6 Sep 2023 14:47:20 GMT, Matthias Baesken wrote: > The test RandomTestBsi1999 fails often with timeouts on Linux ppc64le; even > when it succeeds the test takes a lot of time and is close to timing out. > Probably we should increase the timeout value for this test. Looks good.

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v25]

2023-09-07 Thread Viktor Klang
On Wed, 6 Sep 2023 13:07:10 GMT, Doug Lea wrote: >> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java >> failed with "InterruptedException: sleep interrupted" and related issues. >> >> This is a major ForkJoin update (and hard to review -- sorry) that finally >>

Re: RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles

2023-09-07 Thread Andrey Turbanov
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote: > This reimplements > `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method > handles. > > This API currently generates the bytecode which fails the verification > because `new C; invokespecial A()` where the given

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 19:53:12 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths

2023-09-07 Thread Alan Bateman
On Wed, 6 Sep 2023 21:38:39 GMT, Brian Burkhalter wrote: > In the Windows implementation of java.io.File.getCanonicalPath, strip any > long path or UNC prefix before canonicalizing the remainder of the pathname. Would it be possible to summarise how this behaves when File just presents this

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 19:57:19 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

2023-09-07 Thread Adam Sotona
On Wed, 6 Sep 2023 19:55:49 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into

Re: RFR: 8314260: Unable to load system libraries on Windows when using a SecurityManager [v4]

2023-09-07 Thread Per Minborg
> This PR proposes to read the system environment variable "SystemRoot" using a > privileged operation so it will work in the event a default SecurityManager > is in place. > > As the `SecurityManager` is deprecated for removal, no support methods were > added for reading environmental

Re: RFR: JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le

2023-09-07 Thread Matthias Baesken
On Wed, 6 Sep 2023 14:47:20 GMT, Matthias Baesken wrote: > The test RandomTestBsi1999 fails often with timeouts on Linux ppc64le; even > when it succeeds the test takes a lot of time and is close to timing out. > Probably we should increase the timeout value for this test. Hi Martin, thanks

Integrated: JDK-8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le

2023-09-07 Thread Matthias Baesken
On Wed, 6 Sep 2023 14:47:20 GMT, Matthias Baesken wrote: > The test RandomTestBsi1999 fails often with timeouts on Linux ppc64le; even > when it succeeds the test takes a lot of time and is close to timing out. > Probably we should increase the timeout value for this test. This pull request

Integrated: JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8

2023-09-07 Thread Matthias Baesken
On Fri, 1 Sep 2023 07:22:12 GMT, Matthias Baesken wrote: > on some RHEL Linux 8.X machines , we run into errors in test > tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below. > It looks like these errors occur when running the jtreg tests with higher > concurrency, I did

Re: RFR: JDK-8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8 [v2]

2023-09-07 Thread Matthias Baesken
On Wed, 6 Sep 2023 07:29:20 GMT, Matthias Baesken wrote: >> on some RHEL Linux 8.X machines , we run into errors in test >> tools/jpackage/share/RuntimePackageTest.java#id0 , error can be seen below. >> It looks like these errors occur when running the jtreg tests with higher >> concurrency, I

Re: RFR: 8313612: Use JUnit in lib-test/jdk tests [v3]

2023-09-07 Thread Qing Xiao
> Modified all tests under lib-test/jdk to use JUnit Qing Xiao has updated the pull request incrementally with one additional commit since the last revision: Change test static method to instance method - Changes: - all: https://git.openjdk.org/jdk/pull/15131/files - new:

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-07 Thread Alan Bateman
On Wed, 6 Sep 2023 15:55:21 GMT, Tim Prinzing wrote: > I think it's useful if trying to trace the calls (i.e. set to 0ms). > Apparently the security manager was being used for that by some. The SM isn't called once connected so I don't think anyone could have every done that. Yes, you could

Re: Question on why sun.management MBeans are not exported?

2023-09-07 Thread Kirk Pepperdine
Hi, It would be a shame to lose these metrics because many of them have been very useful over time and some would be even more useful with some modifications. For example, the CPU breakouts found in GC logs has been incredibly useful as a proxy measure in helping sort out other issues in