On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
test/jdk/TEST.ROOT line 15:
> 13: #
> 14: #
On Wed, 22 Nov 2023 21:57:57 GMT, Daniel D. Daugherty
wrote:
>> My point is that it is such an easy thing to do: leave the "cx8" flag
>> sensing code in, and keep setting up `_supports_cx8` based on it for
>> `!_LP64` paths. This both provides more safety by failing cleanly on non-CX8
>>
On Wed, 22 Nov 2023 18:35:33 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/share/runtime/vm_version.cpp line 33:
>>
>>> 31: void VM_Version_init() {
>>> 32: VM_Version::initialize();
>>> 33: guarantee(VM_Version::supports_cx8(), "Support for 64-bit atomic
>>> operations in required in
On Wed, 22 Nov 2023 18:35:59 GMT, Daniel D. Daugherty
wrote:
> Wow! This PR is much larger than I expected.
>
> Thumbs up!
Thanks for the Review Dan! Yes lots of code deletion engineering in this one -
and even better I got to delete template code with meta-programming stuff! :D
On Wed, 22 Nov 2023 15:50:17 GMT, Doug Lea wrote:
>> David Holmes has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits
> As discussed in JBS all platforms (some tweaks to Zero are in progress)
> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
> out the locked-based alternatives to using it and just add a guarantee that
> it is true at runtime. And all platforms except some ARM
On Tue, 21 Nov 2023 14:13:19 GMT, Magnus Ihse Bursie wrote:
>> Yes, it seems weird. But the library we want to built out is `libvmath.so`
>> instead of `libsleef.so`. And we not only check the sleef library, but also
>> the ARM SVE feature inside it. So using `VMATH` suffix is more reasonable
On Tue, 21 Nov 2023 14:12:13 GMT, Magnus Ihse Bursie wrote:
>> This is just used to print the result of `AC_MSG_CEHCKING[if ARM SVE feature
>> is supported]` in configure.
>
> Ah, now I se what you are trying to do here. First of all, in the detection
> part, only set `SVE_FEATURE_SUPPORT`.
Please review this PR which converts the shell test,
_java/util/currency/PropertiesTest.sh_ to a normal java test.
This test is a test runner that launches test methods from
_PropertiesTest.java_. It tests both the ways to supersede the default
currencies, that is, either using a custom
On Fri, 17 Nov 2023 09:25:40 GMT, Justin Lu wrote:
> Please review this PR which allows these _j.util_ tests to launch new JVM
> processes with VM flags,
>
> This is primarily done using by switching to
> `ProcessTools::createTestJavaProcessBuilder`.
This pull request has now been
Many printing tests do not have the @printer keyword. This adds them to those
that need it.
I also found one test that has nothing to do with printing in the print folder
and moved it out.
-
Commit messages:
- 8320608
Changes: https://git.openjdk.org/jdk/pull/16785/files
Webrev:
On Tue, 14 Nov 2023 12:21:42 GMT, Alan Bateman wrote:
>> Yakov Shafranovich has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fixed more line breaks
>> - fixed line breaks
>
>
On Wed, 22 Nov 2023 21:41:50 GMT, Aleksey Shipilev wrote:
>> @shipilev - Do you have a particular legacy x86 in mind?
>
> My point is that it is such an easy thing to do: leave the "cx8" flag sensing
> code in, and keep setting up `_supports_cx8` based on it for `!_LP64` paths.
> This both
On Wed, 22 Nov 2023 18:26:12 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/cpu/x86/vm_version_x86.cpp line 819:
>>
>>> 817: }
>>> 818:
>>> 819: _supports_cx8 = supports_cmpxchg8();
>>
>> I think we should leave the runtime check here (under `ifndef`, like in
>> ARM?). This covers the
On Wed, 22 Nov 2023 11:32:53 GMT, Ivan Šipka wrote:
> @mahendrachhipa @bwhuang-us
Marked as reviewed by msheppar (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16782#pullrequestreview-1745344250
On Wed, 22 Nov 2023 15:29:08 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Wed, 22 Nov 2023 09:05:31 GMT, Andrew Haley wrote:
> > Have you considered the possibility of copying the sleef source to the
> > OpenJDK repository and thereby it becomes part of the build process? I
> > don't know how straightforward that is technically and IANAL but I think
> > it's
On Wed, 22 Nov 2023 08:48:09 GMT, Aleksey Shipilev wrote:
>> David Holmes has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Wed, 22 Nov 2023 02:09:38 GMT, David Holmes wrote:
>> As discussed in JBS all platforms (some tweaks to Zero are in progress)
>> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
>> out the locked-based alternatives to using it and just add a guarantee that
>> it
On Wed, 22 Nov 2023 18:01:21 GMT, Eirik Bjorsnos wrote:
>> @eirbjo Yes, as you noticed, the jar file does matter. And the reason I
>> suspected it wasn't noticed was because it was in the scenario of running
>> without security manager, So may that part of the code wasn't being actively
>>
On Wed, 22 Nov 2023 18:01:21 GMT, Eirik Bjorsnos wrote:
>> @eirbjo Yes, as you noticed, the jar file does matter. And the reason I
>> suspected it wasn't noticed was because it was in the scenario of running
>> without security manager, So may that part of the code wasn't being actively
>>
On Wed, 22 Nov 2023 17:53:33 GMT, Gaurav Chaudhari wrote:
> As for the rewrite, it does look good. But would it make more sense to bring
> this change as a separate PR having a own openjdk bug issue # designated to
> reworking of BadFactoryTest.sh for tracking purposes?
We have two options:
> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
> When running without security manager, the test references 'badfactoty.jar'
> instead of 'badfactory.jar'. This change addresses this by correcting the jar
> name.
Gaurav Chaudhari has refreshed the contents of
On Wed, 22 Nov 2023 11:32:13 GMT, Eirik Bjorsnos wrote:
>>> Looks okay. This test is begging to be re-written in Java, maybe some day.
>>>
>>> I assume the copyright header will be updated before this change is
>>> integrated.
>>
>> Hi @AlanBateman, do I have to update the copyright year to
On Fri, 17 Nov 2023 20:22:40 GMT, Joe Wang wrote:
> Implement the built-in Catalog.
This pull request has now been integrated.
Changeset: 93bdc2a6
Author:Joe Wang
URL:
https://git.openjdk.org/jdk/commit/93bdc2a6db91a95d6ee52ec92080e586c694dad5
Stats: 1647 lines in 50 files
On Wed, 22 Nov 2023 08:58:41 GMT, Alan Bateman wrote:
> I'm happy with the addition of the JDK built-in catalog, the inclusion of the
> DTD defined by Java SE, and the docs updates.
Thanks again, Alan, I really appreciate it! Finally got all pieces together, a
nice foundation for the next.
> Implement the built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
fix whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16719/files
- new:
On Wed, 22 Nov 2023 08:08:39 GMT, Andrey Turbanov wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add a note; fix alignment
>
> test/jaxp/javax/xml/jaxp/unittest/common/catalog/CatalogTestBase.java line
> 299:
>
>>
java/lang/invoke/lambda/LambdaFileEncodingSerialization.java is already problem
listed on linux-x64. However, the issue is not processor specific. We see the
failure on linux on other architectures as well.
-
Commit messages:
- Update ProblemList.txt
Changes:
On Wed, 22 Nov 2023 02:09:38 GMT, David Holmes wrote:
>> As discussed in JBS all platforms (some tweaks to Zero are in progress)
>> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
>> out the locked-based alternatives to using it and just add a guarantee that
>> it
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
On Tue, 21 Nov 2023 10:09:04 GMT, Varada M wrote:
> Following test fails due to missing pthread attributes on AIX :
> java/foreign/TestUpcallAsync.java
> java/foreign/stackwalk/TestAsyncStackWalk.java
> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>
On Thu, 9 Nov 2023 09:22:45 GMT, suchismith1993 wrote:
> 1. use pragma directive to handle alignment.
>
> JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175)
This pull request has now been integrated.
Changeset: bf0a904f
Author:suchismith
Committer: Martin Doerr
URL:
On Wed, 22 Nov 2023 06:50:07 GMT, Jorn Vernee wrote:
>> suchismith1993 has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix Typos
>> - Remove unnecessary includes
>
> Note that on Windows we also have a lookup mechanism on the Java
On Tue, 21 Nov 2023 10:09:04 GMT, Varada M wrote:
> Following test fails due to missing pthread attributes on AIX :
> java/foreign/TestUpcallAsync.java
> java/foreign/stackwalk/TestAsyncStackWalk.java
> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>
> The math library in AIX specifically, is a static archive. Doing a -lm wont
> suffice, because when the symbols are looked up using dlsym or accessing
> native code through Java, it will lead to failures.
> Hence we had to come up with a list of symbols to allow math library symbols
> to be
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont
>> suffice, because when the symbols are looked up using dlsym or accessing
>> native code through Java, it will lead to failures.
>> Hence we had to come up
On Tue, 21 Nov 2023 10:09:04 GMT, Varada M wrote:
> Following test fails due to missing pthread attributes on AIX :
> java/foreign/TestUpcallAsync.java
> java/foreign/stackwalk/TestAsyncStackWalk.java
> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Tue, 21 Nov 2023 10:09:04 GMT, Varada M wrote:
> Following test fails due to missing pthread attributes on AIX :
> java/foreign/TestUpcallAsync.java
> java/foreign/stackwalk/TestAsyncStackWalk.java
> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
@mahendrachhipa @bwhuang-us
-
Commit messages:
- 8316121: JDK22 ATR tasks job definition updates
Changes: https://git.openjdk.org/jdk/pull/16782/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16782=00
Issue: https://bugs.openjdk.org/browse/JDK-8320586
Stats: 10 lines in 1
On Tue, 21 Nov 2023 19:59:16 GMT, Gaurav Chaudhari wrote:
>> Looks okay. This test is begging to be re-written in Java, maybe some day.
>>
>> I assume the copyright header will be updated before this change is
>> integrated.
>
>> Looks okay. This test is begging to be re-written in Java, maybe
On Wed, 22 Nov 2023 08:07:00 GMT, Andrey Turbanov wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commits
On Tue, 21 Nov 2023 21:27:08 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commits
>>
On Thu, 9 Nov 2023 09:22:45 GMT, suchismith1993 wrote:
> 1. use pragma directive to handle alignment.
>
> JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175)
LGTM
-
Marked as reviewed by amitkumar (Committer).
PR Review:
On Wed, 22 Nov 2023 08:57:11 GMT, Aleksey Shipilev wrote:
> Zero tests are running.
Caught the `guarantee` on linux-arm-zero-fastdebug! But that is actually the
fault in my previous patch: #16779.
-
PR Comment: https://git.openjdk.org/jdk/pull/16625#issuecomment-1822510325
On Tue, 21 Nov 2023 21:16:41 GMT, Eirik Bjorsnos wrote:
> So it's not clear to me why this test uses a jar file at all, it does not
> seem necessary.
On a closer look, `${TESTCLASSES}` contains the compiled java classes, but not
the service definition file
On Tue, 21 Nov 2023 14:24:47 GMT, Martin Doerr wrote:
>> Following test fails due to missing pthread attributes on AIX :
>> java/foreign/TestUpcallAsync.java
>> java/foreign/stackwalk/TestAsyncStackWalk.java
>> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>>
On Tue, 21 Nov 2023 14:24:47 GMT, Martin Doerr wrote:
>> Following test fails due to missing pthread attributes on AIX :
>> java/foreign/TestUpcallAsync.java
>> java/foreign/stackwalk/TestAsyncStackWalk.java
>> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>>
Following test fails due to missing pthread attributes on AIX :
java/foreign/TestUpcallAsync.java
java/foreign/stackwalk/TestAsyncStackWalk.java
java/foreign/loaderLookup/TestLoaderLookupJNI.java
java/foreign/enablenativeaccess/TestEnableNativeAccessJarManifest.java
On Tue, 21 Nov 2023 10:09:04 GMT, Varada M wrote:
> Following test fails due to missing pthread attributes on AIX :
> java/foreign/TestUpcallAsync.java
> java/foreign/stackwalk/TestAsyncStackWalk.java
> java/foreign/loaderLookup/TestLoaderLookupJNI.java
>
On Wed, 22 Nov 2023 02:09:38 GMT, David Holmes wrote:
>> As discussed in JBS all platforms (some tweaks to Zero are in progress)
>> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
>> out the locked-based alternatives to using it and just add a guarantee that
>> it
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
I'm happy with the addition of the JDK built-in catalog, the
On Wed, 22 Nov 2023 02:18:32 GMT, Eric Liu wrote:
>> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1412:
>>
>>> 1410: _sve_xunpk(is_unsigned, /* is_high */ false, dst, S, dst);
>>> 1411: _sve_xunpk(is_unsigned, /* is_high */ false, dst, D, dst);
>>> 1412: break;
On Wed, 22 Nov 2023 01:52:51 GMT, Xiaohong Gong wrote:
> > Have you considered the possibility of copying the sleef source to the
> > OpenJDK repository and thereby it becomes part of the build process? I
> > don't know how straightforward that is technically and IANAL but I think
> > it's
On Wed, 22 Nov 2023 02:09:38 GMT, David Holmes wrote:
>> As discussed in JBS all platforms (some tweaks to Zero are in progress)
>> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
>> out the locked-based alternatives to using it and just add a guarantee that
>> it
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the
62 matches
Mail list logo
