On Sat, 24 Aug 2024 21:16:34 GMT, Claes Redestad wrote:
>> This PR refactors SwitchBootstraps so that extra EnumDescs and classes are
>> only passed into bootstraps when needed. Benchmarking shows that in many
>> cases these are not needed, and avoiding passing them (via binding in the
>> list
On Wed, 26 Jun 2024 12:32:20 GMT, Jan Lahoda wrote:
> For general pattern matching switches, the `SwitchBootstraps` class currently
> generates a cascade of `if`-like statements, computing the correct target
> case index for the given input.
>
> There is one special case
gt; One, `enumSwitchTraditional` is an "old" switch, desugared fully by javac,
> the other, `enumSwitchWithBootstrap` is an equivalent switch that uses the
> `SwitchBootstraps`. Before this patch, I was getting values like:
>
> Benchmark Mode Cnt S
On Thu, 27 Jun 2024 19:30:39 GMT, Jan Lahoda wrote:
>> For general pattern matching switches, the `SwitchBootstraps` class
>> currently generates a cascade of `if`-like statements, computing the correct
>> target case index for the given input.
>>
>> There is on
On Fri, 28 Jun 2024 09:33:41 GMT, Aleksey Shipilev wrote:
> > FWIW, there are more `@Stable` uses here: #19906
> > if you would have a moment to check that, it may be helpful. Thanks.
>
> That one looks fine: it is set outside of constructor, is intrinsically racy,
> and it has AFAICS the recov
On Thu, 27 Jun 2024 19:30:34 GMT, Aleksey Shipilev wrote:
> I was auditing the current uses of `@Stable` before relaxing its barriers
> ([JDK-8333791](https://bugs.openjdk.org/browse/JDK-8333791)), and this is an
> easy spot.
>
> `resolvedEnum` is not `final`. So technically publishing the ob
On Thu, 27 Jun 2024 19:30:34 GMT, Aleksey Shipilev wrote:
> I was auditing the current uses of `@Stable` before relaxing its barriers
> ([JDK-8333791](https://bugs.openjdk.org/browse/JDK-8333791)), and this is an
> easy spot.
>
> `resolvedEnum` is not `final`. So technically publishing the ob
On Thu, 27 Jun 2024 19:07:07 GMT, ExE Boss wrote:
> Since `labels` is no longer eagerly cloned, it’s important to store the
> converted labels into a local array to avoid leaking them to user code.
True. But it is easier and cleaner, IMO, to simply put back cloning of the
labels.
gt; One, `enumSwitchTraditional` is an "old" switch, desugared fully by javac,
> the other, `enumSwitchWithBootstrap` is an equivalent switch that uses the
> `SwitchBootstraps`. Before this patch, I was getting values like:
>
> Benchmark Mode Cnt S
gt; One, `enumSwitchTraditional` is an "old" switch, desugared fully by javac,
> the other, `enumSwitchWithBootstrap` is an equivalent switch that uses the
> `SwitchBootstraps`. Before this patch, I was getting values like:
>
> Benchmark Mode Cnt S
gt; One, `enumSwitchTraditional` is an "old" switch, desugared fully by javac,
> the other, `enumSwitchWithBootstrap` is an equivalent switch that uses the
> `SwitchBootstraps`. Before this patch, I was getting values like:
>
> Benchmark Mode Cnt S
On Mon, 24 Jun 2024 12:57:39 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
On Wed, 26 Jun 2024 12:46:18 GMT, Claes Redestad wrote:
>> For general pattern matching switches, the `SwitchBootstraps` class
>> currently generates a cascade of `if`-like statements, computing the correct
>> target case index for the given input.
>>
>> There is one special case which permits
For general pattern matching switches, the `SwitchBootstraps` class currently
generates a cascade of `if`-like statements, computing the correct target case
index for the given input.
There is one special case which permits a relatively easy faster handling, and
that is when all the case labels
On Tue, 25 Jun 2024 13:59:35 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [JDK-808](https://bugs.openjdk.org/browse/JDK-808)
> enabling `javap -system` to handle internal class names.
>
> Thanks,
> Sonia
For a test, I agree it is quite difficult. For the `--sys
On Fri, 21 Jun 2024 18:37:01 GMT, Jorn Vernee wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/Main.java line 417:
>>
>>> 415: return false;
>>> 416: }
>>> 417: JavaFileManager fm =
>>> pp.getPlatformTrusted(release).getFileManager();
>>
>>
On Thu, 20 Jun 2024 17:44:54 GMT, Alan Bateman wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/JNativeScanTask.java
>> line 113:
>>
>>> 111: // Class-Path attribute specifies that jars that
>>> 112: // are not found are simply ignored. Do
On Thu, 20 Jun 2024 19:45:29 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
On Thu, 20 Jun 2024 16:58:55 GMT, Alan Bateman wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/platform/JDKPlatformProvider.java
>> line 93:
>>
>>> 91: }
>>> 92:
>>> 93: public PlatformDescription getPlatformTrusted(String platformName) {
>>
>> I noticed that `getPlatform
On Thu, 30 May 2024 13:50:33 GMT, Jan Lahoda wrote:
> Consider these two programs:
>
>
> public class SystemPrint {
> public static void main(String... args) {
> System.err.println("Hello!");
> }
> }
>
> and:
>
> public class
OPrint
> Hello!
>
> real0m0,051s
> user0m0,038s
> sys 0m0,020s
>
>
> which seems much more acceptable.
>
> There is also #19467, which may reduce the time further.
>
> A future work might focus on making JLine initialize faster, but avoiding
> JL
OPrint
> Hello!
>
> real0m0,051s
> user0m0,038s
> sys 0m0,020s
>
>
> which seems much more acceptable.
>
> There is also #19467, which may reduce the time further.
>
> A future work might focus on making JLine initialize faster, but avoiding
>
On Thu, 30 May 2024 18:39:19 GMT, Chen Liang wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update symbol files for JDK 23 build 25.
>
> src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-N.sym.txt line 1:
>
Consider these two programs:
public class SystemPrint {
public static void main(String... args) {
System.err.println("Hello!");
}
}
and:
public class IOPrint {
public static void main(String... args) {
java.io.IO.println("Hello!");
}
}
They do the same conceptu
On Wed, 29 May 2024 19:51:36 GMT, Naoto Sato wrote:
> There is an initialization code in `Console` class that searches for the
> Console implementations. Refactoring the init code not to use lambda/stream
> would reduce the (initial) number of loaded classes by about 100 for
> java.base implem
On Fri, 24 May 2024 16:41:33 GMT, Adam Sotona wrote:
>> j.l.classfile.ClassReader instance is exposed in the Class-File API through
>> j.l.classfile.AttributeMapper::readAttribute method only.
>> ClassReader only purpose is to serve as a tool for reading content of a
>> custom attribute in a us
On Mon, 20 May 2024 08:03:28 GMT, Adam Sotona wrote:
> Class-File API `ClassRemapper` component suppose to remap all classes
> referenced in a class file.
> Actual implementation missed remapping of bootstrap methods referenced from
> `invokedynamic` instructions.
> This patch fixes the remappi
On Wed, 22 May 2024 13:58:21 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest relea
On Fri, 24 May 2024 11:30:19 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merg
On Thu, 23 May 2024 17:14:19 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merg
On Thu, 23 May 2024 11:09:14 GMT, Claes Redestad wrote:
>> We can fold the call to `Objects.checkIndex` into the code generated in
>> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
>> This loads 9 less classes (of which 8 generated LFs and Species classes) on
>> a
On Tue, 21 May 2024 09:01:32 GMT, Claes Redestad wrote:
>> We can fold the call to `Objects.checkIndex` into the code generated in
>> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
>> This loads 9 less classes (of which 8 generated LFs and Species classes) on
>> a
On Sun, 5 May 2024 15:22:15 GMT, Nizar Benalla wrote:
>> This checker checks the values of the `@since` tag found in the
>> documentation comment for an element against the release in which the
>> element first appeared.
>>
>> Real since value of an API element is computed as the oldest releas
On Wed, 15 May 2024 17:05:17 GMT, Naoto Sato wrote:
>> Proposing new overloaded methods in `java.io.Console` class that explicitly
>> take a `Locale` argument. Existing methods rely on the default locale, so
>> the users won't be able to format their prompts/outputs in a certain locale
>> expl
On Fri, 3 May 2024 10:11:02 GMT, Jan Lahoda wrote:
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
&
ormat` is used, which will convert
> `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution
> is to duplicate the `%`, so that JLine will print it.
Jan Lahoda has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jd
ormat` is used, which will convert
> `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution
> is to duplicate the `%`, so that JLine will print it.
Jan Lahoda has updated the pull request incrementally with one additional
commit since the last revision:
Fixing
ormat` is used, which will convert
> `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution
> is to duplicate the `%`, so that JLine will print it.
Jan Lahoda has updated the pull request incrementally with one additional
commit since the last revision:
Adding anoth
ormat` is used, which will convert
> `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution
> is to duplicate the `%`, so that JLine will print it.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a rebase. The pull request now conta
On Fri, 3 May 2024 21:59:40 GMT, Pavel Rappo wrote:
>>> Ideally, we should have separate tests that make sure that jdk.internal.le
>>> is the default impl.
>>
>> We have a test that checks if `System.console()` returns the correct Console
>> (or null) from the expected module
>> (`test/jdk/ja
On Fri, 3 May 2024 11:20:52 GMT, Pavel Rappo wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> src/jdk.internal.le/share/
On Wed, 17 Apr 2024 09:20:24 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void
On Fri, 12 Apr 2024 10:16:36 GMT, Jan Lahoda wrote:
> Consider code like:
>
> public class MainClass {
> public MainClass() {
> System.out.println("Constructor called!");
> }
> public static void main() {
> System.out.println(&qu
On Mon, 6 May 2024 08:28:50 GMT, Jan Lahoda wrote:
> When integrating:
> https://github.com/openjdk/jdk/pull/18996
>
> I've forgot to push one last commit which was stabilizing the test of Mac
> OS/X. I am sorry for that.
>
> The test will create a pseudo termin
When integrating:
https://github.com/openjdk/jdk/pull/18996
I've forgot to push one last commit which was stabilizing the test of Mac OS/X.
I am sorry for that.
The test will create a pseudo terminal, and change the current process
stdin/stdout to write into the pty. But, there's nothing readin
ormat` is used, which will convert
> `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution
> is to duplicate the `%`, so that JLine will print it.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes
On Mon, 29 Apr 2024 11:44:50 GMT, Jan Lahoda wrote:
> Consider code like:
>
> public class ConsoleTest {
> public static void main(String... args) {
> System.console().printf("Hello!");
> }
> }
>
>
> When run as:
>
> $ java Consol
On Thu, 4 Apr 2024 07:30:34 GMT, Jan Lahoda wrote:
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are p
When JLine reads a line, there may be a prompt provided. However, JLine will
not interpret the prompt literally, it will handle `%` specially. As a
consequence, doing:
System.console().readLine("%%s");
will not print `%s`, as first `String.format` is used, which will convert `%%s`
to `%s`, an
On Thu, 2 May 2024 20:54:58 GMT, Naoto Sato wrote:
> Fixing a comment in `java.io.Console`, which was a leftover from the fix to
> https://bugs.openjdk.org/browse/JDK-8308591
Looks good to me, thanks!
-
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/
On Mon, 29 Apr 2024 18:41:44 GMT, Naoto Sato wrote:
> Looks good to me. Left some minor suggestions. BTW, should we file an issue
> at the `JLine` project, not to redirect to stderr, or suggest a new config
> (sorry if it has already been taken care of)?
The code to choose the output stream is
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
> a pty and to attach to it, and should run in a separate VM, as it leaves the
> VM attached to the terminal.
Jan Lahoda has updated the pull request incrementally with one additional
commit since the last revision:
Adjusting test, as suggested.
-
Changes:
- all: https://
On Mon, 29 Apr 2024 20:21:23 GMT, Archie Cobbs wrote:
> > Of course the question is if it should write to stderr or /dev/tty like
> > mechanism..
>
> I was wondering the same thing. My understanding of the definition of
> "console" is a bidirectional byte channel with a keyboard & screen on th
> a pty and to attach to it, and should run in a separate VM, as it leaves the
> VM attached to the terminal.
Jan Lahoda has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
On Fri, 26 Apr 2024 23:54:17 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](https://bugs.openjdk.org/browse
Consider code like:
public class ConsoleTest {
public static void main(String... args) {
System.console().printf("Hello!");
}
}
When run as:
$ java ConsoleTest.java >/dev/null
it prints `Hello!` to stderr, instead of to stdout (where it would be
redirected).
The proposed fix
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request with a new target base due to a merge
or
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request with a new target base due to a merge
or
On Fri, 19 Apr 2024 13:23:53 GMT, Claes Redestad wrote:
> We can reduce overhead of first use of a switch bootstrap by moving
> `typePairToName` into `TypePairs` and by explicitly overriding `hashCode` and
> `equals`. The first change avoids loading and initializing the `TypePairs`
> class in
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
On Thu, 18 Apr 2024 10:47:11 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating JEP number and caption.
>
> src/jdk.compiler/share/classes
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue link
On Thu, 18 Apr 2024 05:43:03 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing ListModuleDeps test.
>
> src/java.base/share/classes/jdk/internal/javac/Preview
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
own from the constructor are effectively
> ignored, and the launcher will continue with the next variant. This seems
> wrong - the exception should be printed for the user, like:
>
> $ java --enable-preview -classpath /tmp/ MainClass
> Exception in thread "main" java.la
On Wed, 17 Apr 2024 08:51:39 GMT, Jaikiran Pai wrote:
>> Jan Lahoda has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Reflecting code formatting suggestion.
>> - First lookup the main method,
On Wed, 17 Apr 2024 06:34:25 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void
own from the constructor are effectively
> ignored, and the launcher will continue with the next variant. This seems
> wrong - the exception should be printed for the user, like:
>
> $ java --enable-preview -classpath /tmp/ MainClass
> Exception in thread "main" java.la
On Tue, 16 Apr 2024 10:03:21 GMT, David Holmes wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback.
>
> src/java.base/share/native/libjli/java.c line 419:
>
&
own from the constructor are effectively
> ignored, and the launcher will continue with the next variant. This seems
> wrong - the exception should be printed for the user, like:
>
> $ java --enable-preview -classpath /tmp/ MainClass
> Exception in thread "main" java.la
On Sun, 14 Apr 2024 06:51:37 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback.
>
> src/java.base/share/native/libjli/java.c line 434:
>
Consider code like:
public class MainClass {
public MainClass() {
System.out.println("Constructor called!");
}
public static void main() {
System.out.println("main called!");
}
}
and compile and run it, with preview enabled, like:
$ javac /tmp/MainClass.java
$ ja
On Wed, 10 Apr 2024 10:59:25 GMT, Maurizio Cimadamore
wrote:
>> This PR removes support for the string template feature from the Java
>> compiler and the Java SE API, as discussed here:
>>
>> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
>
> Maurizio Cimadamore h
On Wed, 10 Apr 2024 10:44:13 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
>> 120:
>>
>>> 118: * @since 21
>>> 119: */
>>> 120: public static final int MAX_INDY_CONCAT_ARG_SLOTS;
>>
>> May this value change in the f
On Wed, 10 Apr 2024 08:41:19 GMT, Christian Stein wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more tests for ambiguities.
>
> src/jdk.compiler/share/classes
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
On Wed, 10 Apr 2024 11:52:31 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more tests for ambiguities.
>
> src/jdk.compiler/share/classes/com/sun/too
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
On Mon, 8 Apr 2024 16:36:49 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding tests as suggested.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request incrementally with one additional
commit sin
On Fri, 9 Feb 2024 10:47:08 GMT, Adam Sotona wrote:
>> ClassFile API provides two sets of instructions implementations (bound and
>> unbound).
>> Unbound implementation of `IncrementInstruction::constant` returns invalid
>> value.
>> This bug discovered a hole in the ClassFile API test coverag
On Wed, 3 Apr 2024 08:15:52 GMT, Adam Sotona wrote:
> `Opcode.IFNONNULL.primaryTypeKind()` wrongly returned `IntType` instead of
> the right `ReferenceType`.
> Primary type kinds of `BRANCH` opcodes have yet no functional effect in the
> Class-File API.
> This simple patch fixes the typo.
>
>
On Fri, 5 Apr 2024 18:30:30 GMT, Joe Darcy wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback:
>> - pre-generating the JCVarDecls in Attr, to aid Flow
&
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request incrementally with one additional
commit s
On Fri, 5 Apr 2024 13:09:56 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JavaCompiler cleanup
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/F
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request incrementally with one additional
commit sin
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request incrementally with one additional
commi
On Thu, 4 Apr 2024 17:00:33 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler
d some time ago.
> - there are a bit broader changes in `Flow`, to facilitate the introduction
> of variables without an explicit declaration for definite assignment and
> effectively final computation.
Jan Lahoda has updated the pull request with a new target base due to a merge
or
On Thu, 4 Apr 2024 16:47:07 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/F
On Thu, 4 Apr 2024 00:37:45 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/java.compiler/share/classes/javax/lang/model/element/ElementKi
public API AST node/interface, so this is purely an
> implementation choice.
> - JShell now supports module imports as well; and the default, implicit,
> script is changed to use it to import all of `java.base` if preview is
> enabled. It is expected that the default would be changed if/when the mod
On Thu, 4 Apr 2024 11:43:07 GMT, Thiago Henrique Hüpner
wrote:
> Should the pull request incorporate a modification to the JAVASE script file
> for JShell, specifically substituting it with `import module java.se`? (right
> now the imports are computed, not read from a file)
Given we need to
1 - 100 of 231 matches
Mail list logo