On Mon, 29 Apr 2024 21:53:02 GMT, Tim Prinzing wrote:
> Should I set the default to be fairly high (like maybe 1600ms)? I think to be
> useful people will have to set the threshold to something that fits their
> needs anyway.
I wonder about the usefulness of this event if the default
On Thu, 11 Apr 2024 16:39:24 GMT, Daniel Fuchs wrote:
>> I think it's okay for now. If there is another phase of this work to help
>> diagnose spinning issues then it will need to re-visited. I'm very concerned
>> about the possible changes for that second phase, but this first phase of
>>
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Mon, 15 Apr 2024 21:37:15 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Mon, 26 Feb 2024 14:17:09 GMT, Daniel Fuchs wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/SelectorSelectEvent.java line 44:
>>
>>> 42: @Label("SelectionKey Count")
>>> 43: @Description("Number of channels ready for I/O or added to ready
>>> set")
>>> 44: public int
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Thu, 11 Apr 2024 16:08:31 GMT, Alan Bateman wrote:
>> We should probably find a way to not emit the event if n == 0 and the
>> operation was interrupted by `Selector.wakeUp`. Since we have another issue
>> logged to emit a spin event, I wonder if we should only commit the event
>> here if
On Thu, 11 Apr 2024 09:12:30 GMT, Daniel Fuchs wrote:
>>> Maybe that's OK - and maybe in that case the onus is on the user to set a
>>> threshold greater than 1500ms?
>>
>> The threshold is 20ms so these timed-select ops in the HTTP client will
>> record an event when they timeout.
>
> We
On Mon, 26 Feb 2024 17:40:59 GMT, Alan Bateman wrote:
>> Is n == 0 intended to detect a spinning condition where the selector goes
>> back into select when the event has not been handled?
>>
>> In that case should we still emit an event if a timeout is present and the
>> duration is greater
On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Mon, 26 Feb 2024 14:14:21 GMT, Daniel Fuchs wrote:
> Maybe that's OK - and maybe in that case the onus is on the user to set a
> threshold greater than 1500ms?
The threshold is 20ms so these timed-select ops in the HTTP client will record
an event when they timeout.
-
PR
On Wed, 3 Jan 2024 11:11:40 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add select timeout field to the event
>
> src/java.base/share/classes/sun/nio/ch/SelectorImpl.java line 153:
>
>> 151:
On Wed, 13 Dec 2023 18:49:08 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits
On Wed, 13 Dec 2023 18:58:40 GMT, Tim Prinzing wrote:
>> src/java.base/share/classes/jdk/internal/event/SelectorSelectEvent.java line
>> 41:
>>
>>> 39: public class SelectorSelectEvent extends Event {
>>> 40:
>>> 41: public int selectionKeyCount;
>>
>> I still believe we should record
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Wed, 13 Dec 2023 22:20:55 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Wed, 13 Dec 2023 18:47:50 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits
On Wed, 13 Dec 2023 18:38:11 GMT, Tim Prinzing wrote:
>>> It could also be interesting to provide the `timeout` that was given to the
>>> selection operation.
>>
>> I've tried to work through issues, esp. around selector spinning, and being
>> able to distinguish select from selectNow is
On Wed, 13 Dec 2023 18:38:09 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Thu, 23 Nov 2023 11:18:45 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/SelectionEvent.java line 43:
>>
>>> 41:
>>> 42: @Label("Selection Count")
>>> 43: @Description("Number of channels selected")
>>
>> I suspect you'll need to rename this event to something
On Fri, 8 Dec 2023 06:30:21 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/event/SelectionEvent.java line 38:
>>
>>> 36: public class SelectionEvent extends Event {
>>> 37:
>>> 38: public int count;
>>
>> It could also be interesting to provide the `timeout` that was
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has
On Wed, 22 Nov 2023 12:08:08 GMT, Daniel Fuchs wrote:
> It could also be interesting to provide the `timeout` that was given to the
> selection operation.
I've tried to work through issues, esp. around selector spinning, and being
able to distinguish select from selectNow is important for all
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Tue, 28 Nov 2023 20:34:34 GMT, Markus Grönlund wrote:
> Isn't this a replacement for the existing instrumentation? If these are new
> events I am sorry.
It's a new event.
> What is keeping us from removing ASM in that case?
I think file I/O, there is still instrumentation used for
On Tue, 28 Nov 2023 20:30:52 GMT, Alan Bateman wrote:
> > It would be good to integrate this quite soon because it would release the
> > reliance on ASM and let us only use the new ClassFile API. Now, we need to
> > load both implementations, leading to startup regression.
>
> This is a new
On Tue, 28 Nov 2023 18:21:33 GMT, Markus Grönlund wrote:
> It would be good to integrate this quite soon because it would release the
> reliance on ASM and let us only use the new ClassFile API. Now, we need to
> load both implementations, leading to startup regression.
This is a new event so
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Wed, 22 Nov 2023 12:25:45 GMT, Alan Bateman wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at
Added mirror event with static methods: jdk.internal.event.SelectionEvent that
provides the duration of select calls and the count of how many keys are
available.
Emit the event from SelectorImpl::lockAndDoSelect
Test at jdk.jfr.event.io.TestSelectionEvents
-
Commit messages:
-
40 matches
Mail list logo
