On Thu, 30 Nov 2023 15:51:46 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 30 Nov 2023 08:00:12 GMT, Damon Fenacci wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use byte off branches in char_array_compress
>> Verified by manual tests with "-XX:AVX3Threshold=0"
>> And test in
On Thu, 30 Nov 2023 15:51:46 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Mon, 27 Nov 2023 19:09:40 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Mon, 27 Nov 2023 19:09:40 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Mon, 27 Nov 2023 17:28:34 GMT, Roger Riggs wrote:
>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8584:
>>
>>> 8582: evpcmpuw(mask1, tmp1Reg, tmp2Reg, Assembler::le,
>>> Assembler::AVX_512bit);
>>> 8583: kortestdl(mask1, mask1);
>>> 8584: jcc(Assembler::carryClear,
On Mon, 27 Nov 2023 13:43:52 GMT, Damon Fenacci wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply StringUTF16.coderFromArrayLen
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8584:
>
>> 8582:
On Wed, 22 Nov 2023 05:03:41 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Mon, 20 Nov 2023 19:35:27 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Thu, 16 Nov 2023 20:27:11 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Thu, 16 Nov 2023 10:05:14 GMT, Tobias Hartmann wrote:
>> No, we don't mix: the SSE code is used as fallback only when the length is
>> below 32 (if length is above 32 we check the tail with AVX code by
>> shifting).
>>
>> I would suggest factoring out so that the implementations don't mix
On Thu, 16 Nov 2023 09:31:57 GMT, Claes Redestad wrote:
>>> This cause a crash if I run with -XX:UseAVX=3 -XX:AVX3Threshold=0:
>>
>> Good catch! Do we have a test for that scenario? If not, one should be added.
>>
>>> Alternatively [...]
>>
>> I would suggest to use `jmp(copy_chars_loop)`
On Wed, 15 Nov 2023 22:15:54 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 16 Nov 2023 08:59:25 GMT, Tobias Hartmann wrote:
>> Alternatively:
>>
>> if (UseSSE42Intrinsics) {
>> jmpb(copy_chars_loop);
>> } else {
>> jmp(copy_chars_loop);
>> }
>>
>>
>> More generally I do wonder if it'd make most sense to make the AVX512 and
>> SSE42 implementations
On Wed, 15 Nov 2023 15:40:49 GMT, Claes Redestad wrote:
>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8617:
>>
>>> 8615: lea(dst, Address(dst, tmp5, Address::times_1));
>>> 8616: subptr(len, tmp5);
>>> 8617: jmpb(copy_chars_loop);
>>
>> This cause a crash if I run with
On Wed, 15 Nov 2023 22:15:54 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Wed, 15 Nov 2023 15:25:21 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update PPC implementation of string_compress to return the index of the
>> non-latin1 char
>> Patch supplied
On Wed, 15 Nov 2023 22:08:19 GMT, Roger Riggs wrote:
>> test/jdk/java/lang/String/StringRacyConstructor.java line 190:
>>
>>> 188: if (printWarningCount == 0) {
>>> 189: printWarningCount = 1;
>>> 190:
On Wed, 15 Nov 2023 15:23:48 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update PPC implementation of string_compress to return the index of the
>> non-latin1 char
>> Patch supplied
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Tue, 14 Nov 2023 16:05:51 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Wed, 15 Nov 2023 15:32:54 GMT, Claes Redestad wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update PPC implementation of string_compress to return the index of the
>> non-latin1 char
>> Patch supplied by
On Tue, 14 Nov 2023 16:05:51 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Tue, 14 Nov 2023 16:05:51 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Mon, 13 Nov 2023 20:42:00 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Fri, 10 Nov 2023 14:59:57 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Refactored extractCodePoints to avoid multiple resizes if the array was
>> modified
>> - Replaced
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
On Thu, 9 Nov 2023 09:07:31 GMT, Chen Liang wrote:
> Just curious, how does benchmark
> StringConstructor.newStringFromCharsMixedBegin change before and after this
> patch? If we can see how much of an impact this has on CJK strings it would
> be appreciated.
You may have better insights
On Mon, 6 Nov 2023 15:30:46 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/StringUTF16.java line 202:
>>
>>> 200: @ForceInline
>>> 201: public static byte[] compress(final char[] val, final int off,
>>> final int count) {
>>> 202: byte[] latin1 = new
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might invalidate internal invariants for the
> correct
On Wed, 8 Nov 2023 16:47:17 GMT, Raffaello Giulietti
wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Sat, 4 Nov 2023 00:07:33 GMT, Chen Liang wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Sun, 5 Nov 2023 13:32:20 GMT, ExE Boss wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
Strings, after construction, are immutable but may be constructed from mutable
arrays of bytes, characters, or integers.
The string constructors should guard against the effects of mutating the arrays
during construction that might invalidate internal invariants for the correct
behavior of
61 matches
Mail list logo
