Re: RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

+1  > On May 28, 2020, at 3:16 AM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 > > Webrev: http://cr.openjdk.java.net/~sundar/8246034/webrev.00/ > > Thanks > > -Sundar >

Re: RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

On 28/05/2020 07:14, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 Webrev: http://cr.openjdk.java.net/~sundar/8246034/webrev.00/ Have you checked if there are any make file configured to copy .js files? Otherwise looks

RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 Webrev: http://cr.openjdk.java.net/~sundar/8246034/webrev.00/ Thanks -Sundar

Re: RFR: JDK-8225056 VM support for sealed classes

Hi Harold, On 28/05/2020 6:35 am, Harold Seigel wrote: Hi David, Please review this updated webrev: Incremental webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.incr.2/ Changes look good - thanks! One minor comment: src/hotspot/share/prims/jvm.cpp 2159 if (length !=

Re: RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

Yes, checked. No config file refers to these .js files. -Sundar On 28/05/20 12:28 pm, Alan Bateman wrote: On 28/05/2020 07:14, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 Webrev:

Re: contributing to JDK-8171407: Port fdlibm to Java, part 2

Hi Joe, I kind of understand your point of being more at ease with the porting itself than with the review. However, wouldn't a review be needed anyway, regardless how knowledgeable the porter might be? That is, even if an expert like yourself does the port, somebody else would still have

Re: RFR(S) 8242504: Enhance the system clock to nanosecond precision

Thanks Dan! David On 28/05/2020 12:52 pm, Daniel D. Daugherty wrote: I'll wait for your thumbs up on the explanation. I'm good with the explanation. Thanks! Dan On 5/27/20 10:08 PM, David Holmes wrote: Hi Dan, Thanks for taking a look. On 28/05/2020 1:09 am, Daniel D. Daugherty wrote:

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

Hi Mandy, On 28/05/2020 2:13 pm, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.01/ I modify this patch to check the class file version and throws CFE if unsupported before creating ClassReader.  This also fixes JDK-8245061 that it reads

8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi, Please find an almost trivial fix for: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space" https://bugs.openjdk.java.net/browse/JDK-8245867 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.00/ My new test for JDK-8239013 has

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi Daniel, The change looks reasonable. Thank you for addressing so quickly. Best Lance > On May 28, 2020, at 4:50 AM, Daniel Fuchs wrote: > > Hi, > > Please find an almost trivial fix for: > > 8245867: Logger/bundleLeak/BundleTest.java fails due > to "OutOfMemoryError: Java heap

RFR 8246050: Improve scalability of MemoryScope

Hi, during the review of [1] it emerged that the implementation of the memory scope abstraction (which is used to keep track of temporal scope of a memory segment) does not scale well in situations where there is a lot of contention on the acquire() method due to many threads working

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 5/28/20 6:55 AM, Alan Bateman wrote: On 28/05/2020 05:13, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.01/ I modify this patch to check the class file version and throws CFE if unsupported before creating ClassReader.  This also

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 28/05/2020 05:13, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.01/ I modify this patch to check the class file version and throws CFE if unsupported before creating ClassReader.  This also fixes JDK-8245061 that it reads the value of

Re: RFR: JDK-8225056 VM support for sealed classes

Hi Harold, On 5/27/20 1:35 PM, Harold Seigel wrote: Incremental webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.incr.2/ full webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.2/webrev/ Class.java 4406 ReflectionData rd = reflectionData(); 4407

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 28/05/2020 18:25, Mandy Chung wrote: : The runtime will ensure if --enable-preview is set if a class file with minor is loaded.   I will prefer to keep VM::isSupportedClassFileVersion to validate the given major/minor version.  At runtime, it will fail when such class file is loaded if

RFR 8246095: Tweaks to memory access API

Hi, this followup change includes a number of tweaks that have been added to the memory access API while we were in the process of integrating it. Most of them have been contributed by Chris (thanks!), and are all listed in great details in the CSR below:

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 5/28/20 12:44 AM, David Holmes wrote: Hi Mandy, On 28/05/2020 2:13 pm, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.01/ I modify this patch to check the class file version and throws CFE if unsupported before creating ClassReader. 

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

On 5/28/20 12:13 PM, Lance Andersen wrote: Thinking about: - @deprecated The RMI Activation mechanism has been deprecated, and it may + * be removed from a future version. Perhaps it might be a bit clearer to say “… from a future Java SE version”?  I realize that is different

Re: RFR 8246050: Improve scalability of MemoryScope

+1 (previously reviewed on the panama-dev list) It’s very pleasing to see this get simplified through some good collaboration. StampedLock is quite powerful, and likely an under utilized resource. Paul. > On May 28, 2020, at 4:20 AM, Maurizio Cimadamore > wrote: > > Hi, > during the review

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

I've updated the webrev a little bit in response to previous comments: http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.1/ I've also drafted a CSR request and a release note. Please review: CSR: https://bugs.openjdk.java.net/browse/JDK-8245860 Release Note:

Re: RFR 8246050: Improve scalability of MemoryScope

StampedLock iis a sharp knife, hard to use well, but an excellent tool for low-level performance work. On Thu, May 28, 2020 at 10:56 AM Paul Sandoz wrote: > > +1 (previously reviewed on the panama-dev list) > > It’s very pleasing to see this get simplified through some good > collaboration.

Re: RFR 15 (S): 8245068: Implement Deprecation of RMI Activation

Hi Stuart I think your changes read fine. > On May 28, 2020, at 1:34 PM, Stuart Marks wrote: > > I've updated the webrev a little bit in response to previous comments: > >http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.1/ Thinking about: - @deprecated The RMI

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

Hi Mandy, On 29/05/2020 3:28 am, Mandy Chung wrote: On 5/28/20 12:44 AM, David Holmes wrote: Hi Mandy, On 28/05/2020 2:13 pm, Mandy Chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.01/ I modify this patch to check the class file version and

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

Hi, just noticed a small thing: The magic is 4 bytes, but readUnsignedShort reads two bytes. - Johannes On 28-May-20 19:25, Mandy Chung wrote: On 5/28/20 6:55 AM, Alan Bateman wrote: On 28/05/2020 05:13, Mandy Chung wrote: Updated webrev:

Re: RFR: JDK-8225056 VM support for sealed classes

Hi Harold, Sorry Mandy's comment raised a couple of issues ... On 29/05/2020 7:12 am, Mandy Chung wrote: Hi Harold, On 5/27/20 1:35 PM, Harold Seigel wrote: Incremental webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.incr.2/ full webrev:

Re: RFR: JDK-8225056 VM support for sealed classes

Thanks for confirming it. Mandy On 5/28/20 3:31 PM, Harold Seigel wrote: Hi Mandy, The entries in the PermittedSubclasses attribute are constant pool ConstantClass_info entries.  These names get validated by the VM in this code in ClassFileParser::parse_constant_pool():   for (index

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 5/28/20 5:44 PM, David Holmes wrote: This is to validate the given version.  The runtime will check if preview feature is enabled when such class file is loaded. I will make a comment to make it clear. Okay but I thought the intent here was to pre-validate the version information so

Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 29/05/2020 1:52 pm, Mandy Chung wrote: On 5/28/20 5:44 PM, David Holmes wrote: This is to validate the given version.  The runtime will check if preview feature is enabled when such class file is loaded. I will make a comment to make it clear. Okay but I thought the intent here was to

Re: RFR: JDK-8225056 VM support for sealed classes

Hi Mandy, The entries in the PermittedSubclasses attribute are constant pool ConstantClass_info entries.  These names get validated by the VM in this code in ClassFileParser::parse_constant_pool():   for (index = 1; index < length; index++) {     const jbyte tag =

Re: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space"

Hi Daniel, This caught my eye ... On 28/05/2020 6:50 pm, Daniel Fuchs wrote: Hi, Please find an almost trivial fix for: 8245867: Logger/bundleLeak/BundleTest.java fails due to "OutOfMemoryError: Java heap space" https://bugs.openjdk.java.net/browse/JDK-8245867 webrev: