Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Vipin, I'm happy to sponsor this and any related changes. Let me know if you need help with anything. Best, Julia On 26/08/2020 17:55, Daniel Fuchs wrote: Hi Vipin, This looks good to me. Make sure to generate the API docs locally and eyeball them to double check that nothing is amiss.

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

Thanks for the review Max. Comments inline.. On 27/08/2020 14:45, Weijun Wang wrote: I’m OK with using one warning, but prefer it to a little more formal like "POSIX file permission and/or symlink attributes detected…”. One nit in ZipFile.java: 1098 // only set posix perms

Re: RFR 8251989: Hex formatter and parser utility

Roger, > On 27 Aug 2020, at 02:34, Roger Riggs wrote: > > Please review updates to the formatting and parsing API based on the last > round of comments. > There are many changes, so it may be useful to read it as a fresh draft. > > - Rename classes: Encoder -> Formatter; Decoder -> Parser >

Re: RFR 8251989: Hex formatter and parser utility

The meaning of prefix and suffix is not specified in formatter​(boolean uppercase, String delimiter,String prefix, String suffix). It isn't specified whether they precede and follow the entire formatted value or each byte. The class comment clarifies but I shouldn't have to go there to discover

Re: [16] RFR: 8251182: Fix "no comment" warnings in java.naming

Roger, Lance, Daniel, Thanks for your reviews. With Best Regards, Aleksei On 26/08/2020 16:59, Lance Andersen wrote: +1 On Aug 26, 2020, at 7:46 AM, Aleks Efimov > wrote: Hi Roger, Lance, Daniel, Thanks for your reviews and comments! New webrev with

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

I’m OK with using one warning, but prefer it to a little more formal like "POSIX file permission and/or symlink attributes detected…”. One nit in ZipFile.java: 1098 // only set posix perms value via ZipEntry constructor for now 1099 @Override 1100

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

updated webrev: http://cr.openjdk.java.net/~coffeys/webrev.8250968.v2/webrev/ regards, Sean. On 27/08/2020 07:42, Seán Coffey wrote: Hi Max, I looked at updating the warning string but figured that it might have been of no interest to end users. How about this edit then ? +   

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

Hi Max, I looked at updating the warning string but figured that it might have been of no interest to end users. How about this edit then ? +    {"posix.attributes.detected", "POSIX file permission attributes detected. These attributes are ignored when signing and are not protected by

Re: RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

Thanks Sean, updated webrev here: http://cr.openjdk.java.net/~fguallini/8249699/webrev.01/ Regards, Fernando - Original Message - From: sean.cof...@oracle.com To: fernando.guall...@oracle.com, core-libs-dev@openjdk.java.net Sent: Wednesday, 26 August, 2020 7:39:25 PM GMT +00:00 GMT

Re: RFR 8251989: Hex formatter and parser utility

Hi Chris, On 8/27/20 9:20 AM, Chris Hegarty wrote: Roger, On 27 Aug 2020, at 02:34, Roger Riggs wrote: Please review updates to the formatting and parsing API based on the last round of comments. There are many changes, so it may be useful to read it as a fresh draft. - Rename classes:

Re: RFR 8214761 : Bug in parallel Kahan summation implementation

Bump... I've run in to this while running tests that check computation results against the expected bounds of a Kahan summation. Any chance that this gets picked up in the near future? Thanks, Chris On 12/13/18, 6:16 PM, "core-libs-dev on behalf of Ivan Gerasimov" wrote: Gentle

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

Hi Sean, I think the changes are OK in the latest version. A couple of the files have a 2019 copyright still. > On Aug 27, 2020, at 10:58 AM, Weijun Wang wrote: > > > >> On Aug 27, 2020, at 10:36 AM, Seán Coffey wrote: >> >> Thanks for the review Max. Comments inline.. >> >> On

Re: RFR 8251989: Hex formatter and parser utility

Hi Roger, About methods in Hex.Formatter that append to StringBuilder, like the following one:     public StringBuilder format​(StringBuilder sb, byte[] bytes) ...I was thinking that such method could have more utility if it was specified as:     public A format(A appendable, byte[]

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

> On Aug 27, 2020, at 10:36 AM, Seán Coffey wrote: > > Thanks for the review Max. Comments inline.. > > On 27/08/2020 14:45, Weijun Wang wrote: >> I’m OK with using one warning, but prefer it to a little more formal like >> "POSIX file permission and/or symlink attributes detected…”. >> >>

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

Hi Corey, > If I make a requirement, I feel decode0 should check that the > requirement is met, and raise some kind of internal error if it isn't. > That actually was my first implementation, but I received some comments > during an internal review suggesting that I just "round down" the >

Re: RFR 8252265: Replace @exception with @throws java.util.logging package

Hi Daniel, > On Aug 26, 2020, at 10:25 PM, Daniel Fuchs wrote: > > Hi Vipin, > > This looks good to me. > Make sure to generate the API docs locally and eyeball them to > double check that nothing is amiss. Checked API docs, it doesn’t have any change. Regards, Vipin

Re: RFR 8251989: Hex formatter and parser utility

Hi Peter, I made the same observation when exploring the API and ended up concluding that the declared exceptions on Appendable made the API much harder to use. Though the formatted characters can't be directly accumulated in the Appendable it is possible to build the output in a StringBuilder

Re: RFR 8251989: Hex formatter and parser utility

Hi Douglas, On 8/27/20 10:37 AM, Douglas Surber wrote: The meaning of prefix and suffix is not specified in formatter​(boolean uppercase, String delimiter,String prefix, String suffix). It isn't specified whether they precede and follow the entire formatted value or each byte. The class

[PATCH] optimization opportunity regarding misuse of BufferedInputStream

Hi, while looking into java.util.jar.JarInputStream I've found a misuse of BufferedInputStream in checkManifest() method where InputStream is wrapped into BIS and later read from with separately created byte[] buffer. At runtime this means the data is copied from original IS into BIS and from