- cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
volatile, even in case of race in the worst case it is recalculated at most
once per thread
- `defaultLocale` field is read multiple times in `initDefault()`
- `isoLanguages` is accessed multiple times in `getISOLanguages()`
On Mon, 6 Jun 2022 12:58:39 GMT, Сергей Цыпанов wrote:
> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
> volatile, even in case of race in the worst case it is recalculated at most
> once per thread
> - `defaultLocale` field is read multiple times in `initDefault()`
>
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
On Mon, 6 Jun 2022 13:32:21 GMT, liach wrote:
>> Shouldn't the fields annotated with `@Stable` be `final` as well?
>
> These fields can only be written once besides the default values, but they
> don't have to be written in the static initializer or constructor. So when a
> non-zero hash code
On Mon, 6 Jun 2022 13:28:44 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/util/Locale.java line 2260:
>>
>>> 2258: * Calculated hashcode
>>> 2259: */
>>> 2260: private transient volatile int hashCodeValue;
>>
>> We can additionally annotate such cache fields with
On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov wrote:
> Hashtable doesn't allow `null` values. So, instead of pair
> `containsKey`/`remove` calls, we can directly call `remove` and then compare
> result with `null`.
>
On Mon, 6 Jun 2022 13:20:31 GMT, liach wrote:
>> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
>> volatile, even in case of race in the worst case it is recalculated at most
>> once per thread
>> - `defaultLocale` field is read multiple times in `initDefault()`
>> -
On Thu, 2 Jun 2022 03:27:59 GMT, Xiaohong Gong wrote:
>> Currently the vector load with mask when the given index happens out of the
>> array boundary is implemented with pure java scalar code to avoid the IOOBE
>> (IndexOutOfBoundaryException). This is necessary for architectures that do
>>
On Wed, 1 Jun 2022 10:37:23 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote:
> 8250950: Allow per-user and system wide configuration of a jpackaged app
This pull request has now been integrated.
Changeset: c37c8e5d
Author:Alexey Semenyuk
URL:
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf wrote:
> This adds a regression test for a recent fix (JDK-8287073). I've restructured
> the linux specific JDK code to call a separate static function to enable this
> test. It'll help future tests too.
>
> Testing:
> - [x] Container tests
Hi Jai,
The error
java.lang.OutOfMemoryError: Java heap space
indicates that the VM really has run out of memory. Presumably if you increased the
heap size, it would actually be able to allocate that memory. You might have to add
the /othervm test directive and add JVM options to require
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly
On Mon, 6 Jun 2022 21:58:20 GMT, Mandy Chung wrote:
> A typo in ForceGC.java causes several test failing due to compilation error.
Thumbs up. This is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/9043
On Mon, 6 Jun 2022 21:58:20 GMT, Mandy Chung wrote:
> A typo in ForceGC.java causes several test failing due to compilation error.
thanks for the prompt review.
-
PR: https://git.openjdk.java.net/jdk/pull/9043
I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2].
Naoto Sato has been on the Core Libraries team for over a decade and has contributed
hundreds of changes to the JDK project [3]. His most significant recent contribution
is JEP 400: UTF-8 by Default [4]. Naoto is
Vote yes
Iris
From: core-libs-dev on behalf of Stuart
Marks
Sent: Monday, June 6, 2022 5:52 PM
To: core-libs-dev
Subject: CVF: new Core Libraries Group member: Naoto Sato
I hereby nominate Naoto Sato [1] to membership in the Core Libraries Group [2].
Naoto
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond
On Thu, 2 Jun 2022 08:22:11 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/Math.java line 823:
>>
>>> 821: * @apiNote
>>> 822: * This method corresponds to the convertTowardPositive operation
>>> 823: * defined in IEEE 754.
>>
>> Probably what is meant
On Mon, 6 Jun 2022 21:58:20 GMT, Mandy Chung wrote:
> A typo in ForceGC.java causes several test failing due to compilation error.
This pull request has now been integrated.
Changeset: a50b06e8
Author:Mandy Chung
URL:
On Tue, 31 May 2022 16:48:27 GMT, Paul Sandoz wrote:
>> @PaulSandoz, could you please help to check whether the current version is
>> ok for you? Thanks so much!
>
> @XiaohongGong looks good, now the Vector API JEP has been integrated you will
> get a merge conflict, but it should be easier to
> Currently the vector load with mask when the given index happens out of the
> array boundary is implemented with pure java scalar code to avoid the IOOBE
> (IndexOutOfBoundaryException). This is necessary for architectures that do
> not support the predicate feature. Because the masked load
On Mon, 6 Jun 2022 10:40:45 GMT, Jatin Bhateja wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge branch 'jdk:master' into JDK-8283667
>> - Use integer constant for offsetInRange
A typo in ForceGC.java causes several test failing due to compilation error.
-
Commit messages:
- JDK-8287867: Bad merge of jdk/test/lib/util/ForceGC.java causing compilation
error
Changes: https://git.openjdk.java.net/jdk/pull/9043/files
Webrev:
8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
flags is used
-
Commit messages:
- 8287760: Keep do-not-resolve-by-default flag
Changes: https://git.openjdk.java.net/jdk/pull/9049/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9049=00
On Mon, 6 Jun 2022 22:24:03 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull request incrementally with
On Mon, 6 Jun 2022 15:41:06 GMT, Paul Sandoz wrote:
> Looks good. As a follow on PR I think it would be useful to add constants
> `OFFSET_IN_RANGE` and `OFFSET_OUT_OF_RANGE`, then it becomes much clearer in
> source and you can drop the `/* offsetInRange */` comment on the argument.
Hi
Vote: yes
-joe
On 6/6/2022 5:52 PM, Stuart Marks wrote:
I hereby nominate Naoto Sato [1] to membership in the Core Libraries
Group [2].
Naoto Sato has been on the Core Libraries team for over a decade and
has contributed hundreds of changes to the JDK project [3]. His most
significant
Hi Michael,
See below.
On Jun 5, 2022, at 5:58 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
./build/*/images/jdk/bin/jpackage --app-image
~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign
--mac-signing-key-user-name "Developer ID Application: Michael Hall
(5X6BXQB3Q7)"
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev
Hi Michael,
Printing "Warning: Using unsigned app-image to build signed dmg.” with signed
application should be fixed with JDK-8286850. Did you reproduce it on build
containing JDK-8286850?
Thanks,
Alexander
> On Jun 5, 2022, at 3:06 PM, Michael Hall wrote:
>
>
>
>> On Jun 5, 2022, at
On Mon, 6 Jun 2022 23:07:06 GMT, Ioi Lam wrote:
> We should try to consolidate these test cases to improve maintainability.
I filed [JDK-8287185](https://bugs.openjdk.org/browse/JDK-8287185)
-
PR: https://git.openjdk.java.net/jdk/pull/8993
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf wrote:
> This adds a regression test for a recent fix (JDK-8287073). I've restructured
> the linux specific JDK code to call a separate static function to enable this
> test. It'll help future tests too.
>
> Testing:
> - [x] Container tests
On Tue, 10 May 2022 01:23:55 GMT, Xiaohong Gong wrote:
> Checking whether the indexes of masked lanes are inside of the valid memory
> boundary is necessary for masked vector memory access. However, this could be
> saved if the given offset is inside of the vector range that could make sure
>
In a recent enhancement we added new APIs to construct LinkedHashMap,
HashMap and WeakHashMap instances as part of
https://bugs.openjdk.java.net/browse/JDK-8186958.
Since we missed adding tests for that change, I have been working on
adding some basic tests for this change as part of
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed missing BufferedInputStream
Can this PR be closed or returned to daft?
On Sun, 5 Jun 2022 21:19:37 GMT, Joe Darcy wrote:
> Various code blocks in Float and Double would be better as snippets.
src/java.base/share/classes/java/lang/Double.java line 643:
> 641: * expression below can be used to screen the input string:
> 642: *
> 643: * {@snippet
> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
> volatile, even in case of race in the worst case it is recalculated at most
> once per thread
> - `defaultLocale` field is read multiple times in `initDefault()`
> - `isoLanguages` is accessed multiple times in
On Mon, 6 Jun 2022 13:34:27 GMT, liach wrote:
>> These fields can only be written once besides the default values, but they
>> don't have to be written in the static initializer or constructor. So when a
>> non-zero hash code is written, it's cached as if it's a final field. For a
>> zero
On Mon, 6 Jun 2022 14:58:25 GMT, Thiago Henrique Hüpner
wrote:
>> 8287353: Use snippet tag instead of pre tag in Javadoc of
>> InterruptedException
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update
On Thu, 2 Jun 2022 03:27:59 GMT, Xiaohong Gong wrote:
>> Currently the vector load with mask when the given index happens out of the
>> array boundary is implemented with pure java scalar code to avoid the IOOBE
>> (IndexOutOfBoundaryException). This is necessary for architectures that do
>>
> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a
> rounding error to accumulate at the tail of the distribution (probably
> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes
> that by tracking the multiple of exponentialX0 as a long. (This
On Thu, 2 Jun 2022 03:00:32 GMT, Chris Hennick wrote:
>> Chris Hennick has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
On Fri, 3 Jun 2022 16:48:46 GMT, Naoto Sato wrote:
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
On Sat, 4 Jun 2022 11:27:00 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed per suggestion
>
> src/java.base/share/classes/java/lang/String.java line 849:
>
>> 847: int en =
On Wed, 27 Apr 2022 13:33:29 GMT, Thiago Henrique Hüpner
wrote:
>> 8287353: Use snippet tag instead of pre tag in Javadoc of
>> InterruptedException
>
> If this is a valid change, could someone please create a Jira issue to link
> to it?
Hello @Thihup, overall this change looks fine to me.
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed missing BufferedInputStream
I think we should turn it back to draft.
Hi,
(1)
float f = Float.intBitsToFloat(260046848);
JDK 17: Float.toString(f) -> 1.26217745E-29
master: Float.toString(f) -> 1.2621775E-29
BigDecimal.valueOf(Float.intBitsToFloat(260046847)) -> 1.2621773731219804E-29
BigDecimal.valueOf(Float.intBitsToFloat(260046848)) -> 1.2621774483536189E-29
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Update copyright year
-
Changes:
- all:
On Wed, 27 Apr 2022 13:33:29 GMT, Thiago Henrique Hüpner
wrote:
>> 8287353: Use snippet tag instead of pre tag in Javadoc of
>> InterruptedException
>
> If this is a valid change, could someone please create a Jira issue to link
> to it?
@Thihup Please do not rebase or force-push to an
On Thu, 2 Jun 2022 01:29:54 GMT, Xiaohong Gong wrote:
>> Checking whether the indexes of masked lanes are inside of the valid memory
>> boundary is necessary for masked vector memory access. However, this could
>> be saved if the given offset is inside of the vector range that could make
>>
> The code path calls `String.getBytesNoRepl()`, but it blindly replaces
> unmappable characters with replacements if the encoder is an `ArrayEncoder`.
> Changed only to do so if `doReplace` is `true` in
> `String.encodeWithEncoder()`.
Naoto Sato has updated the pull request incrementally with
On 2022-06-05 09:59, LP wrote:
Hi,
(1)
float f = Float.intBitsToFloat(260046848);
JDK 17: Float.toString(f) -> 1.26217745E-29
master: Float.toString(f) -> 1.2621775E-29
BigDecimal.valueOf(Float.intBitsToFloat(260046847)) -> 1.2621773731219804E-29
> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
> volatile, even in case of race in the worst case it is recalculated at most
> once per thread
> - `defaultLocale` field is read multiple times in `initDefault()`
> - `isoLanguages` is accessed multiple times in
On Mon, 6 Jun 2022 20:19:22 GMT, Сергей Цыпанов wrote:
>> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
>> volatile, even in case of race in the worst case it is recalculated at most
>> once per thread
>> - `defaultLocale` field is read multiple times in
On Mon, 6 Jun 2022 14:36:03 GMT, Сергей Цыпанов wrote:
>> - cached hash code of `Locale` and `Locale$LanguageRange` shouldn't be
>> volatile, even in case of race in the worst case it is recalculated at most
>> once per thread
>> - `defaultLocale` field is read multiple times in
On Wed, 1 Jun 2022 21:09:15 GMT, Mandy Chung wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> back to wait 1 second
>
> No, it doesn't work. You can build a fastdebug build with `configure
>
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request with a
On Mon, 6 Jun 2022 17:31:15 GMT, Naoto Sato wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8287860: Mark hash fields with @Stable
>
> src/java.base/share/classes/java/util/Locale.java line 1084:
>
>> 1082:
On Mon, 6 Jun 2022 20:37:07 GMT, Joe Darcy wrote:
>> Various code blocks in Float and Double would be better as snippets.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Use idiom for shorter lines
> - Respond to review
On Mon, 6 Jun 2022 05:29:24 GMT, Alan Bateman wrote:
> One other thing you could do is link Pattern.matches in the snippet to the
> matches method.
Suggestion made in subsequent push; thanks.
> src/java.base/share/classes/java/lang/Double.java line 683:
>
>> 681: *
> Various code blocks in Float and Double would be better as snippets.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Use idiom for shorter lines
- Respond to review feedback.
-
Changes:
- all:
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung wrote:
> This reapplies JDK-8287384 and adjust the number of GCs for negative case,
> i.e. the condition is never met that is used to verify a reference is not
> GC'ed.
JDK-8287384 affects the tests using ForceGC for negative cases only. It will
On Fri, 3 Jun 2022 23:56:31 GMT, Joe Wang wrote:
>> Adjust how XPath operators are counted to improve accuracy. This change does
>> not affect how XPath works.
>>
>> Test:
>> Tier2 passed;
>> JCK XML tests passed.
>
> Joe Wang has updated the pull request incrementally with one
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly
On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk wrote:
> 8250950: Allow per-user and system wide configuration of a jpackaged app
@sashamatveev please resume the review
-
PR: https://git.openjdk.java.net/jdk/pull/9025
> 8250950: Allow per-user and system wide configuration of a jpackaged app
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Add TKit.createDirectories() method that will delete created nonexistent
directories.
-
On Mon, 6 Jun 2022 20:37:11 GMT, Alexey Semenyuk wrote:
>> 8250950: Allow per-user and system wide configuration of a jpackaged app
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add TKit.createDirectories() method
On Sun, 29 May 2022 20:22:55 GMT, Andrey Turbanov wrote:
> In [JDK-8273098](https://bugs.openjdk.java.net/browse/JDK-8273098) I missed
> one place, where Vector could be replaced with ArrayList.
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if
On Wed, 20 Apr 2022 19:16:00 GMT, Andrey Turbanov wrote:
> 1. No need to call `String.substring` if you need need to compare start of
> string with some constant. `String.startWith` suites better.
> 2. Unused String array is allocated in `childrenNamesSpi` method
Thank you for review!
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung wrote:
> This reapplies JDK-8287384 and adjust the number of GCs for negative case,
> i.e. the condition is never met that is used to verify a reference is not
> GC'ed.
This pull request has now been integrated.
Changeset: 2e332c27
Author:
On Sun, 29 May 2022 20:22:55 GMT, Andrey Turbanov wrote:
> In [JDK-8273098](https://bugs.openjdk.java.net/browse/JDK-8273098) I missed
> one place, where Vector could be replaced with ArrayList.
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if
On Wed, 20 Apr 2022 19:16:00 GMT, Andrey Turbanov wrote:
> 1. No need to call `String.substring` if you need need to compare start of
> string with some constant. `String.startWith` suites better.
> 2. Unused String array is allocated in `childrenNamesSpi` method
This pull request has now been
On Sun, 5 Jun 2022 21:19:37 GMT, Joe Darcy wrote:
> Various code blocks in Float and Double would be better as snippets.
This pull request has now been integrated.
Changeset: 0e06bf3b
Author:Joe Darcy
URL:
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request with a
75 matches
Mail list logo
