RFR 8067437: New tests for mJRE feature removal.

Please review new tests for the java launcher. New tests in MultipleJRE.java includes: 1. java -help must not contain information about obsolete flags "-version:", "-jre-restrict-search", "-jre-no-restrict-search" 2. java should emit error if obsolete flag is specified (combo test) 3. java sho

Re: RFR 8067437: New tests for mJRE feature removal.

Hi Kumar, I've updated patch with your comments. http://cr.openjdk.java.net/~anazarov/8067437/webrev.02/ Also see comments inline. Thank you for review. On 23.12.2014 18:28, Kumar Srinivasan wrote: Missed clarifying this, I will be sponsoring this patch. Kumar On 12/23/2014 7:26 AM, Kumar Sr

List.indexOf and List.lastIndexOf lambda version.

Hi everyone, I there any reason why java.util.List doesn't have lambda versions of indexOf and lastIndexOf methods like list.indexOf(Predicate<>) ? --Thanks, Andrey

RFR: JDK-8157850 Jar tests should pass through VM options

Some jar tests start VMs without passing vmoptions from jtreg. This fix pass jtreg's vmoptions and javaoptions to processes(java, jar, javac) started by tests. webrev: http://cr.openjdk.java.net/~anazarov/8157850/webrev.01/ jbs: https://bugs.openjdk.java.net/browse/JDK-8157850 --Andrey

Re: RFR: JDK-8157850 Jar tests should pass through VM options

we need some framework which will pass options for us. It’s common problem not passing through VM options. > > --- > > > On Wed, May 25, 2016 at 9:07 AM, Andrey Nazarov > wrote: >> Some jar tests start VMs without passing vmoptions from jtreg. >> >> This fix pass jtr

Re: RFR: JDK-8157850 Jar tests should pass through VM options

--- Maybe splitting on "\\s+" would be better. --- I think we should have test library methods to return the List for java subprocesses, one that could try hard to get the option tokenization correct. --- On Wed, May 25, 2016 at 9:07 AM, Andrey Nazarov wrote: Some jar tests star

Re: RFR: JDK-8157850 Jar tests should pass through VM options

Any updates, guys? --Andrey On 26.05.2016 19:20, Andrey Nazarov wrote: Thanks for feedback guys. I've updated review http://cr.openjdk.java.net/~anazarov/8157850/webrev.02/ Please sponsor this patch if you are OK. My use case is to run tests with different -Xms and -Xmx options. M

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, Looks OK to me. I can suggest two more cases. A directory and file symlink can be passed in options where tool requires a file path. —Andrey > On 8 Nov 2016, at 16:17, Denis Kononenko wrote: > > > Hi, > > The new version of changes. > > - Switched back to jdk/test/testlibrary to avoid

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, Looks OK. Is it 100% pass rate? —Andrey > On 9 Nov 2016, at 20:36, Denis Kononenko wrote: > > > > Hi, > > After discussion with Andrey we decided to add more tests for corner cases. > The new changes are available by the link below. > > WEBREV: http://cr.openjdk.java.net/~dkononenko/8

RFR: JDK-8161348 Several tools/jlink tests failed due to time out

Hi, please review Jlink tests. I’ve increased default timeout to 5 minutes and skip tests in “-Xcomp” VM mode. CR: http://cr.openjdk.java.net/~anazarov/JDK-8161348/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8161348

Re: RFR: JDK-8161348 Several tools/jlink tests failed due to time out

arlier @requires guard > for an amount of memory on the system? I think it should. Although it’s not related to the original issue, i’ll update patch with @requires > > Cheers, > > -Joe > > On 1/22/2018 12:58 PM, Andrey Nazarov wrote: >> Hi, >> please review Jl

Re: RFR: JDK-8161348 Several tools/jlink tests failed due to time out

> On 22 Jan 2018, at 15:33, Andrey Nazarov wrote: > > > >> On 22 Jan 2018, at 13:07, Joseph D. Darcy wrote: >> >> Hello, >> >> I'm wary of increasing the timeout to 5 minutes. When such tests are run on >> CI servers, the effect

Re: RFR: JDK-8161348 Several tools/jlink tests failed due to time out

/ —Andrei > On 22 Jan 2018, at 16:12, Andrey Nazarov wrote: > > > >> On 22 Jan 2018, at 15:33, Andrey Nazarov wrote: >> >> >> >>> On 22 Jan 2018, at 13:07, Joseph D. Darcy wrote: >>> >>> Hello, >>> >>> I&

RFR: 8186009 tools launcher test AddExportsAndOpensInManifest.java fails intermittently: AccessDeniedException

Hi, Could you review fix in launcher tests. Fix changes “file.jar” name to unique name for every test case. It eliminates dependency between test cases on the file. http://cr.openjdk.java.net/~anazarov/JDK-8186009/webrev.03 https://

Re: RFR: 8186009 tools launcher test AddExportsAndOpensInManifest.java fails intermittently: AccessDeniedException

at 16:05, Andrey Nazarov wrote: > > Hi, > > Could you review fix in launcher tests. Fix changes “file.jar” name to unique > name for every test case. It eliminates dependency between test cases on the > file. > > http://cr.openjdk.java.net/~anazarov/JDK-8186009/webrev.

RFR: 8179294 several langtools tests depend on jar but do not declare that dependency

Hi, Please review fix which adds absent module dependencies in Pack200 and Jlink tests. http://cr.openjdk.java.net/~anazarov/JDK-8179294/webrev.00 https://bugs.openjdk.java.net/browse/JDK-8179294 —Thanks, Andrei

Re: RFR: 8179294 several langtools tests depend on jar but do not declare that dependency

Added test from duplicated issue http://cr.openjdk.java.net/~anazarov/JDK-8179294/webrev.01/ <http://cr.openjdk.java.net/~anazarov/JDK-8179294/webrev.01/> —Andrei > On 26 Jan 2018, at 15:17, Andrey Nazarov wrote: > > Hi, > > Please review fix which adds absent module de

RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

Hi, Please review fix in launcher tests. Review: http://cr.openjdk.java.net/~anazarov/JDK-8196750/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196750?filter=-1 —Thanks, Andrei

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

> maybe more comments explaining what is going on ? Added more comments. see http://cr.openjdk.java.net/~anazarov/JDK-8196750/webrev.02/ > > Kumar > > >> Hi Andrei, >> >> On 22/03/2018 11:12 AM, Andrey Nazarov wrote: >>> Hi, >>> >>> P

RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

Hi, Please review fix in Jlink test. The fix is to close the Stream which works with a file system. Review: http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01 JBS: https://bugs.openjdk.java.net/browse/JDK-8178867 —Thanks, And

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

Anyone? > On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: > > Hi, > > Please review fix in Jlink test. The fix is to close the Stream which works > with a file system. > > Review: http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01 > <http://cr.openjdk.

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

> On 10 Apr 2018, at 11:47, Alan Bateman wrote: > > On 10/04/2018 19:44, Andrey Nazarov wrote: >> Anyone? >> >>> On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: >>> >>> Hi, >>> >>> Please review fix in Jlink test.

RFR 8197388: Added not existing bug id in jdk/ProblemList.txt

Hi, Please review patch that fixes typo in bug id. diff -r 3661f31c6df4 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Thu Apr 26 11:19:05 2018 -0500 +++ b/test/jdk/ProblemList.txt Thu Apr 26 11:47:18 2018 -0700 @@ -243,7 +243,7 @@ sun/java2d/SunGraphics2D/EmptyClipRenderingTest.java

Re: RFR 8197388: Added not existing bug id in jdk/ProblemList.txt

Hi, Could you CC any client alias? —Thanks, Andrei > On 26 Apr 2018, at 11:51, Andrey Nazarov wrote: > > Hi, > > Please review patch that fixes typo in bug id. > > diff -r 3661f31c6df4 test/jdk/ProblemList.txt > --- a/test/jdk/ProblemList.txt Thu Apr 26 11:19:05

Re: [9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

Hi, Looks OK to me. —Andrey > On 22 Nov 2016, at 15:51, Denis Kononenko wrote: > > > Hi, > > Could someone please review this small fix. > > Recently several failing test cases were delivered into jdk9-dev by my > mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just rename

Re: RFR 8171441: tools/launcher/VersionCheck.java doesn't report names of tools which failed checks

Hi, 2 minor comments. bug id has not been added “@bug 8171441” javadoc should start with /** not 152 /* —Andrey > On 26 Dec 2016, at 17:40, Stanislav Smirnov > wrote: > > Hi, > > thanks, looks good > > Best regards, > Stanislav Smirnov > > > > > >> On 23 Dec 2016, at 19:13, Dmitry Fa

Re: RFR 8171441: tools/launcher/VersionCheck.java doesn't report names of tools which failed checks

> On 26 Dec 2016, at 18:36, Dmitry Fazunenenko > wrote: > > Hi Andrey, > > On 26.12.2016 17:53, Andrey Nazarov wrote: >> Hi, >> >> 2 minor comments. >> bug id has not been added “@bug 8171441” > I believe the purpose of the @bug tag is to list t

RFR: 8071566 Improve testing for multi-version JAR file maker tool

Hi, Following tests for Jar tool were added: Tests for API validator. Jar tool should detect API changes between releases. Test for custom manifest file. Test for version format in --release option Also refactoring of existing tests was made: 1. Common base class “MRTestBase.java” was extract

Re: RFR: 8071566 Improve testing for multi-version JAR file maker tool

Thanks for review. I’ve update patch http://cr.openjdk.java.net/~anazarov/8071566/webrev.01/ —Andrey > On 3 Jan 2017, at 14:25, Chris Hegarty wrote: > > Andrey, > >> On 30 Dec 2016, at 14:11, Andrey Nazarov wrote: >> >> Hi, >> >> Following tests

Re: RFR: 8071566 Improve testing for multi-version JAR file maker tool

> On 18 Jan 2017, at 17:59, Chris Hegarty wrote: > > >> On 17 Jan 2017, at 15:33, Andrey Nazarov wrote: >> >> Thanks for review. I’ve update patch >> http://cr.openjdk.java.net/~anazarov/8071566/webrev.01/ > > I think this is ok. Thanks > > -C

RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

Hi, I’ve added sanity checks that wsgen and schemagen tools works with multi-release jar files. Review http://cr.openjdk.java.net/~anazarov/8075617/webrev.00/webrev/ JBS: https://bugs.openjdk.java.net/browse/JDK-8075616 , https://bugs.openjdk.

Re: RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

> On 25 Jan 2017, at 18:03, Alan Bateman wrote: > > On 25/01/2017 14:45, Andrey Nazarov wrote: > >> Hi, >> >> I’ve added sanity checks that wsgen and schemagen tools works with >> multi-release jar files. >> >> Review http://cr.openjdk.java.ne

Re: RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

> On 25 Jan 2017, at 19:00, Alan Bateman wrote: > > On 25/01/2017 15:25, Andrey Nazarov wrote: > >> : >> What is the right location? > These tools are maintained in the upstream Metro project, I suspect the tests > for these tools are located there too but I&#x

RFR: 8173372 Add tests for multi-release module jar API validator

Hi, I’ve added tests to check what MR Jar API validator handles changes in module-info.class Review: http://cr.openjdk.java.net/~anazarov/8173372/webrev.01/webrev/ JBS: https://bugs.openjdk.java.net/browse/JDK-8173372 —Andrey

Re: RFR: 8173372 Add tests for multi-release module jar API validator

Thank you > On 25 Jan 2017, at 22:19, Paul Sandoz wrote: > > >> On 25 Jan 2017, at 10:54, Andrey Nazarov wrote: >> >> Hi, >> >> I’ve added tests to check what MR Jar API validator handles changes in >> module-info.class >> >> Revie

RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

diff -r f5f50c8d8714 test/ProblemList.txt --- a/test/ProblemList.txt Thu Jan 26 14:32:41 2017 +0300 +++ b/test/ProblemList.txt Thu Jan 26 17:17:02 2017 +0300 @@ -264,6 +264,8 @@ tools/jlink/CustomPluginTest.java 8172864 generic-all +tools/jar/multiReleas

Re: RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

g happen between you writing/running this test locally and > pushing? > > Paul. > >> On 26 Jan 2017, at 06:25, Andrey Nazarov wrote: >> >> >> diff -r f5f50c8d8714 test/ProblemList.txt >> --- a/test/ProblemList.txt Thu Jan 26 14:32:41 2017 +0300

Re: RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

This commit leads to regression http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dfba4c3eb1ac#l4.31 > On 26 Jan 2017, at 19:41, Andrey Nazarov wrote: > > Hi, Paul > > It tested agains a bit outdated java version. It was ok. > After push I've realised there is regressi

Re: RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

Hi Move tests to new place. Please review. http://cr.openjdk.java.net/~anazarov/8075617/webrev.01/webrev/ <http://cr.openjdk.java.net/~anazarov/8075617/webrev.01/webrev/> —Andrey > On 25 Jan 2017, at 19:04, Andrey Nazarov wrote: > > >> On 25 Jan 2017, at 19:00, Alan Bate

Re: RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

Hi, Anyone please review and approve —Andrey > On 26 Jan 2017, at 21:29, Andrey Nazarov wrote: > > Hi > Move tests to new place. Please review. > http://cr.openjdk.java.net/~anazarov/8075617/webrev.01/webrev/ > <http://cr.openjdk.java.net/~anazarov/8075617/webrev.01/

Re: RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

Hi Alan, I moved tests to suggested locations. http://cr.openjdk.java.net/~anazarov/8075617/webrev.02/webrev/ —Andrey > On 1 Feb 2017, at 11:25, Alan Bateman wrote: > > On 31/01/2017 21:45, Lance Andersen wrote: > >> Hi Andrey, >> >> The test looks reasonable. >> >> Assuming Alan has blesse

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, looks ok for me. Simple and safe fix. —Andrey > On 9 Feb 2017, at 13:03, Denis Kononenko wrote: > > > Hi, > >> >> On 06/02/2017 10:27, Denis Kononenko wrote: >>> Hi, >>> >>> Could someone please review this very small fix. >>> >>> The class JImageTask >> (src/jdk.jlink/share/classes/jd

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Looks good > On 13 Feb 2017, at 20:58, Denis Kononenko wrote: > > > Hi, > > Optimized buffer's capacity checks. > > WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > >> >> Could please someone review the fix fo

RFR 8178323: Add negative tests for bind services Jlink feature

Hi, Please review 3 negative tests for Jlink which tests new bind-services/suggest-providers feature. JBS: https://bugs.openjdk.java.net/browse/JDK-8178323 webrev: http://cr.openjdk.java.net/~anazarov/8178323/webrev.00/webrev/

RFR 8174692: New MultiReleaseJarTest.java tests fail in JDK 10

Hi, please review simple one line test fix http://cr.openjdk.java.net/~anazarov/JDK-8174692/webrev.00/webrev/ https://bugs.openjdk.java.net/browse/JDK-8174692 —Andrei

RFR 8177357: tools/jar/multiRelease/ApiValidatorTest.java failed due to "Exception java.nio.file.DirectoryNotEmptyException"

Hi, Could you review simple test fix? http://cr.openjdk.java.net/~anazarov/JDK-8177357/webrev.00/webrev JBS: https://bugs.openjdk.java.net/browse/JDK-8177357 —Thanks, Andrei

Re: RFR 8177357: tools/jar/multiRelease/ApiValidatorTest.java failed due to "Exception java.nio.file.DirectoryNotEmptyException"

> On 18 Jul 2017, at 11:38, Paul Sandoz wrote: > > >> On 17 Jul 2017, at 16:51, Andrey Nazarov wrote: >> >> Hi, >> >> Could you review simple test fix? >> >> http://cr.openjdk.java.net/~anazarov/JDK-8177357/webrev.00/webrev >>

RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

Hi, Could you review fix in test library which should help to resolve intermittent issues on Windows machines during directories clean up. Bug: https://bugs.openjdk.java.net/browse/JDK-8184961 Review: http://cr.openjdk.java.net/~anazarov/JDK

RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

Hi, Please review changes in launcher tests. I’ve added absent @modules jtreg tags. Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ JBS: https://bugs.openjdk.java.net/browse/JDK-8179292 —Andrei

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

Can anyone look? —Thanks, Andrei > On 21 Jul 2017, at 18:35, Andrey Nazarov wrote: > > Hi, > > Please review changes in launcher tests. I’ve added absent @modules jtreg > tags. > > Review: http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.00/webrev/ >

Re: RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

Can anyone look? —Thanks, Andrei > On 19 Jul 2017, at 18:21, Andrey Nazarov wrote: > > Hi, > > Could you review fix in test library which should help to resolve > intermittent issues on Windows machines during directories clean up. > > Bug: https://bugs.openjdk.jav

Re: RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

Thanks, Brian —Andrei > On 25 Jul 2017, at 16:41, Brian Burkhalter > wrote: > > Hi Andrei, > > I think this looks good. > > Thanks, > > Brian > > On Jul 25, 2017, at 3:59 PM, Andrey Nazarov > wrote: > >> Can anyone look? >> >

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

Thanks, Mandy I’ve updated patch http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/ <http://cr.openjdk.java.net/~anazarov/JDK-8179292/webrev.01/webrev/> —Andrei > On 25 Jul 2017, at 16:12, Mandy Chung wrote: > > >> On Jul 21, 2017, at 6:35 PM, Andr

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

> On 25 Jul 2017, at 18:01, Mandy Chung wrote: > > >> On Jul 25, 2017, at 5:29 PM, Andrey Nazarov > <mailto:andrey.x.naza...@oracle.com>> wrote: >> >> Thanks, Mandy >> I’ve updated patch >> http://cr.openjdk.java.net/~anazarov/JDK-817929

Re: RFR 8179292: a number of launcher tests fail when run with --limit-modules due to CNFE: javax.tools.ToolProvider

Thank you! > On 25 Jul 2017, at 18:20, Mandy Chung wrote: > > >> On Jul 25, 2017, at 6:18 PM, Andrey Nazarov > <mailto:andrey.x.naza...@oracle.com>> wrote: >> >> >> Updated by this line. >> http://cr.openjdk.java.net/~anazarov/JDK-817929

Re: RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

ists as >> a style cleanup, so I recommend adding a comment explaining why you’re using >> it. > > As the original author of this code, +1000 Code has been pushed. I’ll create new issue for that :) —Andrei > > -Chris. > > >> Thanks, >> >

Re: RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

> MAX_RETRY_DELETE_TIMES) { —Andrei > On 26 Jul 2017, at 12:45, Andrey Nazarov wrote: > > >> On 26 Jul 2017, at 12:31, Chris Hegarty wrote: >> >> >>> On 26 Jul 2017, at 18:03, Hohensee, Paul wrote: >>> >>> A double negative (!Files.notExists) somewh

Review: demos for try-with-resources feature

I've fixed subject --- Hi guys, We want to push our demo code for try-with-resources feature Could you please review this code? http://cr.openjdk.java.net/~anazarov/try-with-resources/ --Andrey.

Review: lamda expressions and bulk data operations on collections.

Hi guys, We want to push our demo code for try-with-resources feature Could you please review this code? http://cr.openjdk.java.net/~anazarov/try-with-resources/ --Andrey.

Review: demos for jdk8

/ -- Andrey. On 13.09.2013 5:49, Andrey Nazarov wrote: I've fixed subject --- Hi guys, We want to push our demo code for try-with-resources feature Could you please review this code? http://cr.openjdk.java.net/~anazarov/try-with-resources/ --Andrey.

Re: Review: demos for jdk8

aybe suppressing one of them)? On Fri, Oct 11, 2013 at 9:56 AM, Andrey Nazarov mailto:andrey.x.naza...@oracle.com>> wrote: Hi guys, Did you have a chance to review our jdk8 demos? http://cr.openjdk.java.net/~anazarov/try-with-resources/ <http://cr.openjdk.java