On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote:
> This is the same patch as
> [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/)
> published in
> [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hot
On Wed, 9 Sep 2020 18:46:33 GMT, Lois Foltan
wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback from Coleen
>
> Thanks Ioi for addressing my review comments. Overall, looks great!
Ok thanks! So many emails ..
On Tue, 15 Sep 2020 16:43:01 GMT, Daniil Titov wrote:
> The change fixes a 'deadlock' situation in VM_RedefineClasses::lock_classes()
> when the current thread is in the middle
> of redefining the same class. The change is based on the fix [1] suggested in
> the Jira issue [2] comment.
> [1] ht
On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
On Thu, 15 Oct 2020 17:08:28 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
On Fri, 6 Nov 2020 21:47:42 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 64 commits:
>>
>> - Merge branch '8254162' into 8254231_linker
On Thu, 5 Nov 2020 21:26:16 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393 [
On Mon, 9 Nov 2020 16:31:23 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 121:
>>
>>> 119: upcall_info.upcall_method.name,
>>> upcall_info.upcall_method.sig,
>>> 120: &args, thread);
>>> 121: }
>>
>>
On Tue, 10 Nov 2020 14:16:22 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
Hi, I saw my name in this thread and had a discussion with Mandy. I
don't like that the VM and JDK having this special coordinated dance of
+1/-1, and the reason for this is to differentiate the value of 0 in
StackFrame meaning either uninitialized or invalid. If through some
race, an uniti
On 8/14/19 3:42 PM, Mandy Chung wrote:
I have further discussion with Coleen and walkthrough the vframe
implementation. Here is what we confirm and agree.
vframeStream::bci might return an invalid bci whereas javaVFrame::bci
returns a valid bci (compiledVFrame::bci adjusts invalid bci to 0
(resending to all the lists)
Hi, I've looked at the hotspot code again, and it looks good. Nice
work, Harold and Vincente!
Coleen
On 11/27/19 11:37 PM, Vicente Romero wrote:
Hi,
Please review the code for the records feature at [1]. This webrev
includes all: APIs, runtime, compiler, seri
On 3/30/20 5:54 AM, David Holmes wrote:
Sorry to jump in on this but it caught my eye though I may be missing
a larger context ...
On 30/03/2020 7:30 pm, serguei.spit...@oracle.com wrote:
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-
See bug for details. Tested:
$ java -XX:+StressLdcRewrite -version
Error: VM option 'StressLdcRewrite' is diagnostic and must be enabled via
-XX:+UnlockDiagnosticVMOptions.
Error: The unlock option must precede 'StressLdcRewrite'.
Error: Could not create the Java Virtual Machine.
Error: A fatal
On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Mon, 25 Jan 2021 14:40:09 GMT, Coleen Phillimore wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
On Mon, 25 Jan 2021 15:01:25 GMT, Anton Kozlov wrote:
>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp line 87:
>>
>>> 85: JavaThread* jt = JavaThread::thread_from_jni_environment(jni_env);
>>> 86: DEBUG_ONLY(JfrJavaSupport::check_java_thread_in_native(jt));;
>>> 87: Thread::WXWr
On Tue, 26 Jan 2021 11:31:18 GMT, Anton Kozlov wrote:
>> This could be a follow-up RFE.
>
> I assume a WXVerifier class that tracks W^X mode in debug mode and does
> nothing in release mode. I've considered to do this, it's relates to small
> inefficiencies, while this patch brings zero overhea
On Wed, 3 Feb 2021 12:21:30 GMT, Claes Redestad wrote:
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Changes requested by coleenp (Reviewer).
src/java.base/share/classes/java/lang/ClassLoader.java line 1259:
> 1257:
On Thu, 4 Feb 2021 13:11:47 GMT, Coleen Phillimore wrote:
>> src/java.base/share/native/libjava/ClassLoader.c line 291:
>>
>>> 289: }
>>> 290: // disallow slashes in input, change '.' to '/'
>>> 291: if (verifyFixClass
On Wed, 3 Feb 2021 19:49:30 GMT, Mandy Chung wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> src/java.base/share/native/libjava/ClassLoader.c line 291:
>
>> 289: }
>> 290: // disallow slashes in input,
s
> option.
>
> Tested with tier1 hotspot, jdk and langtools.
> and tier2-6.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Add comment and read NEVER field from System
-
Changes:
- all: https:/
On Fri, 5 Feb 2021 01:45:58 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add comment and read NEVER field from System
>
> src/hotspot/share/classfile/dict
s
> option.
>
> Tested with tier1 hotspot, jdk and langtools.
> and tier2-6.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix comments and copyright.
-
Changes:
- all: https://git.openjdk.ja
On Fri, 5 Feb 2021 03:00:05 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments and copyright.
>
> src/hotspot/share/classfile/javaClasses.cpp l
On Thu, 11 Feb 2021 12:44:54 GMT, Claes Redestad wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which moves `ClassFileInstaller` class to
> `jdk.test.lib.helpers` package?
> to reduce changes in the tests, `ClassFileInstaller` in the default package
> is kept w/ just `main` method that
On Thu, 8 Apr 2021 15:23:52 GMT, Vladimir Kozlov wrote:
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Ahead-of-Time Compiler from JDK:
>
> - `jdk.aot` module — the `jaotc` tool
> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> -
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 20:28:27 GMT, Igor Ignatyev wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> Test changes look good to me.
There's a comment above
void VM_Redef
On Fri, 23 Apr 2021 19:48:47 GMT, Kim Barrett wrote:
> Please review this change to the String Deduplication facility. It is being
> changed to use OopStorage to hold weak references to relevant objects,
> rather than bespoke data structures requiring dedicated processing phases by
> supporting
On Thu, 22 Jul 2021 14:58:47 GMT, Thomas Stuefe wrote:
> Short: this patch makes NMT available in custom-launcher scenarios and during
> gtests. It simplifies NMT initialization. It adds a lot of NMT-specific
> testing, cleans them up and makes them sideeffect-free.
>
> -
>
> NMT cont
On Fri, 30 Jul 2021 09:44:57 GMT, Thomas Stuefe wrote:
> Is that a real-life problem? Are there cases where the launcher would want to
> live on if the JVM failed to load?
There are a lot of other reasons why the launcher couldn't live on if the JVM
fails to load. This was only one of them.
On Fri, 30 Jul 2021 09:32:22 GMT, Thomas Stuefe wrote:
>> [Not a review, just a drive-by comment.] This is a normal and idiomatic
>> overload on the const-ness of `this`.
>
> To expand on Kim's answer. This is a way to solve const/nonconst problems
> like https://github.com/openjdk/jdk/pull/49
On Sun, 1 Aug 2021 08:17:08 GMT, Thomas Stuefe wrote:
>> Short: this patch makes NMT available in custom-launcher scenarios and
>> during gtests. It simplifies NMT initialization. It adds a lot of
>> NMT-specific testing, cleans them up and makes them sideeffect-free.
>>
>> -
>>
>> NM
On Fri, 27 Aug 2021 15:23:35 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Mon, 13 Sep 2021 17:12:49 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Mon, 13 Sep 2021 17:12:49 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Mon, 13 Sep 2021 10:54:18 GMT, Markus Grönlund wrote:
>> src/hotspot/share/services/finalizerService.cpp line 44:
>>
>>> 42: _ik(ik),
>>> 43: _objects_on_heap(0),
>>> 44: _total_finalizers_run(0) {}
>>
>> Is this hashtable for every InstanceKlass that defines a finalizer? How
>
On Thu, 14 Oct 2021 21:58:42 GMT, Coleen Phillimore wrote:
>> "Since you remove entries on unloading, I don't see any reason to have any
>> concurrent cleanup."
>> Thank you, that is true. The only concurrent work required will be to grow
>> the table.
&g
On Wed, 13 Oct 2021 18:03:25 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Fri, 15 Oct 2021 09:27:54 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> Object.finalize() was deprecated in JDK9. There is an ongoing effort to
>> replace and mitigate Object.finalize() uses in the JDK libraries; please see
>> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info
On Sat, 11 Dec 2021 01:55:50 GMT, Ioi Lam wrote:
>> **Background:**
>>
>> In the Java Language, Enums can be tested for equality, so the constants in
>> an Enum type must be unique. Javac compiles an enum declaration like this:
>>
>>
>> public enum Day { SUNDAY, MONDAY ... }
>>
>>
>> to
>
On Wed, 23 Feb 2022 04:15:28 GMT, Ioi Lam wrote:
>> **Background:**
>>
>> In the Java Language, Enums can be tested for equality, so the constants in
>> an Enum type must be unique. Javac compiles an enum declaration like this:
>>
>>
>> public enum Day { SUNDAY, MONDAY ... }
>>
>>
>> to
>
On Wed, 19 Jan 2022 05:44:10 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/heapShared.cpp line 433:
>>
>>> 431: oop mirror = k->java_mirror();
>>> 432: int i = 0;
>>> 433: for (JavaFieldStream fs(k); !fs.done(); fs.next()) {
>>
>> This seems like it should also use InstanceKlass::do_local_
On Mon, 4 Apr 2022 09:58:35 GMT, Claes Redestad wrote:
> As an alternative to #7667 I took a look at injecting an empty class array
> from the VM. Turns out we already do this for exception types - see
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/oops/method.cpp#L918
> - and
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
Changeset: c6c0b1047985
Author:jmelvin
Date: 2012-04-16 17:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c6c0b1047985
7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with
Apple JDK6
Summary: On Mac OS X, align system property "os.arch" with Apple
Changeset: 77b35c5c4b95
Author:jmelvin
Date: 2012-04-16 18:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77b35c5c4b95
7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with
Apple JDK6
Summary: On Mac OS X, align system property "os.arch" with Apple l
Hi Ioi,
This is a manageable code change.
http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v01/hotspot/src/share/vm/classfile/classListParser.hpp.html
You forward declare Klass* but don't use it in this header file.
Also can you add a comment to #endif to say what it's endifing. ie. /
On 10/30/15 4:18 PM, Karen Kinnear wrote:
Coleen,
Question for you below please ...
On Oct 30, 2015, at 3:44 PM, Coleen Phillimore
wrote:
Hi Ioi,
This is a manageable code change.
http://cr.openjdk.java.net/~iklam/8140802-cds-refactoring.v01/hotspot/src/share/vm/classfile
On 11/2/15 1:57 PM, Ioi Lam wrote:
On 10/30/15 1:31 PM, Coleen Phillimore wrote:
On 10/30/15 4:18 PM, Karen Kinnear wrote:
Coleen,
Question for you below please ...
On Oct 30, 2015, at 3:44 PM, Coleen Phillimore
wrote:
Hi Ioi,
This is a manageable code change.
http
One of the things that I'm struggling with is that StackFrameInfo
contains both the collected information from walking the stack frames,
method id, bci, mirror, version and cpref, and the digested information:
interned string for class name, method name, line number and source file
name.
If
On 11/18/15 5:06 PM, Mandy Chung wrote:
On Nov 18, 2015, at 1:01 PM, Coleen Phillimore
wrote:
One of the things that I'm struggling with is that StackFrameInfo contains both
the collected information from walking the stack frames, method id, bci,
mirror, version and cpref, an
Sending to core-libs mailing list.
On 11/25/15 2:19 PM, Alexander Smundak wrote:
Please take a look at
http://cr.openjdk.java.net/~asmundak/8141491/jdk/webrev.00
that fixes the problem.
It utilizes the ability of some (GCC and Clang) to declare data
alignment explicitly.
I have verified it work
Coleen,
Thanks for review
On 11/24/2015 07:33 PM, Coleen Phillimore wrote:
I have a couple preliminary comments. First, there are no
tests added with all this new functionality. Tests should be
added with the functionality changeset, not promised afterward.
I will add tests.
Secondly, I do not l
On 1/22/16 4:11 AM, Andrew Dinn wrote:
On 21/01/16 22:14, Rafael Winterhalter wrote:
Hi Andrew,
if there is any update on the matter, I would of course love to hear about it.
Unfortunately, I never received an answer to my question, but maybe I
picked the wrong list.
Thank you for your support
Summary: replace JVM_GetStackTraceDepth and JVM_GetStackTraceElement,
with JVM_GetStackTraceElements that gets all the elements in the
StackTraceElement[]
These improvements were found during the investigation for replacing
Throwable with the StackWalkAPI. This change also adds iterator for
hanges :-)
Oh, but you know this code in hotspot, now. That's ok, you don't need
to review hotspot code.
Thanks!
Coleen
best regards,
-- daniel
On 02/03/16 19:44, Coleen Phillimore wrote:
Summary: replace JVM_GetStackTraceDepth and JVM_GetStackTraceElement,
with JVM_GetStackT
On 3/2/16 1:58 PM, Aleksey Shipilev wrote:
Hi Coleen,
On 03/02/2016 09:44 PM, Coleen Phillimore wrote:
Summary: replace JVM_GetStackTraceDepth and JVM_GetStackTraceElement,
with JVM_GetStackTraceElements that gets all the elements in the
StackTraceElement[]
These improvements were found
On 3/2/16 3:21 PM, Aleksey Shipilev wrote:
On 03/02/2016 10:57 PM, Coleen Phillimore wrote:
On 3/2/16 1:58 PM, Aleksey Shipilev wrote:
Is there an underlying reason why we can't return the pre-filled
StackTraceElements[] array from the JVM_GetStackTraceElements to begin
with? This will
Mandy, thank you for reviewing this.
On 3/2/16 9:18 PM, Mandy Chung wrote:
On Mar 2, 2016, at 4:03 PM, Coleen Phillimore
wrote:
Freshly tested changes with jck tests, with missing checks and other changes to
use the depth field, as pointed out by Aleksey. I've kept the
StackTraceEl
Hi Aleksey, This is an interesting experiment.
On 3/4/16 8:28 AM, Aleksey Shipilev wrote:
On 03/02/2016 11:21 PM, Aleksey Shipilev wrote:
On 03/02/2016 10:57 PM, Coleen Phillimore wrote:
On 3/2/16 1:58 PM, Aleksey Shipilev wrote:
Is there an underlying reason why we can't return th
On 3/11/16 6:36 PM, Aleksey Shipilev wrote:
On 03/08/2016 01:55 AM, Coleen Phillimore wrote:
Aside: see the last experiment, avoiding StringTable::intern (shows in
profiles a lot!) trims down construction costs down even further. I'd
think that is a worthwhile improvement to consider
Thanks, Mandy!
Coleen
On 9/8/14, 6:59 PM, Mandy Chung wrote:
Thumbs up.
Mandy
On 9/5/2014 12:55 PM, Coleen Phillimore wrote:
Summary: Add classLoader to java/lang/Class instance for fast access
This is a backport request for 8u40. This change has been in the
jdk9 code for 3 months
Summary: The function has been replaced so is no longer used.
This function was replaced with a better FindClassFromCaller function.
The compatibility request (CCC) was approved.
open webrev at http://cr.openjdk.java.net/~coleenp/8042418_jdk/
open webrev at http://cr.openjdk.java.net/~coleen
Thanks, David.
Coleen
On 12/13/14, 5:47 PM, David Holmes wrote:
Looks okay to me Coleen.
Thanks,
David
On 13/12/2014 6:59 AM, Coleen Phillimore wrote:
Summary: The function has been replaced so is no longer used.
This function was replaced with a better FindClassFromCaller function.
The
Kumar,
This looks good to me. I didn't review all the changes in the test very
carefully, so someone else should vouch for that.
Thank you for fixing this!
Coleen
On 2/23/15, 9:09 PM, David Holmes wrote:
Hi Kumar,
On 24/02/2015 8:14 AM, Kumar Srinivasan wrote:
Hello,
Please review the
oetz ; Java Core Libs ; hotspot-runtime-...@openjdk.java.net; Coleen
Phillimore (coleen.phillim...@oracle.com)
Subject: RE: RFR(L): 8218628: Add detailed message to NullPointerException
describing what is null.
Hi Goetz,
I've played with the messages a little bit and they generally look
Also meant to include core-libs-dev in the email.
Thanks,
Coleen
On 4/5/16 1:27 PM, Coleen Phillimore wrote:
Hi, I've reviewed the hotspot changes and some of the jdk changes.
This looks really good.
One comment about the jvm function names:
I think FillInStackTraceElement is too clo
A correction below.
On 4/5/16 1:29 PM, Coleen Phillimore wrote:
Also meant to include core-libs-dev in the email.
Thanks,
Coleen
On 4/5/16 1:27 PM, Coleen Phillimore wrote:
Hi, I've reviewed the hotspot changes and some of the jdk changes.
This looks really good.
One comment abou
1/index.html
Thank you for making this change. It looks good! I've reviewed this.
Coleen
-Brent
On 04/05/2016 11:25 AM, Coleen Phillimore wrote:
A correction below.
On 4/5/16 1:29 PM, Coleen Phillimore wrote:
Also meant to include core-libs-dev in the email.
Thanks,
Coleen
Hi, You can send this to core-libs-dev@openjdk.java.net and
hotspot-...@openjdk.java.net
The sponsor should be from the runtime group. I don't know this well
enough, so I'm going to point you to Dan (and Jerry, except Jerry's not
a committer).
To run JPRT don't forget to use -testset hot
Thank you for fixing this so quickly. This looks good but I have a
question about:
http://cr.openjdk.java.net/~darcy/8162539.0/test/java/lang/reflect/Constructor/GenericStringTest.java.udiff.html
@ExpectedGenericString(
"protected TestClass1(S,T) throws java.lang.Exception")
+ @Expec
test are weighted toward toGenericString since the tests were added
for that functionality.
HTH,
Yes, thanks. Glad there's a test now.
Coleen
-Joe
On 7/26/2016 12:23 PM, Coleen Phillimore wrote:
Thank you for fixing this so quickly. This looks good but I have a
question abo
On 9/7/16 9:09 AM, Max Ockner wrote:
Does the stackwalk API have access to the type of variable at each
slot? Where is this information stored? My operating assumption was
that it did not have this information, and therefore needed to read
the garbage slot.
This is true. The StackWalk API
On 2/12/18 1:54 AM, David Holmes wrote:
Hi Harold,
Adding core-libs-dev so they are aware of the ClassLoader change.
On 10/02/2018 5:44 AM, harold seigel wrote:
Hi David,
Thanks for reviewing this.
Please see updated webrev:
http://cr.openjdk.java.net/~hseigel/bug_8184289.2/webrev/index.h
This seems like better mailing list for this inquiry.
Coleen
On 5/9/18 6:43 AM, A Z wrote:
Does anyone know what is going to be decided
around full target status of JEP 306?
I have been recommended to this list for the sake
of this question.
?
http://openjdk.java.net/jeps/306
https://bugs.op
Thanks, Alan. I've looked at this and reviewed it too, so I'll push
it. Thanks Harold for sending it out.
Coleen
On 11/14/2013 10:03 AM, harold seigel wrote:
Hi Alan,
Thank you for the review.
Harold
On 11/13/2013 10:04 AM, Alan Bateman wrote:
On 13/11/2013 14:55, harold seigel wrote:
Changeset: 59f46f135584
Author:hseigel
Date: 2013-11-14 10:44 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59f46f135584
8023041: The CDS classlist needs to be updated for JDK 8
Summary: Generate new classlists from JDK 8 classes
Reviewed-by: alanb, coleenp, hseigel
Contribu
hod->print_name works fine. This makes
me feel that the idnum array is out of date somehow. Before I go down
the rabbit hole and try to figure out why that is, does someone else
know why?
Thanks!
Jeremy
On Thu, Oct 3, 2013 at 11:02 AM, Coleen Phillimore
mailto:coleen.phillim...
://bugs.openjdk.java.net/browse/JDK-6642881
Thanks,
Coleen
On 6/19/14, 11:01 PM, David Holmes wrote:
On 20/06/2014 6:53 AM, Joel Borggrén-Franck wrote:
Hi Mandy,
On 19 jun 2014, at 22:34, Mandy Chung wrote:
On 6/19/14 12:34 PM, Joel Borggrén-Franck wrote:
Hi,
On 19 jun 2014, at 20:46, Coleen
On 6/23/14, 9:36 PM, Mandy Chung wrote:
Coleen,
On 6/23/2014 4:45 PM, Coleen Phillimore wrote:
Please review a change to the JDK code for adding classLoader field
to the instances of java/lang/Class. This change restricts
reflection from changing access to the classLoader field. In the
Hi Peter,
On 6/24/14, 4:23 AM, Peter Levart wrote:
On 06/24/2014 01:45 AM, Coleen Phillimore wrote:
Please review a change to the JDK code for adding classLoader field
to the instances of java/lang/Class. This change restricts
reflection from changing access to the classLoader field. In
:
Hi Coleen,
It seems that there's still a reference to JVM_GetClassLoader
in file jdk/src/share/native/common/check_code.c. The code looks
like dead code, but it would be nice to clean it up.
Thanks,
Fred
On 06/24/2014 01:45 AM, Coleen Phillimore wrote:
Please review a change to the JD
Mikael, see below.
On 6/24/14, 9:48 AM, Mikael Gerdin wrote:
On Tuesday 24 June 2014 08.51.18 Coleen Phillimore wrote:
Hi Peter,
On 6/24/14, 4:23 AM, Peter Levart wrote:
On 06/24/2014 01:45 AM, Coleen Phillimore wrote:
Please review a change to the JDK code for adding classLoader field
to
f the macro
BROKEN_JAVAC. I update the copyrights when I commit the changeset.
http://cr.openjdk.java.net/~coleenp/6642881_jdk_5/
Thanks!
Coleen
Thanks,
Fred
On 06/24/2014 01:45 AM, Coleen Phillimore wrote:
Please review a change to the JDK code for adding classLoader field to
the instanc
Summary: Add field in java.lang.Class for componentType to simplify oop
processing and intrinsics in JVM
This is part of ongoing work to clean up oop pointers in the metadata
and simplify the interface between the JDK j.l.C and the JVM. There's a
performance benefit at the end of all of this
://cr.openjdk.java.net/~coleenp/8047737_hotspot/
Thank you for pointing this out David.
Coleen
David
On 28/06/2014 5:24 AM, Coleen Phillimore wrote:
Summary: Add field in java.lang.Class for componentType to simplify oop
processing and intrinsics in JVM
This is part of ongoing work to clean up oop pointers
Thank you, Fred, and thanks for correcting the link below.
Coleen
On 6/30/14, 10:27 AM, Frederic Parain wrote:
On 30/06/2014 14:42, Coleen Phillimore wrote:
On 6/30/14, 1:55 AM, David Holmes wrote:
Hi Coleen,
Your webrev links are to internal locations.
Sorry, I cut/pasted the wrong
ally would like a compiler
person to comment on it.
Thanks so much,
Coleen
On Jun 30, 2014, at 5:42 AM, Coleen Phillimore
mailto:coleen.phillim...@oracle.com>>
wrote:
On 6/30/14, 1:55 AM, David Holmes wrote:
Hi Coleen,
Your webrev links are to internal locations.
Sorry, I cut/
net/%7Ecoleenp/8047737_jdk/>
http://cr.openjdk.java.net/~coleenp/8047737_hotspot/
and the full version
http://cr.openjdk.java.net/~coleenp/8047737_hotspot/
Thank you for pointing this out David.
Coleen
David
On 28/06/2014 5:24 AM, Coleen Phillimore wrote:
Summary: Add field in ja
Thank you!
Coleen
On 7/1/14, 12:51 AM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
wrote:
On 6/30/14, 3:50 PM, Christian Thalinger wrote:
private Class(ClassLoader loader) {
// Initialize final field for classLoader. The initialization value
On 7/2/14, 8:41 AM, Peter Levart wrote:
On 07/02/2014 02:38 PM, Peter Levart wrote:
On 07/02/2014 02:22 PM, Peter Levart wrote:
On 07/02/2014 08:26 AM, Mandy Chung wrote:
On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
wrote:
On 6/30/14
de like this in
the JVM to disable these optimizations if they are ever implemented.
Thank you for reviewing the code.
Coleen
On 7/2/14, 2:26 AM, Mandy Chung wrote:
On 6/30/2014 9:51 PM, Christian Thalinger wrote:
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore
wrote:
On 6/30/14, 3:5
Summary: Add classLoader to java/lang/Class instance for fast access
This is a backport request for 8u40. This change has been in the jdk9
code for 3 months without any problems.
The JDK changes hg imported cleanly. The Hotspot change needed a hand
merge for create_mirror call in klass.cpp
Thanks David!
Coleen
On 9/7/14, 9:38 PM, David Holmes wrote:
Looks okay to me.
David
On 6/09/2014 5:55 AM, Coleen Phillimore wrote:
Summary: Add classLoader to java/lang/Class instance for fast access
This is a backport request for 8u40. This change has been in the jdk9
code for 3 months
Added core-libs-dev.
Coleen
On 1/30/17 5:52 PM, Coleen Phillimore wrote:
Hi Brent,
I think this looks more conservative and better.
in
http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/hotspot/src/share/vm/prims/stackwalk.cpp.html
287 int mode = 0;
288 if (_jvf
Thanks Brent, looks good!
Coleen
On 1/31/17 1:19 PM, Brent Christian wrote:
On 1/30/17 5:52 PM, Coleen Phillimore wrote:
in
http://cr.openjdk.java.net/~bchristi/8156073/webrev.03/hotspot/src/share/vm/prims/stackwalk.cpp.html
287 int mode = 0;
288 if (_jvf->is_interpreted_fr
1 - 100 of 114 matches
Mail list logo
