Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hello Volker. (I'm sorry for duplicate posting, I did bad operation) What's actually the difference between "ibm-942C" and "ibm-942"? They have two differences on single byte part: 1. Control Character rotation for 0x1A and 0x1C, 0x7F [2] 2. Character replacement for 0x5C and 0x7E (0xFE, 0xFF)

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Volker, Thank you for reviewing the patch. > you change looks good, although I can't really verify all the charset > aliases. For example Wikipedia mentions that "ibm-932" is equivalent > to "ibm-942" [1] but you made it an alias for "ibm-942C". What's > actually the difference between

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Bhaktavatsal Reddy, you change looks good, although I can't really verify all the charset aliases. For example Wikipedia mentions that "ibm-932" is equivalent to "ibm-942" [1] but you made it an alias for "ibm-942C". What's actually the difference between "ibm-942C" and "ibm-942"? I can

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

On 16/04/2018 18:43, Xueming Shen wrote: It looks good to me. I agree, the main thing is that it's not adding charsets to java.base for the other builds. -Alan

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

It looks good to me. -Sherman On 4/16/18, 4:10 AM, Bhaktavatsal R Maram wrote: Hi All, I've regenerated webrev using "hg rename" to create template files. webrev looks much neat now.. Thanks Alan for suggestion. webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/ Thanks, Bhaktavatsal

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi All, I've regenerated webrev using "hg rename" to create template files. webrev looks much neat now.. Thanks Alan for suggestion. webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/ Thanks, Bhaktavatsal Reddy -"core-libs-dev" wrote: -

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Alan, I deleted IBM943C.java (using hg remove) and added new file IBM943C.java.template (using hg add). I now understand that using "hg rename" is giving more meaningful representation in webrev/index.html. I will re-generate webrev by renaming source files to templates using "hg rename"

Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

On 16/04/2018 09:22, Bhaktavatsal R Maram wrote: 3. Source files for IBM-942C and IBM-943C are changed to template to support #1 You might want to double check the webrev as it looks like you've added templates where as I assume you mean to use "hg rename" to rename IBM942C.java and

RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi All, Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8201540 webrev: http://cr.openjdk.java.net/~gromero/8201540/v1/webrev/ In this patch, 1. Default charsets Big5, Big5_Solaris, Big5_HKSCS, GB18030, IBM856, IBM921, IBM922, IBM942, IBM942C, IBM943, IBM943C, IBM950, IBM970,