Hi David,
I thought I did make that change. Let me go back and double check and if not,
will push. My build worked fine but maybe I missed this in a merge.
Best
Lance
> On Feb 13, 2018, at 8:05 AM, David Holmes wrote:
>
> Lance,
>
> In Docs.gmk you seem to have missed this:
>
> 445
>
Lance,
In Docs.gmk you seem to have missed this:
445
446 # Setup generation of the Java SE API documentation (javadoc +
modulegraph)
447
448 # The Java SE module scope is just java.se.ee and its transitive
in
One could almost shed a tear - of joy! This is exactly the use case for
the module system that the developer community at large will understand.
Thanks for this change and a leaner meaner JDK.
Cheers,
Martijn
On 8 February 2018 at 13:37, Lance Andersen
wrote:
>
> > On Feb 8, 2018, at 3:04 AM,
> On Feb 8, 2018, at 3:04 AM, Alan Bateman wrote:
>
> On 07/02/2018 16:57, Lance Andersen wrote:
>> Hi all,
>>
>> I think we are at a point where we are ready to start reviewing the changes
>> to remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been
>> targeted to JDK 11.
On 07/02/2018 16:57, Lance Andersen wrote:
Hi all,
I think we are at a point where we are ready to start reviewing the changes to
remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been
targeted to JDK 11.
The CSR for removing the modules has been approved:
https://bugs.open
Hi Mandy
> On Feb 7, 2018, at 5:00 PM, mandy chung wrote:
>
> Hi Lance,
>
> Great to see this JEP moving along. I reviewed all changes except
> test/langtools/tools/javac tests.
>
> Looks fine overall.
Thank you for the review.
> Minor comments:
>
> src/java.base/share/lib/security/default
Hi Lance,
Great to see this JEP moving along. I reviewed all changes except
test/langtools/tools/javac tests.
Looks fine overall. Minor comments:
src/java.base/share/lib/security/default.policy
- no change in this file.
test/jdk/tools/jmod/hashes/HashesTest.java
test/jdk/tools/launcher/modul
Hi Goetz,
I updated the webrev with the suggested update
http://cr.openjdk.java.net/~lancea/8190378/open_changes/tests_webrev/test/jdk/tools/launcher/HelpFlagsTest.java.sdiff.html
Best
Lance
> On Feb 7, 2018, at 3:20 PM, Lindenmaier, Goetz
> wrote:
>
> Hi Lance,
>
> Would you mind to add si
Hi Lance,
Would you mind to add similar change as for
test/jdk/tools/launcher/VersionCheck.java
also for
test/jdk/tools/launcher/HelpFlagsTest.java
That test is pretty recent which is why you may have missed it.
It will not fail though, there will just be left over stuff in it.
Best regards,
Build changes look good.
/Erik
On 2018-02-07 08:57, Lance Andersen wrote:
Hi all,
I think we are at a point where we are ready to start reviewing the changes to
remove the Java EE and CORBA modules as JEP 320, JDK-8189188, has been
targeted to JDK 11.
The CSR for removing the modules has
10 matches
Mail list logo