Re: readlink(1) of more than one file?

2012-12-14 Thread Jim Meyering
Pádraig Brady wrote: ... > I'll push the attached (complete with new test and doc adjustments) soon. ... Nice. I was going to say it looked impeccable, but then noticed a nit at the end of the test. Thanks! > diff --git a/tests/readlink/multi.sh b/tests/readlink/multi.sh ... > +readlink link1 li

Re: readlink(1) of more than one file?

2012-12-14 Thread Pádraig Brady
On 12/13/2012 08:47 AM, Pádraig Brady wrote: On 12/13/2012 05:34 AM, Jim Meyering wrote: Jim Meyering wrote: ... The awkward/somewhat redundant -n, --no-newline option is handled in the same way as on BSD and the help text adjusted like: - -n, --no-newline do not output the trail

Re: [PATCH] maint: ignore GCC coverage files

2012-12-14 Thread Pádraig Brady
On 12/14/2012 06:33 PM, Assaf Gordon wrote: Hello, Related to the updated coverage documentation, perhaps update the ".gitignore" to ignore the generated coverage files? Another possible addition is ignoring "src.lcov", "lib.lcov" and "lcov-html/*" - but those file names are not fixed, just th

Re: [PATCH] doc: mention "git stash" in HACKING

2012-12-14 Thread Bernhard Voelker
On 12/14/2012 07:35 PM, Assaf Gordon wrote: > Bernhard Voelker wrote, On 12/14/2012 03:29 AM: >> On 12/13/2012 08:29 PM, Assaf Gordon wrote: >> >>> [PATCH 1/2] doc: mention "git stash" in HACKING >> >> I tweaked the commit message a bit: even if the change is trivial >> and the subject is HACKING,

Re: enhancement suggestions for "sort" and text editor

2012-12-14 Thread Assaf Gordon
Hello John, Eric Blake wrote, On 12/14/2012 04:19 PM: > On 12/14/2012 02:02 PM, john wrote: >> >> In particular I wish to enter text into predefined (fixed location) >> fields in a record as opposed to variably delimited fields. In other >> words emulate the punched card record where card columns

Re: enhancement suggestions for "sort" and text editor

2012-12-14 Thread Eric Blake
On 12/14/2012 02:02 PM, john wrote: > > In particular I wish to enter text into predefined (fixed location) > fields in a record as opposed to variably delimited fields. In other > words emulate the punched card record where card columns are assigned to > particular data character columns. Thos

enhancement suggestions for "sort" and text editor

2012-12-14 Thread john
Gentlemen; In the course of trying to emulate some simple data processing functions of the early mainframe era, I was surprised they weren't readily supported by current standard tools. In particular I wish to enter text into predefined (fixed location) fields in a record as opposed to vari

Re: [PATCH] doc: mention "git stash" in HACKING

2012-12-14 Thread Assaf Gordon
Bernhard Voelker wrote, On 12/14/2012 03:29 AM: > On 12/13/2012 08:29 PM, Assaf Gordon wrote: > >> [PATCH 1/2] doc: mention "git stash" in HACKING > > I tweaked the commit message a bit: even if the change is trivial > and the subject is HACKING, it's good practice to mention it in a > line below

[PATCH] maint: ignore GCC coverage files

2012-12-14 Thread Assaf Gordon
Hello, Related to the updated coverage documentation, perhaps update the ".gitignore" to ignore the generated coverage files? Another possible addition is ignoring "src.lcov", "lib.lcov" and "lcov-html/*" - but those file names are not fixed, just the recommended file names in HACKING . -gordo

Re: [PATCH 2/2] doc: tweak 'lcov' in HACKING

2012-12-14 Thread Assaf Gordon
Hello Bernhard, Bernhard Voelker wrote, On 12/14/2012 03:29 AM: > splitting the discussion about the 2 patches ... > > On 12/13/2012 08:29 PM, Assaf Gordon wrote: >> [...] >> The second changes parameters for 'lcov' example - the current parameters >> produce wrong output (the source files are no

Re: numfmt (=print 'human' sizes) updates

2012-12-14 Thread Eric Blake
On 12/14/2012 01:53 AM, Pádraig Brady wrote: >>> The "--devdebug" option can be used to show internal states (perhaps >>> will be removed once the program is finalized?). > > Yes we may remove, or at least not document. If you choose to not document it, then name it '---devdebug' (yes, with three

[PATCH] maint: fix typos found by misspellings

2012-12-14 Thread Bernhard Voelker
It's been time to run misspellings again, but the only 2 new mistakes came from me, sorry ... ;-/ Have a nice day, Berny >From 9c506806fa3904fba60d9f67f381cf90fe6f1e69 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Fri, 14 Dec 2012 10:45:21 +0100 Subject: [PATCH] maint: fix typos found by

Re: numfmt (=print 'human' sizes) updates

2012-12-14 Thread Pádraig Brady
On 12/14/2012 05:38 AM, Assaf Gordon wrote: Hello, Attached is a slightly improved patch - minor code changes, and many more tests. Line coverage is 98%, and branch coverage is now >93% , and most of the non-covered branches are simply unreachable (I'm checking the reachable ones). The comment

[PATCH 2/2] doc: tweak 'lcov' in HACKING

2012-12-14 Thread Bernhard Voelker
splitting the discussion about the 2 patches ... On 12/13/2012 08:29 PM, Assaf Gordon wrote: > [...] > The second changes parameters for 'lcov' example - the current parameters > produce wrong output (the source files are not found, with LCOV version 1.9 ). Thanks. > [PATCH 2/2] doc: tweak 'lcov

[PATCH] doc: mention "git stash" in HACKING

2012-12-14 Thread Bernhard Voelker
splitting the discussion about the 2 patches ... On 12/13/2012 08:29 PM, Assaf Gordon wrote: > The first mentions 'git stash' in a relevant paragraph. > [...] Thanks. > [PATCH 1/2] doc: mention "git stash" in HACKING I tweaked the commit message a bit: even if the change is trivial and the subj