Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-24 Thread Sam Varshavchik
Hanno Böck writes: Sam, attached you'll find a patch that changes all instances of test -w / test ! -w in couriers Makefiles. courier-fix-root-check-svn.diff.gz is against latest courier svn and excludes all files not in svn (that are generated by autotools) Can you apply this one? This look

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-24 Thread Hanno Böck
Sam, attached you'll find a patch that changes all instances of test -w / test ! -w in couriers Makefiles. courier-fix-root-check-svn.diff.gz is against latest courier svn and excludes all files not in svn (that are generated by autotools) Can you apply this one? -- Hanno Böck mail

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-16 Thread Sam Varshavchik
Hanno Böck writes: On Fri, 15 Jun 2012 08:33:22 -0400 Sam Varshavchik wrote: > I don't see how it could possibly work. With the change applied, the > install command becomes: > > /bin/install -c `test `id -u` != 0 || echo -o daemon -g daemon` I see your point - my fault, I did it correct for

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-16 Thread Hanno Böck
On Fri, 15 Jun 2012 08:33:22 -0400 Sam Varshavchik wrote: > I don't see how it could possibly work. With the change applied, the > install command becomes: > > /bin/install -c `test `id -u` != 0 || echo -o daemon -g daemon` I see your point - my fault, I did it correct for Makefile.in, but wron

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-15 Thread Sam Varshavchik
Hanno Böck writes: Hi Sam, On Thu, 07 Jun 2012 19:06:08 -0400 Sam Varshavchik wrote: > Hanno Böck writes: > > > So the correct way should be another test for root, e.g. > > test `id -u` != 0 > > > > I've prepared a patch. > > This is for both Makefile.in and Makefile.am to avoid the need for

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-15 Thread Hanno Böck
Hi Sam, On Thu, 07 Jun 2012 19:06:08 -0400 Sam Varshavchik wrote: > Hanno Böck writes: > > > So the correct way should be another test for root, e.g. > > test `id -u` != 0 > > > > I've prepared a patch. > > This is for both Makefile.in and Makefile.am to avoid the need for > > autotools, howeve

Re: [courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-07 Thread Sam Varshavchik
Hanno Böck writes: So the correct way should be another test for root, e.g. test `id -u` != 0 I've prepared a patch. This is for both Makefile.in and Makefile.am to avoid the need for autotools, however the first one gets generated automatically, only the second one probably needs to be applied

[courier-users] [PATCH] courier should use DESTDIR on test ! -w commands

2012-06-07 Thread Hanno Böck
Hello, It just took me some time to dig into an issue I had with courier on Gentoo. The problem was that certain executables like courieresmtpd were not installed with the correct user/group settings. I found that this line was the cause of the problem: INSTALL=@INSTALL@ `test ! -w /etc || echo