Re: github issue #2161
On Fri, 23 Feb 2018, Maroš Priputen wrote: And to answer your question, why should be (total percentage) removed, now the total field is always full size of a file, so percentage would be always at 100%, so now total percentage role falls to received percentage role, if I understand it correctly. I think the same fields should always be present there for consistency. The progress meter should not change style simply because the user resumes a transfer. Why would total always be 100%? Can you elaborate in words exactly what you intend to do in code? And since I'm new here, you can comment if I am doing something wrong i tried to read developer guidelines on the official site, but it's so extensive. If you have the funtionality done the way you want it and want to suggest to us, then please submit a PR on github and it is easy for us to review and comment on your approach. -- / daniel.haxx.se--- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
Re: github issue #2161
Ok so here is a link to my branch: https://github.com/s-3ntinel/curl/tree/fix-bug-%232161 And to answer your question, why should be (total percentage) removed, now the total field is always full size of a file, so percentage would be always at 100%, so now total percentage role falls to received percentage role, if I understand it correctly. And since I'm new here, you can comment if I am doing something wrong i tried to read developer guidelines on the official site, but it's so extensive. 2018-02-22 23:14 GMT+01:00 Ray Satiro : > On 2/22/2018 1:02 PM, Maroš Priputen wrote: > > Hi there, I\m new to curl (first time contributing to open source > > project also). > > > > I am working on resolving this issue ( Github: #2161 ) > > > > So far I think i fixed: Total (and) % Received > > > > > --- > > Here is a snippet (I did it like this because I didn't want to post > > images in attachments) > > > > ** Resuming transfer from byte position 1186172928 > >Total % Received % Xferd Average Speed TimeTime > > Time Current > > Dload Upload > > Total Spent Left Speed > >1432M 79 1141M0 0 2321k 0 0:02:13 > > 0:00:04 0:02:09 2321k > > > > > --- > > > > My question is, should I leave (Time Spent), to count from beginning > > (0:00:00) every time or is it better > > if it continues, from where I left off? > > > > Btw, i also removed (% Total) because it doesn't make sense in this > > format. > > > > And since I'm new here it it appropriate to post these kind of stuff > > here or should I do this on github? > > > > Thanks. > > That's great you are working on it. I suggest participating in github > issue #2161 [1] since it is already tracked there. I think only Total > and Received size amounts should be changed, and not times. Otherwise we > would have to record the cumulative times of transfers. As far as > removing % total I don't know why that is necessary. Please comment on > the issue and share your thoughts and a link to the branch or your code. > > [1]: https://github.com/curl/curl/issues/2161 > > > --- > Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library > Etiquette: https://curl.haxx.se/mail/etiquette.html --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
Re: github issue #2161
On 2/22/2018 1:02 PM, Maroš Priputen wrote: > Hi there, I\m new to curl (first time contributing to open source > project also). > > I am working on resolving this issue ( Github: #2161 ) > > So far I think i fixed: Total (and) % Received > > --- > Here is a snippet (I did it like this because I didn't want to post > images in attachments) > > ** Resuming transfer from byte position 1186172928 > Total % Received % Xferd Average Speed Time Time > Time Current > Dload Upload > Total Spent Left Speed > 1432M 79 1141M 0 0 2321k 0 0:02:13 > 0:00:04 0:02:09 2321k > > --- > > My question is, should I leave (Time Spent), to count from beginning > (0:00:00) every time or is it better > if it continues, from where I left off? > > Btw, i also removed (% Total) because it doesn't make sense in this > format. > > And since I'm new here it it appropriate to post these kind of stuff > here or should I do this on github? > > Thanks. That's great you are working on it. I suggest participating in github issue #2161 [1] since it is already tracked there. I think only Total and Received size amounts should be changed, and not times. Otherwise we would have to record the cumulative times of transfers. As far as removing % total I don't know why that is necessary. Please comment on the issue and share your thoughts and a link to the branch or your code. [1]: https://github.com/curl/curl/issues/2161 --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
github issue #2161
Hi there, I\m new to curl (first time contributing to open source project also). I am working on resolving this issue ( Github: #2161 ) So far I think i fixed: Total (and) % Received --- Here is a snippet (I did it like this because I didn't want to post images in attachments) ** Resuming transfer from byte position 1186172928 Total % Received % Xferd Average Speed TimeTime Time Current Dload Upload Total Spent Left Speed 1432M 79 1141M0 0 2321k 0 0:02:13 0:00:04 0:02:09 2321k --- My question is, should I leave (Time Spent), to count from beginning (0:00:00) every time or is it better if it continues, from where I left off? Btw, i also removed (% Total) because it doesn't make sense in this format. And since I'm new here it it appropriate to post these kind of stuff here or should I do this on github? Thanks. --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
