re: Removing a superfluous warning from xf86-input-ws/dist/src/ws.c

2024-02-06 Thread matthew green
> On Mon 05 Feb 2024 at 10:18:09 +1100, matthew green wrote: > > perhaps convert into a DBG(4, ...)? > > On Mon 05 Feb 2024 at 02:20:25 +0300, Valery Ushakov wrote: > > May be make it reported only once, so that the message is still there > > in the log, but it's not spammed uselessly, adding no

Re: Removing a superfluous warning from xf86-input-ws/dist/src/ws.c

2024-02-06 Thread Rhialto
On Mon 05 Feb 2024 at 20:57:11 +0100, Rhialto wrote: > I think I like the second suggestion slightly better, so I'll go with > that. I'll do a test build first, even though it seems trivial. I didn't > do a build in a while anyway... I'll commit this then, if that looks ok. (I'm asking to

Re: Removing a superfluous warning from xf86-input-ws/dist/src/ws.c

2024-02-05 Thread Rhialto
On Mon 05 Feb 2024 at 10:18:09 +1100, matthew green wrote: > perhaps convert into a DBG(4, ...)? On Mon 05 Feb 2024 at 02:20:25 +0300, Valery Ushakov wrote: > May be make it reported only once, so that the message is still there > in the log, but it's not spammed uselessly, adding no new

Re: Removing a superfluous warning from xf86-input-ws/dist/src/ws.c

2024-02-04 Thread Valery Ushakov
On Sun, Feb 04, 2024 at 20:23:24 +0100, Rhialto wrote: > and it prints this warning every time I scroll using the touchpad on my > ThinkPad. Apparently it is a "new" way for touchpads to report scrolling > (both horizontal and vertica). > > These messages are filling up my /var/log/Xorg.0.log

re: Removing a superfluous warning from xf86-input-ws/dist/src/ws.c

2024-02-04 Thread matthew green
> if (hscroll || vscroll) { > xf86Msg(X_WARNING, "%s: hscroll=%d, vscroll=%d\n", > pInfo->name, hscroll, vscroll); [ ... ] > This touchpad method is not supported by the xf86-input-mouse driver so > with that one the touchpad

Removing a superfluous warning from xf86-input-ws/dist/src/ws.c

2024-02-04 Thread Rhialto
In xsrc/external/mit/xf86-input-ws/dist/src/ws.c there is this fragment: #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) >= 14 if (hscroll || vscroll) { xf86Msg(X_WARNING, "%s: hscroll=%d, vscroll=%d\n", pInfo->name, hscroll, vscroll);