Review: Approve continuous-integration
PASSED: Continuous integration, rev:acc75e2e528df66ea4ae8d9134a7adb6d14b2d63
https://jenkins.ubuntu.com/server/job/curtin-ci/120/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/120/
SUCCESS:
raharper, I have updated the code with the test refactoring. All network
disable tests are now in the same file.
--
https://code.launchpad.net/~lamoura/curtin/+git/curtin/+merge/383785
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
On Wed, May 20, 2020 at 1:43 PM Lucas Albuquerque Medeiros de Moura <
lucas.mo...@canonical.com> wrote:
> Wait, I think I missed something for these scenarios:
>
> network: {config: disabled}
> network: {config: disabled, version=1}
>
> We should not create the
Wait, I think I missed something for these scenarios:
network: {config: disabled}
network: {config: disabled, version=1}
We should not create the /etc/cloud/cloud.cfg.d/50-curtin-networking.cfg file
for them ?
I thought that they were valid cloudinit configs and we should propagate them.
For the three scenarios:
net-meta mode=disabled
network: {config: disabled}
network: {config: disabled, version=1}
We need to check that in the target system, we do not find
/etc/cloud/cloud.cfg.d/50-curtin-networking.cfg
So, let's put that unittest in its own base class and then
build each
Review: Approve continuous-integration
PASSED: Continuous integration, rev:669b5cf73d4cf15e1bccfb9913f15125fbb4b9c1
https://jenkins.ubuntu.com/server/job/curtin-ci/119/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/119/
SUCCESS:
The TestNetMetaDisabledModeBaseTestsAbs overrides some of tests that the
network disable config should use. For example, this class overrides the test:
test_cloudinit_network_passthrough
Which is a test that should be performed for the disable cloud config tests.
But I can move this override
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:7e0fb61b9b9ab35b02ff485ebfe963b1ee77ff01
https://jenkins.ubuntu.com/server/job/curtin-ci/118/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/118/
FAILURE:
Review: Needs Information
Thanks, one more question on the vmtests; it's not clear to me why we've got
network-disabled tests in test_network.py rather than both of those classes in
test_network_disabled.py and have the two different config versions subclass
from your main TestNetMetaDisabled
This looks good! I think we can update one or more of our raid vmtests config
to use the extended name; and we'll likely want to add a vmtest *unittest* to
verify we find the device in /dev/md/
See examples/tests/raid5boot.yaml and
tests/vmtests/test_mdadm_bcache.py:TestRaid5bootAbs
--
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch
Review: Approve continuous-integration
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/201/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/201/
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1bf73abf551d8bdcfa026f943f0d2403544d3af0
https://jenkins.ubuntu.com/server/job/curtin-ci/117/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/117/
SUCCESS:
Merged a fix for the streams url, marking approved to re-run the autolander
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch
The proposal to merge ~legovini/curtin:update-maas-streams-url into
curtin:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
--
Your team curtin developers is subscribed to branch curtin:master.
I notified in #maas about the URL breaking. I'm pushing this branch to master
so we can autoland again.
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/200/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/200/
We may need to pull and push this directly to master if the autolander is going
to fail as well.
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post
The proposal to merge ~legovini/curtin:update-maas-streams-url into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
--
Your team curtin developers is subscribed to branch
Review: Approve
I'm +1 on this; did we file an RT or some thing to let them know the old URL
does not get to the right place?
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
Which is normal as the sync-images stage is *not* part of the CI run, it
happens before it, and it's done by Jenkins with whatever is already on master.
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is requested to review the proposed merge
Thanks for the explanations, post-standup and here. From my testing this all
works as intended, and will greatly help speeding up the vmtest runs.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383805
Your team curtin developers is subscribed to branch curtin:master.
--
CI is failing for the exact problem this MP fixes.
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is requested to review the proposed merge of
~legovini/curtin:update-maas-streams-url into curtin:master.
--
Mailing list:
This MP should get the CI going again:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Background info: the vmtests run on the MAAS images, which are automatically
synced as part of vmtest Jenkins jobs when needed. (The logic is slightly more
complex, but doesn't matter
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:69a1404ff4f986db1fcbaa357050fb32b23de623
https://jenkins.ubuntu.com/server/job/curtin-ci/116/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/116/
FAILURE:
Paride Legovini has proposed merging ~legovini/curtin:update-maas-streams-url
into curtin:master.
Commit message:
vmtest-sync-images: update the URL of the maas streams
The old URL goes through a couple of redirects but does not land at the
correct location.
Requested reviews:
curtin
28 matches
Mail list logo
