Re: [PATCH rebase 0/2] Avoid unncessary rebases

2018-02-13 Thread Achim Gratz
Jon Turney writes: > But (i) we still read and extract the ImageBase out of every DLL in > the database, in case it's changed, I think that's how it should be. When you run rebase, you must consider that something changed behind your back and fix it up or the users will go mad. > and (ii)

Re: [PATCH rebase 0/2] Avoid unncessary rebases

2018-02-13 Thread Jon Turney
On 09/02/2018 11:59, Jon Turney wrote: Add some dignostics which report why a rebase is taking place. Use that information to fix some errors causing unnecessary rebases After these fixes, 'rebase -s' is relatively quick, with a warm disk cache. But (i) we still read and extract the

[PATCH rebase 0/2] Avoid unncessary rebases

2018-02-09 Thread Jon Turney
Add some dignostics which report why a rebase is taking place. Use that information to fix some errors causing unnecessary rebases In those cases, we were often rebasing a DLL to the same address, so we could also drop the rebase if the base address isn't actually changing, but we don't seme