Re: [PATCH setup v2 0/2] Improve the handling of command line package selection

2018-06-10 Thread Jon Turney
On 07/06/2018 18:37, Ken Brown wrote: Suppose an installed package A gets updated because of the "--packages A" command line option. If A requires a version of package B higher than the installed version, then B will also need to be updated. Moreover, if the "--upgrade-also" option hasn't been

Re: setup: uninstalling an orphaned package

2018-06-10 Thread Jon Turney
On 27/03/2018 20:04, Ken Brown wrote: On 3/26/2018 1:55 PM, Ken Brown wrote: In ChooserPage::applyCommandLinePackageSelection() we have the following code:    bool wanted    = pkg.isManuallyWanted();    bool deleted   = pkg.isManuallyDeleted();    bool basemisc  =

Re: [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed

2018-06-10 Thread Jon Turney
On 17/03/2018 14:59, Ken Brown wrote: The IniDBBuilderPackage destructor contains code that is intended to be run after each setup.ini file is processed. But the IniDBBuilderPackage variables in do_local_ini() and do_remote_ini were declared outside the loop that processed the files. Move the

Re: octave-doctest noarch

2018-06-07 Thread Jon Turney
On 06/06/2018 22:43, Marco Atzeri wrote: Hi Jon, of the current package versions 2 are arch specific octave-doctest-0.4.1-1 octave-doctest-0.5.0-1 but the last one is "noarch" octave-doctest-0.6.1-1 as I am preparing the next octave and octave forge releases can you remove 0.4.1 and 0.5.0

Re: [PATCH setup] Finish providing support for provides: and conflicts:

2018-06-06 Thread Jon Turney
On 04/04/2018 14:21, Ken Brown wrote: On 3/21/2018 3:38 PM, Ken Brown wrote: Introduce member functions SolvableVersion::provides() and SolvableVersion::conflicts().  This enables packagedb::read() to access provides and conflicts lists from setup.ini. Ignore this patch.  It breaks libsolv's

Re: [PATCH setup] Sort the packages listed in the "confirm" dialog

2018-06-06 Thread Jon Turney
On 18/03/2018 16:31, Ken Brown wrote: --- confirm.cc | 44 ++-- 1 file changed, 30 insertions(+), 14 deletions(-) Applied, thanks. I know you had a few other patchsets in flight, which I've unfortunately taken my eye off. If it's easier, you could

[PATCH cygport] Fix handling of python{2,3} atoms in DEPEND

2018-05-13 Thread Jon Turney
python{2,3} atoms are not deparenthesized correctly, as that function assumes the atom type consists of lowercase alphabetic characters only. Probably also need to allow uppercase alphabetic characters as well, to allow R atoms to work... Signed-off-by: Jon Turney <jon.tur...@dronecode.org

[PATCH cygport] Handle meson configuration options containing spaces

2018-05-13 Thread Jon Turney
Similarly to cygconf, cygmeson should protect configuration options containing spaces from word splitting so that e.g. cygmeson "-Dstring_option=foo bah" works as expected. Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- cygclass/meson.cygclass | 2 +- 1 file chan

Re: cygwin-htdocs.git log failure

2018-05-08 Thread Jon Turney
On 08/05/2018 08:24, Marco Atzeri wrote: Hi, while pushing a change on cygwin-pkg-maint I see: $ git push Enter passphrase for key '/home/marco/.ssh/id_rsa': Counting objects: 3, done. Delta compression using up to 4 threads. Compressing objects: 100% (3/3), done. Writing objects: 100% (3/3),

Re: RFC: setup package in Base

2018-04-11 Thread Jon Turney
On 11/04/2018 00:14, Ken Brown wrote: On 4/10/2018 2:12 PM, Yaakov Selkowitz wrote: In order to speed up the adoption of the latest setup.exe, would it make sense to ship it as a package?  Here is an initial draft of what this might look like:

Re: upload cygcheck-dep to noarch directory

2018-04-09 Thread Jon Turney
On 09/04/2018 13:44, Mikhail Usenko via cygwin-apps wrote: Please, move cygcheck-dep to noarch/release hierarchy, so that the new version can be uploaded appropriately. Done. Sorry for the inconvenience.

Re: [Bug] Re3gression in setup handling of SHA512 checksum failures

2018-03-22 Thread Jon Turney
On 21/03/2018 18:14, Ken Brown wrote: On 3/20/2018 4:11 PM, Achim Gratz wrote: Ken Brown writes: I'll look into both of these issues, unless Jon beats me to it. Thanks. By the way, this only affects local installs.  For network installs, the hash gets checked at an earlier stage. That's

Re: [PATCH setup] Link with -lws2_32 again

2018-03-22 Thread Jon Turney
On 20/03/2018 21:42, Yaakov Selkowitz wrote: libgpg-error 1.28 includes new APIs which use socket functions, which on Win32 are provided by WinSock2. https://cygwin.com/ml/cygwin/2018-03/msg00306.html Signed-off-by: Yaakov Selkowitz Thanks.

Re: Problem with packagesource::sites in setup

2018-03-15 Thread Jon Turney
On 15/03/2018 21:23, Ken Brown wrote: I think we're currently mishandling packagesource::sites when several libsolv repos contain the same version of a package.  If I'm not mistaken, we create a new packageversion pv for each repo, and pv.source()->sites contains a single site, corresponding

Re: setup: problems with local install

2018-03-15 Thread Jon Turney
On 14/03/2018 19:24, Ken Brown wrote: On 3/14/2018 12:07 PM, Jon Turney wrote: On 12/03/2018 13:22, Ken Brown wrote: On 3/8/2018 4:59 PM, Ken Brown wrote: On 3/8/2018 10:59 AM, Ken Brown wrote: On 3/7/2018 4:52 PM, Ken Brown wrote: On 3/6/2018 1:47 PM, Jon Turney wrote: On 06/03/2018 15:18

Re: setup: problems with local install

2018-03-14 Thread Jon Turney
On 12/03/2018 13:22, Ken Brown wrote: On 3/8/2018 4:59 PM, Ken Brown wrote: On 3/8/2018 10:59 AM, Ken Brown wrote: On 3/7/2018 4:52 PM, Ken Brown wrote: On 3/6/2018 1:47 PM, Jon Turney wrote: On 06/03/2018 15:18, Jon Turney wrote: So yeah, I guess putting some complexity back in accessible

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
On 06/03/2018 19:31, Ken Brown wrote: On 3/6/2018 10:18 AM, Jon Turney wrote: (I also note we have also have another 'erase an element from a vector while we are iterating over it' here, so that needs fixing, as well) I think this one might be OK.  If I'm not mistaken, pkg.versions.erase(i

Re: [PATCH setup 2/2] Improve file:// url handling

2018-03-06 Thread Jon Turney
On 28/02/2018 11:51, SZAVAI Gyula wrote: As a repo url, we're accepting * raw windows paths (with both \ and /) c:\cygwin repo \\machine\share\cygwin repo * proper file: urls file:///c:/cygwin%20repo file://machine/share/cygwin%20repo Most non-standard urls accepted by the old code

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
On 06/03/2018 15:18, Jon Turney wrote: So yeah, I guess putting some complexity back in accessible() would work, or perhaps the attached?  (This doesn't do the right thing for a few packages, for reasons I'm still looking into...) To be specific it was doing the wrong thing for those few

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
ne in the following commit: commit 0c539f7f7d86fb100f260f21367682fa2c0bb529 Author: Jon Turney <jon.turney-grjqepx9rppajuda+fb...@public.gmane.org> Date:   Sat Nov 4 18:01:49 2017 +     Correctly order preparing packagedb for chooser I think the problem might be that createListview(

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
es which have corrupt local copies or something? It would be clearer to omit the whole thing in that case. From d8aac08cf3d1ddf98ab9a6a8706b2c7b8bdfd7ad Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Tue, 6 Mar 2018 14:56:40 + Subject: [PATCH set

Re: Planned setup.ini changes for early 2018

2018-03-01 Thread Jon Turney
On 01/03/2018 16:39, Marco Atzeri wrote: On 01/03/2018 17:00, Jon Turney wrote: I've done this migration today. Have you stopped calm schedule ? It seem not reactive calm was stopped between 02:00 and 15:45 UTC today. Your postgres upload has been processed, but no email was sent

Re: Planned setup.ini changes for early 2018

2018-03-01 Thread Jon Turney
On 10/01/2018 22:44, Jon Turney wrote: * Migrate from setup.hint to pvr.hint in release area I also plan to migrate all remaining setup.hints to pvr.hints in the release area (setup.hint in uploads have been automatically migrated since [5]). This should have no effect on the generated

Re: version anomalies

2018-02-27 Thread Jon Turney
On 26/02/2018 21:38, Tony Kelman wrote: [f] https://cygwin.com/ml/cygwin/2015-03/msg00384.html socat 2.0.0-b7-1 was relabelled as test I'm seeing an attempted update to socat 2.0.0-b8-1 (which doesn't even exist on the mirror I'm using, AFAICT) so that may need the same treatment? Slightly

Re: [PATCH setup] Add setup-minimum-version: to setup.ini

2018-02-26 Thread Jon Turney
On 26/02/2018 17:10, cyg Simple wrote: On 2/26/2018 9:02 AM, Jon Turney wrote: This allows setup.ini to require a certain setup version, rather than advise a newer version when one is available. Unfortunately, versions of setup prior to this one don't implement this, but at least we have

[PATCH setup] Add setup-minimum-version: to setup.ini

2018-02-26 Thread Jon Turney
This allows setup.ini to require a certain setup version, rather than advise a newer version when one is available. Unfortunately, versions of setup prior to this one don't implement this, but at least we have this going forward. When we want to start using this, we can break backwards

Re: setup 2.888 crashes on --prune-install

2018-02-26 Thread Jon Turney
On 24/02/2018 14:58, Jon Turney wrote: On 20/02/2018 18:33, Andrew Schulman wrote: [...] Problem 1/97 ! Augmented Transaction List:     0   erase    base 0.0-0 !! Yeah, that's not working right... :( I fixed the crash problem in 2.889

Re: version anomalies

2018-02-24 Thread Jon Turney
On 24/02/2018 15:39, Jon Turney wrote: I've added replace-versions: annotations in override.hint for the below: [...] It's increasingly pointless to compensate for mistakes the longer ago they were made, so I don't think I'll bother doing anything about even older mistakes which only

Re: version anomalies

2018-02-24 Thread Jon Turney
I've added replace-versions: annotations in override.hint for the below: On 31/01/2018 17:58, Jon Turney wrote: This finds the following anomalies for x86_64: [...] [a] https://cygwin.com/ml/cygwin/2018-01/msg00204.html gcc 6.4.0-5 was relabelled as test (now current again since cygwin

Re: Remove legacy networking code

2018-02-24 Thread Jon Turney
On 28/01/2018 21:47, Jon Turney wrote: On 26/01/2018 16:56, SZAVAI Gyula wrote: [PATCH setup 1/5] Remove direct(legacy) connection type [PATCH setup 2/5] Rename IDC_NET_IE5 to IDC_NET_PRECONFIG [PATCH setup 3/5] Remove NetIO_File [PATCH setup 4/5] Add Proxy class [PATCH setup 5/5] Remove

Re: setup 2.888 crashes on --prune-install

2018-02-24 Thread Jon Turney
On 20/02/2018 18:33, Andrew Schulman wrote: When I run setup-x86_64.exe or setup-x86.exe with --prune-install as shown below, it crashes. An error dialog pops up saying "setup-x86.exe has stopped working". No other debug information appears on the console - the whole session is shown below.

Re: setup 2.887 release candidate - please test

2018-02-15 Thread Jon Turney
On 14/02/2018 23:02, Ken Brown wrote: On 2/6/2018 10:04 AM, Jon Turney wrote: A new setup release candidate is available at:    https://cygwin.com/setup/setup-2.887.x86_64.exe (64 bit version)    https://cygwin.com/setup/setup-2.887.x86.exe    (32 bit version) Please test and report any

[PATCH cygport 3/3] Don't allow SRC_URI or PATCH_URI to depend on ARCH

2018-02-13 Thread Jon Turney
The values which SRC_URI and PATCH_URI evaluate to should not change depending on ARCH, as this will make the source package arch-dependent --- bin/cygport.in | 26 ++ 1 file changed, 26 insertions(+) diff --git a/bin/cygport.in b/bin/cygport.in index c3370e1..2b603d4

[PATCH cygport 2/3] Add src_patch_apply_hook

2018-02-13 Thread Jon Turney
--- lib/check_funcs.cygpart | 1 + lib/src_prep.cygpart| 18 ++ 2 files changed, 19 insertions(+) diff --git a/lib/check_funcs.cygpart b/lib/check_funcs.cygpart index 961f263..224a7b1 100644 --- a/lib/check_funcs.cygpart +++ b/lib/check_funcs.cygpart @@ -687,6 +687,7 @@

[PATCH cygport 1/3] Document src_unpack_hook and src_patch_hook

2018-02-13 Thread Jon Turney
Mention that these are unstable API and may be change in future. --- lib/src_prep.cygpart | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/src_prep.cygpart b/lib/src_prep.cygpart index 1e9247a..2277ba4 100644 --- a/lib/src_prep.cygpart +++

[PATCH cygport 0/3] Don't allow source packages to differ by arch

2018-02-13 Thread Jon Turney
This is where I got to, after the discussion at [1]. [1] https://cygwin.com/ml/cygwin-apps/2017-05/msg00050.html Jon Turney (3): Document src_unpack_hook and src_patch_hook Add src_patch_apply_hook Don't allow SRC_URI or PATCH_URI to depend on ARCH bin/cygport.in | 26

[PATCH cygport 0/2] Better handling of build requires (v2)

2018-02-13 Thread Jon Turney
v2: BUILD_REQUIRES Jon Turney (2): Rename DEPEND to BUILD_REQUIRES Pass BUILD_REQUIRES through to .hint for source package as build-requires: bin/cygport.in | 7 +++ lib/check_funcs.cygpart | 10 ++ lib/pkg_pkg.cygpart | 5 + 3 files changed, 18 insertions

[PATCH cygport 2/2] Pass BUILD_REQUIRES through to .hint for source package as build-requires:

2018-02-13 Thread Jon Turney
Converting a dependency atom to a package name with full generality requires a database of all the pathnames contained in all packages, so we don't even try to do that here. In the fullness of time, calm may have the information needed to perform that task, at which time it can start emitting

[PATCH cygport 1/2] Rename DEPEND to BUILD_REQUIRES

2018-02-13 Thread Jon Turney
Somewhat clearer as to it's purposes, and pluralized for consistency with REQUIRES. Still support the previous name for backwards compatibility v2: Do backwards compatibility correctly so it works when not doing 'all' --- bin/cygport.in | 7 +++ lib/check_funcs.cygpart | 10

Re: [PATCH rebase 0/2] Avoid unncessary rebases

2018-02-13 Thread Jon Turney
On 09/02/2018 11:59, Jon Turney wrote: Add some dignostics which report why a rebase is taking place. Use that information to fix some errors causing unnecessary rebases After these fixes, 'rebase -s' is relatively quick, with a warm disk cache. But (i) we still read and extract

Re: [PATCH cygport 0/2] Better handling of build depends

2018-02-13 Thread Jon Turney
On 13/02/2018 06:31, Yaakov Selkowitz wrote: On 2017-10-03 14:53, Jon Turney wrote: Jon Turney (2): Rename DEPEND to BUILD_DEPENDS Pass BUILD_DEPENDS through to .hint for source package as build-depends: Why can't this be BUILD_REQUIRES and build-requires: ? No reason at all. I

Re: [PATCH cygport] Produce obsoletes: headers in .hint files

2018-02-13 Thread Jon Turney
On 13/02/2018 06:30, Yaakov Selkowitz wrote: On 2018-02-06 15:13, Jon Turney wrote: lib/pkg_pkg.cygpart | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/pkg_pkg.cygpart b/lib/pkg_pkg.cygpart index 0dba03d..aa6f0e8 100644 --- a/lib/pkg_pkg.cygpart +++ b/lib/pkg_pkg.cygpart

[PATCH 2/2] Fix some errors which cause unnecessary rebases

2018-02-09 Thread Jon Turney
Also add some parentheses for clarity --- rebase.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/rebase.c b/rebase.c index 0aad1b2..1c8fe7a 100644 --- a/rebase.c +++ b/rebase.c @@ -750,8 +750,8 @@ merge_image_info () } /* However, if the

[PATCH rebase 0/2] Avoid unncessary rebases

2018-02-09 Thread Jon Turney
to keep around the infomation to do that, currently. Jon Turney (2): Make verbose give a reason why a rebase is needed Fix some errors which cause unnecessary rebases rebase.c | 59 ++- 1 file changed, 46 insertions(+), 13 deletions

[PATCH 1/2] Make verbose give a reason why a rebase is needed

2018-02-09 Thread Jon Turney
--- rebase.c | 47 --- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/rebase.c b/rebase.c index 6f98d37..0aad1b2 100644 --- a/rebase.c +++ b/rebase.c @@ -649,7 +649,16 @@ merge_image_info () { /* Reuse

[PATCH cygport] Produce obsoletes: headers in .hint files

2018-02-06 Thread Jon Turney
Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- lib/pkg_pkg.cygpart | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/pkg_pkg.cygpart b/lib/pkg_pkg.cygpart index 0dba03d..aa6f0e8 100644 --- a/lib/pkg_pkg.cygpart +++ b/lib/pkg_pkg.cygpart @@ -718,6 +718,11 @@ re

setup 2.887 release candidate - please test

2018-02-06 Thread Jon Turney
A new setup release candidate is available at: https://cygwin.com/setup/setup-2.887.x86_64.exe (64 bit version) https://cygwin.com/setup/setup-2.887.x86.exe(32 bit version) Please test and report any problems here. This is not the place for setup feature requests. Changes compared to

Re: setup 2.886 release candidate - please test

2018-02-03 Thread Jon Turney
On 02/02/2018 19:38, Achim Gratz wrote: Jon Turney writes: Do you have an idea yet why the last package gets orphaned (or did, if 'Yet'? This is the first time I've heard of this! Right you are. I thought I had mentioned it already, but forgot since I can't post from work

Re: [ITP] neomutt

2018-02-02 Thread Jon Turney
On 31/01/2018 19:21, Federico Kircheis wrote: On 01/31/2018 06:55 PM, Jon Turney wrote: On 30/01/2018 05:56, Federico Kircheis wrote: On 01/28/2018 03:43 PM, Jon Turney wrote: On 28/01/2018 11:38, Federico Kircheis wrote: Name: Federico Kircheis Package: neomutt Done Uploaded. Please

Re: setup 2.886 release candidate - please test

2018-02-02 Thread Jon Turney
On 01/02/2018 20:21, Achim Gratz wrote: Jon Turney writes: A new setup release candidate is available at: https://cygwin.com/setup/setup-2.886.x86.exe(32 bit version) https://cygwin.com/setup/setup-2.886.x86_64.exe (64 bit version) Locally compiled, but not well tested yet

setup 2.886 release candidate - please test

2018-02-01 Thread Jon Turney
A new setup release candidate is available at: https://cygwin.com/setup/setup-2.886.x86.exe(32 bit version) https://cygwin.com/setup/setup-2.886.x86_64.exe (64 bit version) Since this contains many internal changes, I think this could use some wider testing before being deployed.

version anomalies

2018-01-31 Thread Jon Turney
clear what to do about these. [1] https://github.com/jon-turney/version-anomalies [2] https://cygwin.com/ml/cygwin-apps/2018-01/msg00047.html

Re: [ITP] neomutt

2018-01-31 Thread Jon Turney
On 30/01/2018 05:56, Federico Kircheis wrote: On 01/28/2018 03:43 PM, Jon Turney wrote: On 28/01/2018 11:38, Federico Kircheis wrote: Name: Federico Kircheis Package: neomutt Done Uploaded. Please upload a x86 package as well.

Re: setup 2.885 release candidate - please test

2018-01-31 Thread Jon Turney
On 30/01/2018 20:18, Jon Turney wrote: On 29/01/2018 19:19, Achim Gratz wrote: Jon Turney writes: [...]>>> - The "prereq" page showing dependencies which will be added is replaced by "problems" page showing problems found by the dependency solver, with default

Re: setup 2.885 release candidate - please test

2018-01-31 Thread Jon Turney
On 30/01/2018 20:18, Jon Turney wrote: On 30/01/2018 18:49, Achim Gratz wrote: Another thing I noticed today is that when packages get upgraded the transaction list that gets printed to the console seems to always show the removal of the old package _after_ the installation of the new version

Re: setup 2.885 release candidate - please test

2018-01-30 Thread Jon Turney
On 30/01/2018 18:49, Achim Gratz wrote: Achim Gratz writes: - Add support for 'depends2: package (relation version) [...]', in a version section in setup.ini Those lines don't seem to get generated for all packages yet. I currently merge with requires: to produce a working setup.ini re-write

Re: setup 2.885 release candidate - please test

2018-01-30 Thread Jon Turney
On 29/01/2018 19:19, Achim Gratz wrote: Jon Turney writes: Since this contains many internal changes, I think this could use some wider testing before being deployed. Please test and report any problems here. I've built these myself, but I don't think that changes anything below. Thanks

Re: Remove legacy networking code

2018-01-28 Thread Jon Turney
On 26/01/2018 16:56, SZAVAI Gyula wrote: [PATCH setup 1/5] Remove direct(legacy) connection type [PATCH setup 2/5] Rename IDC_NET_IE5 to IDC_NET_PRECONFIG [PATCH setup 3/5] Remove NetIO_File [PATCH setup 4/5] Add Proxy class [PATCH setup 5/5] Remove NetIO_HTTP Thanks, this is great. A few

Re: [PATCH setup libsolv, v2] Let the user review added dependencies

2018-01-28 Thread Jon Turney
On 25/01/2018 03:57, Ken Brown wrote: On 1/24/2018 10:25 PM, Ken Brown wrote: On 1/24/2018 3:30 PM, Jon Turney wrote: On 22/01/2018 17:37, Ken Brown wrote: If the solver found no problems but added packages to resolve dependencies, ask the user whether they want to review the added packages

setup 2.885 release candidate - please test

2018-01-28 Thread Jon Turney
A new setup release candidate is available at: https://cygwin.com/setup/setup-2.885.x86.exe(32 bit version) https://cygwin.com/setup/setup-2.885.x86_64.exe (64 bit version) Since this contains many internal changes, I think this could use some wider testing before being deployed.

Re: Planned setup.ini changes for early 2018

2018-01-28 Thread Jon Turney
On 22/01/2018 23:13, Jon Turney wrote: On 10/01/2018 22:44, Jon Turney wrote: * Add depends: to version descriptions This is a version-specific list of required packages (as opposed to requires:, which is per-package, and contains the union of the dependencies for all versions). I believe

Re: [ITP] cmark: CommonMark parsing and rendering library

2018-01-28 Thread Jon Turney
On 21/01/2018 23:30, David Stacey wrote: 'cmark' is a prerequisite for the latest version of mkvtoolnix-gui. 'cmark' is found in most major distros - see https://pkgs.org/download/cmark The library does not have a 'so' version. I've had a look to see how the major distros cope with this, and

Re: [ITP] neomutt

2018-01-28 Thread Jon Turney
On 28/01/2018 11:38, Federico Kircheis wrote: Name: Federico Kircheis Package: neomutt Done

Re: [ITP] neomutt

2018-01-26 Thread Jon Turney
On 24/01/2018 18:07, Federico Kircheis wrote: On 01/21/2018 09:18 PM, Federico Kircheis wrote: On 01/21/2018 06:51 PM, Jon Turney wrote: Maybe it's not a good idea to describe it as a fork of Mutt, when https://www.neomutt.org/about.html says "It's not a fork of Mutt. It's a larg

Re: [PATCH setup libsolv, v2] Let the user review added dependencies

2018-01-24 Thread Jon Turney
, this just contains a simple text report, but I guess this could be extended e.g. to use a grid control, or give reasons for why packages are being installed. From f73030816b16d9dbcb0ed13ce84ee6c7914d8c3e Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Tue, 23 Jan 2

[PATCH setup] Make any MessageBox shown by the GuiParseFeedback class modal to the progress page

2018-01-23 Thread Jon Turney
--- ini.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ini.cc b/ini.cc index e9152ec..87443a8 100644 --- a/ini.cc +++ b/ini.cc @@ -108,11 +108,11 @@ public: } virtual void warning (const std::string& message)const { - mbox (0, message.c_str (),

Re: [PATCH setup] Send User-Agent even when setup-specific proxy is used

2018-01-19 Thread Jon Turney
On 18/01/2018 19:16, SZAVAI Gyula wrote: Setup is sending User-Agent header if direct connection or system proxy is used, but not when direct(legacy) or setup-specific proxy. Fix this. Thanks for the patch. This is fine, as far as it goes. However, I don't think 'direct(legacy)' is actually

Re: setup with experimental libsolv-based dependency solving

2018-01-18 Thread Jon Turney
On 23/11/2017 18:08, Jon Turney wrote: On 30/10/2017 15:52, Jon Turney wrote: On 25/10/2017 20:18, Jon Turney wrote: This has a lot of internal changes, so could use some wider testing. Please test. [...] I've replaced these with: [...] I've replaced these with: [...] I've replaced

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-18 Thread Jon Turney
On 15/01/2018 21:48, Ken Brown wrote: On 1/15/2018 2:01 PM, Jon Turney wrote: On 13/01/2018 19:56, Ken Brown wrote: [...]>>> 1. I think the code you added to PrereqPage::OnNext() also needs to be added to PrereqPage::OnBack(). Hmm... not sure. I don't thin

Re: Removing a faulty package?

2018-01-15 Thread Jon Turney
On 15/01/2018 18:37, Andy Li wrote: On Tue, Jan 16, 2018 at 12:43 AM, Jon Turney wrote: https://cygwin.com/package-upload.html#deleting should work. Indeed, thanks! Another question: Is there a way to list all the packages that depends on a dll? Currently the libgc1 package contains 3 dll

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-15 Thread Jon Turney
On 13/01/2018 19:56, Ken Brown wrote: On 1/13/2018 9:14 AM, Jon Turney wrote: On 09/01/2018 15:49, Ken Brown wrote: On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work as expected.  Even though "Unin

Re: Planned setup.ini changes for early 2018

2018-01-15 Thread Jon Turney
On 13/01/2018 18:35, Achim Gratz wrote: Jon Turney writes: * De-duplicate source archives Source archives which are identical[2] between x86 and x86_64 will be moved to paths starting src/ in the release area. You keep acting like using a new src/ hierarchy was already decided upon, yet I

Re: Removing a faulty package?

2018-01-15 Thread Jon Turney
On 15/01/2018 16:36, Andy Li wrote: I made a mistake when updating libgc. The new version bumped the so version so it now ships cyggc-2.dll instead of cyggc-1.dll, but I didn't rename the libgc1 package to libgc2. Is there a way to take down the new version (7.6.2)?

Re: Planned setup.ini changes for early 2018

2018-01-13 Thread Jon Turney
On 12/01/2018 18:11, Peter A. Castro wrote: On Fri, 12 Jan 2018, Jon Turney wrote: On 11/01/2018 17:53, Peter A. Castro wrote: On Wed, 10 Jan 2018, Jon Turney wrote: * Add depends: to version descriptions This is a version-specific list of required packages (as opposed to requires:, which

Re: Planned setup.ini changes for early 2018

2018-01-13 Thread Jon Turney
On 10/01/2018 23:27, David Stacey wrote: On 10/01/18 22:44, Jon Turney wrote: * Add depends: to version descriptions * De-duplicate source archives * Migrate from setup.hint to pvr.hint in release area That all sounds good to me. Regarding the de-duplication of source files: will sources

Re: [PATCH setup v3] Query the user if a corrupt local file is found

2018-01-13 Thread Jon Turney
On 10/01/2018 02:59, Ken Brown wrote: Also reorganize package validation. Move the size-validation code in download.cc and the hash-validation code in install.cc into new member functions of the packagesource class. Add a bool member 'validated' to the class to make sure that the checking is

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-13 Thread Jon Turney
On 09/01/2018 15:49, Ken Brown wrote: On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work as expected.  Even though "Uninstall A" was the first solution, A didn't get uninstalled. In case you want to replicate this,

Re: Planned setup.ini changes for early 2018

2018-01-12 Thread Jon Turney
On 11/01/2018 17:53, Peter A. Castro wrote: On Wed, 10 Jan 2018, Jon Turney wrote: * Add depends: to version descriptions This is a version-specific list of required packages (as opposed to requires:, which is per-package, and contains the union of the dependencies for all versions). I

Planned setup.ini changes for early 2018

2018-01-10 Thread Jon Turney
* Add depends: to version descriptions This is a version-specific list of required packages (as opposed to requires:, which is per-package, and contains the union of the dependencies for all versions). I believe that historical setup versions will either ignore, or can handle depends:

Re: setup libsolv UI: Silently install dependencies?

2018-01-09 Thread Jon Turney
On 05/01/2018 16:04, Ken Brown wrote: On 1/5/2018 10:48 AM, Jon Turney wrote: On 24/12/2017 23:23, Ken Brown wrote: Currently the libsolv version of setup silently installs added dependencies.  The user gets a chance to review them first only if libsolv finds problems and has to display

Re: setup libsolv UI: Silently install dependencies?

2018-01-09 Thread Jon Turney
On 25/12/2017 19:18, Ken Brown wrote: [Side comment: Jon, in v2 of commit 9367283, you removed some newlines, saying that they weren't needed because wrapping would be done.  But I'm not seeing that wrapping; I have to scroll horizontally to see the whole text.] Yeah, what I wrote was

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2018-01-09 Thread Jon Turney
attached. From a60bbd19aa5504e0e7da6722dc7f3b81ac3afd6b Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Wed, 6 Dec 2017 17:52:45 + Subject: [PATCH setup] Apply default solution(s) Refactoring of SolverSolution::update() so we can apply the default solution.

Re: [PATCH setup] Throw exceptions instead of exiting with error codes

2018-01-08 Thread Jon Turney
On 20/12/2017 16:25, Ken Brown wrote: On 12/20/2017 11:06 AM, Jon Turney wrote: On 19/12/2017 17:20, Ken Brown wrote: ---   Exception.h |  1 +   PickView.cc | 11 +++   choose.cc   |  7 +--   3 files changed, 13 insertions(+), 6 deletions(-) Yeah, silently dying seems like a bad

Re: calm: cygwin package upload report from sourceware.org for Erwin Waterlander

2018-01-07 Thread Jon Turney
On 07/01/2018 20:43, cygwin-no-re...@cygwin.com wrote: ERROR: package 'libunistring-devel' version '0.9.8-1' is missing source ERROR: error while validating merged x86 packages for Erwin Waterlander SUMMARY: 5 INFO(s), 2 ERROR(s) The libunitstring-devel hint file appears to be missing

Re: setup libsolv UI: Silently install dependencies?

2018-01-05 Thread Jon Turney
On 24/12/2017 23:23, Ken Brown wrote: Currently the libsolv version of setup silently installs added dependencies.  The user gets a chance to review them first only if libsolv finds problems and has to display the prerequisite page. I'm not sure if this was a deliberate design decision,

Re: [PATCH setup] Query the user if a corrupt local file is found

2018-01-05 Thread Jon Turney
On 16/12/2017 18:37, Ken Brown wrote: If a corrupt file is found in one of the selected mirror site directories, offer to delete it instead of making this a fatal error. Do this only on the first call to check_for cached(). If the corrupt file is still there on the second call, then the

Re: setup libsolv: getting rid of ".any"

2018-01-05 Thread Jon Turney
On 13/12/2017 00:04, Ken Brown wrote: I've been trying to think of a way to get rid of the suffix ".any" that gets appended to package names.  I think users will be confused by this when they see it in log files and, more importantly, in problem reports.  The only thing I can come up with is

Re: [PATCH setup] Make sure that fatal error messages are visible

2018-01-05 Thread Jon Turney
On 28/12/2017 01:38, Ken Brown wrote: On 12/21/2017 5:55 PM, Ken Brown wrote: On 12/20/2017 12:09 PM, Ken Brown wrote: On 12/20/2017 11:19 AM, Jon Turney wrote: On 19/12/2017 00:53, Ken Brown wrote: The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously

Re: calm and library bump

2017-12-31 Thread Jon Turney
On 31/12/2017 11:59, Marco Atzeri wrote: first time I see a problem on library bump upload and it is not reporting for "ntl" that has also a bump. Because it doesn't end with digits, 'libflint' isn't automatically recognized as an old soversion and excluded from this check. I added an

Re: [PATCH setup] Make sure that fatal error messages are visible

2017-12-20 Thread Jon Turney
On 19/12/2017 00:53, Ken Brown wrote: The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously being displayed, so that setup appeared to hang. Fix this by giving fatal error message boxes type MB_SETFOREGROUND. This is good as far as it goes, but is kind of

Re: [PATCH setup] Throw exceptions instead of exiting with error codes

2017-12-20 Thread Jon Turney
On 19/12/2017 17:20, Ken Brown wrote: --- Exception.h | 1 + PickView.cc | 11 +++ choose.cc | 7 +-- 3 files changed, 13 insertions(+), 6 deletions(-) Yeah, silently dying seems like a bad idea. Hmmm... does this not need a corresponding use of TOPLEVEL_CATCH to

Re: [RFC] calm, setup: per-version requires

2017-12-11 Thread Jon Turney
On 05/12/2017 18:14, Achim Gratz wrote: Jon Turney writes: 2.880 onwards: The curr: version will get the union of 'depends:' and 'requires:', other versions will get 'requires:'. Actually it's worse than that, it just concatenates requires: and any depends: lines, applying the current

setup 2.883 release candidate - please test

2017-12-11 Thread Jon Turney
A new setup release candidate is available at: https://cygwin.com/setup/setup-2.883.x86.exe(32 bit version) https://cygwin.com/setup/setup-2.883.x86_64.exe (64 bit version) Please test and report problems to cyg...@cygwin.com. If no regressions are discovered in the next week or so,

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

2017-12-08 Thread Jon Turney
On 08/12/2017 14:47, Ken Brown wrote: On 12/7/2017 11:55 PM, Brian Inglis wrote: On 2017-12-07 13:46, Ken Brown wrote: In my testing, 'Next' does indeed become the default button after I click outside of the textbox, but there's no visual indication of this. The MSDN page for DM_SETDEFID

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

2017-12-08 Thread Jon Turney
On 07/12/2017 20:46, Ken Brown wrote: On 12/7/2017 1:35 PM, Jon Turney wrote: On 05/12/2017 17:32, Ken Brown wrote: On 12/5/2017 11:03 AM, Ken Brown wrote: On 12/5/2017 7:58 AM, Jon Turney wrote: The search textbox on the package chooser page needs the same fix. It's not immediately clear

Re: [PATCH setup v3 0/6] Distinguish between user URLs and cygwin mirrors in UI

2017-12-07 Thread Jon Turney
On 07/12/2017 15:07, Ken Brown wrote: On 12/7/2017 8:55 AM, Jon Turney wrote: On 06/12/2017 22:15, Brian Inglis wrote: On 2017-12-06 14:55, Ken Brown wrote: On 12/6/2017 4:07 PM, Brian Inglis wrote: On 2017-12-06 13:45, Ken Brown wrote: This is a followup to     https://cygwin.com/ml/cygwin

Re: [PATCH setup v3 0/6] Distinguish between user URLs and cygwin mirrors in UI

2017-12-07 Thread Jon Turney
On 06/12/2017 22:15, Brian Inglis wrote: On 2017-12-06 14:55, Ken Brown wrote: On 12/6/2017 4:07 PM, Brian Inglis wrote: On 2017-12-06 13:45, Ken Brown wrote: This is a followup to    https://cygwin.com/ml/cygwin-apps/2011-04/msg00014.html, in which Jon suggested splitting site selection

Re: [RFC] calm, setup: per-version requires

2017-12-05 Thread Jon Turney
On 09/11/2017 18:18, Achim Gratz wrote: Jon Turney writes: On 05/11/2017 07:34, Achim Gratz wrote: Yeah, I guess we could generate requires: line in each version section now, and this might work with current setup. I don't think this did anything useful prior to [1] being fixed. Yes

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-12-05 Thread Jon Turney
On 14/09/2017 21:46, Ken Brown wrote: On 9/14/2017 1:26 PM, Achim Gratz wrote: Ken Brown writes: What I've been struggling with, however, is the UI.  But now that I think about it, maybe it isn't that hard.  It's just a matter of doing something reasonable if the user unchecks "Accept default

Re: [PATCH setup v2 0/5] Distinguish between user URLs and cygwin mirrors in UI

2017-12-05 Thread Jon Turney
On 04/12/2017 21:48, Ken Brown wrote: On 12/4/2017 10:18 AM, Ken Brown wrote: This is the same as the previous patch series with one cosmetic improvement: I've now made user URLs sort last, so that the distinction between user URLs and cygwin.com mirrors is visually more clear. Sorry for

<    5   6   7   8   9   10   11   12   13   14   >