Re: pine setup.hint update needed?
On Mon, 29 Sep 2008, Corinna Vinschen wrote: Igor, On Aug 30 19:34, Christopher Faylor wrote: - Forwarded message from Sagar Chaki - hello, pine 4.58 needs cygcrypto-0.9.7.dll, which is provided by openssl097. however, it seems that openssl097 is not automatically installed along with pine 4.58. thanks - End forwarded message - I think the right thing(TM) to do here would be to upload a new pine release which is linked against openssl-0.9.8. Openssl 0.9.7 is outdated and has security issues. Hi, Corinna, Yes, that's the right thing to do, and I will try to do this early next week (will be without internet access all weekend). In the meantime, please add openssl097 to the requires: line in pine's setup.hint. Thanks, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: Putting my packages up for adoption
On Wed, 30 Apr 2008, Warren Young wrote: Please email me the package build scripts, and brief instructions on their use. I maintain the ctags package, but do so with hand-rolled tools due to weirdnesses of its build system. So, I know how to build Cygwin packages, but I don't know how to build _your_ packages. :) Warren, Downloading the corresponding source packages from the Cygwin mirrors should give you the exact set of tools used to build the packages. Depending on the packaging method, it could be as simple as running a script. HTH, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [HEADSUP] Let's start a Cygwin 1.7 release area
On Sat, 12 Apr 2008, Brian Dessent wrote: Unresolved issues with this plan: - What are we going to do about text/binary mode? To maintain the setting, setup would have to be taught to parse/write fstab. Ugh. Plan B would be to say that if you want textmode you have to edit fstab yourself. That has the advantage of making it harder to use textmode, which leads to fewer bugreports. On the other hand, the small army of insane people that do actually use textmode will probably be mad that they have to manually edit config files (the horror!) because the setup tool no longer has a choice. Hmm. Even now, one does not have to edit the registry to switch from binary mode to text mode -- you just need to re-mount with the appropriate option. I assume the same will hold for the /etc/fstab approach. It might make it easier if mount understood absolute POSIX paths as well (i.e., mount -t /etc/text /etc/text should work). If we taught mount to do this now and removed the Text option from setup altogether, complainers could be directed to the mount manpage. Then switching to the new setup won't be that much of a pain (at least in the text/binary department). - Do we really want to pick a new key for $newkey, or wedge it into the same existing location somehow? I admit that I do find it a bit silly that Cygwin still installs under Cygnus Solutions, and since a 1.7 DLL will not even look at the registry I guess it is proper to move to a totally new key for this setting. And of course for the 1.7 testing period we'd want it to be separate. But I mean long term, are we making 3rd parties lives easier or harder by having two totally different places/formats to check for an existing install of Cygwin? I agree that naming the new key Cygnus Solutions is silly, beyond certain nostalgic value. But one thing to consider is that by adding a registry key, we're setting things up for one dominant installation of Cygwin. So people juggling multiple installations really *will* have to go edit the registry to switch -- no more nice mount -m approach, since the mounts will no longer apply anyway. Also, things like heap_chunk_in_mb currently live in the registry. Will they stay there? Will we instead have /etc/cygwinopts (or move it to $CYGWIN)? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [HEADSUP] Let's start a Cygwin 1.7 release area
On Thu, 3 Apr 2008, Corinna Vinschen wrote: [snip] Get own path == C:\\cygwin\\bin\\cygwin1.dll Where's fstab? == C:\\cygwin\\etc\\fstab So, it implicitly computes where / is? No, it doesn't. It just snips away the last two path components and tacks the etc/fstab string on. Plus the .$SID to get the user mounts. After the mount points have been read, root can potentially be somewhere else entirely. So would it make sense to put the root mount info in the same directory as cygwin1.dll? I know it doesn't belong in /bin, but playing with relative paths is even more error-prone. [snip] For 1.7, I think we ought to decouple /bin /usr/bin and /lib /usr/lib. The rationale for keeping those linked no longer applies in the modern setup.exe world. Full ACK! However, this needs a bit of careful revisiting of some of the packages. For instance, assuming the Cygwin DLL will go to /bin, cygrunsrv should also reside in /bin when we do this, not in /usr/bin, obviously. Umm, i don't see how that follows. cygrunsrv can easily reside in /usr/bin, as long as (a) /bin is in the PATH when cygrunsrv is invoked from the shell, and (b) when cygrunsrv installs the services, it adds /bin to the PATH in the service environment. Right now I must admit that I prectically don't care if my packages install the binaries in /bin or /usr/bin. /bin should contain programs that should work even if the PATH and mounts are screwed up. So, kill, shutdown, etc. Or simply root / ntfs binary 0 0 and stick to /usr/bin and /usr/lib as they are today. I think something like an automount is needed since it would be nice to eventually generalize the cygdrive stuff and we don't want to explicitly mount a: - z: So, maybe we could consider a linux-like solution to accomplish this although I really don't like automount. I'm not sure I understand this, that's why I was puzzled above. Do you think that / should be free as today: C:\arbitrary\useless\new\path / ntfs binary 0 0 or do you think an automatic approach as the above root / ntfs binary 0 0 is the way to go? As for cygdrives, isn't the cygdrive /mnt auto binary 0 0 already along the lines of an automount?!? It is, IMHO. I have the vague feeling it would be sufficient to install only a /etc/fstab, even in just me mode, though. The fstab.$SID file is only necessary in multi-user installations, IMHO. Why do we need a fstab.$SID and linux doesn't need this? Let me think... I don't know. I assume I just took this as it is. I guess the only reason to create user mounts to begin with was, so that any non-privileged user can create mount points, too, for a pure just me installation in a restricted environment. That, and also to allow completely disjoint Cygwin installations for different users (where the mount table would otherwise be shared). But this effect can also be accomplished with /etc/fstab (one per installation). However, that's not really necessary anymore with /etc/fstab. So I agree, we can simply get rid of fstab.$SID. Yes, that reasoning is mostly correct. However, some packages (like Cygwin/X) apparently assume a single-user installation, and create sockets/temp files in shared locations (i.e., /tmp). That, unfortunately, makes the default startup scripts insufficient to allow multiple users to run Cygwin/X sessions simultaneously, unless that shared location is overridden in a per-user manner (e.g., through user mounts). So, until we figure out how to solve that issue, user mounts are actually userful. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: Regarding using .so file in gcc
On Wed, 12 Mar 2008, Magesh K wrote: Hi, #sorry if the mail received again as i am trying to post from mailer utility This is the worst case of cross-posting I've seen in a while. The cygwin-apps mailing list is not a list for general questions about Cygwin (neither is cygwin-developers). Please use the main Cygwin mailing list for such questions. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITP] pure-ftpd 1.0.21
On Wed, 5 Mar 2008, Kostya Altukhov wrote: On Wed, Mar 5, 2008 at 12:14 AM, Corinna Vinschen wrote: Btw., this is a candidate for a setup script along the lines of ssh-host-config, exim-config, etc. Did you notice the discussion starting with http://cygwin.com/ml/cygwin-apps/2008-02/msg00183.html ? Yes, I'm following that discussion with lots of interest. Creating a setup script for pure-ftpd is a good idea. I will do that once csih package is available in the distribution. FYI: http://cygwin.com/ml/cygwin-apps/2008-03/msg00114.html. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITP] rdiff/librsync 0.9.1 - rsync remote delta algorithm
On Tue, 4 Mar 2008, Jari Aalto wrote: * Mon 2008-03-03 David Rothenberger [EMAIL PROTECTED] Umm, http://cygwin.com/acronyms/#PCYMTNQREAIYR... Thanks. On 3/3/2008 12:54 PM, Dr. Volker Zell wrote: requires: cygwin libpopt0 This doesn't seem to depend on libpopt0 /usr/lib/librsync.la lists as dependency_libs: /usr/lib/libpopt.la -lbz2 -lz. So, what should the dependencies be? It's a bit tricky. You can use: $ cygcheck usr/bin/cygrsync-1.dll usr/bin/cygrsync-1.dll ! D:\cygwin\bin\cygwin1.dll C:\WINNT\system32\ADVAPI32.DLL C:\WINNT\system32\NTDLL.DLL C:\WINNT\system32\KERNEL32.DLL C:\WINNT\system32\RPCRT4.DLL Where the toplevel (!) is the only dependency. That won't quite work. The problem is that if some dependency is both top-level AND transitive, and the transitive one happens to be encountered earlier, cygcheck will not (by default) output the top-level one. So, if you see $ cygcheck foo.exe foo.exe bar.dll baz.dll That does not mean that foo.exe does not depend on baz.dll. You can probably use $ cygcheck -v foo.exe foo.exe bar.dll baz.dll baz.dll (already done) to make sure, but the output does tend to be rather verbose... Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
RE: [ITP] txt2regex-0.8 -- A Regular Expression wizard, all written with bash2 builtins
On Mon, 3 Mar 2008, Buchbinder, Barry (NIH/NIAID) [E] wrote: Jari Aalto (Cygwin-bug#20080303T1357) wrote on Monday, March 03, 2008 9:02 AM: Included in Debain stable: http://packages.debian.org/txt2regex Jari sdesc: A Regular Expression wizard, all written with bash2 builtins ldesc: A program that converts human sentences to RegExs. With a simple interface, you just answer to questions and build your own RegEx for a large variety of programs, like awk, emacs, grep, perl, php, procmail, python, sed and vim. There are more than 20 supported programs. category: Utils requires: cygwin Shouldn't requires include bash? You're right, IMO. The requires: line is not only an indication of what to pull in, but also what the package actually uses. These dependences are also used to find the order of postinstall scripts (so, for example, if Jari's package has any postinstall scripts with #!/bin/sh, the scripts may not work because the bash postinstall script was not run). So yes, please include all direct dependences in the requires: line, even if they are in Base. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITP] rsnapshot 1.3.0 -- A local and remote filesystem snapshot utility
On Tue, 4 Mar 2008, Jari Aalto wrote: ... rsnapshot makes extensive use of hard links, so disk space is only used when absolutely necessary... This will not be true on some non-NTFS filesystems (e.g., FAT). Perhaps a note in the Cygwin-specific README to that regard is in order? FWIW, I would also change the ldesc to indicate that hard links will only be used on NTFS and whatever other systems support them (Corinna?). Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: cygwin-services-helper [was: Re: [ITA] inetutils-1.5-1]
On Wed, 27 Feb 2008, Corinna Vinschen wrote: On Feb 27 00:34, Charles Wilson wrote: Corinna Vinschen wrote: On Feb 25 20:46, Charles Wilson wrote: [*] or maybe a script function library somewhere like /usr/lib/cygwin-services/ that foo-config could 'source', and then call the functions directly. This would help the enter the password twice problem... Sounds good! The function library would be cool. Here's my first draft. Totally untested, almost nuthin' in the way of documentation...but I figured I'd post it now, because I won't have time for any more cygwin stuff until the weekend... Wow, thanks for the quick implementation. Unfortunately I won't have time to look into this for now since I have to look into a Win2K problem with network paths. TODO: (1) test, documentation, bughunt this function library (2) rewrite ssh-host-config to use it (3) rewrite iu-config to use it (4) rewrite syslog-config to use it (4a) rewrite syslog-ng-config to use it But actually, services which don't have to switch user accounts don't really need it. They won't need the create a user that can switch user contexts functionality, but they might use the install as service using cygrunsrv with the following flags one. # REQUIREMENTS: # SHELL must be bash # # PROVIDES: # csh_error # csh_error_multi # csh_warning # csh_inform # csh_verbose # csh_request # csh_is_nt # csh_is_nt2003 # csh_check_prog # csh_check_prog_req # csh_install_config # csh_make_dir # csh_privileged_user_name # csh_privileged_user_exists # csh_service_should_run_as # csh_check_mounts # csh_create_privileged_user # csh_create_unprivileged_user Erm... why are all these functions called csh_foo? Cygwin SHell? I would guess Cygwin Services Helper... Though it probably should be Cygwin Service Installation Helper, or csih. It sounds so much as if these functions are csh functions. Maybe cf or cyg would be a better prefix? Umm, did you mean cgf? :-D Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: Ping? + RFC [was RE: Setup.exe vs corrupt lst.gz files.]
On Tue, 26 Feb 2008, Brian Dessent wrote: Dave Korn wrote: And here is part 1. No comments then? I'll apply it sometime tonight or tomorrow if nobody objects. Well, you labeled it as part 1 and so I mentally said, okay, I'll take a look at this whenever it's complete. Meanwhile (here's the RFC part), my suggestion for part 2 is attached (merged into part 1). It's pretty crude: it disables and reenables the cancel button around each call to Installer::installOne(). This probably doesn't stop the user from pressing the cancel key or clicking the X close box, although I haven't tested that yet. I would be interested in hearing from anyone who reckons they do know the proper way to do this. Ick. I don't really like that. It seems to me that we simply don't support canceling in any sane way once the installation step has begun. Even if we are able to cancel cleanly at a point in between unpacking two packages, that still could leave the system in a horrid state -- missing dependencies, postinstalls not run, etc. We should disable the button for the entirety. I don't like Dave's proposal either. However, simply disabling the Cancel button altogether is not the solution -- if the user is unable to interrupt the installation, she will just kill the process, with disastrous results. The question is: what kind of behavior do we really want in case of cancellation? If we want setup to stop whatever it's doing (dependences, etc, aside), but be able to resume at a later point to fix the state of the system, then Dave's part 1 is the right approach. If we want setup to always leave the system in a sane state, even when it's interrupted, then we should capture the exit message and figure out how to clean up the missing dependences. Keep in mind that processes can be killed in a way that isn't capturable, so setup *will* leave corrupt listing files and missing dependences in some cases. Making sure setup does not crash when restarted after such cases is probably the best we can do. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
RE: Ping? + RFC [was RE: Setup.exe vs corrupt lst.gz files.]
On Tue, 26 Feb 2008, Dave Korn wrote: On 26 February 2008 14:55, Igor Peshansky wrote: The question is: what kind of behavior do we really want in case of cancellation? If we want setup to stop whatever it's doing (dependences, etc, aside), but be able to resume at a later point to fix the state of the system, then Dave's part 1 is the right approach. If we want setup to always leave the system in a sane state, even when it's interrupted, then we should capture the exit message and figure out how to clean up the missing dependences. You've somewhat missed the point. The justification for part 1 is that, entirely orthogonal to and regardless of whatever else we do, those dialog boxes should be modal and they aren't. It Is Just Plain Wrong. Sorry, I misspoke (mis-wrote?). I meant to say that your part 1 takes us towards that goal. Also, in my morning confusion, I referred to the fix for the corrupt lst.gz files as your part 1. There is no question that both were the right thing to do. It is a fortuitous side-effect of making them correctly modal that it becomes slightly trickier to accidentally cancel an installation when you thought you were just cancelling an individual pop-up request. An alternative would be to pop up a warning box on Cancel that says that this action may leave the system in an unstable state, and are you sure you want to cancel?. I'd still like to have the ability to cancel a long install (preferably with the ability to fix things later by rerunning setup). Incidentally, we already get an incremental install from the way setup is structured -- it will not re-download packages, and will rerun any postinstall scripts remaining from the previous run. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: mktemp obsolete
On Sat, 23 Feb 2008, Eric Blake wrote: According to Charles Wilson on 2/23/2008 9:08 AM: | The mktemp package's setup.hint now specifies the _obsolete category. | The package directory has been moved from release/mktemp/ to | release/_obsolete/mktemp. | | What's to do? | | I thought about creating a new, empty package with an updated version | number -- but it's too late now. Once somebody has updated to the new | coreutils, if they update using my new empty mktemp, then coreutils' | mktemp.exe will be deleted. That's no good. I can bump the version number of coreutils if you want to bump the version number of mktemp. But I think we're okay leaving things as they are for now - no one has complained. They won't complain until they try to uninstall mktemp and find their coreutils incomplete... That wouldn't be a very common situation (so no rush), but it would be nice to do what you propose at some point. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
RE: Setup.exe vs corrupt lst.gz files.
On Sat, 23 Feb 2008, Dave Korn wrote: On 23 February 2008 18:50, Brian Dessent wrote: problem. The other half is that we generate one of these bogus .lst.gz files while installing a package if the user is prompted to retry an in-use file and clicks the close-X in the dialog instead of chosing retry or replace. Need a bit of clarification here: I could only get this to happen by clicking the X on the main setup.exe dialog behind, not the popup warning itself; I take it that's what you meant. You'd also get that if you press Cancel in the main dialog while the package is being installed. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
RE: [ITP] colordiff-1.0.7
On Thu, 21 Feb 2008, Buchbinder, Barry (NIH/NIAID) [E] wrote: Kostya Altukhov wrote on Thursday, February 21, 2008 6:55 AM: requires: cygwin perl ldesc:A wrapper for the diff command. If this is a wrapper to diff, shouldn't it require diffutils? (Please excuse me if this is terribly naïve.) I think you're right. If the package does not make sense to install without diffutils, then it should pull in diffutils. A minor point of confusion might be that diffutils is in Base, and thus will be automatically installed anyway. But the requires: line should still indicate the dependency. Thanks for packaging this. I'm looking forward to having it show up in the mirrors! FWIW, another little-used tool is the less.sh script that comes with vim. Piping the output of diff into that gives you a very nice syntax highlighting of diffs. It's good to have alternative tools, however. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [GTG] Re: [ITP] rzip 2.1 -- Compression program to use long distance redundencies in files
On Thu, 20 Dec 2007, Dr. Volker Zell wrote: Jari Aalto writes: Included in Debain stable http://packages.debian.org/rzip Jari sdesc: Compression program to use long distance redundencies in files ldesc: A compression program able to take advantage of long distance redundancies in files, allowing greater compression ratios. rzip uses a history buffer of up to 900MB, while gzip uses 32KB and bzip2 uses 900KB. rzip cannot read from the standard input or write to the standard output. category: Utils requires: cygwin libbz2_1 Builds fine from source, packaging and setup.hint look good. Minor typo in the sdesc: it's redundancies, not redundencies. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITA] nano package
On Mon, 17 Dec 2007, Yaakov (Cygwin Ports) wrote: Lapo Luchini wrote: PS: AFAIR the g-b-s' deps target lists them all, but cygport's dep does not. The g-b-s deps check was based on cygcheck, which shows the entire dependency tree, where cygport uses objdump, which lists only those that the binary is linked against. The latter option can sometimes be slower (*cough*KDE*cough*), but is much more accurate. By default, cygcheck eliminates duplicates in the list of DLL dependencies, even if they previously appeared at a deeper level of dependency nesting. Adding the -v option causes it to list all dependencies without eliminating duplicates (except that there is a bug that causes the following line: Warning: C:/cygwin/bin\cygreadline6.dll hides C:\cygwin\bin\cygreadline6.dll to be repeated quite a few times, but that's something to be fixed separately). So, the solution would be to use cygcheck -v program in the g-b-s based scripts and to select from the output lines with exactly two leading spaces. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITA] nano package
On Mon, 17 Dec 2007, Corinna Vinschen wrote: On Dec 17 12:50, Lapo Luchini wrote: http://cyberx.lapo.it/cygwin/nano/nano-2.0.6-1.tar.bz2 http://cyberx.lapo.it/cygwin/nano/nano-2.0.6-1-src.tar.bz2 Looks good, uploaded. Thanks for taking over, Corinna http://cygwin.com/goldstars/#JAa. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITA] nano package
On Mon, 17 Dec 2007, Lapo Luchini wrote: Igor Peshansky wrote: http://cygwin.com/goldstars/#JAa. Doh? ;-) Sort of. Just making sure this time things don't get buried in the TODO list... :-) Uh.. not exactly: I was dohing to the fact that that I'm not quite as active as Jari is, in adopting packages 0=) (second hint: #JAa vs #LL :P) D'oh indeed. Chalk it off to the lack of sleep and doing things in a hurry. Should be fixed now: http://cygwin.com/goldstars/#LL. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITA] joe 3.5 - Fast and simple editor which emulates 5 other editors
On Sat, 15 Dec 2007, Corinna Vinschen wrote: On Dec 14 10:19, Jari Aalto wrote: wget\ http://cygwin.cante.net/joe/setup.hint \ http://cygwin.cante.net/joe/joe-3.5-2-src.tar.bz2 \ http://cygwin.cante.net/joe/joe-3.5-2.tar.bz2 \ Uploaded. Thanks for taking over, Corinna So noted: http://cygwin.com/goldstars/#JAa. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel --lBG2Ksno015852.1197771654/access1.cims.nyu.edu-- ReSent-Date: Sat, 15 Dec 2007 21:36:30 -0500 (EST) ReSent-From: Igor Peshansky [EMAIL PROTECTED] ReSent-To: cygwin-apps@cygwin.com ReSent-Subject: Re: [ITA] joe 3.5 - Fast and simple editor which emulates 5 other editors ReSent-Message-ID: [EMAIL PROTECTED] On Sat, 15 Dec 2007, Corinna Vinschen wrote: On Dec 14 10:19, Jari Aalto wrote: wget\ http://cygwin.cante.net/joe/setup.hint \ http://cygwin.cante.net/joe/joe-3.5-2-src.tar.bz2 \ http://cygwin.cante.net/joe/joe-3.5-2.tar.bz2 \ Uploaded. Thanks for taking over, Corinna So noted: http://cygwin.com/goldstars/#JAa. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel --lBG2Ksno015852.1197771654/access1.cims.nyu.edu--
Re: [ITA] editrights 1.01-2 -- Alter Windows user rights and privileges from command line
On Thu, 13 Dec 2007, Corinna Vinschen wrote: On Dec 13 13:06, Jari Aalto wrote: Adoption of package by Chris Rodgers. Note: the category was changed from Base to Util, since this does not seem to be essential package. This package is in Base for a reason. It is an essential package and used for instance in the openssh config script. Then wouldn't it make sense to simply have all the packages that need it depend on it? OTOH, one of those packages is cygwin (since cygserver config should probably use editrights as well), and that effectively puts it in Base... Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITA] editrights 1.01-2 -- Alter Windows user rights and privileges from command line
On Thu, 13 Dec 2007, Corinna Vinschen wrote: On Dec 13 16:13, Jari Aalto wrote: * Thu 2007-12-13 Corinna Vinschen [EMAIL PROTECTED] ...it's still version 1.01. Wouldn't the above change qualify for a 1.02 release? Just an idea... I'll contact the original author; I feel the upstream number should stay in the official version. The added functionality is a separate patch, so I' would go for -2. Ok, no worries. Uploaded. Thanks for taking over, Indeed: http://cygwin.com/goldstars/#JAa. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITA] rcs: The Revision Control System
On Tue, 11 Dec 2007, Corinna Vinschen wrote: On Dec 10 16:35, Dr. Volker Zell wrote: Hi I would like to adopt and maintain the `rcs' package from Stipe Tolj. Sure, no problem! wget http://volkerzell.de/cygwin/ITP/rcs/setup.hint wget http://volkerzell.de/cygwin/ITP/rcs/rcs-5.7-4-src.tar.bz2 wget http://volkerzell.de/cygwin/ITP/rcs/rcs-5.7-4.tar.bz2 Looks good. Uploaded. Where's Igor? IIIGOOOR! Another gold star for Volker, please. Wha? Sorry, I was off in the vault polishing the stars... Done. I put in all 3 at once (for enscript, squid, and rcs). Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Starfall
I apologize profusely to everyone who worked hard to adopt packages over the past few months. I've discovered a stash of unanswered gold star emails in my Follow-up folder, and have just completed giving out all of them (all well deserved): http://cygwin.com/goldstars/#LL http://cygwin.com/goldstars/#JAa http://cygwin.com/goldstars/#JA http://cygwin.com/goldstars/#VZ On the plus side, I've spent quite a while spinning my wheels^W^W^W... err... polishing the stars, so this new batch should be extra shiny. Igor P.S. I think I've covered all of the pending ones, but if I missed some, please don't hesitate to let me know. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! That which is hateful to you, do not do to your neighbor. That is the whole Torah; the rest is commentary. Go and study it. -- Rabbi Hillel
Re: [ITP] mksh-R31b-1 -- Enhanced version of the Korn shell
On Thu, 13 Sep 2007, Christopher Faylor wrote: On Thu, Sep 13, 2007 at 09:52:39AM -0400, Igor Peshansky wrote: On Thu, 13 Sep 2007, Christopher Faylor wrote: On Thu, Sep 13, 2007 at 10:56:41AM +0200, Dr. Volker Zell wrote: Jari Aalto writes: Included in Debian stable (etch). This is nice lighweight almost-bash-like shell. http://packages.debian.org/mksh Jari sdesc: Enhanced version of the Korn shell ldesc: A shell which is MirBSD enhanced version of the Public Domain Korn shell (pdksh), a bourne-compatible shell which is largely similar to the original ATT Korn shell. It includes bug fixes and feature improvements in order to produce a modern, robust shell good for interactive and especially script use. category: Shells requires: cygwin a) manual wget\ http://cygwin.cante.net/mksh/setup.hint \ http://cygwin.cante.net/mksh/mksh-R31b-1-src.tar.bz2 Binary package missing. I wasn't paying attention. Do we really want two versions of ksh in the distribution? I'd say this was Igor's call. We've had this discussion before. The last message was http://cygwin.com/ml/cygwin-apps/2006-05/msg00024.html, which never got a reply. I thought I remembered something like this. Let's not bother with mksh then. Actually, let's hope that this time Jari answers my questions... As I said, if mksh is a full (and fully compatible) replacement for pdksh, I'm in favor of getting the newer package into the distro. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Belief can be manipulated. Only knowledge is dangerous. -- Frank Herbert
Re: [ITP] mksh-R31b-1 -- Enhanced version of the Korn shell
On Thu, 13 Sep 2007, Jari Aalto wrote:
Actually, let's hope that this time Jari answers my questions... As I
said, if mksh is a full (and fully compatible) replacement for pdksh
To my knowledge, it is. If someone has *.ksh files to try, please
download and install that binary package and see it the mksh handles
them.
Hmm, you seem to be contradicting that below...
The developer is active and responsive.
I'm in favor of getting the newer package into the distro. Igor
According to:
http://cygwin.com/ml/cygwin-apps/2006-05/msg00024.html
The bug reports:
http://cygwin.com/ml/cygwin/2004-08/msg00112.html [1]
http://cygwin.com/ml/cygwin/2005-06/msg00202.html [2]
http://cygwin.com/ml/cygwin/2005-08/msg01382.html [3]
http://cygwin.com/ml/cygwin/2006-02/msg00448.html [4]
They are not very clear, but I tried my best to reproduce.
[1] Multiple sourcing of initializations files.
The script that fails sources another script which loads a whole
bunch of functions.
The error happens when I call a function from a certain script, I
get this error. However, if I call it from a smaller script
(specially written to just call this function) it works
Not a problem under mksh. Multiple sourced files; function work. That is
This sentence seems truncated. In any case, the bug report was too vague,
and I haven't had the time to investigate.
[2] Memory allocation error
/home/tbaker/u/bin/urlists[50]: internal error: alloc: freeing
memory outside of block (corrupted?)
By running the scripts in debug mode (set -x), I found that
the problem seemed to occur when declared functions (i.e.,
declared within the script) were invoked multiple times.
The functions would work at first, then stop working --
as if the functions somehow ate up the available memory.
I invoked function 1000 times in a loop, no malloc errors.
I have a testcase for this one (attached). This has nothing to do with
functions. I think it's a matter of not handling long filenames properly
(an off-by-one error?).
[3] Prompt which gets repeated if it's multiline
keying ESC/ results in
WS-XP-4960: /home/rthompso
WS-XP-4960: /home/rthompso
WS-XP-4960: /home/rthompso
$ /
Not applicaple. ESC-/ key combination doe snot exist in mksh.
Multiline prompts work without promlems.
Sure it exists. You have to set -o vi first. But this one I can't
reproduce in the current pdksh, either.
Also, this one was #4 -- you missed #3, which was about tab completion and
quoting spaces and special characters (which is reproducible).
Since we're testing known issues, here's another one I missed:
http://cygwin.com/ml/cygwin/2005-01/msg00073.html. Again, reproducible
in current pdksh.
Anyway, I don't mind a test release of this -- if people find no problems
with their ksh scripts, we can switch over to mksh (and switch the
maintainership over to you).
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Belief can be manipulated. Only knowledge is dangerous. -- Frank Herbert#!/usr/bin/ksh
mkdir -p
./A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name
function main
{
set -x
echo 1
./A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name/A_Long_Name.txt
}
main
Re: [RFU] vorbis-tools-1.1.1-6
On Tue, 31 Jul 2007, Corinna Vinschen wrote: On Jul 30 10:22, David Rothenberger wrote: wget -x -nH --cut-dirs=2 \ http://mysite.verizon.net/res00a7j/cygwin/vorbis-tools/vorbis-tools-1.1.1-6-src.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin/vorbis-tools/vorbis-tools-1.1.1-6.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin/vorbis-tools/setup.hint Uploaded. Thanks, Corinna How many stars does that make? :-) Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Belief can be manipulated. Only knowledge is dangerous. -- Frank Herbert
Re: [RFU] libao
On Mon, 30 Jul 2007, Corinna Vinschen wrote: On Jul 29 18:32, David Rothenberger wrote: wget -x -nH --cut-dirs=2 \ http://mysite.verizon.net/res00a7j/cygwin/libao/libao-0.8.8-1-src.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin/libao/libao-0.8.8-1.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin/libao/setup.hint \ http://mysite.verizon.net/res00a7j/cygwin/libao/libao-devel/libao-devel-0.8.8-1.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin/libao/libao-devel/setup.hint \ http://mysite.verizon.net/res00a7j/cygwin/libao/libao2/libao2-0.8.8-1.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin/libao/libao2/setup.hint Packaging looks good to me. I've uploaded this package. Please send the announcement according to http://cygwin.com/setup.html#submitting, section 8. Igor, even though the xiph packages are not orphaned, I'd like to give a gold star to David. Updating these packages was overdue and I just didn't have the stamina to get on. Who am I to argue? :-) http://cygwin.com/goldstars/#DR Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Belief can be manipulated. Only knowledge is dangerous. -- Frank Herbert
Re: CMake 2.4.7-1 ready
On Fri, 27 Jul 2007, Bill Hoffman wrote: Bill Hoffman wrote: I had some trouble myself when I tested the install. I had to unpack the tar file by hand. I must have messed something up. Any ideas what? Once unpacked by hand the cmake install was fine. -Bill I have tried again myself, and if I do a reinstall, the download part works fine. But the install stage happens really fast. I suspect there maybe an error flashing by, but I can't see it. Is there a way to debug setup or get more verbose output? Thanks. Look at /var/log/setup.log.full for a reasonably fine-grained trace of setup's activity. If there is an I/O error, it should show that. Also, it will contain the output your postinstall script produces. HTH, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Belief can be manipulated. Only knowledge is dangerous. -- Frank Herbert
Re: New Berkeley DB 4.5.20 from Oracle Corporation
On Thu, 12 Jul 2007, Corinna Vinschen wrote: On Jul 12 18:12, Dr. Volker Zell wrote: Corinna Vinschen writes: Your packages are known to be well packed, but I think a quick ITP wouldn't hurt. Thanks for doing this, btw. In lack of public web space I have temporarily uploaded the packages to sourceware o sourceware.org:/home/vzell/db If everything looks good, you can move them to the release directory. Right now I'm using more or less the same build script as Gerrit. Looks good to me, except of the external-source entry in libdb4.5 and libdb4.5-devel, which point to db, rather than db4.5. As for Gerrit's db packages, would you be willing to take over maintainership of them? It would be good for the records to have Ok. Whohooo! Thank you! Igor! Can you throw a fat gold star in Volker's direction, please? You mean, like a shuriken? :-) I don't have a fat one. I do have a spinning one, which, unfortunately, is a GIF. I'm going with a PNG instead: http://cygwin.com/goldstars/#VZ. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Belief can be manipulated. Only knowledge is dangerous. -- Frank Herbert
Re: regarding updated lighttpd and upx
On Fri, 29 Jun 2007, Lapo Luchini wrote: They changed quite a bit, upgrading them is not straightforward and will take a few more time slots... unfortunately (or rather, fortunately ;-)) I no longer use Windows on my laptop, so they have to compete with free time at home ;-) Don't despair... Umm, VMware? Or is it a disk space issue? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: Installing Cygwin in restricted environment
On Tue, 5 Jun 2007, Sharuzzaman Ahmat Raslan wrote: Hi, My workstation in office is running Win2K. The environment is locked, but I have a folder named C:\Apps that is open and writeable to all user. The folder is being used to install non-standard apps. Standard apps is always installed in C:\Program Files It looks like Cygwin is not able to be installed in my environment, with the error message: This operation has been cancelled due to restriction in effect on this computer. Please contact your system administrator. Is there any other way to install Cygwin in this kind of environment? Besides writing the files to disk, Cygwin also needs to store its mount table in the registry. An environment like that very likely disallows writing to system registry, and that is probably what's tripping this error. I'd be surprised if the user registry hive were locked down as well, so you could try instructing setup to install for Just me. Without further information about your installation process (e.g., the attached /etc/setup/setup.log.full from that installation attempt) I cannot offer further guesses as to what went wrong. HTH, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: [PATCH] Setup: adjust copyright and fix the installation finished behavior for download-only mode
On Fri, 4 May 2007, Brian Dessent wrote: Igor Peshansky wrote: Thanks, but it turns out the patch wasn't tested enough. Using the Back button from the final dialog in download-only mode and then going through setup again after changing the mode to Install would not change the final dialog back to its original state. The attached patch fixes that (and also makes sure no extra files are created in download-only mode). New ChangeLog below. Must have missed this before, please commit. Thanks, committed. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: Please review and upload cron-4.1-1
On Wed, 11 Apr 2007, Corinna Vinschen wrote: On Apr 10 10:33, Pierre A. Humblet wrote: http://mysite.verizon.net/phumblet/cron-4.1-1/setup.hint http://mysite.verizon.net/phumblet/cron-4.1-1/cron-4.1-1.tar.bz2 http://mysite.verizon.net/phumblet/cron-4.1-1/cron-4.1-1-src.tar.bz2 The packaging looks good to me. We talked about the details already in PM. I really like the `cronlog' idea. I've uploaded this package and removed 3.0.1-19. Thank you *very* much for taking over cron. Igor? Do you have a gold star for Pierre handy? Or better two? Yep: http://cygwin.com/goldstars/#PAH. Apologies for the delay -- I was on vacation. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: [PATCH] Setup: adjust copyright and fix the installation finished behavior for download-only mode
On Mon, 9 Apr 2007, Brian Dessent wrote:
Igor Peshansky wrote:
The attached patch fixes the seemingly abrupt exit in download-only mode
reported in http://cygwin.com/ml/cygwin/2007-04/msg00251.html (and also
adds 2007 to the copyright range). The ChangeLog is below. Comments
welcome. Please let me know if it's ok to commit.
Looks good, please commit.
Thanks, but it turns out the patch wasn't tested enough. Using the Back
button from the final dialog in download-only mode and then going through
setup again after changing the mode to Install would not change the
final dialog back to its original state. The attached patch fixes that
(and also makes sure no extra files are created in download-only mode).
New ChangeLog below.
I knew that copyright year display stuff would come up again. I'm
tempted to just remove it; I'm not really seeing what good it does to
display that to the user. And according to the GNU coding standards,
we're supposed to bump the copyright year in the header of any source
file whenever we make changes to it, which I don't think any of us have
been bothering with either. Sigh.
Well, I've adjusted it on the splash screen anyway. And yes, I haven't
really adjusted it in the headers of the sources... Sigh, indeed.
Igor
==
ChangeLog:
2007-04-10 Igor Peshansky [EMAIL PROTECTED]
* resource.h (IDC_STATIC_HEADER): New control id.
* res.rc (IDD_SPLASH): Adjust copyright.
(IDD_DESKTOP): Make header text accessible as a separate control.
* desktop.cc (set_status): Use eset() instead of SetWindowText().
(header_string,message_string): New static variables.
(load_dialog): Disable checkboxes and change dialog text in
download-only mode. Save header and message text; restore it if
mode changes back to install.
(DesktopSetupPage::OnInit): Move functionality to
DesktopSetupPage::OnActivate.
(DesktopSetupPage::OnActivate): Disable checkboxes in download-only
mode.
(DesktopSetupPage::OnFinish): Avoid creating shortcuts in
download-only mode.
* desktop.h (DesktopSetupPage::OnActivate): Override virtual function.
* threebar.cc (ThreeBarProgressPage::OnMessageApp): Deprecate the
default fallthrough.
* download.cc (do_download_thread): Explicitly return the next
dialog.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Freedom is just another word for nothing left to lose... -- Janis JoplinIndex: desktop.cc
===
RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
retrieving revision 2.47
diff -u -p -r2.47 desktop.cc
--- desktop.cc 30 Mar 2007 22:18:34 - 2.47
+++ desktop.cc 10 Apr 2007 14:02:21 -
@@ -245,15 +245,38 @@ set_status (HWND h)
if (LoadString (hinstance, exit_msg, fmt, sizeof (fmt)) 0)
{
snprintf (buf, 1000, fmt,
backslash(theLog-getFileName(LOG_BABBLE)).c_str());
- ::SetWindowText (GetDlgItem (h, IDC_STATUS), buf);
+ eset(h, IDC_STATUS, buf);
}
}
+static char *header_string = NULL;
+static char *message_string = NULL;
static void
load_dialog (HWND h)
{
- rbset (h, da, root_desktop);
- rbset (h, ma, root_menu);
+ if (source == IDC_SOURCE_DOWNLOAD)
+{
+ // Don't need the checkboxes
+ EnableWindow (GetDlgItem (h, IDC_ROOT_DESKTOP), FALSE);
+ EnableWindow (GetDlgItem (h, IDC_ROOT_MENU), FALSE);
+ if (header_string == NULL)
+header_string = eget (h, IDC_STATIC_HEADER_TITLE, header_string);
+ if (message_string == NULL)
+message_string = eget (h, IDC_STATIC_HEADER, message_string);
+ eset (h, IDC_STATIC_HEADER_TITLE, Installation complete);
+ eset (h, IDC_STATIC_HEADER, Shows installation status in download-only
mode.);
+}
+ else
+{
+ EnableWindow (GetDlgItem (h, IDC_ROOT_DESKTOP), TRUE);
+ EnableWindow (GetDlgItem (h, IDC_ROOT_MENU), TRUE);
+ if (header_string != NULL)
+eset (h, IDC_STATIC_HEADER_TITLE, header_string);
+ if (message_string != NULL)
+eset (h, IDC_STATIC_HEADER, message_string);
+ rbset (h, da, root_desktop);
+ rbset (h, ma, root_menu);
+}
check_if_enable_next (h);
set_status (h);
}
@@ -359,7 +382,13 @@ DesktopSetupPage::OnInit ()
// FIXME: This CoInitialize() feels like it could be moved to startup in
main.cc.
CoInitialize (NULL);
- if (NoShortcutsOption)
+ SetDlgItemFont(IDC_STATUS_HEADER, MS Shell Dlg, 8, FW_BOLD);
+}
+
+void
+DesktopSetupPage::OnActivate
[PATCH] Setup: adjust copyright and fix the installation finished behavior for download-only mode
The attached patch fixes the seemingly abrupt exit in download-only mode
reported in http://cygwin.com/ml/cygwin/2007-04/msg00251.html (and also
adds 2007 to the copyright range). The ChangeLog is below. Comments
welcome. Please let me know if it's ok to commit.
Igor
==
ChangeLog:
2007-04-09 Igor Peshansky [EMAIL PROTECTED]
* resource.h (IDC_STATIC_HEADER): New control id.
* res.rc (IDD_SPLASH): Adjust the copyright.
(IDD_DESKTOP): Make header text accessible as a separate control.
* desktop.cc (set_status): Use eset() instead of SetWindowText().
(load_dialog): Disable checkboxes and change dialog text in
download-only mode.
(DesktopSetupPage::OnInit): Disable checkboxes in download-only
mode.
* threebar.cc (ThreeBarProgressPage::OnMessageApp): Deprecate the
default fallthrough.
* download.cc (do_download_thread): Explicitly return the next
dialog.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Freedom is just another word for nothing left to lose... -- Janis JoplinIndex: desktop.cc
===
RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
retrieving revision 2.47
diff -u -p -r2.47 desktop.cc
--- desktop.cc 30 Mar 2007 22:18:34 - 2.47
+++ desktop.cc 9 Apr 2007 14:34:32 -
@@ -245,15 +245,26 @@ set_status (HWND h)
if (LoadString (hinstance, exit_msg, fmt, sizeof (fmt)) 0)
{
snprintf (buf, 1000, fmt,
backslash(theLog-getFileName(LOG_BABBLE)).c_str());
- ::SetWindowText (GetDlgItem (h, IDC_STATUS), buf);
+ eset(h, IDC_STATUS, buf);
}
}
static void
load_dialog (HWND h)
{
- rbset (h, da, root_desktop);
- rbset (h, ma, root_menu);
+ if (source == IDC_SOURCE_DOWNLOAD)
+{
+ // Don't need the checkboxes
+ EnableWindow (GetDlgItem (h, IDC_ROOT_DESKTOP), 0);
+ EnableWindow (GetDlgItem (h, IDC_ROOT_MENU), 0);
+ eset (h, IDC_STATIC_HEADER_TITLE, Installation complete);
+ eset (h, IDC_STATIC_HEADER, Shows installation status in download-only
mode.);
+}
+ else
+{
+ rbset (h, da, root_desktop);
+ rbset (h, ma, root_menu);
+}
check_if_enable_next (h);
set_status (h);
}
@@ -359,7 +370,7 @@ DesktopSetupPage::OnInit ()
// FIXME: This CoInitialize() feels like it could be moved to startup in
main.cc.
CoInitialize (NULL);
- if (NoShortcutsOption)
+ if (NoShortcutsOption || source == IDC_SOURCE_DOWNLOAD)
{
root_desktop = root_menu = 0;
}
Index: download.cc
===
RCS file: /cvs/cygwin-apps/setup/download.cc,v
retrieving revision 2.48
diff -u -p -r2.48 download.cc
--- download.cc 16 Apr 2006 15:37:49 - 2.48
+++ download.cc 9 Apr 2007 14:34:32 -
@@ -287,7 +287,7 @@ do_download_thread (HINSTANCE h, HWND ow
exit_msg = IDS_DOWNLOAD_INCOMPLETE;
else if (!unattended_mode)
exit_msg = IDS_DOWNLOAD_COMPLETE;
- return 0;
+ return IDD_DESKTOP;
}
else
return IDD_S_INSTALL;
Index: res.rc
===
RCS file: /cvs/cygwin-apps/setup/res.rc,v
retrieving revision 2.72
diff -u -p -r2.72 res.rc
--- res.rc 30 Mar 2007 22:18:34 - 2.72
+++ res.rc 9 Apr 2007 14:34:33 -
@@ -265,7 +265,7 @@ BEGIN
necessary.,IDC_SPLASH_TEXT,115,25,195,90
ICONIDI_CYGWIN,IDC_SPLASH_ICON,114,114,21,20,WS_GROUP
LTEXT Version (unknown),IDC_VERSION,115,137,195,10
-LTEXT Copyright 2000-2006,IDC_SPLASH_COPYR,115,150,195,8
+LTEXT Copyright 2000-2007,IDC_SPLASH_COPYR,115,150,195,8
LTEXT http://www.cygwin.com/,IDC_SPLASH_URL,115,162,90,8
END
@@ -283,7 +283,7 @@ BEGIN
CONTROL ,IDC_HEADSEPARATOR,Static,SS_BLACKFRAME |
SS_SUNKEN,0,28,
317,1
LTEXT Tell setup if you want it to create a few icons for
convenient access to the Cygwin environment.,
-IDC_STATIC,21,9,239,16,NOT WS_GROUP
+IDC_STATIC_HEADER,21,9,239,16,NOT WS_GROUP
LTEXT Create Icons,IDC_STATIC_HEADER_TITLE,7,0,258,8,NOT
WS_GROUP
CONTROL ,IDC_DESKTOP_SEPARATOR,Static,SS_BLACKFRAME |
SS_SUNKEN,
Index: resource.h
===
RCS file: /cvs/cygwin-apps/setup/resource.h,v
retrieving revision 2.34
diff -u -p -r2.34 resource.h
--- resource.h 30 Mar 2007 22:18:34
Re: Please Upload: mingw-runtime-3.12-2
On Fri, 6 Apr 2007, Christopher Faylor wrote: On Fri, Apr 06, 2007 at 04:18:39PM +0200, Dr. Volker Zell wrote: Christopher Faylor writes: On Thu, Apr 05, 2007 at 04:49:02PM -0400, Chris Sutcliffe wrote: As discussed, I've modified the man page locations as follows: $ tar jtvf mingw-runtime-3.12-2.tar.bz2 | grep man drwxr-xr-x csutclif/Administrators 0 2007-04-05 14:35:49 usr/share/man/ drwxr-xr-x csutclif/Administrators 0 2007-04-05 14:35:55 usr/share/man/mingw/ -rw-r--r-- csutclif/Administrators 8956 2007-04-05 14:35:55 usr/share/man/mingw/mingw-basename.mingw -rw-r--r-- csutclif/Administrators 8956 2007-04-05 14:35:55 usr/share/man/mingw/mingw-dirname.mingw With the newly released man-1.6e-1, I added mingw to MANSECT in man.conf. The naming should be /usr/share/man/manmingw/dirname.mingw /usr/share/man/manmingw/basename.mingw for man -S mingw manpage to find it. Sorry but I don't think we're there yet. If you're going to put these in their own section then I don't think they need the mingw- prefix. I was only thinking that would be necessary if the manpages were going to be living in /usr/share/man/man1. If they are going into their own section then I'd like the manpage maintainer to add mingw to the list of searchable sections. Thank you, Volker. Can I get a gold star over here for Chris and Volker for this nice coordination of efforts? Done. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: Please Upload: mingw-runtime-3.12-2 (gold stars for Volker and Chris)
On Fri, 6 Apr 2007, Christopher Faylor wrote: On Fri, Apr 06, 2007 at 04:13:13PM -0400, Chris Sutcliffe wrote: With the newly released man-1.6e-1, I added mingw to MANSECT in man.conf. The naming should be /usr/share/man/manmingw/dirname.mingw /usr/share/man/manmingw/basename.mingw Excellent, many thanx Volker! I've modified the manpages accordingly: $ tar jtvf mingw-runtime-3.12-2.tar.bz2 | grep man drwxr-xr-x ironhead/Administrators 0 2007-04-06 15:23:38 usr/share/man/ drwxr-xr-x ironhead/Administrators 0 2007-04-06 15:23:45 usr/share/man/mingw/ -rw-r--r-- ironhead/Administrators 8956 2007-04-06 15:23:45 usr/share/man/mingw/basename.mingw -rw-r--r-- ironhead/Administrators 8956 2007-04-06 15:23:45 usr/share/man/mingw/dirname.mingw Please upload: http://emergedesktop.org/cygwin/mingw-runtime-3.12-2-src.tar.bz2 http://emergedesktop.org/cygwin/mingw-runtime-3.12-2.tar.bz2 I've uploaded these files. Thanks again for being so accommodating. Igor, I hate to saturate the market but I think this kind of coordination and cooperation deserves gold stars. Could you see to that, please? So, just to confirm, they each get *2* gold stars for this? That is, those in addition to the ones you asked for before? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: [PATCH] Setup Re: Installation finished
Ping? I'd like to apply this. Corinna, is that what you were
envisioning? Would you like me to make a pre-compiled version available
on the web to let people test without having to build?
Igor
On Wed, 28 Mar 2007, Igor Peshansky wrote:
On Thu, 22 Mar 2007, Brian Dessent wrote:
Corinna Vinschen wrote:
Question to the setup.exe maintainers:
Do we really need the Installation finished. message box at the end?
I find it increasingly annoying that I have to confirm the end of the
installation on a centered button when all the rest of the OK buttons
were at the bottom right of the prevous dialogs.
Wouldn't it suffice to rename the OK button in the last dialog to
Finish?
You're right, I hate that too and it's been on the todo list to remove
this for a long time.
And here is a patch. It does a bit more than remove the final mbox -- it
also moves the status information into the Create Icons dialog. It
should handle the resizing of that dialog correctly, but please test it
anyway. ChangeLog is below. Comments welcome.
Igor
==
ChangeLog:
2007-03-28 Igor Peshansky [EMAIL PROTECTED]
* LogFile.cc (LogFile::exit): Write exit_msg directly to log, without
the message box.
* resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New
control ids.
* res.rc (IDD_DESKTOP): Change the caption. Add status information.
* desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor
in the implementation.
* desktop.cc (DesktopControlsInfo): Position specifiers for status
information items.
(DesktopSetupPage::DesktopSetupPage): Register position specifiers.
(set_status): New static method.
(load_dialog): Set status information, if available.
(DesktopSetupPage::OnInit): Set status header font.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Freedom is just another word for nothing left to lose... -- Janis JoplinIndex: LogFile.cc
===
RCS file: /cvs/cygwin-apps/setup/LogFile.cc,v
retrieving revision 2.15
diff -u -p -r2.15 LogFile.cc
--- LogFile.cc 15 Apr 2006 21:21:25 - 2.15
+++ LogFile.cc 28 Mar 2007 14:50:38 -
@@ -24,6 +24,7 @@ static const char *cvsid =
#include io_stream.h
#include win32.h
#include msg.h
+#include dialog.h
#include resource.h
#include iostream
#include sstream
@@ -126,7 +127,14 @@ LogFile::exit (int const exit_code)
been_here = 1;
if (exit_msg)
-note (NULL, exit_msg, backslash(getFileName(LOG_BABBLE)).c_str());
+{
+ char buf[1000], fmt[1000];
+ if (LoadString (hinstance, exit_msg, fmt, sizeof (fmt)) 0)
+{
+ snprintf (buf, 1000, fmt,
backslash(getFileName(LOG_BABBLE)).c_str());
+ log (LOG_PLAIN) note: buf endLog;
+}
+}
log (LOG_TIMESTAMP) Ending cygwin install endLog;
Index: desktop.cc
===
RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
retrieving revision 2.46
diff -u -p -r2.46 desktop.cc
--- desktop.cc 28 Feb 2007 00:55:04 - 2.46
+++ desktop.cc 28 Mar 2007 14:50:38 -
@@ -45,6 +45,7 @@ static const char *cvsid =
#include io_stream.h
#include getopt++/BoolOption.h
#include PackageSpecification.h
+#include LogFile.h
static BoolOption NoShortcutsOption (false, 'n', no-shortcuts, Disable
creation of desktop and start menu shortcuts);
static BoolOption NoStartMenuOption (false, 'N', no-startmenu, Disable
creation of start menu shortcut);
@@ -61,6 +62,18 @@ static BoolOption NoDesktopOption (false
static std::string batname;
static std::string iconname;
+static ControlAdjuster::ControlInfo DesktopControlsInfo[] = {
+ {IDC_DESKTOP_SEPARATOR, CP_STRETCH, CP_BOTTOM},
+ {IDC_STATUS, CP_LEFT, CP_BOTTOM},
+ {IDC_STATUS_HEADER, CP_LEFT, CP_BOTTOM},
+ {0, CP_LEFT, CP_TOP}
+};
+
+DesktopSetupPage::DesktopSetupPage ()
+{
+ sizeProcessor.AddControlInfo (DesktopControlsInfo);
+}
+
static void
make_link (const std::string linkpath,
const std::string title,
@@ -223,12 +236,26 @@ check_if_enable_next (HWND h)
EnableWindow (GetDlgItem (h, IDOK), 1);
}
+extern LogFile * theLog;
+
+static void
+set_status (HWND h)
+{
+ char buf[1000], fmt[1000];
+ if (LoadString (hinstance, exit_msg, fmt, sizeof (fmt)) 0)
+{
+ snprintf (buf, 1000, fmt,
backslash(theLog-getFileName(LOG_BABBLE)).c_str());
+ ::SetWindowText (GetDlgItem (h, IDC_STATUS), buf
Re: [PATCH] Setup Re: Installation finished
On Fri, 30 Mar 2007, Brian Dessent wrote: Igor Peshansky wrote: Ping? I'd like to apply this. Corinna, is that what you were envisioning? Would you like me to make a pre-compiled version available on the web to let people test without having to build? I like it. Please install, and I'll update the snapshot. Thanks. Committed. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
[PATCH] Re: Installation finished
On Thu, 22 Mar 2007, Brian Dessent wrote:
Corinna Vinschen wrote:
Question to the setup.exe maintainers:
Do we really need the Installation finished. message box at the end?
I find it increasingly annoying that I have to confirm the end of the
installation on a centered button when all the rest of the OK buttons
were at the bottom right of the prevous dialogs.
Wouldn't it suffice to rename the OK button in the last dialog to
Finish?
You're right, I hate that too and it's been on the todo list to remove
this for a long time.
And here is a patch. It does a bit more than remove the final mbox -- it
also moves the status information into the Create Icons dialog. It
should handle the resizing of that dialog correctly, but please test it
anyway. ChangeLog is below. Comments welcome.
Igor
==
ChangeLog:
2007-03-28 Igor Peshansky [EMAIL PROTECTED]
* LogFile.cc (LogFile::exit): Write exit_msg directly to log, without
the message box.
* resource.h (IDC_DESKTOP_SEPARATOR,IDC_STATUS_HEADER,IDC_STATUS): New
control ids.
* res.rc (IDD_DESKTOP): Change the caption. Add status information.
* desktop.h (DesktopSetupPage::DesktopSetupPage): Define constructor
in the implementation.
* desktop.cc (DesktopControlsInfo): Position specifiers for status
information items.
(DesktopSetupPage::DesktopSetupPage): Register position specifiers.
(set_status): New static method.
(load_dialog): Set status information, if available.
(DesktopSetupPage::OnInit): Set status header font.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Freedom is just another word for nothing left to lose... -- Janis JoplinIndex: LogFile.cc
===
RCS file: /cvs/cygwin-apps/setup/LogFile.cc,v
retrieving revision 2.15
diff -u -p -r2.15 LogFile.cc
--- LogFile.cc 15 Apr 2006 21:21:25 - 2.15
+++ LogFile.cc 28 Mar 2007 14:50:38 -
@@ -24,6 +24,7 @@ static const char *cvsid =
#include io_stream.h
#include win32.h
#include msg.h
+#include dialog.h
#include resource.h
#include iostream
#include sstream
@@ -126,7 +127,14 @@ LogFile::exit (int const exit_code)
been_here = 1;
if (exit_msg)
-note (NULL, exit_msg, backslash(getFileName(LOG_BABBLE)).c_str());
+{
+ char buf[1000], fmt[1000];
+ if (LoadString (hinstance, exit_msg, fmt, sizeof (fmt)) 0)
+{
+ snprintf (buf, 1000, fmt,
backslash(getFileName(LOG_BABBLE)).c_str());
+ log (LOG_PLAIN) note: buf endLog;
+}
+}
log (LOG_TIMESTAMP) Ending cygwin install endLog;
Index: desktop.cc
===
RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
retrieving revision 2.46
diff -u -p -r2.46 desktop.cc
--- desktop.cc 28 Feb 2007 00:55:04 - 2.46
+++ desktop.cc 28 Mar 2007 14:50:38 -
@@ -45,6 +45,7 @@ static const char *cvsid =
#include io_stream.h
#include getopt++/BoolOption.h
#include PackageSpecification.h
+#include LogFile.h
static BoolOption NoShortcutsOption (false, 'n', no-shortcuts, Disable
creation of desktop and start menu shortcuts);
static BoolOption NoStartMenuOption (false, 'N', no-startmenu, Disable
creation of start menu shortcut);
@@ -61,6 +62,18 @@ static BoolOption NoDesktopOption (false
static std::string batname;
static std::string iconname;
+static ControlAdjuster::ControlInfo DesktopControlsInfo[] = {
+ {IDC_DESKTOP_SEPARATOR, CP_STRETCH, CP_BOTTOM},
+ {IDC_STATUS, CP_LEFT, CP_BOTTOM},
+ {IDC_STATUS_HEADER, CP_LEFT, CP_BOTTOM},
+ {0, CP_LEFT, CP_TOP}
+};
+
+DesktopSetupPage::DesktopSetupPage ()
+{
+ sizeProcessor.AddControlInfo (DesktopControlsInfo);
+}
+
static void
make_link (const std::string linkpath,
const std::string title,
@@ -223,12 +236,26 @@ check_if_enable_next (HWND h)
EnableWindow (GetDlgItem (h, IDOK), 1);
}
+extern LogFile * theLog;
+
+static void
+set_status (HWND h)
+{
+ char buf[1000], fmt[1000];
+ if (LoadString (hinstance, exit_msg, fmt, sizeof (fmt)) 0)
+{
+ snprintf (buf, 1000, fmt,
backslash(theLog-getFileName(LOG_BABBLE)).c_str());
+ ::SetWindowText (GetDlgItem (h, IDC_STATUS), buf);
+}
+}
+
static void
load_dialog (HWND h)
{
rbset (h, da, root_desktop);
rbset (h, ma, root_menu);
check_if_enable_next (h);
+ set_status (h);
}
static int
@@ -362,6 +389,7 @@ DesktopSetupPage::OnInit ()
load_dialog (GetHWND
Missing dependency (Attn: links, w3m maintainers) (Was Re: ossl 0.9.7 is still needed by some apps)
On Wed, 28 Mar 2007, Joel Rubin wrote: I decided to clean up my cygwin setup and got rid of some things and reinstalled stuff. I found out that the current versions of two of the text-only browsers, links and w3m, won't run unless you have openssl097 which is, unless you uncheck the hide box, invisible in setup. Doing a Google search, I see that this has been a problem in the past with other packages. Yes, this is a missing dependency issue. Since openssl is now pointing to a new version, and these packages have not been recompiled, they need to put openssl097 into their list of dependencies instead. Thanks for the report. I'm cc'ing the cygwin-apps list, where such issues are usually discussed. Package maintainers, please note. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: Bug: setup.exe crashes on Windows Server 2000
Ugh, top-posting... Reformatted. On Mon, 26 Mar 2007, Charles Hyder wrote: On 3/26/07, Igor Peshansky [EMAIL PROTECTED] wrote: http://cygwin.com/acronyms/#PCYMTNQREAIYR. Thanks. On Mon, 26 Mar 2007, Charles Hyder wrote: Hi, fellows, I'm trying to install Cygwin on Windows Server 2000. I've downloaded the latest version of Cygwin's setup.exe, started it, got all the way to the point where downloading of packages begins, but there i get Integer division by zero crash. No packages are created in the downloads dir. Tried setup.exe with Install from local dir (I have another installation under XP): same crash. I know, 2000 Server is not on everybody's mind anymore, but I do need to install Cygwin there, so help with fixing the bug would be appreciated. Does the latest snapshot from http://cygwin.com/setup/snapshots/ also crash? Igor Yes, exactly the same crash: The exception Integer division by zero Ok. Problems with setup.exe are usually discussed on the cygwin-apps list, so I'm Cc'ing there. If you don't feel like subscribing, you can continue to reply on the main cygwin list. The debugger output follows: 004A74A2 mov dword ptr [esp+4],edx 004A74A6 mov dword ptr [esp],1 [169 lines of assembly dump snipped] 004A764D xor edx,edx 004A764F div eax,ecx -- This is where the breakpoint occurred. Thanks for the effort to debug this, but the above output was pretty useless. What would be more useful is a stack trace. We really need to build a version of the snapshot with debugging symbols (Brian?). When that version is up, please run it and give us the stack trace of the failure. If you have another machine with Cygwin and feel up to it, you can try building a debugging version of setup yourself. Otherwise, please monitor the cygwin-apps list (http://cygwin.com/ml/cygwin-apps/) for the announcement of a debug snapshot. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: Libusb-win32-0.1.12.1-1 makes system unusable after reboot.
On Mon, 26 Mar 2007, Samuel Thibault wrote: Hi, Corinna Vinschen, le Mon 26 Mar 2007 10:42:51 +0200, a écrit : On Mar 24 20:21, Samuel Thibault wrote: Actually, I'm wondering: instead of trying to make libusb0.sys work from /usr/lib/libusb/, is it fine (packaging-wise, I mean), in libusb-install, to just copy it into c:\windows\system32\drivers\ and then use the usual libusb-win32 filter setup? That works fine and actually makes the patch simpler... I am pretty sure that would solve the problem. Yes it does, but the question to cygwin developers is: is it ok packaging-wise? If it helps to work better, it should be ok in this case. It will help a lot yes. What is the best way to get the C:\windows\system32\drivers directory ? %systemroot%\system32\drivers, %windir%\system32\drivers or something else ? Take a look at /etc/postinstall/base-files-mketc.sh. HTH, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: [ITP-adopt] stunnel-4.20-1
On Wed, 21 Feb 2007, Corinna Vinschen wrote: On Feb 21 09:22, Andrew Schulman wrote: Actually, the layout should be usr/share/man/man8/stunnel.8.gz usr/share/man/fr/man8/stunnel.8.gz usr/share/man/pl/man8/stunnel.8.gz Thanks. Corrected and re-uploaded. A. Thanks. Uploaded. You're now officially doomed to maintainership of stunnel. *evil laughter* Igor, got a gold star for Andrew? You mean this[*] one? Igor [*] http://cygwin.com/goldstars/#AS -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: signing off, mostly
On Mon, 4 Dec 2006, Corinna Vinschen wrote: Hi Joshua, On Dec 2 22:20, Joshua Daniel Franklin wrote: Cygwin Community, It's been a fun few years that I've been maintaining the Cygwin documentation, but I think it's come time to ask for replacement volunteers. I now rarely use Windows and just realized when I got a few minutes on my wife's laptop that it doesn't even have the build tools installed, and that the FAQ alert I was going to respond to is nearly two months old: http://www.cygwin.com/ml/cygwin/2006-10/msg00587.html The good news is that I believe I got cygwin-doc in a very stable state, so a lot of it is just a matter of building the docs from CVS, copying the files into a tarball, and releasing. thanks for your commitment in the last couple of years, it's been highly appreciated. I had two gold stars for you in my pocket, but now that I'm trying to give them to you I can't find them... Igor? Would those be the two stars you've sent me to save for a special occasion? ;-) Do you have two gold stars in stock for Joshua? Yep. Thanks, Joshua! Igor P.S. Incidentally, Joshua now holds the record for the most years between gold stars... :-) -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: signing off, mostly
On Mon, 4 Dec 2006, Christopher Faylor wrote: On Mon, Dec 04, 2006 at 10:01:51AM +0100, Corinna Vinschen wrote: Hi Joshua, On Dec 2 22:20, Joshua Daniel Franklin wrote: Cygwin Community, It's been a fun few years that I've been maintaining the Cygwin documentation, but I think it's come time to ask for replacement volunteers. I now rarely use Windows and just realized when I got a few minutes on my wife's laptop that it doesn't even have the build tools installed, and that the FAQ alert I was going to respond to is nearly two months old: http://www.cygwin.com/ml/cygwin/2006-10/msg00587.html The good news is that I believe I got cygwin-doc in a very stable state, so a lot of it is just a matter of building the docs from CVS, copying the files into a tarball, and releasing. thanks for your commitment in the last couple of years, it's been highly appreciated. Big ditto from me. I'm very sad that you are leaving Joshua. It's been a real pleasure working with you. I had two gold stars for you in my pocket, but now that I'm trying to give them to you I can't find them... Igor? Do you have two gold stars in stock for Joshua? Igor, I just happened to bump into Corinna recently, and, coincidentally enough, I am now in possession of two gold stars (and a small number of Euros) myself. Sleek! Perhaps you'd care to share some pointers on the hippo list when the statute of limitations runs out. Rather than let them go stale, I'd like to also apply them to Joshua. Done. This, incidentally, makes him also the record holder for the shortest time period between gold stars. But we all knew he was special... :-) Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Freedom is just another word for nothing left to lose... -- Janis Joplin
Re: [PATCH] Retry replacing in-use files in setup (Was Re: call for testing of latest setup.exe snapshot)
On Mon, 20 Nov 2006, Corinna Vinschen wrote: On Oct 29 22:50, Igor Peshansky wrote: Ping. It's been over a month, which means the archives won't automatically keep thread history, so here's the link to the original message (with the patch): http://cygwin.com/ml/cygwin-apps/2006-08/msg00073.html. Opinions? Can I apply this? Igor Why don't you just go ahead? Corinna Ok. Since there was no objection from Brian, the patch is applied. We should probably kick off a setup snapshot with this change. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Gold stars galore (Was Re: [ITP-adopt] wget-1.10.2-2)
On Fri, 17 Nov 2006, Christopher Faylor wrote: On Fri, Nov 17, 2006 at 09:57:33AM -0700, Eric Blake wrote: I would like to adopt the recently orphaned wget (or maybe I'm just feeling in the mood for another gold star ;). I'm not even going to check this. I assume that you will fix any problems with your usual alacrity, so go ahead and upload. And, please give the man a gold star. Done! Thanks, Eric. Which, btw, makes me ask: Have we missed gold stars for any other package adopters? I tend to hold off on issuing a gold star until the package has already been uploaded so I may have missed somebody. On Fri, 17 Nov 2006, Dave Korn wrote: :) Can I have an experimental gold star for having uploaded an experimental version of gcc and get it upgraded to a real gold star when I upload the new Curr: version? By all means. Unfortunately, I have no time to actually draw the real experimental star, though I do have a design in mind, so I had to improvise -- hopefully this looks experimental enough... :-) On Fri, 17 Nov 2006, Jonathan C. Allen wrote: I'm due two new stars for ncftp and keychain. :) You've got them, Jon! Thanks. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Updated: ncftp-3.2.0-1
On Wed, 8 Nov 2006, Jonathan C. Allen wrote: PACKAGE DESCRIPTION === ncftp - An improved FTP client [snip] Did you, perhaps, mean to send this to cygwin-announce? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Please upload: ImageMagick 6.3.0.1-2 (gold star)
On Mon, 6 Nov 2006, Christopher Faylor wrote: On Mon, Nov 06, 2006 at 10:03:13AM -0500, Volker Quetschke wrote: Eric Blake wrote: According to Volker Quetschke on 11/5/2006 2:45 PM: Please upload: ... Done, and sorry for not more closely reviewing the -1 version (cgf's wet blanket caught up with me). I assume you wanted 6.0.4-1 left as previous, and delete 6.3.0.1-1; so that's the approach I took. Yes, that was the plan. Thank you for doing this. As previously suggested by Eric, can I get a gold star for Volker for picking up this problematic package? I am sure there are a number of people who will be very happy to have a functioning ImageMagick. Done. Thanks, Volker! Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] Retry replacing in-use files in setup (Was Re: call for testing of latest setup.exe snapshot)
Ping. It's been over a month, which means the archives won't automatically keep thread history, so here's the link to the original message (with the patch): http://cygwin.com/ml/cygwin-apps/2006-08/msg00073.html. Opinions? Can I apply this? Igor On Wed, 16 Aug 2006, Igor Peshansky wrote: On Tue, 8 Aug 2006, Igor Peshansky wrote: On Sun, 6 Aug 2006, Brian Dessent wrote: [snip] http://cygwin.com/ml/cygwin-apps/2006-02/msg00099.html So, we have a couple of issues here. Firstly, the bug/unintended feature of -r causing the infinite retries until the file can be written (if I understand correctly.) Second the patch by Igor that adds a dialog when trying to replace an in-use file. Right. Here is my opinion on the matter: I like the dialog idea, but I don't think having Abort as an option is appropriate, as it will potentially cause a really screwed up install, plus it was left unimplemented in the patch submitted. So let's just have two options: Retry and Replace on Reboot. I know that this means we can't use the stock Abort/Retry/Ignore dialog but I think it's worth it for clarity. Agreed on all points. However, there is a technical issue here. Stock MessageBoxes come in many flavors -- there actually is a Retry/Cancel box. There is no Retry/Continue stock box, unfortunately. We can use the Retry/Cancel one, and perhaps play some games with the WNDPROC of the MessageBox class to make Cancel look like Replace on reboot (or Continue, which I like better -- we can explain in the MessageBox text that pressing Continue will require a reboot later), but I'm not sure it'll work, and it'll be ugly. Plus, I don't know that much about the WNDPROC, so it'll take me a bit of time to get something like this working. OTOH, I can change my patch to use the Retry/Cancel box today, and add the following to the text: Pressing 'Cancel' will cause setup to use Windows mechanisms for replacing in-use files. It will be necessary for you to reboot after setup completes. I know, the label Cancel is evocative of aborting the whole installation, but this functionality is so useful, IMO, that I, for one, would put up with a little annoyance of a wrong label. Changing the label in a way I've described above could be a later enhancement. Well, lo and behold, I overreacted. It turned out to be much easier than I anticipated, so attached is the patch with the Retry/Continue message box. http://cygwin.com/ml/cygwin-apps/2006-01/msg00204.html [snip] However, there was another issue in that thread (the inline patch). It seems that applying that will cause the code to be simpler, but I'm afraid there's some little issue I'm missing. I still have that one in my private sandbox, and had it in my running copy of setup for a while with no observed problems. Any opinions? If we can finish off the Retry/Replace file-in-use thing and assuming there are no reports of new issues with this snapshot then I think we can push out a release. Sounds good. If people are fine with the Retry/Cancel box, I can have a new patch by the end of this week. So my weeks end on Wednesdays... :-) Since this change involved indenting an 80-line chunk of code, I'm also attaching a whitespace-indifferent patch for ease of reviewing. ChangeLog is below. Igor == 2006-08-16 Igor Peshansky [EMAIL PROTECTED] * install.cc (Installer::installOne): If file is in use, ask the user to stop processes and retry. (MB_RETRYCONTINUE, IDCONTINUE): New macros. (hMsgBoxHook): New static field. (CBTProc): New window hook function. (_custom_MessageBox): New function. * CHANGES: Update with the above. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
[PATCH] setup: capitalize names of files in /
As mentioned in http://cygwin.com/ml/cygwin/2006-10/msg00466.html,
here's a patch to capitalize the names of /Cygwin.bat and /Cygwin.ico, to
allow better tab completion for /cygdrive on new installs.
I've been doing this rename manually for ages, and it hasn't adversely
affected the operation of Cygwin.
ChangeLog below.
Igor
==
2006-10-12 Igor Peshansky [EMAIL PROTECTED]
* desktop.cc (make_cygwin_bat,save_icon): Capitalize filename.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte.
But no -- you are no fool; you call yourself a fool, there's proof enough in
that! -- Rostand, Cyrano de BergeracIndex: desktop.cc
===
RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
retrieving revision 2.44
diff -u -p -r2.44 desktop.cc
--- desktop.cc 6 Aug 2006 21:39:28 - 2.44
+++ desktop.cc 12 Oct 2006 13:47:30 -
@@ -155,7 +155,7 @@ desktop_icon (const std::string title,
static void
make_cygwin_bat ()
{
- batname = backslash (cygpath (/cygwin.bat));
+ batname = backslash (cygpath (/Cygwin.bat));
/* if the batch file exists, don't overwrite it */
if (_access (batname.c_str(), 0) == 0)
@@ -179,7 +179,7 @@ make_cygwin_bat ()
static void
save_icon ()
{
- iconname = backslash (cygpath (/cygwin.ico));
+ iconname = backslash (cygpath (/Cygwin.ico));
HRSRC rsrc = FindResource (NULL, CYGWIN.ICON, FILE);
if (rsrc == NULL)
Re: [PATCH] setup: capitalize names of files in /
On Thu, 12 Oct 2006, Brian Dessent wrote: Igor Peshansky wrote: As mentioned in http://cygwin.com/ml/cygwin/2006-10/msg00466.html, here's a patch to capitalize the names of /Cygwin.bat and /Cygwin.ico, to allow better tab completion for /cygdrive on new installs. I've been doing this rename manually for ages, and it hasn't adversely affected the operation of Cygwin. Looks fine to me, go ahead and check in. Done, thanks. That is, unless we want to consider moving these to another location alltogether so as not to clutter the root directory. Seems to me that /usr/bin would be the logical choice, but really they could go anywhere. Sure, but that's independent. On Thu, 12 Oct 2006, Dave Korn wrote: I can confirm that, having also done it. In fact, it *so* didn't affect the operation of cygwin that I forgot it was me who did it and thought they always came that way! And now it always will. :-) Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [ANNOUNCEMENT] Updated [experimental]: readline-5.2-1, libreadline6-5.2-1
Moving to cygwin-apps, as this is a packaging issue. On Wed, 4 Oct 2006, Eric Blake wrote: Additionally, this version is not strictly binary compatible with readline 5.1; it removes a cygwin-specific entry point that bash 3.0 (but not bash 3.1) depended on. Now that bash 3.0 is no longer available from the cygwin mirrors, I felt it safe to drop that cygwin-specific patch. Although it is unlikely that any other package depended on this entry point, I need to know now if this decision was not wise, in which case I will create libreadline7 when promoting readline 5.2 to current, leaving libreadline6 to preserve the entry point; but I will only do this if someone can demonstrate why it is needed (hint, you would have to mention the entry point by name to show you know what you are talking about). It's usually a good idea to leave the compatibility library around in any case (hint: someone may have linked their executable with that particular version of libreadline, and would not be in a position to rebuild the executable). The upstream maintainer claims that this version fixes some prompt display bugs when using non-printing escape sequences with a single-line prompt. I have not verified this, but hope that this is the case. FWIW, still doesn't work for me: $ export PS1='[\[\e[32m\]\h\[\e[0m\]:\[\e[33m\]\w\[\e[0m\]] \[\]' [helios:~] cd /c^L [helios:~] cd /c/c ^^^ This is what's displayed. Removing the '\[\]' at the end doesn't help. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Access to upset program
On Wed, 23 Aug 2006, Phil Nelson wrote: Hi everyone, I've been working with Carnegie Mellon University for the last several years to get the Coda Distributed File system working with Windows. Since it was originally developed for UNIX, it turned out that the user land parts of Coda required a lot less changes if compiled with Cygwin. As of last year, we have a beta release that installs a kernel module and the user land parts. As we have been working with this, we discovered that venus (the local cache manager and the program that talks with the servers) ran well with only a few versions of the cygwin .dll. The previous version of the .dll that worked well with venus was 1.5.11. Later versions caused venus to crash in a variety of places. To help people using Coda, we set up a private mirror of cygwin that didn't upgrade past 1.5.11 and so it sat at an old version for a couple of years. At the time, upset was available via anonymous CVS and I could easily build the proper files to be able to add a couple of private packages, coda-base and coda-devel. Finally, this summer 1.5.21 runs venus well again and we are in the process of updating our private mirror to the current version of cygwin. In the process, I went to update our copy of upset only to discover that it is no longer available via anonymous CVS. Is there a way I can get the current version of upset so our private mirror will have the files built correctly? The upset script is no longer publicly available. For the purposes of generating setup.ini files it's been superseded by the genini script, which lives at http://cygwin.com/cgi-bin/cvsweb.cgi/genini/?cvsroot=cygwin-apps. HTH, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: call for testing of latest setup.exe snapshot
On Tue, 8 Aug 2006, Igor Peshansky wrote: On Sun, 6 Aug 2006, Brian Dessent wrote: [snip] http://cygwin.com/ml/cygwin-apps/2006-02/msg00099.html So, we have a couple of issues here. Firstly, the bug/unintended feature of -r causing the infinite retries until the file can be written (if I understand correctly.) Second the patch by Igor that adds a dialog when trying to replace an in-use file. Right. Here is my opinion on the matter: I like the dialog idea, but I don't think having Abort as an option is appropriate, as it will potentially cause a really screwed up install, plus it was left unimplemented in the patch submitted. So let's just have two options: Retry and Replace on Reboot. I know that this means we can't use the stock Abort/Retry/Ignore dialog but I think it's worth it for clarity. Agreed on all points. However, there is a technical issue here. Stock MessageBoxes come in many flavors -- there actually is a Retry/Cancel box. There is no Retry/Continue stock box, unfortunately. We can use the Retry/Cancel one, and perhaps play some games with the WNDPROC of the MessageBox class to make Cancel look like Replace on reboot (or Continue, which I like better -- we can explain in the MessageBox text that pressing Continue will require a reboot later), but I'm not sure it'll work, and it'll be ugly. Plus, I don't know that much about the WNDPROC, so it'll take me a bit of time to get something like this working. OTOH, I can change my patch to use the Retry/Cancel box today, and add the following to the text: Pressing 'Cancel' will cause setup to use Windows mechanisms for replacing in-use files. It will be necessary for you to reboot after setup completes. I know, the label Cancel is evocative of aborting the whole installation, but this functionality is so useful, IMO, that I, for one, would put up with a little annoyance of a wrong label. Changing the label in a way I've described above could be a later enhancement. Well, lo and behold, I overreacted. It turned out to be much easier than I anticipated, so attached is the patch with the Retry/Continue message box. http://cygwin.com/ml/cygwin-apps/2006-01/msg00204.html [snip] However, there was another issue in that thread (the inline patch). It seems that applying that will cause the code to be simpler, but I'm afraid there's some little issue I'm missing. I still have that one in my private sandbox, and had it in my running copy of setup for a while with no observed problems. Any opinions? If we can finish off the Retry/Replace file-in-use thing and assuming there are no reports of new issues with this snapshot then I think we can push out a release. Sounds good. If people are fine with the Retry/Cancel box, I can have a new patch by the end of this week. So my weeks end on Wednesdays... :-) Since this change involved indenting an 80-line chunk of code, I'm also attaching a whitespace-indifferent patch for ease of reviewing. ChangeLog is below. Igor == 2006-08-16 Igor Peshansky [EMAIL PROTECTED] * install.cc (Installer::installOne): If file is in use, ask the user to stop processes and retry. (MB_RETRYCONTINUE, IDCONTINUE): New macros. (hMsgBoxHook): New static field. (CBTProc): New window hook function. (_custom_MessageBox): New function. * CHANGES: Update with the above. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de BergeracIndex: CHANGES === RCS file: /cvs/cygwin-apps/setup/CHANGES,v retrieving revision 1.13 diff -u -p -r1.13 CHANGES --- CHANGES 13 Jun 2006 14:00:23 - 1.13 +++ CHANGES 16 Aug 2006 03:56:05 - @@ -3,6 +3,8 @@ Note: For easier maintenance try to keep Version 2.548 (HEAD) + - Allow interactively retrying to replace open files. + - Fix unreadable chooser page due to bad background colour problem. - Make categories named with an initial . default to expanded display. Index: install.cc === RCS file: /cvs/cygwin-apps/setup/install.cc,v retrieving revision 2.78 diff -u -p -r2.78 install.cc --- install.cc 16 Apr 2006 15:37:49 - 2.78 +++ install.cc 16 Aug 2006 03:56:06 - @@ -178,6 +178,44 @@ Installer::replaceOnRebootSucceeded (con
Re: [ITP] catdoc-0.94.2-1
On Wed, 9 Aug 2006, Reini Urban wrote: BTW: I wonder if people want wv, htmldoc and antiword also. antiword is already part of the distribution. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ [EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-'old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: call for testing of latest setup.exe snapshot
in that thread (the inline patch). It seems that applying that will cause the code to be simpler, but I'm afraid there's some little issue I'm missing. http://www.cygwin.com/ml/cygwin-apps/2006-03/msg00070.html -p option to specify packages to add. I think I must have missed this patch the first time it was posted but I reviewed it here: http://www.cygwin.com/ml/cygwin-apps/2006-07/msg8.html If the submitter can fix the minor points raised I think it's fine for inclusion. If the submitter is still around (if he's not subscribed to cygwin-apps anymore, I can resend your original message to him). Otherwise, I'd just reindent and apply anyway, but it's your call. I don't have a URL Background color issues. These should have been fixed for some time, but a newer snapshot was never made. Bottom line: If we can finish off the Retry/Replace file-in-use thing and assuming there are no reports of new issues with this snapshot then I think we can push out a release. Sounds good. If people are fine with the Retry/Cancel box, I can have a new patch by the end of this week. Thanks, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Please upload: clisp-2.39-1
On Thu, 3 Aug 2006, Corinna Vinschen wrote: On Aug 2 23:06, Reini Urban wrote: Reini Urban schrieb: Christopher Faylor schrieb: Some mail to the spam trap on sourceware indicates that CLISP no longer has a Cygwin maintainer. Is anyone interested in maintaining this? Yep, me. Package is ready, but I will wait until some dependent build req's are through ITP and uploaded: fcgi, libsigsegv and maybe pari. These are just build requirements and may be used optionally at run-time. Still, if someone wants to have a look: http://xarch.tu-graz.ac.at/publ/cygwin/release/clisp/setup.hint http://xarch.tu-graz.ac.at/publ/cygwin/release/clisp/clisp-2.39-1.tar.bz2 http://xarch.tu-graz.ac.at/publ/cygwin/release/clisp/clisp-2.39-1-src.tar.bz2 After extensive testing with some other possible module and feature combinations, the very first and simpliest attempt was the best. So please take the three urls from above. Uploaded, 2.37-1 removed. Thanks for taking over maintainership. Do we still have one of these gold stars in stock, Igor? Yep, just ordered a new batch. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Can a build system other than autotools be used?
On Mon, 31 Jul 2006, Bo Peng wrote: We are planning to submit lyx (www.lyx.org) to cygwin-apps. Although autotools is currently used as the primary build system, we have a scons based system that works better under cygwin, and may replace autotools in the future. Will cygwin accept a build system other than autotools? I ask this question since all instructions seem to be autotools specific. Bo, In the past, packages that used non-autotools builds were accepted into the Cygwin distribution with few problems. The only requirement is that the packages should be buildable with things that are already in the Cygwin distribution. Since, AFAIK, scons isn't yet, you might want to ITP scons before you ITP lyx. HTH, Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: postgresql-client-8.0.7-1.tar.bz2 filesize is 0 in setup.ini
On Sat, 29 Jul 2006, Reini Urban wrote: Igor Peshansky schrieb: Hi, I just noticed that the size of postgresql-client-8.0.7-1.tar.bz2 (the curr version) is set to 0. Is that intentional? It doesn't seem to break setup, but is something to look into, nonetheless. Yes, that's on purpose. There are three main packages: postgresql, libpq4 and postgresql-client. All three of them have existing curr and test packages. The two client packages should have correct cross-dependencies. 1. Empty not to conflict with the existing postgresql-8.0.7-1, which has all the client binaries. 2. Existing, because when installing postgresql-client-8.0.7-1 after having installed 8.1.4-2, to pull in the correct dependencies. Hmm, the usual way of doing this is creating an empty .tar.bz2 archive, which is not 0 bytes (it's something like 46). I'm surprised setup doesn't croak on a 0-byte archive file. Oh, well... Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
postgresql-client-8.0.7-1.tar.bz2 filesize is 0 in setup.ini
Hi, I just noticed that the size of postgresql-client-8.0.7-1.tar.bz2 (the curr version) is set to 0. Is that intentional? It doesn't seem to break setup, but is something to look into, nonetheless. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [RFU] lftp 3.5.1
On Tue, 25 Jul 2006, Corinna Vinschen wrote: On Jul 25 04:18, [EMAIL PROTECTED] wrote: Ahem. I'd like to take over maintainership of the lftp package. It's currently unmaintained. I've packaged version 3.5.1, the latest release. Since this isn't a new package for Cygwin I don't think an ITP is needed, but please review the package files. If they're found to be suitable, please upload them. The package layout is about the same as in the old version; there are some new files, but no new directories. I've kept the postinstall script from the old version. That script is fancier than just plain old [ -f /etc/lftp.conf ] || cp /etc/defaults/etc/lftp.conf /etc but that's in fact what it does in an automated installation (e.g. setup.exe). In an interactive installation, it will prompt the user to decide whether to replace an existing config file. Maybe not too useful, but no harm done either. Thanks, Andrew. wget \ http://home.comcast.net/~andrex/cygwin/lftp/setup.hint \ http://home.comcast.net/~andrex/cygwin/lftp/lftp-3.5.1-1.tar.bz2 \ http://home.comcast.net/~andrex/cygwin/lftp/lftp-3.5.1-1-src.tar.bz2 Cool, thank you. I've uploaded the above files. You're now the official lftp maintainer :-) Time to polish up another gold star. Igor? I'm running out of polish here. Time to order a new batch. :-) Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Cygwin service account (Re: inetd help)
On Mon, 17 Jul 2006, Corinna Vinschen wrote: On Jul 17 16:49, Corinna Vinschen wrote: On Jul 17 10:40, Christopher Faylor wrote: Are there bad reasons for not just calling this account root? A while back I thought this is a good idea, but not anymore. The account is a service-starter account only. Nothing else should be done with this account and the installation script actually forbids this account to be used for logon. I don't want people to get the wrong idea what this account is for. I know from earlier discussions that some people are already using the root account name as a substitute for some Admin account, or that some people are already created a root account on their machines. I can easily imagine what happens next after we occupied the root account name for the service-starter account. Having said that, the account name is still open for discussion of course. If everybody except me thinks root is a good idea, so be it. FWIW, I'd go with daemon (or, as a second choice, server). I agree with your reasoning about root, and, IMO, cygwin_server is too long. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Care to submit a patch? (Was Re: inilex.l misses three \xf8 characters in libwmf ldesc; makefile s.b. flex -7 not flex -8)
On Sun, 2 Jul 2006, sue wrote: (Yes, nothing). Some context would help (at least those not fully familiar with the setup sources). Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: ssh-host-config doesn't chown /var/empty properly from setup.exe
On Tue, 20 Jun 2006, Christopher Faylor wrote: On Mon, Jun 19, 2006 at 08:04:13PM -0400, Igor Peshansky wrote: Hmm, ok, the next thing to check is the fact that PATH and other environment variables may not be set the same. Try adding some debugging information to the postinstall script (or even change the shebang line to bash -x), and see what's different in setup.exe and the command line. This seems to be debugging of an application problem rather than package-related issues. As such, I think this thread belongs in the cygwin mailing list. This was my first impulse too, but then I realized that we were really debugging the environment that setup presents to the postinstall scripts. As such, it's a setup issue, and specifically belongs here, IMHO. If it turns out to be an ssh-host-config issue instead, it'll definitely get moved. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: ssh-host-config doesn't chown /var/empty properly from setup.exe
On Mon, 19 Jun 2006, Thrall, Bryan wrote: I've created a package which does some automatic configuration in its postinstall script, including running `ssh-host-config -y /dev/null`. When setup.exe runs this postinstall script, ssh-host-install works almost perfectly, except that it doesn't chown /var/empty properly: /var/empty ends up owned by the user who is running setup.exe and group none when it should be SYSTEM.root. It also ends up with 700 permissions instead of 755. ssh-host-config has no problems when run from an xterm or tty; I've only noticed it happening when executed from a postinstall script. I'm trying to install on a WinXP machine, the user has administrative privileges, and I tested the latest setup snapshot (2.529) but no luck. I didn't notice any obvious clues from the setup source, either. Any suggestions? Cygcheck output from the target machine is attached, in case it helps. At a guess, your package is not dependent on the base-passwd package, and thus setup is free to run your postinstall script before /etc/passwd is created (which would result in chown not knowing who SYSTEM or root is). Add base-passwd to the requires: line of your setup.hint, and see if it helps. You can check that by looking at the order of script execution in setup.log.full. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
RE: ssh-host-config doesn't chown /var/empty properly from setup.exe
On Mon, 19 Jun 2006, Thrall, Bryan wrote: Igor Peshansky wrote on Monday, June 19, 2006 4:41 PM: On Mon, 19 Jun 2006, Thrall, Bryan wrote: I've created a package which does some automatic configuration in its postinstall script, including running `ssh-host-config -y /dev/null`. When setup.exe runs this postinstall script, ssh-host-install works almost perfectly, except that it doesn't chown /var/empty properly: /var/empty ends up owned by the user who is running setup.exe and group none when it should be SYSTEM.root. It also ends up with 700 permissions instead of 755. ssh-host-config has no problems when run from an xterm or tty; I've only noticed it happening when executed from a postinstall script. I'm trying to install on a WinXP machine, the user has administrative privileges, and I tested the latest setup snapshot (2.529) but no luck. I didn't notice any obvious clues from the setup source, either. Any suggestions? Cygcheck output from the target machine is attached, in case it helps. At a guess, your package is not dependent on the base-passwd package, and thus setup is free to run your postinstall script before /etc/passwd is created (which would result in chown not knowing who SYSTEM or root is). Add base-passwd to the requires: line of your setup.hint, and see if it helps. You can check that by looking at the order of script execution in setup.log.full. Igor Actually, I get the same results even if I try to install my package as a separate step, after completely installing all the standard Cygwin packages I need (Sorry I didn't make that clear). I'm testing on a machine with a working Cygwin installation and just reinstalling my package (I delete /var/empty and cygrunsrv -R sshd before each attempt, so ssh-host-config has something to do). Running ssh-host-config in the same context (working Cygwin, no /var/empty, sshd not installed as a service), but from an xterm or tty sets up /var/empty just fine. I just confirmed that /etc/passwd has the user, SYSTEM, and sshd in it, and /etc/group has root (just in case that could've still been the problem). Hmm, ok, the next thing to check is the fact that PATH and other environment variables may not be set the same. Try adding some debugging information to the postinstall script (or even change the shebang line to bash -x), and see what's different in setup.exe and the command line. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [RFU] lftp 3.4.7-1
On Thu, 25 May 2006, Schulman.Andrew wrote: I've kept the postinstall script from the old version. That script is fancier than just plain old [ -f /etc/lftp.conf ] || cp /etc/defaults/etc/lftp.conf /etc but that's what it in fact does in an automated installation (e.g. setup.exe). In an interactive installation, it will prompt the user to decide whether to replace an existing config file. Maybe not too useful, but no harm done either. Just to make sure, does it actually read its input from stdin? If so, it's not going to work in older versions of setup (before it started redirecting postinstall script input from /dev/null). No. It looks to see if it was invoked as /etc/postinstall/lftp.sh, and if so assumes a no answer to the Overwrite existing /etc/lftp.conf? question. It does print some installation chatter to stdout, but I believe that's okay. Ah, yes, that is certainly ok. As long as it doesn't try to read stdin as a postinstall script, you're fine. I have no particular attachment to this script. I'd be just as happy with the simple version I mentioned above, but decided to leave it since it was already there. Up to you as the maintainer. Besides, since you're keeping the old postinstall script intact, and we didn't hear any complaints about lftp installation, my comment was probably too paranoid. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: Always draw chooser icons using system colors
On Wed, 24 May 2006, Brian Dessent wrote: Igor Peshansky wrote: New iteration of the patch attached. The ChangeLog is slightly different, and is included below. Again, comments welcome, but IMO this is ready to be checked in (as soon as Brian looks it over and gives the go-ahead). I would also guess this is a good excuse for generating a new setup snapshot. Warm fuzzies indeed. Go ahead. Thanks, done. There are some pending patches/discussions, though, that it might be a good idea to commit/resolve before firing off a snapshot build: http://cygwin.com/ml/cygwin-apps/2006-03/msg00060.html http://cygwin.com/ml/cygwin-apps/2006-03/msg00063.html (2 issues) http://cygwin.com/ml/cygwin-apps/2006-03/msg00061.html http://cygwin.com/ml/cygwin-apps/2006-03/msg00070.html http://cygwin.com/ml/cygwin-apps/2006-02/msg00124.html Those are the ones I've found. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
[PATCH] setup: Always draw chooser icons using system colors
Hi,
As promised in http://cygwin.com/ml/cygwin/2006-05/msg00612.html, here's
a patch that makes setup always draw the chooser icons using the system
foreground and background colors (just like it does for text). I've also
taken the opportunity to do a slight bit of code clean-up. There's still
a little glitch left -- when doing a lot of fast scrolling back and forth,
the icons sometimes switch from the system foreground color to the
inverted system background color. I think I know why this is happening
(i.e., the FillRgn() gets ignored for some reason), but this needs further
debugging. As this is a corner case, I wouldn't worry too much about it.
As always, the ChangeLog is below -- opinions welcome.
Igor
ChangeLog:
==
2006-05-23 Igor Peshansky [EMAIL PROTECTED]
* PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView.
* PickView.h (PickView::DrawIcon): Move from PickPackageLine.
* PickCategoryLine.cc (PickCategoryLine::paint): Use
PickView::DrawIcon() instead of BitBlt().
* PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView.
(PickPackageLine::paint): Use PickView::DrawIcon().
* PickView.cc (PickView::~PickView): Delete GDI objects.
(PickView::DrawIcon): New function. Use system default colors to
draw bitmaps.
(PickView::paint): Set background color instead of using transparent
mode.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte.
But no -- you are no fool; you call yourself a fool, there's proof enough in
that! -- Rostand, Cyrano de BergeracIndex: PickCategoryLine.cc
===
RCS file: /cvs/cygwin-apps/setup/PickCategoryLine.cc,v
retrieving revision 2.9
diff -u -p -r2.9 PickCategoryLine.cc
--- PickCategoryLine.cc 9 Sep 2005 19:08:02 - 2.9
+++ PickCategoryLine.cc 23 May 2006 13:10:27 -
@@ -38,9 +38,7 @@ PickCategoryLine::paint (HDC hdc, HRGN h
int by = r + (theView.tm.tmHeight / 2) - 5;
// draw the '+' or '-' box
- SelectObject (theView.bitmap_dc,
- (collapsed ? theView.bm_treeplus :
theView.bm_treeminus));
- BitBlt (hdc, x2, by, 11, 11, theView.bitmap_dc, 0, 0, SRCAND);
+ theView.DrawIcon (hdc, x2, by, (collapsed ? theView.bm_treeplus :
theView.bm_treeminus));
// draw the category name
TextOut (hdc, x2 + 11 + ICON_MARGIN, r, cat.first.c_str(),
cat.first.size());
@@ -52,9 +50,8 @@ PickCategoryLine::paint (HDC hdc, HRGN h
}
// draw the 'spin' glyph
- SelectObject (theView.bitmap_dc, theView.bm_spin);
spin_x = x2 + 11 + ICON_MARGIN + labellength + ICON_MARGIN;
- BitBlt (hdc, spin_x, by, 11, 11, theView.bitmap_dc, 0, 0, SRCAND);
+ theView.DrawIcon (hdc, spin_x, by, theView.bm_spin);
// draw the caption ('Default', 'Install', etc)
TextOut (hdc, spin_x + SPIN_WIDTH + ICON_MARGIN, r,
Index: PickPackageLine.cc
===
RCS file: /cvs/cygwin-apps/setup/PickPackageLine.cc,v
retrieving revision 2.20
diff -u -p -r2.20 PickPackageLine.cc
--- PickPackageLine.cc 16 Apr 2006 23:07:44 - 2.20
+++ PickPackageLine.cc 23 May 2006 13:10:27 -
@@ -19,13 +19,6 @@
#include package_version.h
void
-PickPackageLine::DrawIcon (HDC hdc, int x, int y, HANDLE hIcon)
-{
- SelectObject (theView.bitmap_dc, hIcon);
- BitBlt (hdc, x, y, 11, 11, theView.bitmap_dc, 0, 0, SRCAND);
-}
-
-void
PickPackageLine::paint (HDC hdc, HRGN unused, int x, int y, int col_num, int
show_cat)
{
int rb = y + theView.tm.tmHeight;
@@ -40,21 +33,21 @@ PickPackageLine::paint (HDC hdc, HRGN un
else if (col_num == theView.new_col)
{
// TextOut (hdc, x + HMARGIN/2 + NEW_COL_SIZE_SLOP, y, s.c_str(),
s.size());
- // DrawIcon (hdc, x + HMARGIN/2 + ICON_MARGIN/2 + RTARROW_WIDTH, by,
theView.bm_spin);
+ // theView.DrawIcon (hdc, x + HMARGIN/2 + ICON_MARGIN/2 + RTARROW_WIDTH,
by, theView.bm_spin);
TextOut (hdc, x + HMARGIN/2 + ICON_MARGIN/2 + SPIN_WIDTH , y,
pkg.action_caption ().c_str(), pkg.action_caption ().size());
- DrawIcon (hdc, x + HMARGIN/2, by, theView.bm_spin);
+ theView.DrawIcon (hdc, x + HMARGIN/2, by, theView.bm_spin);
}
else if (col_num == theView.bintick_col)
{
if (/* uninstall or skip */ !pkg.desired ||
/* current version */ pkg.desired == pkg.installed ||
/* no source
Re: [PATCH] setup: Always draw chooser icons using system colors
On Tue, 23 May 2006, Brian Dessent wrote: Igor Peshansky wrote: As promised in http://cygwin.com/ml/cygwin/2006-05/msg00612.html, here's a patch that makes setup always draw the chooser icons using the system foreground and background colors (just like it does for text). I've also taken the opportunity to do a slight bit of code clean-up. There's still a little glitch left -- when doing a lot of fast scrolling back and forth, the icons sometimes switch from the system foreground color to the inverted system background color. I think I know why this is happening (i.e., the FillRgn() gets ignored for some reason), but this needs further debugging. As this is a corner case, I wouldn't worry too much about it. As always, the ChangeLog is below -- opinions welcome. Thanks for taking a look at this. I like that it abstracts all the blitting to one place, although it seems wasteful to me to have to create and destroy dc_tmp like that every time. However, whatever performance hit this creates is probably better than the blatant incorrectness that is there now, so I guess this is progress. I'm also a little hesitant about this glitch you mention, but it sounds like you're on top of that too so I say go ahead and check this in and we can smooth out the rough edges later. Right. I was a bit concerned about the performance hit, but I haven't noticed any slowdown in drawing the chooser. Also, I couldn't factor out (and cache) the creation of those resources, and figured a timely patch was better than wasting time exploring it. We can always do this in a later refactoring. As for the glitch, I've only noticed this after very intensive fast scrolling back-and-forth, using the scroll buttons instead of the scroll bars... It's annoying, but I wouldn't worry about it. What I do worry about is that my patch doesn't check the return values of any functions. I need to fix that before I check it in. Maybe tonight. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: Always draw chooser icons using system colors
On Tue, 23 May 2006, Igor Peshansky wrote: On Tue, 23 May 2006, Brian Dessent wrote: Igor Peshansky wrote: As promised in http://cygwin.com/ml/cygwin/2006-05/msg00612.html, here's a patch that makes setup always draw the chooser icons using the system foreground and background colors (just like it does for text). I've also taken the opportunity to do a slight bit of code clean-up. There's still a little glitch left -- when doing a lot of fast scrolling back and forth, the icons sometimes switch from the system foreground color to the inverted system background color. I think I know why this is happening (i.e., the FillRgn() gets ignored for some reason), but this needs further debugging. As this is a corner case, I wouldn't worry too much about it. As always, the ChangeLog is below -- opinions welcome. Thanks for taking a look at this. I like that it abstracts all the blitting to one place, although it seems wasteful to me to have to create and destroy dc_tmp like that every time. However, whatever performance hit this creates is probably better than the blatant incorrectness that is there now, so I guess this is progress. I'm also a little hesitant about this glitch you mention, but it sounds like you're on top of that too so I say go ahead and check this in and we can smooth out the rough edges later. Right. I was a bit concerned about the performance hit, but I haven't noticed any slowdown in drawing the chooser. Also, I couldn't factor out (and cache) the creation of those resources, and figured a timely patch was better than wasting time exploring it. We can always do this in a later refactoring. I was wrong. I could (and did) factor out the creation of the resources. My previous approach was trying to create the brush upon initialization, instead of in the paint() function. There is still no perceptible performance difference, but there *is* a warm fuzzy feeling. As for the glitch, I've only noticed this after very intensive fast scrolling back-and-forth, using the scroll buttons instead of the scroll bars... It's annoying, but I wouldn't worry about it. What I do worry about is that my patch doesn't check the return values of any functions. I need to fix that before I check it in. Maybe tonight. As a bonus, I've also tracked down the glitch, which turned out to be related. Contrary to the MSDN example code, you *are* supposed to delete any region you allocate using CreateRectRgn() -- otherwise the system runs out of space in the region handle table, and refuses to create any more of them. As I wasn't deleting the regions, eventually new regions didn't get created, and thus didn't get filled, and thus I lost the neat color combo that effectively turned the icon into a mask. Adding the DeleteObject() call fixed my original patch, but now I've factored this out anyway (with the appropriate deletions for all objects, I think). FWIW, the MSDN entry on CreateRectRegion is also silent on whether they should be deleted. Oh, well... New iteration of the patch attached. The ChangeLog is slightly different, and is included below. Again, comments welcome, but IMO this is ready to be checked in (as soon as Brian looks it over and gives the go-ahead). I would also guess this is a good excuse for generating a new setup snapshot. Igor == ChangeLog: 2006-05-23 Igor Peshansky [EMAIL PROTECTED] * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView. * PickView.h (PickView::DrawIcon): Move from PickPackageLine. (PickView::icon_dc,PickView::bm_icon): New instance field. (PickView::rect_icon,PickView::bg_fg_brush): Ditto. * PickCategoryLine.cc (PickCategoryLine::paint): Use PickView::DrawIcon() instead of BitBlt(). * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView. (PickPackageLine::paint): Use PickView::DrawIcon(). * PickView.cc (PickView::~PickView): Delete GDI objects. (PickView::init): Create icon drawing context. (PickView::DrawIcon): New function. Use system default colors to draw bitmaps. (PickView::paint): Set background color instead of using transparent mode. Create system-colored brush. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de BergeracIndex: PickCategoryLine.cc
Re: Apache Tomcat / Tomcat based apps
On Sun, 21 May 2006, Christopher Molnar wrote: Hello, A few weeks back I posted a message asking for some direction on contributing to Cygwin by maintaining Apache Tomcat and a few other tomcat based applications. A few people responded and suggested that I look at gcj as the possible compiler to use as it is already in Cygwin. I have spent the last few weeks trying to get this to work with no success. I would like to find out if it is possible to create a dependency in a package on the sun java sdk. For example the default install of Java 1.5 from Sun uses a home directory of: /cygdrive/c/Program\ Files/Java/jdk1.5.0_06 , so keying on the presence of that directory is a good bet Java is installed with the correct version. Suggestions? Comments? You can have a configuration script that contains a path to the Java SDK, which the users can edit, and install it from a default location if not present. As long as the only thing in that script is the Java SDK location, you should never have to replace it on installation. Sure, the package won't work OOTB, but configuration is as easy as putting one path in, say, /etc/tomcat.java.cfg (invent the name, there isn't a standard one). This also might be a good time to plug my java wrapper scripts in the cygwin-apps repository. They started out exactly along the lines of what you've been thinking (i.e., a hard-coded user-editable path), but my latest improvement that I've just committed uses the $JAVA_HOME setting to detect the installation. This works with both IBM and Sun JDKs (1.4.2 and 1.5.0 are the ones I've tested). I usually make symlinks in /usr/local/bin to the scripts in the local CVS copy. Check them out: http://cygwin.com/cgi-bin/cvsweb.cgi/wrappers/java/?cvsroot=cygwin-apps. I do intend to package them as a Cygwin package at some point soon. Comments and suggestions welcome. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: Apache Tomcat / Tomcat based apps
Ugh, top-posting... Reformatted. On Sun, 21 May 2006, Christopher Molnar wrote: Igor Peshansky wrote: My wrapper scripts do a bit more than that -- they also translate the arguments containing paths appropriately, before eventually invoking the right executables. The part that dispatches based on JAVA_HOME is not the main point of the scripts, though it's nice to have. Igor So if I follow your java.sh script correctly and get the idea, I could call this at the start of the startup.sh script which needs the location of JAVA_HOME and it would find the correct jdk location? or does it just find the java.exe? Well, JAVA_HOME is expected to already point to the correct JDK location. And you would simply invoke the appropriate wrapper for each program (e.g., invoke java to find java.exe, jar to find jar.exe, etc). The wrappers will help those JDK programs understand Cygwin paths, etc. Their intent was to help non-Cygwin-aware Unix scripts that invoke java and other JDK executables. I would need it to find JAVA_HOME and set that variable If I am thinking this through correctly. One of the future work items in the wrappers is the logic (which would most likely go into a /etc/profile.d script) to find some Java installation automatically and set JAVA_HOME if it's not already set. But this is obviously not done yet. I also need this for the build scripts for ANT and TOMCAT. I'm not very familiar with the Tomcat build procedure, but, IIRC, my wrappers will not be very helpful for Ant, as its build scripts understand the JAVA_HOME setting, are Cygwin-aware, and do the appropriate path conversion themselves (so the wrappers never get invoked -- Ant invokes java.exe directly). Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: best practice for upgrading config files?
On Wed, 10 May 2006, Thomas Wolff wrote: Igor Peshansky wrote: ... If the user has modified the default configuration, she most likely knows what she is doing, and probably wouldn't want the installation to muck with her changes (not even if we could create diffs This is certainly true. (On the other hand, having experienced this nuisance of certain packages a number of times, it is good advice anyway not to rely on changing system configurations whenever possible, but rather add overriding local configurations.) As long as you only change existing option values, the patches should apply (possibly with some amount of fuzz). But if you add new configuration option settings, there is a possibility of changing the state of the config file to something invalid. If you're really that concerned with the users keeping their changes *and* getting new updates, split the configuration files into user-modifiable (i.e., those that will only have the user-overridden settings) and standard (which should not be modified by the users), and include the user-modifiable version into the standard one (if your application supports it). But - again on the other hand - if a new release brings in additional parameters, I would of course want them to show up in the configuration so they become effective (and configurable :). with the previous version and cleanly apply the patch). What would be nice in this case, though, is some feedback like Not replacing config file /etc/lftp.conf due to user changes to the postinstall script's stdout, which will end up in the setup.log file. Considering what I said above, I think an automatic merge would be the best, not changing modified parameters, and adding any new parameters. Apart from some moderate handling effort, the only remaining problem would be whether to change default values of previously unchanged parameters - which might have been deliberately unchanged by the user! Dealing with configuration files is usually quite a large can of worms. The users are expected to read release announcements (though I admit, Cygwin setup doesn't make it very easy to find them[*]). (3) Compute a checksum of the current /etc/lftp.conf, and compare it to the checksum of the old default. If they're the same, then the user hasn't touched the old default so copy the new default in. If they're different, then prompt the user as in (2). So we need to store checksums of default config files somewhere. This is Debian's method. ... 2) In the preremove, compare each config file from the manifest with the current default version of that file, and remove the config file if they are identical (using cmp). ... Approaches which either can only replace or not, depending on comparison of the complete file, or delegate all merging problems to the user, are unsuitable for my taste. Unless the part that you're comparing *can* be replaced as a whole (i.e., all user changes are confined to another file that is included into the main config). [*] Would there be interest in propagating URLs of announcement messages in setup.ini, so that Cygwin setup can let the users view the announcements from the chooser screen? An alternative would be keeping this information separately on the sourceware server, writing a CGI script that would retrieve the announcement(s) based on the range of versions, and have setup reference the URL of that CGI script instead. The database of announcements could be updated when announcement messages are forwarded to cygwin-announce, but I don't know enough about that mechanism to offer any concrete suggestions at the moment. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [ITP] mksh 2.6.3 -- MirBSD Korn shell, improved pdksh implementation
On Fri, 5 May 2006, Jari Aalto wrote: Igor Peshansky [EMAIL PROTECTED] writes: As the pdksh maintainer, I would like to veto having this package in the distro simultaneously with pdksh (since this is a newer version of pretty much the same package). In fact, I've been (slowly) working on preparing a new release of pdksh that includes many of the mirbsd patches. I don't mind obsoleting pdksh in favor of mksh, but we'll need to coordinate this. Jari, you might want to review the pending complaints about pdksh to see if they are fixed in your mksh version. I can send you a list (with links to archives) if you're interested. Yes please send them, Ok, here are the ones I have on my list: http://cygwin.com/ml/cygwin/2004-08/msg00112.html http://cygwin.com/ml/cygwin/2005-06/msg00202.html http://cygwin.com/ml/cygwin/2005-08/msg01382.html http://cygwin.com/ml/cygwin/2006-02/msg00448.html I've been in contact with the mksh maintainer and already provided a patch to implement standard shell startup file: ~/.mkshrc in addition to current use of ~/.profile + ENV That's nice. As Debian and Gentoo includes both pdksh and mksh, I'm not sure what is vetoed here. I'd like not to involve with politics if there is some schisma between these two development camps. I'd rather like to offer oppurtunity for users to select what they prefer. Just to oppose program because similar is already there to do same thing, would in fact veto any other program as well, like: MTAs? Sure, there is already exim4 in Cygwin, why should there were need for more MTAs? I'd be more in favor of porting applications regardless of GNOME vs KDE type of rivarly. Jari, there is no rivalry that I know of, and no politics. The veto was purely for practical reasons -- since pdksh development is dead, AFAICS, except in various branches (e.g., Debian, or BSD), we shouldn't keep it in the distro if we decide to also provide a newer (better?) version, and I wouldn't want to maintain an obsolete package. If there are substantial differences, please list them so that we can make an informed decision on whether to keep both pdksh and mksh. As I understand it, mksh subsumes pdksh. Again, I'm willing to obsolete pdksh in favor of mksh *if* it is indeed a drop-in replacement. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [ITP] mksh 2.6.3 -- MirBSD Korn shell, improved pdksh implementation
On Tue, 25 Apr 2006, Jari Aalto wrote: Included in o Debian (testing = f'coming stable) http://packages.debian.org/mksh o Gentoo http://packages.gentoo.org/ebuilds/?mksh-23 Jari sdesc: Enhanced version of the Korn shell ldesc: A shell which is MirBSD enhanced version of the Public Domain Korn shell (pdksh), a bourne-compatible shell which is largely similar to the original ATT Korn shell. It includes bug fixes and feature improvements in order to produce a modern, robust shell good for interactive and especially script use. category: Shells requires: cygwin 1) Manual download wget\ http://cygwin.cante.net/mksh/mksh-2.6.3-1.tar.bz2.sig \ http://cygwin.cante.net/mksh/mksh-2.6.3-1.tar.bz2 \ http://cygwin.cante.net/mksh/mksh-2.6.3-1-src.tar.bz2.sig \ http://cygwin.cante.net/mksh/mksh-2.6.3-1-src.tar.bz2 \ http://cygwin.cante.net/mksh/setup.hint 2) Automated; running sh get.sh will print further instructions gpg --keyserver wwwkeys.pgp.net --recv-keys 955A92D8 mkdir mksh ; cd mksh rm -f get.sh get.sh.sig wgethttp://cygwin.cante.net/mksh/get.sh \ http://cygwin.cante.net/mksh/get.sh.sig gpg --verify get.sh.sig get.sh sh get.sh As the pdksh maintainer, I would like to veto having this package in the distro simultaneously with pdksh (since this is a newer version of pretty much the same package). In fact, I've been (slowly) working on preparing a new release of pdksh that includes many of the mirbsd patches. I don't mind obsoleting pdksh in favor of mksh, but we'll need to coordinate this. Jari, you might want to review the pending complaints about pdksh to see if they are fixed in your mksh version. I can send you a list (with links to archives) if you're interested. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [ITP] mksh 2.6.3 -- MirBSD Korn shell, improved pdksh implementation
On Mon, 1 May 2006, Christopher Faylor wrote: On Mon, May 01, 2006 at 03:33:46PM -0600, Paul Watson wrote: The mksh.exe cannot do some things in my .profile which are now being done by pdksh on Cygwin, ksh on AIX and Solaris, and ATT ksh on FC4. The man page does not specify anything about reporting bugs. Is there an email address, bugzilla, mailing list? Igor has vetoed this package so I don't think there is any reason to continue testing it for now. Just a clarification -- I did not veto the package as much as I vetoed having it as a *separate* package. If this is indeed an update of pdksh, I'm willing to relinquish maintainership (and the package could also be renamed, FWIW). But having both in the distro would be pretty useless. IMO, until Jari replies to my proposal, cygwin-apps is not an appropriate place for reporting bugs and results of testing mksh. You should be able to report the bugs directly to him, however. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: HEADS-UP: Modular X11 (ALL maintainers, please read)
On Mon, 17 Apr 2006, James R. Phillips wrote: --- James R. Phillips wrote: --- Yaakov S (Cygwin Ports) wrote: I have been working on packaging the new, modular X11R7.0 for Cygwin for the last few weeks. Mega-gold-stars for you! SECOND, the following packages install into /usr/X11R6. These should be repackaged into /usr ASAP after the X11R7.0 upgrade: [...] ghostscript-x11 [2] OK [...] [2] ghostscript currently provides two sets of executables; a non-X version in /usr and an X version in /usr/X11R6. What is the reasoning for this, and is it really necessary? It is necessary if you want to have a ghostscript version that does not depend on X. Maybe this will be less important now, with the modular X, but I suspect it is still important. ghostscript functions just fine as a command-line filter, so many folks would prefer to have the non-X version. The X version has the additional capability to write a bitmap rendering to an X client - I think that is about the only difference. I'll take a look at how Debian or Ubuntu handle it, and see if I can shamelessly copy their ideas. OK, I looked at debian, and to my surprise they don't offer a version of ghostscript that doesn't depend on X. And this in spite of the fact that they haven't switched to the modular X-server yet (although they will shortly). X is part of the base Debian install. It is not part of the base Cygwin install. So I wonder if cygwin really needs to support a non-X version of ghostscript in the future. I have no clue whether it might be able to live with a small subset of the newly-modular X libraries. Thoughtful comments would be appreciated. Unless the set of X libraries is *really* small, it would make sense to have a non-X version of ghostscript. If we keep both versions, we need a way to keep them from overwriting each other, because they could both be installed. This needs to be considered because cygwin setup doesn't have a concept of conflicting packages. The current arrangement just puts them in different paths, and lets the $PATH environmental variable sort out which one you will get. I don't think the alternatives sytem really does what you want for this set of packages, because one is _not_ just as good as the other, i.e., if the version linked to X is installed, you definitely want to use it. It should probably be taken care of using a symlinks in pre- and post-install scripts. The desired behavior would be to use the non-X version only if it is the only version installed; and otherwise to set the symlink to the version that is linked to X. You're right, the alternatives system will not work. You could try to have a postinstall script that retargets a symlink -- have ghostscript-nox postinstall only create the symlink if not present, but let ghostscript-x11 retarget the symlink if it points to the nox version. Besides, I'm sure many files could be shared betwee the two installations. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: HEADS-UP: Modular X11 (ALL maintainers, please read)
On Mon, 17 Apr 2006, James R. Phillips wrote: --- Igor Peshansky wrote: X is part of the base Debian install. It is not part of the base Cygwin install. Um, that is not true. It is still perfectly possible to setup a debian install without any X libraries. But of course you couldn't install ghostscript. Right. I guess I should have said X is part of the common Debian install (and it isn't part of the common Cygwin install). However, once we switch to the modular codebase, nothing really prevents us from adding parts of X to the common Cygwin install. I'm not convinced that it's such a good idea, but it's a possibility. Unless the set of X libraries is *really* small, it would make sense to have a non-X version of ghostscript. OK, we'll have to wait and see on that. Otherwise, I guess we have consensus in principle on a method to carry both versions forward. You're the maintainer -- ultimately, it's your call. :-) Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: HEADS-UP: Modular X11 (ALL maintainers, please read)
On Sun, 16 Apr 2006, Yaakov S (Cygwin Ports) wrote:
I have been working on packaging the new, modular X11R7.0 for Cygwin for
the last few weeks. There's still a few dozen packages left, but the
time has come to deal with handling some of the issues involved in this
transition.
Good job!
For those unaware of X11 internals, the major changes included in
X11R7.0 over our current X11R6.8 are:
[snip]
3) /usr/X11R6 is deprecated; like any other package, X11R7.0 is being
configured with --prefix=/usr.
The move to /usr will affect a number of packages.
Not only that, it will affect many users' shortcuts. For example, many
users have a shortcut to xterm that says something like
c:\cygwin\usr\X11R6\bin\run /usr/X11R6/bin/xterm [options]
Some have quite a few. If we go through with this change, we'll need to
find a good way of dealing with the move so that shortcuts either won't
need to be changed, or can be changed automatically.
FWIW, we cannot use mounts, since shortcuts use Win32 paths.
FIRST, the following two packages *must* be rearranged BEFORE the X11R7.0
upgrade, in order not to cause collisions:
[snip]
xpm-nox:
a) /usr/bin/{c,s}xpm.exe and /usr/share/man/man1/{c,s}xpm.1 will collide with
those provided by libXpm. These should have -noX appended to their names.
SECOND, the following packages install into /usr/X11R6. These should be
repackaged into /usr ASAP after the X11R7.0 upgrade:
[snip]
[2] ghostscript currently provides two sets of executables; a non-X
version in /usr and an X version in /usr/X11R6. What is the reasoning
for this, and is it really necessary?
Yes. Its purpose is the same as xpm-nox -- to allow rendering postscript
to a non-screen device in batch mode. People who don't have X may still
want to do this, for example to convert postscript to PDF.
Status:
By tonight, I'll have completed everything relevant in app, data, doc,
lib, proto, and util. That leaves font and xserver remaining.
You'll also have to think of things like X-startup-scripts. While they
are not part of the X server proper, many people rely on them to start the
X server. There may also be quite a few custom scripts with hard-coded
paths, but a simple symlink of /usr/X11R6-/usr should do the trick for
those.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte.
But no -- you are no fool; you call yourself a fool, there's proof enough in
that! -- Rostand, Cyrano de Bergerac
Re: Please Upload: ghostscript-8.50-1
On Thu, 16 Feb 2006, Corinna Vinschen wrote: On Feb 15 10:07, James R. Phillips wrote: This is the first ghostscript release from a new maintainer (James R. Phillips). Uploaded. I removed 7.05-2. I kept 8.15-1 and 8.15-2 for now. Thanks for taking over maintainance of an orphaned package. Igor, could you brush up a gold star, please? Corinna A bit late, but nonetheless... Done. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: setup problems when updating cygwin1.dll
On Sun, 26 Mar 2006, Lapo Luchini wrote: It correctly says you have to reboot, cygwin could not work correctly until you reboot... but then works not correctly a few seconds later, during postinstall scripts ;-) (lots of entry point not found) Hmm, one way of addressing this would be to also schedule the postinstall scripts to run on reboot, rather than running them at that point. I don't think this can easily avoided, but at least the message could be changed to warn the user about it (maybe just in the case it can be needed, i.e. when cygwin1.dll changes). FWIW, any DLL change can prompt such behavior... It's just more common with cygwin1.dll. Ah, I also had a local package aspell-it whose .tar.bz2 was truncated as far as tar told, but that setup.exe extracted in an infinite file (I killed it when it had already extracted 840MB out of a 33MB file). Hmm, that's a completely separate issue. If you still have that truncated file, it would be useful in figuring out whether setup's tar algorithm has a bug. Does the command-line tar have the same problem? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: ITP: xsri
On Tue, 21 Mar 2006, Charles Wilson wrote: X Set Root Image This is a simple app that does nothing much -- and uses a bazillion gtk2 libraries to do it. However, that means it can do nothing much, but with STYLE. Then why not name it xsris (X Set Root Image with STYLE)? It has a much nicer pronunciation, too (i.e., accessorize)... :-) Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: ITP: rxvt-W
On Tue, 21 Mar 2006, Corinna Vinschen wrote: On Mar 21 02:34, Charles Wilson wrote: So, long term plan: (1) obsolete the current rxvt package (maybe not officially put it in the _obsolete category, but it's still on Corinna's missing-maintainer list, so...) (2) rxvt-unicode-X and rxvt-unicode-W packages, installed side-by-side. Medium term plan: (1) keep using current rxvt package for native windows (2) provide rxvt-unicode-X for X-based operation -- see earlier ITP (3) provide libW11, libXpm-W11, and [broken]rxvt-W which uses them. Keep banging on libW11 and rxvt-W until it works as good as current rxvt. Hope others help. (4) provide rxvt-W and rxvt-unicode-X installed side-by-side, obsoleting current rxvt completely Medium-Long term plan (1) provide [broken]rxvt-unicode-W side by side with working rxvt-W and rxvt-unicode-X. (2) Bang some more on libW11 and rxvt-unicode-W until it works as well as rxvt-W (even if it doesn't actually support *unicode*, per se). (3) replace rxvt-W with rxvt-unicode-W Sounds like a good plan, but... ...how do you plan to replace the old rxvt functionality from the user's perspective? This I don't see in your description. So far the user can call just rxvt and gets what the DISPLAY variable suggests. With rxvt-unicode you will get two binaries which can't (or rather, shouldn't) use the same name. Will rxvt in the long term be the X11 version or the W11 version? Or will rxvt become a wrapper script calling the right version depending on the DISPLAY setting to maintain the current usability? That shouldn't be hard. The current rxvt is pretty simple-minded about when it uses native mode. In particular, it tests for $DISPLAY (or the -display argument) being empty or exactly :0, and runs in native mode, otherwise it tries to connect to an X server on that display. This could be easily implemented in a wrapper script that parses the options and the value of $DISPLAY and exec's rxvt-unicode-W or rxvt-unicode-X. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
On Fri, 17 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 16 Mar 2006, Max Bowsher wrote: Speaking of in-use DLLs, did you have a chance to look at http://cygwin.com/ml/cygwin-apps/2006-03/msg00060.html? OK, I'll have a look. Thanks. So, I think we should always rename preremove scripts, because we certainly don't want a failed preremove script to be removed by the later file-removal phase - it might be wanted for debugging. I would even go one step further, and cancel the uninstall of the current package and all packages it depends on if the preremove failed. But that should be a separate patch. Would this work, BTW? As for postinstall scripts ... I think ideally it would be a separate operation (c.f. 'dpkg --configure --pending'), but I guess we can go with the simple solution for now, and defer a more complex solution until someone has the inclination. So, does this mean please check in? I'd like preremove scripts to be renamed on failure. But, OK, you check in as-is, and I'll follow-up with a change for that. Hmm, it's easy enough to rename scripts on failure -- it is simply a question of propagating the information of whether this is a preremove script or not to the script object itself. Since all preremove scripts are run from try_run_script(), and none of the postinstall scripts are, it should be reasonably easy to add a rename_on_failure field (and constructor argument that defaults to false), and set it to true in the Script() constructor in try_run_script(). Once I commit this one in, I can look into adding the rename_on_failure code... While we're at it, I'd also like to clean up the constant mentions of strings /etc/postinstall (in at least 3 places) and /etc/preremove (in two). Those should be defined in script.h as macros, most likely... Another patch coming up... Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: RFC: [PATCH] Simplify installed.db format
On Thu, 16 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: Hi, The current format for installed.db is (except the first line) PKG-NAME TARBALL-NAME 0 which setup tries to parse as package-name filename filesize src-filename srcsize (with src-filename and srcsize never used, and the filesize field never accessed). I propose to remove the unused fields, with the intention of later reusing the (always 0) for something else. The attached patch fixes the parsing of installed.db package lines. Comments welcome. Igor == ChangeLog: 2006-01-22 Igor Peshansky [EMAIL PROTECTED] * cygpackage.h (filesize): Remove unused field. (cygpackage::createInstance): Ditto. * cygpackage.cc (cygpackage::createInstance): Ditto. * package_db.cc (packagedb::packagedb): Remove unused variables. Simplify parsing of installed.db. Does this constitute dropping support for version 1 installed.db files? If so, we should remove the rest of the code attempting to support version 1 too. I think support for this has been dropped a while ago, and what we're seeing are spurious remnants. FWICS, I did not remove the parsing and processing of any fields that were actually used... Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
On Thu, 16 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Tue, 14 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). Do we necessarily want to try to re-run failed scripts the next time setup installs some packages? Why not? It would make recovery from a hosed install because of in-use DLLs easy enough -- just re-run setup and select Keep, which will only rerun the postinstall scripts. Speaking of in-use DLLs, did you have a chance to look at http://cygwin.com/ml/cygwin-apps/2006-03/msg00060.html? Perhaps renaming to .failed would be better that not renaming. Max. Perhaps setup should check when you first start it up whether there are any postinstall scripts left lying around from last time and offer to run them for you then and there? Failed postinstalls should be run to completion *before* next updating the package! Why? I'm not so certain. So your preremove will fail -- who cares, it would also fail if cygwin is upgraded and is uninstalled before the preremove script is run. Next time you upgrade, it'll be like the initial install all over again, and the *new* postinstall will run. If you didn't touch the package, however, the postinstall that failed before will be re-run. If it failed because of something in the environment when setup was run (e.g., a stale DLL in memory), it will now succeed and will be renamed to .done. If it fails again, we'll know something was wrong, and will recommend looking at the output in setup.log.full. I'm concerned about introducing weird subtle edge cases. For example: Upgrade package in which old version has preremove, new version does not. preremove fails. Next time setup runs, stale preremove zaps parts of the upgraded package. Granted, it's a fairly tenuous situation, but at least the current behaviour is very predictable: scripts are only re-run manually. Umm, we can never have stale postinstalls and preremoves, since those are part of the manifest (pkg.lst) and will be removed by the uninstall part of the upgrade. The only way we can have a stale postinstall is if it no longer has the name in the manifest (i.e., is renamed to .done). Am I missing something? Ah, I hadn't thought of that. So, I think we should always rename preremove scripts, because we certainly don't want a failed preremove script to be removed by the later file-removal phase - it might be wanted for debugging. I would even go one step further, and cancel the uninstall of the current package and all packages it depends on if the preremove failed. But that should be a separate patch. As for postinstall scripts ... I think ideally it would be a separate operation (c.f. 'dpkg --configure --pending'), but I guess we can go with the simple solution for now, and defer a more complex solution until someone has the inclination. So, does this mean please check in? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
On Tue, 14 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). Do we necessarily want to try to re-run failed scripts the next time setup installs some packages? Why not? It would make recovery from a hosed install because of in-use DLLs easy enough -- just re-run setup and select Keep, which will only rerun the postinstall scripts. Perhaps renaming to .failed would be better that not renaming. Max. Perhaps setup should check when you first start it up whether there are any postinstall scripts left lying around from last time and offer to run them for you then and there? Failed postinstalls should be run to completion *before* next updating the package! Why? I'm not so certain. So your preremove will fail -- who cares, it would also fail if cygwin is upgraded and is uninstalled before the preremove script is run. Next time you upgrade, it'll be like the initial install all over again, and the *new* postinstall will run. If you didn't touch the package, however, the postinstall that failed before will be re-run. If it failed because of something in the environment when setup was run (e.g., a stale DLL in memory), it will now succeed and will be renamed to .done. If it fails again, we'll know something was wrong, and will recommend looking at the output in setup.log.full. I'm concerned about introducing weird subtle edge cases. For example: Upgrade package in which old version has preremove, new version does not. preremove fails. Next time setup runs, stale preremove zaps parts of the upgraded package. Granted, it's a fairly tenuous situation, but at least the current behaviour is very predictable: scripts are only re-run manually. Umm, we can never have stale postinstalls and preremoves, since those are part of the manifest (pkg.lst) and will be removed by the uninstall part of the upgrade. The only way we can have a stale postinstall is if it no longer has the name in the manifest (i.e., is renamed to .done). Am I missing something? Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: initially expand categories starting with .
On Tue, 14 Mar 2006, Max Bowsher wrote: Igor Pechtchanski wrote: This patch implements one of the setup augmentations useful for the installation profiles idea (for lack of a better name :-) ). Igor == ChangeLog: 2005-11-16 Igor Pechtchanski [EMAIL PROTECTED] * PickView.cc (PickView::setViewMode): Auto-expand category if its name starts with a dot. I'm fine with the concept, BUT: using *string to mean the first character of string, whilst valid, doesn't express the intent very clearly to people reading the code. So, please use (*n).first.c_str()[0] instead. With that change, please commit. Thanks, done. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: setup.exe: feature request with patch
On Thu, 9 Mar 2006, Joshua Daniel Franklin wrote: On Mon, 6 Mar 2006, Dr. F. Lee wrote: I deploy cygwin using unattended (http://unattended.sf.net/) and wpkg (http://www.wpkg.org/). It's useful for me to be able to specify additional packages to be installed on the command line. The attached file is a patch to provide this: call setup -p package1,package2,package3,...,packageN to have packages1-N artificially included in the 'Base' part of the distribution and hence automatically included. Simply set up a local package server with one empty package, which is in Base and requires: all the packages you need installed. Had thought about that, but I didn't see how to specify two repositories on the command line - and I didn't fancy having to run an httpd to serve a few files when it seemed like a useful thing for setup to do from the command line. It also would work for people without access to a web server, and FWIW, another way of doing this is creating a full setup.ini entry for that empty package, and then appending it to setup.ini whenever a new one is downloaded. This would also work without a web server. probably be easier for blind users (we've had a couple of requests). The blind user problem was actually with the chooser screen, which doesn't work with screen readers. I think most of our blind users are capable of editing a text file... That said, I do like the patch, and with a bit of cleanup it would be a useful addition to setup (again, IMO). I'd actually like a copy of your build, if you wouldn't mind emailing it to me off-list or posting a URL with testing instructions to the main list. Perhaps someone could even put it at http://cygwin.com/setup/snapshots/ When this patch (possibly cleaned up) gets applied, someone will. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: RFC: [PATCH] Retry replacing in-use files in setup
The recent messages about in-use files and hosed postinstall reminded me
of this pending patch.
Ping.
Lapo liked it. Any comments from anyone else? Should we scrap the idea?
What's left to do, besides the obvious cleanup?
Igor
On Tue, 14 Feb 2006, Igor Peshansky wrote:
Hi,
Here's a quick and dirty patch to retry replacing in-use files. Unless
setup is running in unattended mode, it will show an Abort/Retry/Ignore
dialog warning the user that a particular file was in-use. The user can
Retry indefinitely, though the second and subsequent messages are going
to be a bit more stringent. Ignore will prevent any further pop-ups
(the logic being that if even one file was set to be replaced on reboot,
might as well do all of them).
This worked for me in some limited testing, but is obviously not complete
(e.g., Abort doesn't work -- do we even need it?).
I'd like some comments from people on both the behavior and my
assumptions. The patch was intentionally done in whitespace-indifferent
mode to make the actual changes easier to see, so please don't mention the
sloppy indentation. :-) Just in case this gets passed with flying colors
and accepted into the codebase, I've included the ChangeLog below.
Igor
==
2006-02-14 Igor Peshansky [EMAIL PROTECTED]
* install.cc (Installer::installOne): If file is in use, ask the user
to stop processes and retry.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte.
But no -- you are no fool; you call yourself a fool, there's proof enough in
that! -- Rostand, Cyrano de BergeracIndex: install.cc
===
RCS file: /cvs/cygwin-apps/setup/install.cc,v
retrieving revision 2.77
diff -u -p -w -r2.77 install.cc
--- install.cc 1 Sep 2005 16:39:27 - 2.77
+++ install.cc 15 Feb 2006 02:44:52 -
@@ -206,6 +206,7 @@ Installer::installOne (packagemeta pkgm
io_stream *tmp = io_stream::open (source.Cached (), rb);
io_stream *tmp2 = 0;
archive *thefile = 0;
+ bool ignoreExtractErrors = unattended_mode;
if (tmp)
{
tmp2 = compress::decompress (tmp);
@@ -253,8 +254,38 @@ Installer::installOne (packagemeta pkgm
Progress.SetText3 (canonicalfn.c_str());
log (LOG_BABBLE) Installing file prefixURL prefixPath
fn endLog;
- if (archive::extract_file (thefile, prefixURL, prefixPath) != 0)
+ bool firstIteration = true;
+ while (archive::extract_file (thefile, prefixURL, prefixPath) != 0)
{
+ if (!ignoreExtractErrors)
+ {
+ char msg[fn.size() + 300];
+ sprintf (msg,
+ %snable to extract %s -- the file is in use.\r\n
+ Please stop %s Cygwin processes and select
\Retry\,\r\n
+ or select \Ignore\ to go on anyway (you will need
to reboot).\r\n
+ Select \Abort\ to stop the installation\r\n,
+ firstIteration?U:Still u, fn.c_str(),
firstIteration?all:ALL);
+ switch (MessageBox
+ (NULL, msg, In-use files detected,
+ MB_ABORTRETRYIGNORE | MB_ICONWARNING | MB_TASKMODAL))
+ {
+ case IDRETRY:
+ // retry
+ firstIteration = false;
+ continue;
+ case IDABORT:
+ MessageBox(NULL, This option is ignored for now,
+Option ignored, MB_OK | MB_ICONINFORMATION |
MB_TASKMODAL);
+ break;
+ case IDIGNORE:
+ ignoreExtractErrors = true;
+ break;
+ default:
+ break;
+ }
+ // fall through to previous functionality
+ }
if (NoReplaceOnReboot)
{
++errors;
@@ -324,6 +355,8 @@ Installer::installOne (packagemeta pkgm
}
}
}
+ // We're done with this file
+ break;
}
progress (tmp-tell ());
num_installs++;
Re: RFC: [PATCH] Simplify installed.db format (take 3)
On Mon, 23 Jan 2006, Igor Peshansky wrote:
: The attached patch fixes the parsing of installed.db package lines.
: Comments welcome.
:
: 2006-01-23 Igor Peshansky [EMAIL PROTECTED]
:
:* cygpackage.h (filesize): Remove unused field.
:(cygpackage::createInstance): Ditto.
:* cygpackage.cc (cygpackage::createInstance): Ditto.
:* package_db.cc (packagedb::packagedb): Remove unused variables.
:Simplify parsing of installed.db.
In fact, let's use the attached patch instead.
YA ping?
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte.
But no -- you are no fool; you call yourself a fool, there's proof enough in
that! -- Rostand, Cyrano de BergeracIndex: setup/cygpackage.cc
===
RCS file: /cvs/cygwin-apps/setup/cygpackage.cc,v
retrieving revision 2.15
diff -u -p -r2.15 cygpackage.cc
--- setup/cygpackage.cc 14 May 2005 15:57:29 - 2.15
+++ setup/cygpackage.cc 23 Jan 2006 15:06:52 -
@@ -66,7 +66,7 @@ cygpackage::createInstance (const String
packageversion
cygpackage::createInstance (String const pkgname, String const filename,
- size_t const fs, String const version,
+ String const version,
package_status_t const newstatus,
package_type_t const newtype)
{
@@ -75,7 +75,6 @@ cygpackage::createInstance (String const
temp-fn = filename;
temp-status = newstatus;
temp-type = newtype;
- temp-filesize = fs;
temp-setCanonicalVersion (version);
return packageversion(temp);
}
Index: setup/cygpackage.h
===
RCS file: /cvs/cygwin-apps/setup/cygpackage.h,v
retrieving revision 2.15
diff -u -p -r2.15 cygpackage.h
--- setup/cygpackage.h 14 May 2005 15:57:29 - 2.15
+++ setup/cygpackage.h 23 Jan 2006 15:06:52 -
@@ -72,7 +72,7 @@ public:
const package_type_t type);
static packageversion createInstance (String const , String const ,
- size_t const, String const ,
+ String const ,
package_status_t const,
package_type_t const);
@@ -92,7 +92,6 @@ private:
package_type_t type;
io_stream *listdata, *listfile;
- size_t filesize;
};
#endif /* SETUP_CYGPACKAGE_H */
Index: setup/package_db.cc
===
RCS file: /cvs/cygwin-apps/setup/package_db.cc,v
retrieving revision 2.30
diff -u -p -r2.30 package_db.cc
--- setup/package_db.cc 14 Oct 2005 04:10:26 - 2.30
+++ setup/package_db.cc 23 Jan 2006 15:06:53 -
@@ -57,8 +57,8 @@ packagedb::packagedb ()
if (!db)
return;
/* flush_local_db_package_data */
- char line[1000], pkgname[1000], inst[1000], src[1000];
- int instsz, srcsz;
+ char line[1000], pkgname[1000], inst[1000];
+ int instsz;
if (db-gets (line, 1000))
{
@@ -80,14 +80,11 @@ packagedb::packagedb ()
while (db-gets (line, 1000))
{
int parseable;
- src[0] = '\0';
+ int ign;
pkgname[0] = '\0';
inst[0] = '\0';
- srcsz = 0;
- instsz = 0;
- sscanf (line, %s %s %d %s %d, pkgname, inst, instsz, src,
- srcsz);
+ sscanf (line, %s %s %d, pkgname, inst, ign);
if (pkgname[0] == '\0' || inst[0] == '\0')
continue;
@@ -109,7 +106,7 @@ packagedb::packagedb ()
}
packageversion binary =
- cygpackage::createInstance (pkgname, inst, instsz, f.ver,
+ cygpackage::createInstance (pkgname, inst, f.ver,
package_installed,
package_binary);
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
On Thu, 9 Mar 2006, Igor Peshansky wrote: P.S. A note for the archives: now that setup has a proper mechanism to detect failed postinstall scripts... [snip] Whoops, I guess I misremembered that the patch has not yet been applied. So... On Mon, 23 Jan 2006, Igor Peshansky wrote: Just noticed that the postinstall mechanism in setup inverts the test for abnormal exit. The attached one-liner patch fixes that. ChangeLog below. Igor == 2006-01-23 Igor Peshansky [EMAIL PROTECTED] * script.cc (Script::run): Fix inverted test for abnormal exit. Ping (attached as setup-script-exit-code-fix.patch-1). On Tue, 31 Jan 2006, Igor Peshansky wrote: Dave's advice in http://cygwin.com/ml/cygwin/2006-01/msg01475.html, made me realize that setup will always rename the script to .done, even if it didn't complete properly (i.e., exited with a non-zero exit code). Now that we detect the code correctly, let's also use that to not rename failed scripts for easier detection (patch attached). ChangeLog below. Note that this will put a bit of extra burden on package maintainers to ensure that their scripts always return a zero exit code. Most scripts already do that, though. Igor == 2006-01-31 Igor Peshansky [EMAIL PROTECTED] * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). In light of the extra burden consideration, let's look at those separately. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de BergeracIndex: script.cc === RCS file: /cvs/cygwin-apps/setup/script.cc,v retrieving revision 2.21 diff -u -p -r2.21 script.cc --- script.cc 14 Oct 2005 04:00:50 - 2.21 +++ script.cc 23 Jan 2006 17:07:02 - @@ -243,7 +243,7 @@ Script::run() const if (to_log !file_out.isEmpty ()) log(LOG_BABBLE) file_out endLog; - if (!retval) + if (retval) log(LOG_PLAIN) abnormal exit: exit code= retval endLog;; /* if file exists then delete it otherwise just ignore no file error */ Index: script.cc === RCS file: /cvs/cygwin-apps/setup/script.cc,v retrieving revision 2.21 diff -u -p -r2.21 script.cc --- script.cc 14 Oct 2005 04:00:50 - 2.21 +++ script.cc 31 Jan 2006 14:39:40 - @@ -243,14 +243,15 @@ Script::run() const if (to_log !file_out.isEmpty ()) log(LOG_BABBLE) file_out endLog; - if (!retval) + if (retval) log(LOG_PLAIN) abnormal exit: exit code= retval endLog;; /* if file exists then delete it otherwise just ignore no file error */ io_stream::remove (String (cygfile://) + scriptName + .done); - io_stream::move (String (cygfile://) + scriptName, - String (cygfile://) + scriptName + .done); + if (!retval) +io_stream::move (String (cygfile://) + scriptName, + String (cygfile://) + scriptName + .done); return retval; }
Re: [PATCH] setup: Handle the package validation exception
On Mon, 23 Jan 2006, Igor Peshansky wrote:
On Mon, 23 Jan 2006, Brian Dessent wrote:
Igor Peshansky wrote:
I've looked at this a bit. Here's the weird part: the error says
Uncaught Exception, but all the throws of that exception appear to be
properly wrapped in try/catch blocks. So a simple change exception
into
an mbox kind of solution won't work here. More debugging is needed.
The reason for the box is that the md5 checking was changed to run in a
different thread than originally designed (now in the main thread
instead of the download thread IIRC) and that thread does not have any
particular catch handler for that exception, only the TOPLEVEL_CATCH
which punts with the generic error.
Do you mean packagemeta::ScanDownloadedFiles() calling
packageversion::scan(), which calls check_for_cached()? Then yes, this
isn't properly wrapped in a try/catch. I'd like to verify that this is
the culprit (when someone sends me the corrupt tarball), but I think I see
a proper fix for this. Will submit a patch shortly.
And here's the patch (attached). The ChangeLog is below.
While we're at it, I found another weird bit of code in setup. Would
someone please enlighten me on how the semantics would change if the
following patch were applied:
Index: package_meta.cc
===
RCS file: /cvs/cygwin-apps/setup/package_meta.cc,v
retrieving revision 2.50
diff -u -p -r2.50 package_meta.cc
--- package_meta.cc 11 Sep 2005 14:45:54 - 2.50
+++ package_meta.cc 23 Jan 2006 21:18:10 -
@@ -620,8 +620,8 @@ packagemeta::ScanDownloadedFiles ()
while (i != pkg.versions.end ())
{
/* scan doesn't alter operator == for packageversions */
- const_castpackageversion (*i).scan ();
packageversion foo = *i;
+ foo.scan ();
packageversion pkgsrcver = foo.sourcePackage ();
pkgsrcver.scan ();
The current code looks way too complex, and my alternative looks cleaner,
but there may be an obscure C++ issue I'm missing.
Ping on this one...
Igor
==
2006-01-23 Igor Peshansky [EMAIL PROTECTED]
* package_version.cc (packageversion::scan): Catch and handle
validation exception.
And ping on this. The patch discussion thread starts at
http://cygwin.com/ml/cygwin-apps/2006-01/msg00204.html.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte.
But no -- you are no fool; you call yourself a fool, there's proof enough in
that! -- Rostand, Cyrano de BergeracIndex: package_version.cc
===
RCS file: /cvs/cygwin-apps/setup/package_version.cc,v
retrieving revision 2.24
diff -u -p -r2.24 package_version.cc
--- package_version.cc 14 May 2005 12:30:32 - 2.24
+++ package_version.cc 23 Jan 2006 21:20:41 -
@@ -29,6 +29,7 @@ static const char *cvsid =
#include resource.h
#include algorithm
#include download.h
+#include Exception.h
using namespace std;
@@ -322,8 +323,22 @@ packageversion::scan()
* FIXME: This is a bit of a hack. a better way is to abstract
* the availability logic to the package
*/
- if (!check_for_cached (*(source())) ::source == IDC_SOURCE_CWD)
-source()-sites.clear();
+ try
+{
+ if (!check_for_cached (*(source())) ::source == IDC_SOURCE_CWD)
+ source()-sites.clear();
+}
+ catch (Exception * e)
+{
+ // We can ignore these, since we're clearing the source list anyway
+ if (e-errNo() == APPERR_CORRUPT_PACKAGE)
+ {
+ source()-sites.clear();
+ return;
+ }
+ // Unexpected exception.
+ throw e;
+}
}
static bool
Re: [PATCH] setup: initially expand categories starting with .
On Tue, 31 Jan 2006, Igor Peshansky wrote: On Sun, 22 Jan 2006, Igor Peshansky wrote: On Thu, 17 Nov 2005, Igor Pechtchanski wrote: (see http://cygwin.com/ml/cygwin-apps/2005-11/msg00141.html) 2005-11-16 Igor Peshansky [EMAIL PROTECTED] * PickView.cc (PickView::setViewMode): Auto-expand category if its name starts with a dot. Ping. YA ping. Igor Should I keep yapping? :-D Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
RE: [PATCH] setup: fix abnormal exit test for postinstall scripts
On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). Do we necessarily want to try to re-run failed scripts the next time setup installs some packages? Why not? It would make recovery from a hosed install because of in-use DLLs easy enough -- just re-run setup and select Keep, which will only rerun the postinstall scripts. Perhaps renaming to .failed would be better that not renaming. Max. Perhaps setup should check when you first start it up whether there are any postinstall scripts left lying around from last time and offer to run them for you then and there? Failed postinstalls should be run to completion *before* next updating the package! Why? I'm not so certain. So your preremove will fail -- who cares, it would also fail if cygwin is upgraded and is uninstalled before the preremove script is run. Next time you upgrade, it'll be like the initial install all over again, and the *new* postinstall will run. If you didn't touch the package, however, the postinstall that failed before will be re-run. If it failed because of something in the environment when setup was run (e.g., a stale DLL in memory), it will now succeed and will be renamed to .done. If it fails again, we'll know something was wrong, and will recommend looking at the output in setup.log.full. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
On Thu, 9 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: 2006-01-23 Igor Peshansky [EMAIL PROTECTED] * script.cc (Script::run): Fix inverted test for abnormal exit. Ping (attached as setup-script-exit-code-fix.patch-1). Clearly correct, please commit. Thanks, done. 2006-01-31 Igor Peshansky [EMAIL PROTECTED] * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). Do we necessarily want to try to re-run failed scripts the next time setup installs some packages? Perhaps renaming to .failed would be better that not renaming. See the discussion in http://cygwin.com/ml/cygwin-apps/2006-03/msg00068.html. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_[EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`'-. ;-;;,_Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte. But no -- you are no fool; you call yourself a fool, there's proof enough in that! -- Rostand, Cyrano de Bergerac
