Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-17 Thread Max Bowsher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Igor Peshansky wrote: On Thu, 16 Mar 2006, Max Bowsher wrote: Speaking of in-use DLLs, did you have a chance to look at http://cygwin.com/ml/cygwin-apps/2006-03/msg00060.html? OK, I'll have a look. So, I think we should always rename preremove

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-17 Thread Igor Peshansky
On Fri, 17 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 16 Mar 2006, Max Bowsher wrote: Speaking of in-use DLLs, did you have a chance to look at http://cygwin.com/ml/cygwin-apps/2006-03/msg00060.html? OK, I'll have a look. Thanks. So, I think we should always rename

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-16 Thread Max Bowsher
Igor Peshansky wrote: On Tue, 14 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-16 Thread Igor Peshansky
On Thu, 16 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Tue, 14 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit.

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-14 Thread Igor Peshansky
On Tue, 14 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-09 Thread Igor Peshansky
On Thu, 9 Mar 2006, Igor Peshansky wrote: P.S. A note for the archives: now that setup has a proper mechanism to detect failed postinstall scripts... [snip] Whoops, I guess I misremembered that the patch has not yet been applied. So... On Mon, 23 Jan 2006, Igor Peshansky wrote: Just noticed

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-09 Thread Max Bowsher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Igor Peshansky wrote: 2006-01-23 Igor Peshansky [EMAIL PROTECTED] * script.cc (Script::run): Fix inverted test for abnormal exit. Ping (attached as setup-script-exit-code-fix.patch-1). Clearly correct, please commit. 2006-01-31 Igor

RE: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-09 Thread Dave Korn
On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). Do we necessarily want to try to re-run failed scripts the

RE: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-09 Thread Igor Peshansky
On Thu, 9 Mar 2006, Dave Korn wrote: On 09 March 2006 23:14, Max Bowsher wrote: * script.cc (Script::run): Fix inverted test for abnormal exit. Do not rename to .done unless completed successfully. And ping (attached as setup-script-exit-code-fix.patch). Do we necessarily want

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-03-09 Thread Igor Peshansky
On Thu, 9 Mar 2006, Max Bowsher wrote: Igor Peshansky wrote: 2006-01-23 Igor Peshansky [EMAIL PROTECTED] * script.cc (Script::run): Fix inverted test for abnormal exit. Ping (attached as setup-script-exit-code-fix.patch-1). Clearly correct, please commit. Thanks, done.

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts

2006-01-31 Thread Igor Peshansky
On Mon, 23 Jan 2006, Igor Peshansky wrote: Just noticed that the postinstall mechanism in setup inverts the test for abnormal exit. The attached one-liner patch fixes that. ChangeLog below. Dave's advice in http://cygwin.com/ml/cygwin/2006-01/msg01475.html, made me realize that setup will