Re: Patch to handle Win32 named pipes as file names

On Thu, May 06, 2004 at 01:45:54PM -0400, Stephen Cleary wrote: >>However, if you want to contribute code to Cygwin, we need a copyright >>assignment from you, filled out and snail mailed to Red Hat. Please >>see http://cygwin.com/contrib.html for details. > >I will get this in the mail. Remember

Re: [Patch]: chdir

On Thu, May 06, 2004 at 11:03:33AM -0400, Pierre A. Humblet wrote: >"Pierre A. Humblet" wrote: >> Corinna Vinschen wrote: >> > Ooops: >> > >> > $ cd / >> > /: No such file or directory. >> >>Oops, nothing to do with chdir. It's in the code that detects file >>components consisting entirely of

Re: [Patch]: chdir

On Thu, May 06, 2004 at 10:00:37AM -0400, Pierre A. Humblet wrote: > >Corinna Vinschen wrote: >> Ooops: >> >> $ cd / >> /: No such file or directory. > >Oops, nothing to do with chdir. It's in the code that detects >file components consisting entirely of dots or spaces. > >Something crossed my

Re: [Patch]: chdir

On Tue, May 04, 2004 at 08:20:03PM -0400, Christopher Faylor wrote: >On Tue, May 04, 2004 at 08:03:59PM -0400, Pierre A. Humblet wrote: >>Here is a simple patch that simplifies chdir processing >>and avoids calling normalized_posix_path multiple times. >> >>If it doe

Re: [Patch]: chdir

On Tue, May 04, 2004 at 08:03:59PM -0400, Pierre A. Humblet wrote: >Here is a simple patch that simplifies chdir processing >and avoids calling normalized_posix_path multiple times. > >If it doesn't break anything it will simplify removing >trailing dots and spaces, as discussed earlier today. "If

Re: [Patch]: Last path.cc

On Sat, Apr 10, 2004 at 11:37:07PM -0400, Pierre A. Humblet wrote: >2004-04-11 Pierre Humblet <[EMAIL PROTECTED]> > > * path.cc (normalize_win32_path): Detect components with only dots. > Remove a final . if it follows '\\'. > (slash_unc_prefix_p): Remove redundant tests. >

Re: Copyright assignment received for Chris Faylor

On Thu, Apr 29, 2004 at 06:55:53PM -0400, Sergey Okhapkin wrote: >Corinna Vinschen wrote: >>Red Hat received the copyright assignment for Chris Faylor and the yay of >>his new employer. So patch right away, Chris! > >Hmm... I remember the day when I got similar message from Geof Noer... >Welcome

Re: Recent changes in pthread_create

On Wed, Apr 21, 2004 at 10:44:57AM -0400, Christopher Faylor wrote: >On Wed, Apr 21, 2004 at 09:18:11AM +0200, Thomas Pfaff wrote: >>Date: Thu, 18 Apr 2002 12:11:26 +0200 >>[...] >>2. The InterlockedIncrement (&MT_INTERFACE->threadcount) in >> __pthread_create

Re: Recent changes in pthread_create

On Wed, Apr 21, 2004 at 09:18:11AM +0200, Thomas Pfaff wrote: >Date: Thu, 18 Apr 2002 12:11:26 +0200 >[...] >2. The InterlockedIncrement (&MT_INTERFACE->threadcount) in > __pthread_create is misplaced. If the newly created thread terminates > fast enough the threadcount will be decremented before

Re: Recent changes in pthread_create

On Wed, Apr 21, 2004 at 09:18:11AM +0200, Thomas Pfaff wrote: >i am not so happy with the recent changes to pthread_create and >pthread::init_wrapper. Is it at all possible for you not to apprise me of your emotional state regarding any changes I make? If you have a technical problem then present

Re: [Patch]: 3 or more initial slashes

On Tue, Apr 20, 2004 at 01:38:01PM -0400, Pierre A. Humblet wrote: >POSIX specifies that three ore more slashes at the beginning >of a pathname are equivalent to a single one. >This patch implements that feature. >Only Posix paths are affected, Windows paths are left alone. >Also, Posix paths are

Re: wingdi.h (ENUMLOGFONTEXDV[AW]): breaks cygwin (fwd)

On Tue, Apr 20, 2004 at 09:52:32AM -0500, Brian Ford wrote: >I sent this to mingw-patches yesterday, but it got stuck waiting on >moderator approval because I am not subscribed. As such, I thought I'd >forward it here as well. I stumbled across this while generating a snapshot today and checked i

Re: [Patch]: st_size for symlinks

On Tue, Apr 13, 2004 at 10:16:32PM -0400, Pierre A. Humblet wrote: >This patch sets st_size correctly for symlinks. Please check in. Thanks. cgf

Re: [Patch]: Last path.cc

On Tue, Apr 13, 2004 at 10:49:13PM +0200, Corinna Vinschen wrote: >Oh, one problem left. Currently fhandler_disk_file::fchmod calls >chmod_device which is pretty ugly. Chris, do you have an idea how >to do that in a cleaner way? It sounds like the same thing as required by fhandler_base::fstat_f

Re: [Patch]: path.cc

On Mon, Apr 12, 2004 at 07:06:45PM -0400, Pierre A. Humblet wrote: >This fixes the /proc bug reported on the list. Please check in. Thanks, cgf

Re: [Patch]: dtable.cc

On Sat, Apr 10, 2004 at 11:42:39PM -0400, Pierre A. Humblet wrote: >Here is a minor fix in dtable.cc. Thanks. Applied. >My next fix is to remove the normalized_path from path_conv, >and the attendant malloc and path_conv destructor. Please, don't bother. I don't want to do this. I want to hav

Re: [Patch]: Last path.cc

On Sat, Apr 10, 2004 at 11:37:07PM -0400, Pierre A. Humblet wrote: >This should take care of the issues I listed yesterday evening. > >I simply don't understand the logic in normalize_win32_path >well enough to touch it intelligently. >So I removed the final . in the dumbest way possible Why do w

Re: [Patch]: path.cc

On Fri, Apr 09, 2004 at 11:19:57PM -0400, Pierre A. Humblet wrote: >I am somewhat concerned that the update of fsinfo isn't thread safe. >I don't know how the overhead of making it thread safe compares with >the overhead of the old method (not caching the fs_info). Corinna, this is a problem that

Re: [PATCH] thread self handling revised

On Thu, Apr 01, 2004 at 11:58:45AM +0200, Thomas Pfaff wrote: >Rethinking the changes to pthread::init_mainthread i came to the conclusion >that this stuff can be made simpler and cleaner. >The changes to init_maintread are reverted, the thread self pointer for an >unknown thread is now set in pthr

Re: [Patch]: path.cc

On Sun, Apr 04, 2004 at 11:46:22PM -0400, Pierre A. Humblet wrote: >2004-04-05 Pierre Humblet <[EMAIL PROTECTED]> > > * path.cc (path_conv::check): Optimize symlink replacements. I've checked both of these in and am generating a snapshot now. Could you advertise its existence on cygwin at

Re: [Patch]: path.cc

On Sun, Apr 04, 2004 at 09:57:56AM -0400, Pierre A. Humblet wrote: >At 11:01 PM 4/3/2004 -0500, Christopher Faylor wrote: >>On Sat, Apr 03, 2004 at 09:49:40PM -0500, Pierre A. Humblet wrote: > >>Also, there is a problem in execution: > > >>I believe that this

Re: [Patch]: path.cc

On Sat, Apr 03, 2004 at 09:49:40PM -0500, Pierre A. Humblet wrote: >This patch removes old cruft from and streamlines the mainline of >path_conv::check (avoiding a bunch of strlen, strcpy and the like). >It also removes trailing / in win32 paths. Pierre, this patch didn't compile. I had to decla

Re: [Dr.Volker.Zell@oracle.com: Re: uxterm from xterm-185-3 and xfontsel crashing when running under cygserver support]

On Tue, Mar 30, 2004 at 05:33:07PM +0200, Corinna Vinschen wrote: >On Mar 30 16:39, Thomas Pfaff wrote: >>Corinna Vinschen wrote: >>>Do you have an appropriate patch? >> >>2004-03-30 Thomas Pfaff <[EMAIL PROTECTED]> >> >> * thread.h (pthread::init_mainthread): Add parameter forked. >> S

Re: [Dr.Volker.Zell@oracle.com: Re: uxterm from xterm-185-3 and xfontsel crashing when running under cygserver support]

On Tue, Mar 30, 2004 at 03:55:14PM +0200, Corinna Vinschen wrote: >On Mar 30 15:34, Thomas Pfaff wrote: >> Regardless whether a process is started from a cygwin app or not it will >> always start at mainCRTStartup. >> >> When it is started by the SCM however the service_main thread is created by

Re: [Dr.Volker.Zell@oracle.com: Re: uxterm from xterm-185-3 and xfontsel crashing when running under cygserver support]

On Tue, Mar 30, 2004 at 02:42:20PM +0200, Thomas Pfaff wrote: >1. The thread which is started by the service control manager must be >initiallized, for example in the first get_tls_self_pointer call. Chris has made >some changes to TLS, i do not know if _my_tls can be used for a thread that is >cr

Re: [PATCH]: Trivial move in pthread::atforkprepare

On Mon, Mar 29, 2004 at 10:26:18AM +0200, Thomas Pfaff wrote: >MT_INTERFACE->fixup_before_fork () should be done as the last step in >pthread::atforkprepare. > >I am sorrry if the Changelog contains spaces, but i have limited internet >access at the moment (only Webmail). > >2004-03-29 Thomas Pfa

Re: [RFA]: Thread safe stdio again

On Fri, Mar 26, 2004 at 01:50:08AM -0500, Christopher Faylor wrote: >On Sun, Mar 14, 2004 at 08:28:02PM +0100, Thomas Pfaff wrote: >>This time i am using the non portable mutex initializers, therefore >>moving __sinit is no longer needed. And i added calls to newlibs >

Re: [RFA]: Thread safe stdio again

On Sun, Mar 14, 2004 at 08:28:02PM +0100, Thomas Pfaff wrote: >This time i am using the non portable mutex initializers, therefore >moving __sinit is no longer needed. And i added calls to newlibs >__fp_lock_all and __fp_unlock_all at fork. > >2004-03-14 Thomas Pfaff <[EMAIL PROTECTED]> > > *

Re: Patch 20040321 for audio recording with /dev/dsp (indented), test issues

On Tue, Mar 23, 2004 at 12:09:33PM +0100, Corinna Vinschen wrote: >Chris, do you have a personally approved set of indent options which >give a useful result, perhaps? No, I don't use indent very often. Gdb has an indent script, though. I've attached it to this message. I can't confirm or deny

Re: [Patch]: Win95

On Mon, Mar 22, 2004 at 02:57:36PM -0500, Pierre A. Humblet wrote: > > >Christopher Faylor wrote: >> >> On Mon, Mar 22, 2004 at 09:36:36AM -0500, Pierre A. Humblet wrote: >> >This fixes gnuchess on Win95. >> >There is still a compiler warning, will look

Re: [Patch]: Win95

On Mon, Mar 22, 2004 at 09:36:36AM -0500, Pierre A. Humblet wrote: >This fixes gnuchess on Win95. >There is still a compiler warning, will look at it tonight. >Tested on ME, 95 and NT4.0 > >2004-03-22 Pierre Humblet <[EMAIL PROTECTED]> > > * init.cc (munge_threadfunc): Handle all instances o

Re: [Patch]: rmdir

On Wed, Mar 17, 2004 at 10:21:44PM -0500, Pierre A. Humblet wrote: >This is not a bug fix, just the reversion of a comment removal >following some recent tests on NT, plus some code simplification. > >Here are the details: >- Until last Sunday, rmdir(".") didn't work. >- Now it works on 9x if the d

Re: [Patch]: rmdir

On Sun, Mar 14, 2004 at 10:46:06AM -0500, Pierre A. Humblet wrote: > >2004-03-14 Pierre Humblet <[EMAIL PROTECTED]> > > * dir.cc (rmdir): Construct real_dir with flag PC_FULL. > Use a loop instead of recursion to handle the current directory. Looks good. Please apply. Thanks, cgf

Re: [Patch] src/winsup/mingw/include/process.h __STRICT_ANSI__

On Thu, Mar 11, 2004 at 07:23:37PM -0500, Brian Keener wrote: >I notice when trying to compile the #endif got left behind. Sure you found it by >now. > >2004-03-11 Brian Keener <[EMAIL PROTECTED]> > >* include/process.h: Remove the #endif associated with removal of >__STRICT_AN

Re: [Patch] Signal mask handling

On Thu, Mar 11, 2004 at 09:04:05PM -0500, Pierre A. Humblet wrote: >2004-02-11 Pierre Humblet <[EMAIL PROTECTED]> > > * cygtls.h (_cygtls::newmask): Delete member. > (_cygtls::newmask): New member. > * gendef (_sigdelayed): Replace the call to > set_process_mask by

Re: [Patch] Signal mask handling

On Thu, Mar 11, 2004 at 09:04:05PM -0500, Pierre A. Humblet wrote: >At 08:43 PM 3/11/2004 -0500, you wrote: >>On Thu, Mar 11, 2004 at 07:36:41PM -0500, Pierre A. Humblet wrote: >>>There was a problem: pause() calls handle_sigsuspend(), which overwrites >>>the oldmask set by _cygtls::interrupt_setup

Re: [Patch] Signal mask handling

On Thu, Mar 11, 2004 at 07:36:41PM -0500, Pierre A. Humblet wrote: >There was a problem: pause() calls handle_sigsuspend(), which overwrites >the oldmask set by _cygtls::interrupt_setup. It's all fixed, and I have >renamed newmask to deltamask in cygtls.h. I can send you a fresh patch >(everything

Re: [Patch] Signal mask handling

On Wed, Mar 10, 2004 at 11:26:19PM -0500, Pierre A. Humblet wrote: >2004-02-11 Pierre Humblet <[EMAIL PROTECTED]> > > * gendef (_sigdelayed): Replace the call to > set_process_mask by a call to set_process_mask_delta. > * exceptions.cc (_cygtls::interrupt_setup): Set oldm

Re: Implement TIOCSBRK / TIOCCBRK serial ioctl

2004-03-03 Jaakko Hyvatti <[EMAIL PROTECTED]> * fhandler_serial.cc (fhandler_serial::ioctl): Implement TIOCSBRK and TIOCCBRK which set and clear break condition on serial TxD. Applied. Thanks. cgf

Re: sigproc.cc (proc_subproc): make -j hang

On Mon, Mar 08, 2004 at 03:05:12PM -0600, Brian Ford wrote: >While trying to analyze my own strace example of a "make -j hang" ala this >ugly thread: > >http://www.cygwin.com/ml/cygwin/2004-03/msg00376.html > >My last strace output from the hung make process was: > 69 1576822 [proc] make 6724 pro

Re: FW: Final patch for audio recording with /dev/dsp

On Wed, Mar 03, 2004 at 10:55:43AM +0100, Corinna Vinschen wrote: >[Sorry for the delay, I didn't realize that my mail to cygwin-patches > didn't come through] > >Hi Gerd, > >thanks for the patch, but regardless of the content, it's not acceptable >for a few stylistic reasons: > >- All sentences en

Re: [PATCH] Add support for non portable mutex initializers

On Fri, Feb 20, 2004 at 08:47:43AM +0100, Thomas Pfaff wrote: >This patch will add support for PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP, >PTHREAD_NORMAL_MUTEX_INITIALIZER_NP and >PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP (+ some small bugfixes). >Attached are also testcases for these initializers. >The

Assignment received from Gerd Spalink

We've received an assignment from Gerd Spalink so any patch submissions are now ok. Gerd, please resubmit patches against current CVS. Thanks, cgf

Re: [PATCH] Thread safe stdio

On Wed, Feb 11, 2004 at 11:08:57AM +0100, Thomas Pfaff wrote: >The __sinit call must be done after malloc is initialized, otherwise the >mutex creation will fail. I am not comfortable with this part of the patch. I moved the __sinit call where I did for a reason. It needed to be called earlier

Re: DEBUGGING guards in winsup/cygwin/exceptions.cc are missing

On Sun, Feb 08, 2004 at 08:46:23PM -0500, Volker Quetschke wrote: >When compiling the cygwin dll from cvs, without --enable-debugging >the build fails in winsup/cygwin/exceptions.cc because console_printf >has no prototype defined without DEBUGGING set. Thanks for the heads up. I will check in a

Re: Final patch for audio recording with /dev/dsp

On Sat, Feb 07, 2004 at 07:36:32PM +0100, Gerd Spalink wrote: >Please find attached the refined patch to enable audio recording with /dev/dsp. > >It replaces the patch I posted on December 8, 2003 > >Enhancements in comparison to what I previously posted: > >Late and rate-dependent audio buffer all

Re: [PATCH]: 2. Thread safe stdio update

On Fri, Jan 23, 2004 at 12:03:09PM +0100, Thomas Pfaff wrote: >Corinna Vinschen wrote: >>On Jan 22 21:48, Thomas Pfaff wrote: >> >>>This is an update of my previous patch. It adds support for newlibs >>>__LOCK_INIT macro. >>> >>>Thomas >>> >>>2004-01-22 Thomas Pfaff <[EMAIL PROTECTED]> >>> >>>

Re: [Patch]: heap_chunk_size

On Mon, Feb 02, 2004 at 08:22:01PM -0500, Pierre A. Humblet wrote: >Here is a no brainer patch that eliminates the use of "heap_chunk" in >the cygwin shared. That removes a source of DOS attack and it's >another step towards the demise of the cygwin shared. This isn't a no-brainer. This value is

Re: [Patch]: ciresrv.parent

On Mon, Feb 02, 2004 at 04:04:05PM -0500, Christopher Faylor wrote: >On Mon, Feb 02, 2004 at 09:47:35AM -0500, Pierre A. Humblet wrote: >>Do you want to apply the patch now, or I do it this evening? > >I applied it. I also got rid of all of the now-obsolete >argum

Re: [Patch]: ciresrv.parent

On Mon, Feb 02, 2004 at 09:47:35AM -0500, Pierre A. Humblet wrote: >Do you want to apply the patch now, or I do it this evening? I applied it. I also got rid of all of the now-obsolete arguments/parameters to fixup_after_exec. cgf

Re: [Patch]: ciresrv.parent

On Sat, Jan 31, 2004 at 02:18:48PM -0500, Pierre A. Humblet wrote: >Fortunately it is never used in the case of spawn: all handles are >inherited, or the parent does the work (sockets). The one placed the handle is actually used is in fhandler_socket::fixup_after_exec. I'd like Corinna's confirm

Re: patch for audio recording with /dev/dsp

On Thu, Jan 29, 2004 at 12:07:26PM +0100, Corinna Vinschen wrote: >We just have no feedback from the person who's collecting the papers so far. >For that reason we have to wait, yet. Actually, I believe we do have the individual form. I had asked for the employer's signature also since we don't h

Re: [Patch]: secret event

On Fri, Jan 23, 2004 at 11:04:05AM -0500, Pierre A. Humblet wrote: > >Christopher Faylor wrote: >> >> >> I agree, with one nit. Was there a reason for getting rid of the handle >> protection in this patch? We are apparently stumbling over a problem with >>

Re: Fix write deadlock with streaming serial devices

On Thu, Jan 22, 2004 at 05:07:38PM -0600, Brian Ford wrote: >2004-01-22 Brian Ford <[EMAIL PROTECTED]> > > * fhandler_serial.cc (fhandler_serial::raw_write): Prevent a > deadlock when the input buffer overflows. > (fhandler_serial::raw_read): Correct to print the actual error >

Re: [PATCH]: 2. Thread safe stdio update

On Fri, Jan 23, 2004 at 12:14:32PM +0100, Corinna Vinschen wrote: >I think you should RFA it on newlib and apply the rest of the patch >when Jeff applied. But I'd like to hear from Chris first, if that >patch should go into 1.5.7 or if it should wait for a while. I haven't looked at the patch in

Re: [Patch]: secret event

On Fri, Jan 23, 2004 at 10:59:52AM +0100, Corinna Vinschen wrote: >On Jan 22 18:33, Pierre A. Humblet wrote: >> 2004-01-22 Pierre Humblet <[EMAIL PROTECTED]> >> >> * fhandler_socket.cc (fhandler_socket::create_secret_event): Avoid >> creating multiple handles. Always allow event inherit

Re: [PATCH]: Fix typo in signal.cc

On Wed, Jan 21, 2004 at 10:34:42AM -0500, [EMAIL PROTECTED] wrote: >2004-01-21 Nicholas Wourms <[EMAIL PROTECTED]> > > * signal.cc (sigaction): Fix if-statement typo. Applied. Thanks. cgf

Re: lstat symbolic link size

On Wed, Jan 07, 2004 at 11:33:18AM -0600, Brian Ford wrote: >On Mon, 5 Jan 2004, Christopher Faylor wrote: > >> On Mon, Jan 05, 2004 at 08:38:24PM -0500, Christopher Faylor wrote: >> >On Tue, Jan 06, 2004 at 09:30:26AM +0800, peter garrone wrote: >> >>lstat return

Re: termios.cc: Restore setting of EBADF appropriately throughout

On Fri, Dec 12, 2003 at 01:14:32PM -0600, Brian Ford wrote: >I noticed this while digging through other serial port problems. It >appears to have been lost in version 1.16, although there did not appear >to be a reason for the loss in that change. Please let me know if it was >intentional for som

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Wed, Dec 10, 2003 at 10:30:16PM -0500, Christopher Faylor wrote: >On Wed, Dec 10, 2003 at 10:28:53PM -0500, Christopher Faylor wrote: >>On Wed, Dec 10, 2003 at 09:54:30PM -0500, Pierre A. Humblet wrote: >>>At 12:08 AM 12/9/2003 -0500, Christopher Faylor wrote: >>>

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Wed, Dec 10, 2003 at 10:28:53PM -0500, Christopher Faylor wrote: >On Wed, Dec 10, 2003 at 09:54:30PM -0500, Pierre A. Humblet wrote: >>At 12:08 AM 12/9/2003 -0500, Christopher Faylor wrote: >>>I'll work on that tomorrow. >> >>OK, it works, but I found a few

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Wed, Dec 10, 2003 at 09:54:30PM -0500, Pierre A. Humblet wrote: >At 12:08 AM 12/9/2003 -0500, Christopher Faylor wrote: >>I'll work on that tomorrow. > >OK, it works, but I found a few odd things. I haven't checked in any changes to fix anything I've noticed. cgf

Re: patch for audio recording with /dev/dsp

On Tue, Dec 09, 2003 at 06:54:02PM -0500, Nicholas Wourms wrote: >Gerd Spalink wrote: > >>Hi, >> >>This patch changes the device /dev/dsp so that audio recording works. >>I have tested it with >>cp /dev/dsp test.wav (stop by hitting ctrl-C) >>and subsequent playback with >>cp test.wav /dev/

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Mon, Dec 08, 2003 at 11:36:01PM -0500, Christopher Faylor wrote: >I would have but the information that the fhandler contains the >controlling tty is lost by the time dup is called. Hmm. I guess I >could just check the io_handle. I'll do that. I did this but, in testing, fo

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Mon, Dec 08, 2003 at 10:46:03PM -0500, Pierre A. Humblet wrote: >At 10:28 PM 12/8/2003 -0500, Christopher Faylor wrote: >>On Mon, Dec 08, 2003 at 10:10:10PM -0500, Pierre A. Humblet wrote: >>>Either myself->set_ctty should be smarter, or fhandler_tty_slave::dup >>&

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Mon, Dec 08, 2003 at 10:10:10PM -0500, Pierre A. Humblet wrote: >Either myself->set_ctty should be smarter, or fhandler_tty_slave::dup >could see if it's about the ctty and simply copy it. I stared at the set_ctty code a long time trying to understand why it went out of its way to do the ctty d

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Sun, Dec 07, 2003 at 10:24:31PM -0500, Pierre A. Humblet wrote: >It's mostly fine (rxvt and notty) but starting the following from DOS >creates a slew of warning from the handler protection code (below). >However the shell is functional. >tty reports /dev/tty, instead of /dev/ttyN with 1.5.5 > >

Re: patch for audio recording with /dev/dsp

On Mon, Dec 08, 2003 at 03:37:19AM +0100, Gerd Spalink wrote: >Hi, > >This patch changes the device /dev/dsp so that audio recording works. >I have tested it with >cp /dev/dsp test.wav (stop by hitting ctrl-C) >and subsequent playback with >cp test.wav /dev/dsp > >I also tested successfully

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Mon, Sep 29, 2003 at 09:55:25PM -0400, Pierre A. Humblet wrote: >Here is a patch that allows to open master ttys without giving >full access to the process, at least for access to the ctty. > >It works by snooping the ctty pipe handles and duplicating them >on the cygheap, for use by future ope

Re: [Patch]: Create Global Privilege

On Mon, Dec 01, 2003 at 10:55:46PM -0500, Pierre A. Humblet wrote: >Below is another small patch to lookup pinfo's in the global name space >when possible. Btw, applied. Thanks. cgf

Re: [Patch]: Create Global Privilege

On Mon, Dec 01, 2003 at 10:55:46PM -0500, Pierre A. Humblet wrote: >Corinna Vinschen wrote: >>On Sun, Nov 30, 2003 at 12:07:22AM +0100, Corinna Vinschen wrote: >>> On Wed, Nov 26, 2003 at 10:45:57AM -0500, Pierre A. Humblet wrote: >>> > At 03:32 PM 11/26/2003 +0100, Corinna Vinschen wrote: >>> > >I

Re: [Patch]: Create Global Privilege

On Mon, Dec 01, 2003 at 12:18:05PM +0100, Corinna Vinschen wrote: >On Sun, Nov 30, 2003 at 12:07:22AM +0100, Corinna Vinschen wrote: >> On Wed, Nov 26, 2003 at 10:45:57AM -0500, Pierre A. Humblet wrote: >> > At 03:32 PM 11/26/2003 +0100, Corinna Vinschen wrote: >> > >Imagine a sshd service is runni

Re: [PATCH]: Add flock syscall emulation

On Sun, Nov 30, 2003 at 12:01:04AM +0100, Corinna Vinschen wrote: >On Thu, Nov 27, 2003 at 02:51:10PM -0500, Nicholas Wourms wrote: >> Hi All, >> >> Here is a patch to add the flock() syscall to Cygwin. I've noticed that some > >Applied with changes. > >I've run indent on flock.c since its format

Re: [PATCH]: Add flock syscall emulation

On Fri, Nov 28, 2003 at 08:12:27AM -0500, Nicholas Wourms wrote: >cgf wrote: >>On Thu, Nov 27, 2003 at 02:51:10PM -0500, Nicholas Wourms wrote: >> >>And, the employee was...? Your reasoning may be correct but it isn't >>possible to know for sure without details. >> >Chris, > >Ooops, sorry about th

Re: [PATCH]: Add flock syscall emulation

On Thu, Nov 27, 2003 at 02:51:10PM -0500, Nicholas Wourms wrote: >I decided to port this particular version of flock emulation from a >patch written by a Red Hat employee for use in Red Hat's IMAPd RPM. I >tried contacting the individual listed in the spec's ChangeLog, but got >no response. IANAL

Re: [Patch]: Create Global Privilege

On Tue, Nov 25, 2003 at 10:12:19PM -0500, Pierre A. Humblet wrote: >At 09:47 PM 11/25/2003 -0500, you wrote: >>On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: >>>Other than that minor point, this looks ok. >> >>Sorry. On rereading this this soun

Re: [Patch]: Create Global Privilege

On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: >Other than that minor point, this looks ok. Sorry. On rereading this this sounded rather lukewarm. I'm very happy that you are fixing this problem. I should probably let Corinna have the final word on this, though.

Re: [Patch]: Create Global Privilege

On Tue, Nov 25, 2003 at 08:55:33PM -0500, Pierre A. Humblet wrote: >This patch will stop the "CreateFileMapping, Win32 error 5. Terminating." >complaints. > >It changes shared_name() to avoid setting the Global\ prefix on file mappings >when the Create Global Object privilege may be required but th

Re: For masochists: the leap o faith

On Fri, Nov 21, 2003 at 07:43:09AM +1100, Robert Collins wrote: >On Sat, 2003-11-15 at 09:07, Christopher Faylor wrote: > >> >> This problem is fixed in the gcc cvs trunk. I've asked Danny and Gerrit >> about backporting the fix to 3.3.2. It should be trivial to do

Re: The increased path length changes

On Sun, Nov 16, 2003 at 09:11:34AM +1100, Robert Collins wrote: >On Sun, 2003-11-16 at 08:46, Christopher Faylor wrote: >> On Sun, Nov 16, 2003 at 07:36:21AM +1100, Robert Collins wrote: >> >...Ron claims said assignment is in place... >> >> I have no record of a

Re: The increased path length changes

On Sun, Nov 16, 2003 at 07:36:21AM +1100, Robert Collins wrote: >...Ron claims said assignment is in place... I have no record of an assignment so if there is an assignment, it predates me. I don't see any changes in the ChangeLog which would indicate the need for an assignment prior to this eith

Re: src/winsup/cygwin ChangeLog bsdlib.cc cygheap. ...

On Sat, Nov 15, 2003 at 11:33:34AM -0500, Christopher Faylor wrote: >The patch below modifies user-visible files in the include tree. >I thought we were just making the CYG_MAX_PATH change and, even if >that was not the case, the ChangeLog does not correctly deal with >this sce

The increased path length changes

Btw, I am wondering a few things about these patches. 1) Does Ron Parker have an assignment on file with Red Hat? I can't find one, if so. This will be a requirement if the patches are accepted. The mechanical change that was just checked in is ok but any more substantial changes will need an a

Re: For masochists: the leap o faith

On Sat, Nov 15, 2003 at 10:53:52AM +1100, Robert Collins wrote: >Christopher Faylor wrote: > >>For the record, I don't have any problems with changing PATH_MAX to >>CYG_PATH_MAX as a first step for this change. Small steps are, as >>always, appreciated. > >O

Re: src/winsup/cygwin ChangeLog bsdlib.cc cygheap. ...

The patch below modifies user-visible files in the include tree. I thought we were just making the CYG_MAX_PATH change and, even if that was not the case, the ChangeLog does not correctly deal with this scenario. cgf On Fri, Nov 14, 2003 at 11:40:06PM -, [EMAIL PROTECTED] wrote: >CVSROOT:

Re: For masochists: the leap o faith

On Sat, Nov 15, 2003 at 09:48:46AM +1100, Robert Collins wrote: >Christopher Faylor wrote: >>It is fairly unusual for PATH_MAX to be many times greater than what is >>support by pathconf. > >And yet: >http://www.opengroup.org/onlinepubs/007908799/xsh/fpathconf.html Yes,

Re: For masochists: the leap o faith

On Sat, Nov 15, 2003 at 07:31:42AM +1100, Robert Collins wrote: >Robert Collins wrote: > >>Ok, so this it for tonight, my bed is calling me. >> >>If playing with this, be sure to: >>rebuild libc as well as cygwin1.dll. >>be setup to debug cygwin1.dll. >> >>I don't *think* I've changed the size of t

Re: dtable.cc (build_fh_pc): serial port handling

On Fri, Nov 14, 2003 at 02:41:06PM -0600, Brian Ford wrote: >However, it certainly looked like an obvious and logical bug fix. It's only logical and obvious if you assume that the com file device handling is the same as other devices. I needed to reaquaint myself with whether that was true or not

Re: thunking, the next step

On Sat, Nov 15, 2003 at 04:52:43AM +1100, Robert Collins wrote: >On Sat, 2003-11-15 at 02:57, Christopher Faylor wrote: >> On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: >> >Ok, I've now integrated and generalised Ron's unicode support mini-patch. >

Re: thunking, the next step

On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: >Ok, I've now integrated and generalised Ron's unicode support mini-patch. > >So, here tis a version that, well the changelog explains the overview, >and io.h the detail. > >Overhead wise, this is reasonably low: >1 strlen() per IO ca

Re: thunk createDirectory and createFile calls

On Fri, Nov 14, 2003 at 08:41:21PM +1100, Robert Collins wrote: >Rename CreateFile to cygwin_create_file throughout. ^^ >Rename CreateDirectory to cygwin_create_directory throughout. ^^^

Re: Small patch for the FAQ

On Thu, Nov 13, 2003 at 10:46:51PM +, David Starks-Browning wrote: >When I started over as FAQ maintainer (sheesh -- *years* ago?) I was >told that Changelog entries were not necessary for documentation, as >long as the cvs commit messages were informative. (Perhaps this was >only intended for

Re: dtable.cc (build_fh_pc): serial port handling

On Wed, Nov 12, 2003 at 01:24:21PM -0600, Brian Ford wrote: >2003-11-12 Brian Ford <[EMAIL PROTECTED]> > > * dtable.cc (build_fh_pc): Use DEV_SERIAL_MAJOR to catch all > serial ports. Remove redundant FH_CYGDRIVE case since it is > handled by DEV_CYGDRIVE_MAJOR. > >FYI, this is

Re: dtable.cc typo

On Tue, Nov 11, 2003 at 06:08:08PM -0600, Brian Ford wrote: >I don't know c++ much/at all, but this looks wrong to me. I don't >understand how it even compiled before? Feel free to slap me in the face >because you can switch on a struct in c++? :) > >2003-11-11 Brian Ford <[EMAIL PROTECTED]> >

Re: [PATCH] stdio initialization

On Tue, Nov 11, 2003 at 03:43:50PM +0100, Thomas Pfaff wrote: >Christopher Faylor wrote: >>Actually, on poking around a little, I wonder if we should be calling >>_reclaim_reent to get back all of the stuff allocated in the REENT >>structure? > >I think you are

Re: [PATCH] stdio initialization

On Mon, Nov 10, 2003 at 10:09:52AM -0500, Christopher Faylor wrote: >On Mon, Nov 10, 2003 at 03:03:06PM +0100, Thomas Pfaff wrote: >>Christopher Faylor wrote: >>>On Mon, Nov 10, 2003 at 12:23:35PM +0100, Thomas Pfaff wrote: >>> >>>>Attached patch fixes the

Re: [PATCH] stdio initialization

On Mon, Nov 10, 2003 at 03:03:06PM +0100, Thomas Pfaff wrote: >Christopher Faylor wrote: >>On Mon, Nov 10, 2003 at 12:23:35PM +0100, Thomas Pfaff wrote: >> >>>Attached patch fixes the memory leak reported by Arash Partow by >>>initializing stdio during startup a

Re: [PATCH] stdio initialization

ff <[EMAIL PROTECTED]> > > * dcrt0.cc: Add prototype for __sinit. > (dll_crt0_1): Initialize stdio. The above two things are already done in dcrt0.cc. Why are you adding additional prototypes and going to additional work? 2003-10-02 Christopher Faylor <[EMAIL PROTECTED]>

Re: [PATCH] : make cygpath use multiple filename arguments

On Thu, Nov 06, 2003 at 11:57:35AM -0500, Mark Blackburn wrote: >This patch will allow you to do this. > >$ ./cygpath.exe -w -a cygpath.cc cygpath.exe >E:\cygwin\usr\src\cygwin-cvs\src\winsup\utils\cygpath.cc >E:\cygwin\usr\src\cygwin-cvs\src\winsup\utils\cygpath.exe > >I don't know if this is desi

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

On Wed, Nov 05, 2003 at 08:02:01PM -0500, Pierre A. Humblet wrote: >Ping? > >This has been pending for a while. See also > I haven't forgotten about it. Unfortunately, in quick scans, the implementation gives me heartburn. That doesn't

<    4   5   6   7   8   9   10   11   12   13   >