Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Patrick Shanahan
* Mario Lüder [04-16-18 18:43]: > Hi Dan, > > Thanks for your advise. I thought that mailing list here would the right > channel to communicate thoughts/ideas and getting suggestion in return. > > I have pushed my changes and did a pull request. > > I hope nobody feels offended by doing it in t

Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Mario Lüder
Hi Dan, Thanks for your advise. I thought that mailing list here would the right channel to communicate thoughts/ideas and getting suggestion in return. I have pushed my changes and did a pull request. I hope nobody feels offended by doing it in this way. I am open for comments and suggestions.

Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Dan Torop
Hi Mario, Thank you! You should also, certainly, chat with the darktable developers (IRC?) before going too far. They've been clear in the past that they don't want someone putting in lots of work on a feature if they don't think it'll make it in, or make it in in the initial form. I'd be curious

Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Mario Lüder
Hi Dan, thanks for your suggestion and your interest. To your suggestion > Perhaps a simpler version is best: sort order associated not with a > particular "collect images" filter but as another column in the "images" > table. This would cause less worry about a lengthy join and indexing on a >

Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Mario Lüder
Hi Jefferson, hi Heiko, Jefferson, thanks for pointing that out. I have fixed that issue. Heiko, I have done a pull request for my change. See: https://github.com/darktable-org/darktable/pull/1677 So, I am (eagerly :-) ) wait for for your response - It would be helpful for me to get your feedbac

Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Dan Torop
Hi Mario, The patch looks sympathetic with the spirit of the darktable code, and you've clearly gotten deep into the code. A query, from reading it through (I haven't run it), is about sort order depending upon the setting of "collect images" as a string: - What if the user filters the images

Re: [darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-16 Thread Heiko Bauke
Hi, Am 15.04.2018 um 22:16 schrieb Mario Lüder: Thanks for your interest. You may find my patch attached. looks interesting and potentially useful. I think the canonical way to contribute code to draktabe is to open a pull request on github, see https://github.com/darktable-org/darktable/ To

[darktable-dev] Re: Custom Image Order by Drag and Drop

2018-04-15 Thread Mario Lüder
Hi Jefferson, Thanks for your interest. You may find my patch attached. If you have any questions, please let me know. Best regards, Mario 2018-04-15 20:46 GMT+02:00 Mario Lüder : > Hi, > > I missed the possibility to order images by drag and drop in lighttable. I > needed this for my image se