Re: [PATCH v2] v4l2_device/v4l2_subdev: final (?) version

2008-11-29 Thread Hans Verkuil
On Sunday 30 November 2008 00:31:38 Andy Walls wrote: On Sat, 2008-11-29 at 18:52 +0100, Hans Verkuil wrote: Hi all, This is hopefully the final version. All earlier comments have been incorporated into this patch. I also made a new change: the mutex has been replaced by a spinlock

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-30 Thread Hans Verkuil
On Saturday 29 November 2008 20:08:44 Guennadi Liakhovetski wrote: On Sat, 29 Nov 2008, Hans Verkuil wrote: +Introduction + + +The V4L2 drivers tend to be very complex due to the complexity of the +hardware: most devices have multiple ICs, export multiple

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-30 Thread Hans Verkuil
Hi Laurent, On Sunday 30 November 2008 22:02:21 Laurent Pinchart wrote: Hi Hans, On Saturday 29 November 2008, Hans Verkuil wrote: Hi Laurent, Let me start by thanking you for reviewing this! Much appreciated. You're welcome. On Saturday 29 November 2008 00:34:44 Laurent Pinchart

Re: [RFC 0/7] ARM: DaVinci: DM646x Video: DM646x display driver

2009-03-13 Thread Hans Verkuil
quickly after a few changes. The main drivers in patches 6 7 will probably require some more thought. Since I've been working with this device for over a year now I can bring in a user-perspective as well :-) Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

Re: [RFC 3/7] ARM: DaVinci: DM646x Video: THS7303 video amplifier driver

2009-03-14 Thread Hans Verkuil
THS7303_SETVALUE _IOW('e', BASE_VIDIOC_PRIVATE + 1,\ + v4l2_std_id *) + +#endif -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux

Re: [RFC 4/7] ARM: DaVinci: DM646x Video: Defintions for standards supported by display

2009-03-14 Thread Hans Verkuil
who needs these HDTV formats. The advantage of being the first is that you can design it yourself, of course! Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci

Re: [RFC 2/7] ARM: DaVinci: DM646x Video: ADV7343 video encoder driver

2009-03-14 Thread Hans Verkuil
HD_ADPT_FLTR_MODEA (0xBF) +#define HD_ADPT_FLTR_EN (0x80) +#define HD_ADPT_FLTR_DI (0x7F) + +#endif /* End of #ifdef __KERNEL__ */ + +#endif /* End of #ifndef ADV7343_H */ -- Hans

Re: DM355 DM6446 VPFE capture driver patch submitted for review

2009-03-14 Thread Hans Verkuil
to this driver before it comes up for review on the linux-media list. I have only so much time, and reviewing both on short notice is a bit too much :-) Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open

Re: [RFC 6/7] ARM: DaVinci: DM646x Video: Add VPIF driver

2009-03-14 Thread Hans Verkuil
/* End of #ifndef VPIF_H */ + -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci

Re: DM355 DM6446 VPFE capture driver patch submitted for review

2009-03-16 Thread Hans Verkuil
, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: DM355 DM6446 VPFE capture driver patch submitted for review

2009-03-16 Thread Hans Verkuil
agrees. As long as the naming is consistent for both dm355/dm6446 and dm646x. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com

Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-03-18 Thread Hans Verkuil
coverage! Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open

Re: [RFC 4/7] ARM: DaVinci: DM646x Video: Defintions for standards supported by display

2009-03-18 Thread Hans Verkuil
priority. I'm not sure if the importance of this came across in my initial review. My apologies if that wasn't clear. Regards, Hans On Saturday 14 March 2009 14:27:09 Hans Verkuil wrote: On Friday 13 March 2009 10:01:37 chaithr...@ti.com wrote: From: Chaithrika U S chaithr...@ti.com

Re: [PATCH] v4l2-subdev: THS7303 video amplifier driver

2009-03-23 Thread Hans Verkuil
small things and I'm happy with it! Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman

Re: [PATCH] v4l2-subdev: ADV7343 video encoder driver

2009-03-23 Thread Hans Verkuil
+137,9 @@ enum { /* module saa7191: just ident 7191 */ V4L2_IDENT_SAA7191 = 7191, + /* module adv7343: just ident 7343 */ + V4L2_IDENT_ADV7343 = 7343, + /* module wm8739: just ident 8739 */ V4L2_IDENT_WM8739 = 8739, Regards, Hans -- Hans Verkuil

Re: [PATCH v2] v4l2-subdev: THS7303 video amplifier driver

2009-03-25 Thread Hans Verkuil
prior to this. The dependency is due to the modification of the 'Kconfig', 'Makefiile', 'v4l2-chip-ident.h' files by both the patches. This updated version of the patch has incorporated the review comments. Signed-off-by: Chaithrika U S chaithr...@ti.com Looks good! Reviewed-by: Hans Verkuil

Re: [PATCH v2] v4l2-subdev: ADV7343 video encoder driver

2009-03-25 Thread Hans Verkuil
, + /* module wm8739: just ident 8739 */ V4L2_IDENT_WM8739 = 8739, One more round and this should be ready to be merged! If it wasn't for the querystd thing I'd have acked it probably. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

Re: [PATCH v3] v4l2-subdev: ADV7343 video encoder driver

2009-03-26 Thread Hans Verkuil
. In this verision of the patch, review comments have been incorporated. The querystd implementation has been removed. A note regarding the hardware not supporting SECAM has been added. Signed-off-by: Chaithrika U S chaithr...@ti.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl Thanks! This looks

Re: [PATCH 2/4] ARM: DaVinci: DM646x Video: VPIF driver

2009-03-30 Thread Hans Verkuil
; + union param{ + struct vpif_vbi_params vbi_params; + struct vpif_capture_params_raw raw_params; + } params; +}; + +#endif /* End of #ifndef VPIF_H */ + It's fine otherwise. Regards, Hans -- Hans Verkuil - video4linux

Re: [PATCH v2 0/4] ARM: DaVinci: DM646x Video: DM646x display driver

2009-04-13 Thread Hans Verkuil
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http

Re: [PATCH v2 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-04-18 Thread Hans Verkuil
. + int output_count; + const char *card_name; +}; + + +void dm646x_setup_vpif(struct vpif_config *config); + #endif /* __ASM_ARCH_DM646X_H */ Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-davinci

2009-04-19 Thread Hans Verkuil
|2 8 files changed, 935 insertions(+), 14 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http

Re: [PATCH v3 0/4] ARM: DaVinci: DM646x Video: DM646x display driver

2009-05-21 Thread Hans Verkuil
On Thursday 21 May 2009 08:12:57 chaithrika wrote: Hi All, Do you have any review comments on this patch set? Reviewed-by: Hans Verkuil hverk...@xs4all.nl I'm happy with these patches! There is one thing that can be improved, though. It is really an enhancement and does not prevent

Re: [PATCH 3/9] dm355 ccdc module for vpfe capture driver

2009-05-28 Thread Hans Verkuil
than best practice rules. I did a quick review of your review :-) and it looks fine to me! Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open

RE: Driver for V4L2 based video-decoder.

2009-06-03 Thread Hans Verkuil
/disclaimer.html ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

Re: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-09 Thread Hans Verkuil
) and polarities (vsync, hsync, field etc) in sub device. This allows bridge driver to configure the sub device for a specific set of bus parameters through s_bus() function call. Reviewed By Hans Verkuil. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to v4l-dvb

Re: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-09 Thread Hans Verkuil
On Tuesday 09 June 2009 23:03:01 Hans Verkuil wrote: On Tuesday 09 June 2009 22:55:53 m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com re-sending with RFC in the header This patch adds support for setting bus parameters such as bus type (BT

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-10 Thread Hans Verkuil
, but it doesn't seem final yet. Thanks Guennadi Reviewed By Hans Verkuil. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to v4l-dvb repository include/media/v4l2-subdev.h | 36 1 files changed, 36 insertions(+), 0 deletions

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-10 Thread Hans Verkuil
On Wednesday 10 June 2009 21:59:13 Guennadi Liakhovetski wrote: On Wed, 10 Jun 2009, Hans Verkuil wrote: On Wednesday 10 June 2009 20:32:25 Guennadi Liakhovetski wrote: On Tue, 9 Jun 2009, m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com

Re: [PATCH 0/10 - v2] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-10 Thread Hans Verkuil
) Tested with driver built statically and dynamically Muralidhara Karicheri Reviewed By Hans Verkuil. Reviewed By Laurent Pinchart. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-10 Thread Hans Verkuil
On Wednesday 10 June 2009 23:30:55 Guennadi Liakhovetski wrote: On Wed, 10 Jun 2009, Hans Verkuil wrote: My view of this would be that the board specification specifies the sensor (and possibly other chips) that are on the board. And to me it makes sense that that also supplies the bus

Re: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Hans Verkuil
Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open

Re: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Hans Verkuil
On 06/11/2009 10:35 AM, Hans Verkuil wrote: Karicheri, Muralidharan a écrit : We need streaming capability in the driver. This is how our driver works with mt9t031 sensor raw-bus (10 bit) vpfe-capture - mt9t031 driver

Re: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Hans Verkuil
On 06/11/2009 11:33 AM, Hans Verkuil wrote: On 06/11/2009 10:35 AM, Hans Verkuil wrote: snip (a lot) Hmm, Why would we want the *application* to set things like this *at all* ? with sensors hsync and vsync and other timing are something between the bridge and the sensor, actaully

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-12 Thread Hans Verkuil
On Wed, 10 Jun 2009, Hans Verkuil wrote: On Wednesday 10 June 2009 23:30:55 Guennadi Liakhovetski wrote: On Wed, 10 Jun 2009, Hans Verkuil wrote: My view of this would be that the board specification specifies the sensor (and possibly other chips) that are on the board. And to me

Re: [PATCH (V2)] TVP514x: Migration to sub-device framework

2009-06-14 Thread Hans Verkuil
video/core functionality like, .g_chip_ident .reset .g_input_status - Migration master driver to validate this driver. - validate on Davinci and OMAP boards. Reviewed By Hans Verkuil. Signed-off-by: Brijesh Jadav brijes...@ti.com Signed-off-by: Hardik Shah

Re: [PATCH (V2)] TVP514x: Migration to sub-device framework

2009-06-14 Thread Hans Verkuil
On Sunday 14 June 2009 12:14:38 Hans Verkuil wrote: On Wednesday 06 May 2009 20:31:33 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com This patch converts TVP514x driver to sub-device framework from V4L2-int framework. NOTE: Please note that this patch has not been

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-14 Thread Hans Verkuil
driver based on last review Reviewed By Hans Verkuil. Reviewed By Laurent Pinchart. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to Davinci GIT Tree arch/arm/mach-davinci/board-dm355-evm.c| 72 +++- arch/arm/mach-davinci/dm355.c

Re: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-14 Thread Hans Verkuil
will include vpss.h header file and call functions defined in this module to configure vpss system module. Reviewed By Hans Verkuil. Reviewed By Laurent Pinchart. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- drivers/media/video/davinci/vpss.c | 290

tcm825x.c: migrating to sub-device framework? (was: TVP514x: Migration to sub-device framework)

2009-06-14 Thread Hans Verkuil
On Sunday 14 June 2009 14:44:53 Hans Verkuil wrote: On Sunday 14 June 2009 12:14:38 Hans Verkuil wrote: On Wednesday 06 May 2009 20:31:33 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com This patch converts TVP514x driver to sub-device framework from V4L2-int framework

Re: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Hans Verkuil
email: m-kariche...@ti.com -Original Message- From: davinci-linux-open-source-bounces+m- karicheri2=ti@linux.davincidsp.com [mailto:davinci-linux-open-source- bounces+m-karicheri2=ti@linux.davincidsp.com] On Behalf Of Hans Verkuil Sent: Sunday, June 14, 2009 10:37 AM To: linux

Re: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Hans Verkuil
will allow it to be merged. It's a pretty tight schedule, I'm afraid. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source

Re: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-15 Thread Hans Verkuil
framework is very high on my TODO list since it is getting really annoying to implement in drivers. And the inconsistent driver support isn't helping applications either. I really hope I'll have time for it in the next few weeks. Regards, Hans -- Hans Verkuil - video4linux developer

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-15 Thread Hans Verkuil
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http

Re: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-17 Thread Hans Verkuil
-- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [RFC PATCH] adding support for setting bus parameters in sub device

2009-06-17 Thread Hans Verkuil
by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Murali Karicheri m-kariche...@ti.com --- Applies to v4l-dvb repository include/media/v4l2-subdev.h | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/include/media/v4l2-subdev.h b

[PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-vpfe-cap

2009-06-19 Thread Hans Verkuil
|4 v4l/versions.txt |7 21 files changed, 6346 insertions(+), 555 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-19 Thread Hans Verkuil
On Wednesday 17 June 2009 23:29:31 Alexey Klimov wrote: Hello, very small comments, see below please Thanks, I've added the missing newlines and the wrong return code in a separate patch in my pull request. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored

Re: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-19 Thread Hans Verkuil
dm355_ccdc_exit(void) +{ +       vpfe_unregister_ccdc_device(ccdc_hw_dev); +} -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http

Re: [PATCH 0/11 - v3] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-20 Thread Hans Verkuil
driver available on davinci git tree 2) Tested with driver built statically and dynamically Muralidhara Karicheri Reviewed by: Hans Verkuil hverk...@xs4all.nl Reviewed by: Laurent Pinchart laurent.pinch...@skynet.be Reviewed by: Alexey Klimov klimov.li...@gmail.com Reviewed

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-vpfe-cap

2009-06-21 Thread Hans Verkuil
On Sunday 21 June 2009 19:33:11 Mauro Carvalho Chehab wrote: Em Fri, 19 Jun 2009 14:39:14 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-vpfe-cap for the following: - tvp514x: Migration to sub-device framework

RE: [PATCH] adding support for setting bus parameters in sub device

2009-06-25 Thread Hans Verkuil
. Reviewed by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Murali Karicheri m-kariche...@ti.com --- Applies to v4l-dvb repository include/media/v4l2-subdev.h | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/include/media/v4l2

Re: [PATCH] mt9t031 - migration to sub device frame work

2009-06-26 Thread Hans Verkuil
the sensor. Reviewed by: Hans Verkuil hverk...@xs4all.nl Reviewed by: Guennadi Liakhovetski g.liakhovet...@gmx.de Excuse me? This is the first time I see this patch. FYI, Reviewed-by means that the respective person has actually reviewed the patch and submitted that line _him_ or _her_self

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-06-26 Thread Hans Verkuil
-davinci/include/mach/dm646x.h | 25 ++ 3 files changed, 210 insertions(+), 0 deletions(-) -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

2009-06-26 Thread Hans Verkuil
On Friday 26 June 2009 20:25:42 Kevin Hilman wrote: Hans Verkuil hverk...@xs4all.nl writes: On Monday 22 June 2009 10:14:30 chaithrika wrote: Kevin, I think this patch has to be taken into DaVinci tree so that it can be submitted upstream. This patch has to be present in the Linux

Re: [PATCH 1/3 - v0] V4L: vpfe capture driver - adding support for camera capture

2009-06-27 Thread Hans Verkuil
function Mandatory Reviewers: Hans Verkuil hverk...@xs4all.nl NOTE: Requires support for v4l2_i2c_new_subdev_board() which was recently added to v4l2 framework by Hans Verkuil. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to v4l-dvb repository drivers/media/video

Re: [PATCH 2/3 - v0] V4L: ccdc driver - adding support for camera capture

2009-06-27 Thread Hans Verkuil
with tvp514x driver. 3) Returns proper error code from ccdc_init (comments against previous patch version v3) Mandatory Reviewers: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to v4l-dvb repository drivers/media/video

Re: [PATCH 3/3 - v0] davinci: platform changes to support vpfe camera capture

2009-06-27 Thread Hans Verkuil
capture driver patch Mandatory Reviewers: Kevin Hilman khil...@deeprootsystems.com Mandatory Reviewers: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to DaVinci GIT Tree arch/arm/mach-davinci/board-dm355-evm.c | 208

Re: [RFC PATCH] adding support for setting bus parameters in sub device

2009-06-29 Thread Hans Verkuil
) in sub device. This allows bridge driver to configure the sub device bus for a specific set of bus parameters through s_bus() function call. This also can be used to define platform specific bus parameters for host and sub-devices. Reviewed by: Hans Verkuil hverk...@xs4all.nl Signed-off

RE: [RFC PATCH] adding support for setting bus parameters in sub device

2009-06-29 Thread Hans Verkuil
Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Monday, June 29, 2009 5:26 AM To: Karicheri, Muralidharan Cc: linux-me...@vger.kernel.org; davinci-linux-open- sou

Re: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-07-02 Thread Hans Verkuil
Reviewed by: Hans Verkuil hverk...@xs4all.nl Reviewed by: Laurent Pinchart laurent.pinch...@skynet.be Reviewed by: Alexey Klimov klimov.li...@gmail.com Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to v4l-dvb repository drivers/media/video/davinci/vpfe_capture.c | 2136

Linux Plumbers Conference 2009: V4L2 API discussions

2009-08-04 Thread Hans Verkuil
all the new SoCs. So the more input we get, the better the end-result will be. Early-bird registration is still possible up to August 5th (that's tomorrow :-) ). Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

Re: Linux Plumbers Conference 2009: V4L2 API discussions

2009-08-04 Thread Hans Verkuil
On Tuesday 04 August 2009 09:12:24 Hans Verkuil wrote: Hi all, During this years Plumbers Conference I will be organizing a session (or possibly more than one) on what sort of new V4L2 APIs are needed to support the new SoC devices. These new APIs should also solve the problem of how

Re: [PATCH v0 4/5] V4L: vpif_capture driver for DM6467

2009-08-12 Thread Hans Verkuil
-kariche...@ti.com First of all I've reviewed the other patches in this series and they look OK to me. So you can add Reviewed-by: Hans Verkuil hverk...@xs4all.nl for patches 1, 2, 3 and 5. Will do. + ret = vpif_check_format(ch, common-fmt.fmt.pix, 0); + if (ret) + return ret

Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver

2009-08-15 Thread Hans Verkuil
tree are these arch changes applied? I've lost track of that :-) Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com

Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver

2009-08-17 Thread Hans Verkuil
in this way. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux

Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver

2009-08-17 Thread Hans Verkuil
compiles against that one, so that is the most appropriate tree to do the patches against. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source

Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver

2009-08-18 Thread Hans Verkuil
Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Monday, August 17, 2009 4:27 PM To: Karicheri, Muralidharan Cc

Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver

2009-08-18 Thread Hans Verkuil
On Tuesday 18 August 2009 08:49:13 Hans Verkuil wrote: On Tuesday 18 August 2009 01:23:10 Karicheri, Muralidharan wrote: Hans, I have re-send vpfe capture patch. I will re-send vpif patches tomorrow. These patches apply fine. I'll merge them in my v4l-dvb-dm646x tree tonight. Oops

Re: [PATCH 1/6] Support for TVP7002 in v4l2 definitions

2009-08-28 Thread Hans Verkuil
*/ V4L2_IDENT_ADV7170 = 7170, -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo

Re: [PATCH 1/6] Updated Support for TVP7002 in v4l2 definitions

2009-08-29 Thread Hans Verkuil
{ V4L2_IDENT_SAA6752HS = 6752, V4L2_IDENT_SAA6752HS_AC3 = 6753, + /* module tvp7002: just ident 7002 */ + V4L2_IDENT_TVP7002 = 7002, + /* module adv7170: just ident 7170 */ V4L2_IDENT_ADV7170 = 7170, -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

RE: [PATCH 1/6] Support for TVP7002 in v4l2 definitions

2009-08-31 Thread Hans Verkuil
) email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Friday, August 28, 2009 2:42 AM To: davinci-linux-open-source@linux.davincidsp.com Cc: santiago.nu...@ridgerun.com; Karicheri, Muralidharan; clark.bec...@ridgerun.com; todd.fisc...@ridgerun.com

Re: [PATCH 1/6] Support for TVP7002 in v4l2 definitions

2009-08-31 Thread Hans Verkuil
and 5/6 (note that I didn't see a 6/6 patch, that was apparently never posted). Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source

Re: [PATCH 5/6 v3] Updated TVP7002 driver for DM365

2009-09-02 Thread Hans Verkuil
On Wednesday 02 September 2009 00:54:58 santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Implemented revisions by Vaibhav Hiremath and Hans Verkuil. Removed most

Re: [PATCH 5/6 v4] Updated TVP7002 driver for DM365

2009-09-06 Thread Hans Verkuil
On Friday 04 September 2009 00:52:44 santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Implemented revisions by Vaibhav Hiremath and Hans Verkuil. Removed most

Re: RFC: V4L - Support for video timings at the input/output interface

2009-09-15 Thread Hans Verkuil
Hi Murali, Thanks for your work on this! See below for a few notes I made. On Monday 14 September 2009 15:51:28 Karicheri, Muralidharan wrote: RFC: V4L - Support for video timings at the input/output interface Thanks to Hans Verkuil for his initial proposal and feedbacks to help write

Re: [PATCH 1/6 v5] Support for TVP7002 in v4l2 definitions

2009-10-15 Thread Hans Verkuil
. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open

Re: [PATCH 5/6 v5] TVP7002 driver for DM365

2009-10-15 Thread Hans Verkuil
On Thursday 15 October 2009 16:43:54 santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Signed-off-by: Santiago Nunez-Corrales santiago.nu...@ridgerun.com ---

Re: [PATCH] V4L: adding digital video timings APIs

2009-10-21 Thread Hans Verkuil
your comments. Mandatory reviewer - Hans Verkuil hverk...@xs4all.nl Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com --- Applies to V4L-DVB linux-next branch drivers/media/video/v4l2-compat-ioctl32.c |7 ++ drivers/media/video/v4l2-ioctl.c | 122

Re: [PATCH 0/4 v6] Support for TVP7002 in DM365

2009-11-05 Thread Hans Verkuil
... Regards, Hans Santiago. Hans Verkuil wrote: On Wednesday 04 November 2009 18:23:40 Santiago Nunez-Corrales wrote: This series of patches provide support for the TVP7002 decoder in DM365. Support includes: * Inclusion of the chip in v4l2 definitions * Definition

Re: [PATCH 2/4 v6] Definitions for TVP7002 in DM365

2009-11-09 Thread Hans Verkuil
clk_polarity; + u8 hs_polarity; + u8 vs_polarity; + u8 fid_polarity; + u8 sog_polarity; +}; This should have a comment telling how each value is interpreted. I assume it's something like 0 = negative polarity, 1 = positive, but I'm not sure. +#endif Regards, Hans -- Hans

Re: [PATCH 3/4 v6] TVP7002 driver for DM365

2009-11-09 Thread Hans Verkuil
Hi Santiago, See review comments below: On Friday 06 November 2009 16:42:56 santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Implemented using the V4L2 DV presets API.

Re: [PATCH 3/4 v6] TVP7002 driver for DM365

2009-11-10 Thread Hans Verkuil
to the relevant sections/register descriptions of the datasheet. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http

Re: [PATCH] V4L: adding digital video timings APIs

2009-11-10 Thread Hans Verkuil
On Thursday 05 November 2009 13:56:29 Hans Verkuil wrote: On Friday 23 October 2009 22:44:34 Karicheri, Muralidharan wrote: Hans, following IOCTLS :- - verify the new v4l2_input capabilities flag added - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS - Set one

Re: [PATCH] V4L: adding digital video timings APIs

2009-11-11 Thread Hans Verkuil
need to do a bit more work. Regards, Hans Murali Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

Re: [PATCH 3/4 v7] TVP7002 driver for DM365

2009-11-15 Thread Hans Verkuil
On Tuesday 10 November 2009 22:50:36 santiago.nu...@ridgerun.com wrote: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides the implementation of the TVP7002 decoder driver for DM365. Implemented using the V4L2 DV presets API. Signed-off-by: Santiago

Re: [PATCH 3/4 v7] TVP7002 driver for DM365

2009-11-16 Thread Hans Verkuil
in the driver state struct. You need to have functions to set the preset/gain/whatever anyway, so just call them again. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing

Re: [PATCH] V4L: adding digital video timings APIs

2009-11-16 Thread Hans Verkuil
Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source

Re: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Hans Verkuil
ioctl (will send another patch after compilation issue is resolved) Please review this and let me know your comments. I found a few small things, see comments below. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl --- Applies to V4L

Re: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Hans Verkuil
]; +}; +}; Ditto. I also attached a small diff for the v4l2-apps/test/ioctl-test.c source which I used to test this. The patch is Signed-off-by: Hans Verkuil hverk...@xs4all.nl You can include this when you post the v4l2-apps patches. Regards, Hans -- Hans Verkuil - video4linux developer

Re: [PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Hans Verkuil
VIDIOC_QUERY_DV_PRESET - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device. - Tested on 64bit platform by Hans Verkuil TODOs : - Update v4l2-apps for the new ioctl (will send another patch after compilation issue

2.6.32-rc8 davinci-emac.c compile error

2009-11-20 Thread Hans Verkuil
a compile error in vpif_display.c. I've posted a fix already to the linux-media mailinglist, but that hasn't yet been pulled in. I'll ping the maintainer about that to try and get that fix into 2.6.32 as well. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

Re: [PATCH] Adding helper function to get dv preset description

2009-11-20 Thread Hans Verkuil
, unsigned int wmin, unsigned int hmax, unsigned int halign, unsigned int salign); +int v4l_fill_dv_preset_info(u32 preset, struct v4l2_dv_enum_preset *info); #endif /* V4L2_COMMON_H_ */ -- Hans Verkuil - video4linux developer - sponsored by TANDBERG

Re: [PATCH 0/4 v11] Support for TVP7002 in DM365

2009-12-07 Thread Hans Verkuil
. Support includes: * Inclusion of the chip in v4l2 definitions * Definition of TVP7002 specific data structures * Kconfig and Makefile support This series corrects many issued pointed out by Snehaprabha Narnakaje, Muralidharan Karicheri, Vaibhav Hiremath and Hans Verkuil and solves

Re: [PATCH - v1 2/6] V4L - vpfe capture - Adding DM365 ISIF driver - header files

2009-12-14 Thread Hans Verkuil
Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [PATCH - v1 3/6] V4L-vpfe-capture-Adding ISIF driver for DM365 - source

2009-12-14 Thread Hans Verkuil
On Thursday 10 December 2009 18:00:26 m-kariche...@ti.com wrote: From: Muralidharan Karicheri m-kariche...@ti.com This is the source file for ISIF driver for DM365. This has comments incorporated from initial version. ISIF driver is equivalent to CCDC driver on DM355 and DM644x. This

Re: [PATCH 3/4 v11] TVP7002 driver for DM365

2009-12-15 Thread Hans Verkuil
on failure. + */ +static void __exit tvp7002_exit(void) +{ + i2c_del_driver(tvp7002_driver); +} + +module_init(tvp7002_init); +module_exit(tvp7002_exit); -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open

Re: [PATCH 2/4 v11] Definitions for TVP7002 in DM365

2009-12-15 Thread Hans Verkuil
hs_polarity; + u8 vs_polarity; + u8 fid_polarity; + u8 sog_polarity; +}; +#endif -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http

Re: [PATCH 0/4 v11] Support for TVP7002 in DM365

2009-12-15 Thread Hans Verkuil
On Tuesday 15 December 2009 20:24:19 Santiago Nunez-Corrales wrote: Hi Hans, I know you'be been busy and in the road lately. Just checking if you had the chance to review this version of the code. Done! Regards, Hans Regards, Hans Verkuil wrote: On Tuesday 08 December

Re: [PATCH - v1 4/6] V4L - vpfe_capture bug fix and enhancements

2009-12-15 Thread Hans Verkuil
*) + #endif /* _DAVINCI_VPFE_H */ -- Hans Verkuil - video4linux developer - sponsored by TANDBERG ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman

  1   2   3   >