[PATCH 15/18] [CCID2]: Remove redundant ack-counting variable

2007-11-24 Thread Arnaldo Carvalho de Melo
-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c | 46 +++--- net/dccp/ccids/ccid2.h |6 ++ 2 files changed, 17 insertions(+), 35 deletions(-) diff --git a/net/dccp/ccids/ccid2.c b

[PATCH 05/18] [CCID2]: Deadlock and spurious timeouts when Ack Ratio cwnd

2007-11-24 Thread Arnaldo Carvalho de Melo
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c | 39 +-- 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c index f18235e..ef19fb8 100644 --- a/net/dccp/ccids/ccid2.c

Re: TX history patches was: Re: Test tree patch inventory - update

2007-11-23 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 23, 2007 at 10:49:29AM +, Gerrit Renker escreveu: | -- | The patch set migrates TFRC TX history to a singly-linked list. | | The details are: | * use of a consistent naming scheme (all TFRC functions

Re: Test tree patch inventory - update

2007-11-21 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 21, 2007 at 11:52:55AM +, Gerrit Renker escreveu: | Test Tree Inventory |=== | |[CCID3]: Ignore trivial amounts of elapsed time | | Applied, but I think we can revisit elapsed time later by taking a |

Re: Test tree patch inventory - update: 3rd batch

2007-11-21 Thread Arnaldo Carvalho de Melo
Em Sat, Nov 17, 2007 at 03:42:52PM +, Gerrit Renker escreveu: 7. Miscellaneous DCCP updates - The last batch before the begin of the feature-negotiation patch set contains individual, standalone patches (and thus ideal for cherry-picking): [DCCP]:

Re: Test tree patch inventory - update: 3rd batch

2007-11-21 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 21, 2007 at 02:07:43PM +, Gerrit Renker escreveu: | 7. Miscellaneous DCCP updates | - snip |[DCCP]: Promote CCID2 as default CCID | | Applied to simplify things for now, but I still think that for some | setups it may be interesting to

[PATCH 04/11] [CCID3]: Inline for moving average

2007-11-21 Thread Arnaldo Carvalho de Melo
[EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c| 25 + net/dccp/ccids/lib/tfrc.h |9 + 2 files changed, 14 insertions(+), 20 deletions(-) diff --git a/net/dccp

[PATCH 01/11] [CCID3]: Revert use of MSS instead of s

2007-11-21 Thread Arnaldo Carvalho de Melo
Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 21 - 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index dfe1aa7..567146f 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -83,18

[PATCH 03/11] [CCID3]: Accurately determine idle application-limited periods

2007-11-21 Thread Arnaldo Carvalho de Melo
, the `idle' flag is removed. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 18 ++ net/dccp/ccids/ccid3.h |2 -- 2 files changed, 10

[PATCH 05/11] [DCCP]: Make PARTOPEN an autonomous state

2007-11-21 Thread Arnaldo Carvalho de Melo
is always referred to directly (i.e. not via the mapping to TCP state). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/dccp.h | 14 +++--- 1 files changed, 3 insertions

[PATCH 06/11] [DCCP]: Honour and make use of shutdown option set by user

2007-11-21 Thread Arnaldo Carvalho de Melo
Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt |2 ++ net/dccp/input.c | 27 --- net/dccp/proto.c |2 +- 3 files

[PATCH 11/11] [DCCP]: Update documentation on ioctls

2007-11-21 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff

[PATCH 07/11] [DCCP]: Update documentation

2007-11-21 Thread Arnaldo Carvalho de Melo
Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/Documentation/networking/dccp.txt b/Documentation/networking/dccp.txt index f771034..fdc93be 100644 --- a/Documentation/networking

[PATCH 08/11] [DCCP]: Promote CCID2 as default CCID

2007-11-21 Thread Arnaldo Carvalho de Melo
CCID2 when DCCP is enabled. Documentation also added. Discussions with Ian McDonald on this subject are gratefully acknowledged. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation

[PATCH 09/11] [DCCP]: Remove redundant dependency on IP_DCCP

2007-11-21 Thread Arnaldo Carvalho de Melo
-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/Kconfig |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/net/dccp/ccids/Kconfig b/net/dccp/ccids/Kconfig index

[PATCH 10/11] [DCCP]: Ignore Ack Vectors / Elapsed Time on DCCP-Request also

2007-11-21 Thread Arnaldo Carvalho de Melo
[EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/options.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/net/dccp/options.c b/net/dccp/options.c index d286cff..523250b 100644 --- a/net/dccp/options.c +++ b/net/dccp

Re: Test tree patch inventory - update: batch #4

2007-11-21 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 21, 2007 at 04:51:22PM -0200, Arnaldo Carvalho de Melo escreveu: Em Sat, Nov 17, 2007 at 03:42:52PM +, Gerrit Renker escreveu: 11. First batch of CCID2/Ack Vector bug fixes - Most patches in this set are standalone, so again

Re: Test tree patch inventory - update: batch #4

2007-11-21 Thread Arnaldo Carvalho de Melo
Em Sat, Nov 17, 2007 at 03:42:52PM +, Gerrit Renker escreveu: 11. First batch of CCID2/Ack Vector bug fixes - Most patches in this set are standalone, so again an easy target for cherry-picking. The batch is the preparation for the Ack Vector

Re: Test tree patch inventory - update

2007-11-20 Thread Arnaldo Carvalho de Melo
Em Sat, Nov 17, 2007 at 03:42:52PM +, Gerrit Renker escreveu: Test Tree Inventory === This is the list of current small batches (from oldest to latest) as of Sat 17 Nov. The entire test tree is fully bisectable, so batches

Re: Test tree patch inventory - update

2007-11-20 Thread Arnaldo Carvalho de Melo
Em Sat, Nov 17, 2007 at 03:42:52PM +, Gerrit Renker escreveu: Test Tree Inventory === 4. Support for passive-close without flushing unread data - This set actually

Re: How much is available for reading on the socket?

2007-11-09 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 09, 2007 at 01:51:27PM +, Gerrit Renker escreveu: | using ioctl (socket, FIONREAD, readsize) I can get how much is | available to read from the socket using TCP. Is there a equivalent | option for DCCP? | | Looks like dccp_ioctl() happily returns -ENOIOCTLCMD (for now). If

Re: [PATCH 14/25] Basic implementation for ccid-4 dropped packet option

2007-11-01 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2007 at 09:31:40PM -0300, Leandro escreveu: [CCID-4] Basic implementation for ccid-4 dropped packet option as per ccid-4 draft Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Index: leandro.new/net/dccp/ccids/lib/tfrc_ccids.h

Re: [PATCH 3/25] Adjustments of the ccid-4 copyright and kernel module authors

2007-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2007 at 02:22:49PM +0200, Tommi Saviranta escreveu: On Wed, Oct 31, 2007 at 20:21:53 -0300, Leandro wrote: [CCID-4] Adjustments of the ccid-4 copyright and kernel module authors Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Signed-off-by: Tommi Saviranta [EMAIL

Re: [PATCH 13/25] Share TFRC feedback types struct via ccid34_lib

2007-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2007 at 09:59:14AM +, Gerrit Renker escreveu: I have a suggestion regarding types, names, and things shared between CCID3 and CCID4 via dccp_tfrc_lib: I think it would be best to name all such shared structures / names, when they are to appear in the dccp_tfrc_lib, as

Re: systemtap networking tapsets was: Re: [RFC]: field name identifier conventions

2007-10-25 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 25, 2007 at 03:03:55PM +0100, Gerrit Renker escreveu: | The full sources for the tapsets used (for things like ccid3_hc_tx_sk_rtt(), etc) are at: | | http://oops.ghostprotocols.net:81/acme/nettaps.tar.bz2 | This is awesome. Is all that is needed to run these a new

[PATCH 3/5] [DCCP]: Convert Reset code into socket error number

2007-10-24 Thread Arnaldo Carvalho de Melo
PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/dccp.h |2 ++ net/dccp/input.c | 48 +++- 2 files changed, 41 insertions(+), 9 deletions(-) diff --git a/include/linux

[PATCH 4/5] [DCCP]: Unaligned pointer access

2007-10-24 Thread Arnaldo Carvalho de Melo
/0x880 [dccp] by using the get_unaligned macro for parsing options. Commiter note: Preserved the sparse __be{16,32} annotations. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids

Re: [PATCH 1/1][RFC]: field name identifier conventions

2007-10-24 Thread Arnaldo Carvalho de Melo
I have no problems with this one. Shortens the namespace while keeping it. - Arnaldo Em Wed, Oct 24, 2007 at 01:31:05PM +0100, Gerrit Renker escreveu: Arnaldo can you please indicate if you are ok with this - there are other Ack Vector patches in the pipeline, and I would change them

Re: systemtap networking tapsets was: Re: [RFC]: field name identifier conventions

2007-10-24 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 24, 2007 at 02:35:42PM +0100, Gerrit Renker escreveu: Quoting Arnaldo Carvalho de Melo: | I think that dccpprobe.c is the wrong name ... it should really be called ccid3_probe.c ... | I have been working on printing entries for CCID2, since in ccid2.c there is no probe

Re: [Announce][PATCH v2 1/1]: Patch dropped / [DCCP]: Initialisation and type-checking of feature sysctls

2007-10-24 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 24, 2007 at 04:26:44PM +0100, Gerrit Renker escreveu: After discussion with Arnaldo, I have decided to remove the following patch from the test tree -- [DCCP]: Collect all scattered sysctl

[PATCH][DCCP 1/1] Implement SIOCINQ/FIONREAD

2007-10-23 Thread Arnaldo Carvalho de Melo
Just like UDP. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] diff --git a/net/dccp/proto.c b/net/dccp/proto.c index cc9bf1c..723c29e 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c @@ -26,6 +26,7 @@ #include net/sock.h

systemtap networking tapsets was: Re: [RFC]: field name identifier conventions

2007-10-22 Thread Arnaldo Carvalho de Melo
CCing dccp@vger.kernel.org, since I wrote a nice description about this new toy :) Em Mon, Oct 22, 2007 at 03:24:41PM +0100, Gerrit Renker escreveu: | perhaps one that could understand types and then could allow developers | to ask questions like show me all the places where the field foo of

Re: [RFC]: field name identifier conventions

2007-10-20 Thread Arnaldo Carvalho de Melo
Em Sat, Oct 20, 2007 at 07:03:49PM -0200, Arnaldo Carvalho de Melo escreveu: Em Sat, Oct 20, 2007 at 04:54:35PM +0100, Gerrit Renker escreveu: I have a question/suggestion for DCCP/CCID field names, which have a tendency to grow into really_quite_long_strings. The convention for field

Re: [RFC]: field name identifier conventions

2007-10-20 Thread Arnaldo Carvalho de Melo
Em Sat, Oct 20, 2007 at 04:54:35PM +0100, Gerrit Renker escreveu: I have a question/suggestion for DCCP/CCID field names, which have a tendency to grow into really_quite_long_strings. The convention for field members seems to be x-x_fieldname Examples are in particular *

Re: [PATCH 7/8]: Handle timestamps on Request/Response exchange separately

2007-10-05 Thread Arnaldo Carvalho de Melo
solution is planned. I'd need to know so that I can rework the patches and resubmit them accordingly. Quoting Gerrit Renker: | Quoting Arnaldo Carvalho de Melo: | | I suggest it to become: | | | | [EMAIL PROTECTED] net-2.6.24]$ pahole -C dccp_request_sock net/dccp/minisocks.o

Re: [PATCH v2 4/9]: Resolve dependencies of features on choice of CCID

2007-10-02 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2007 at 01:06:55PM +0100, Gerrit Renker escreveu: Reworked patch thanks to suggestions by Ian. Changes: * removed on/off constants * used reserved feature number instead of reserved pointer value (NULL) to mark the end of table; marked this in the commit message * all

Re: [PATCH 1/11]: Auxiliary function for smallest-fit option lengths

2007-10-01 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 01, 2007 at 03:18:11PM +0100, Gerrit Renker escreveu: [DCCP]: Auxiliary function for smallest-fit option lengths This introduces a function to determine the smallest-fit data type to carry options, which is used by the feature-negotiation code to insert option values. While

Re: [PATCH 3/3]: Convert Reset code into socket error number

2007-10-01 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 02, 2007 at 09:07:24AM +1300, Ian McDonald escreveu: On 10/2/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: He used a designated initializer, i.e. he said at which index in the array it the value is to be set. So it really doesn't matter the order. And when checking

Re: [PATCH 3/10]: Dedicated auxiliary states to support passive-close

2007-09-30 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 12, 2007 at 03:23:39PM +0100, Gerrit Renker escreveu: [DCCP]: Dedicated auxiliary states to support passive-close This adds two auxiliary states to deal with passive closes: * PASSIVE_1 (reached from OPEN via reception of Close) and * PASSIVE_2 (reached from OPEN via

[PATCH 01/13] [DCCP]: Wait for CCID

2007-09-29 Thread Arnaldo Carvalho de Melo
also added. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/output.c | 34 +++--- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/net

[PATCH 02/13] [DCCP]: Add socket option to query the current MPS

2007-09-29 Thread Arnaldo Carvalho de Melo
Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt |3 +++ include/linux/dccp.h |1 + net/dccp/proto.c |4 3 files changed, 8 insertions

[PATCH 03/13] [DCCP]: Make all `debug' parameters bool

2007-09-29 Thread Arnaldo Carvalho de Melo
This just sets the parameter to bool, since debugging messages are either on or off. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c |2 +- net/dccp/ccids/ccid3.c

[PATCH 04/13] [DCCP]: Update API documentation

2007-09-29 Thread Arnaldo Carvalho de Melo
This adds documentation on the use of service codes on client and server. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt |8 +--- 1 files changed

[PATCH 06/13] [CCID2]: Remove ugly BUG_ON

2007-09-29 Thread Arnaldo Carvalho de Melo
), but that requires more complicated changes to the algorithm; thus a `FIXME' has been added. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions

[PATCH 08/13] [CCID2]: Remove redundant case block

2007-09-29 Thread Arnaldo Carvalho de Melo
skb's passed to ccid2_hc_tx_send_packet() are headerless, the packet type is decided later, in dccp_write_xmit(). Therefore the first test of the switch/case block is always true, the others are never reached. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo

[PATCH 09/13] [CCID2]: Sequence number wraparound issues

2007-09-29 Thread Arnaldo Carvalho de Melo
the incremented ccid2hctx_rpseq == seqno, used assignment instead. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/net/dccp/ccids

[PATCH 10/13] [DCCP]: Tidy-up -- minisock initialisation

2007-09-29 Thread Arnaldo Carvalho de Melo
PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/dccp.h |1 - net/dccp/minisocks.c | 10 ++ net/dccp/options.c | 10 -- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/include/linux/dccp.h b/include/linux/dccp.h index

[PATCH 13/13] [DCCP]: Twice the wrong reset code in receiving connection-Requests

2007-09-29 Thread Arnaldo Carvalho de Melo
the behaviour here also (not done by this patch). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ipv4.c | 11 --- net/dccp/ipv6.c |7 +++ 2 files changed, 7

Re: [PATCH 2/9]: Query supported CCIDs

2007-09-29 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 29, 2007 at 05:24:18PM +0100, Gerrit Renker escreveu: Quoting Arnaldo Carvalho de Melo: | +static u8 builtin_ccids[] = { | + DCCPC_CCID2,/* CCID2 is supported by default */ | +#if defined(CONFIG_IP_DCCP_CCID3) || defined(CONFIG_IP_DCCP_CCID3_MODULE

Re: [PATCH 8/8]: Support inserting options during the 3-way handshake

2007-09-26 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 26, 2007 at 10:04:22AM +0100, Gerrit Renker escreveu: Quoting Arnaldo Carvalho de Melo: | --- a/net/dccp/options.c | +++ b/net/dccp/options.c | @@ -160,7 +160,7 @@ int dccp_parse_options(struct sock *sk, |   if (len != 4

Re: Header size of the data packet

2007-09-26 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 26, 2007 at 10:19:48AM -0300, ツ Leandro Sales escreveu: Hi, according to ccid-4 internet draft, the estimated header size on data packets is 36 bytes (20 bytes for the IP header and 16 bytes for the DCCP-data header with 48-bit sequence numbers). The header size would be 32

Re: tcpdump broken wrt CsCov CsVal parsing?

2007-09-26 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 09:08:29AM +0100, Gerrit Renker escreveu: | On 9/23/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: | Trying to rebuild a proper test setup, so far using just loopback for | simple tests I noticed this problem: | | Who was the last person to touch

[PATCHES 0/8][DCCP] More core work

2007-09-26 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24 Best Regards, - Arnaldo - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 1/8] [DCCP]: Send Reset upon Sync in state REQUEST

2007-09-26 Thread Arnaldo Carvalho de Melo
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/input.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/net/dccp/input.c b/net/dccp/input.c index cde0e70..86ad3ba 100644 --- a/net/dccp/input.c +++ b/net/dccp/input.c @@ -540,11 +540,6 @@ int dccp_rcv_state_process

[PATCH 3/8] [DCCP]: Add FIXME for send_delayed_ack

2007-09-26 Thread Arnaldo Carvalho de Melo
think leaving the function in is good, in case someone wants to implement this. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/dccp.h |1 - net/dccp/output.c |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 4/8] [DCCP]: Add Support for Data 1 .. 3 fields of Reset packets

2007-09-26 Thread Arnaldo Carvalho de Melo
errors. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/dccp.h | 14 ++ net/dccp/dccp.h | 14 +- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/include/linux/dccp.h b

[PATCH 5/8] [DCCP]: Remove duplicate code for Reset from connected socket

2007-09-26 Thread Arnaldo Carvalho de Melo
. The only thing that has been removed is the call to dst_clone(dst), since the queue_xmit functions use sk_dst_cache anyway. I wasn't sure which purpose inet_sk_rebuild_header served, so I left it in. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL

[PATCH 6/8] [DCCP]: Rate-limit DCCP-Syncs

2007-09-26 Thread Arnaldo Carvalho de Melo
sending a sync. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt |5 + include/linux/dccp.h |2 ++ net/dccp/dccp.h

[PATCH 7/8] [DCCP]: Sequence number wrap-around when sending reset

2007-09-26 Thread Arnaldo Carvalho de Melo
This replaces normal addition with mod-48 addition so that sequence number wraparound is respected. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ipv4.c |2 +- net/dccp/ipv6

[PATCH 8/8] [DCCP]: Factor out common code for generating Resets

2007-09-26 Thread Arnaldo Carvalho de Melo
; * Code 2, Aborted; * Code 11, Aggression Penalty (12.3). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/dccp.h |2 ++ net/dccp/ipv4.c | 38 +- net/dccp/ipv6.c | 39

Re: [PATCHES 0/8][DCCP] More core work

2007-09-26 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 26, 2007 at 02:08:37PM -0700, David Miller escreveu: From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 15:39:00 -0300 Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24 Pulled, but I'd

My plans

2007-09-26 Thread Arnaldo Carvalho de Melo
Hi, Dave merged more 8 patches today, so I'm making progress on merging all the pending work, yay! I plan to continue working on the non-ccid patches that are easier to merge at this stage. Gerrit, so I think that right now for you the best is to continue working on your codebase, as

[PATCHES 0/2][DCCP]: Today's last batch

2007-09-26 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24 Thanks, - Arnaldo - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH v2 4/5]: Rate-limit DCCP-Syncs

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 10:58:41AM +0100, Gerrit Renker escreveu: Arnaldo - | Algorithm is fine, just use time_after when comparing jiffies based | timestamps, here: Many thanks for pointing this out - it was a stupid oversight. The interdiff to the previous patch is: *

Re: [PATCH v2 4/5]: Rate-limit DCCP-Syncs

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 01:16:53PM +0100, Gerrit Renker escreveu: | +/* rate-limit for syncs in reply to sequence-invalid packets; RFC 4340, 7.5.4 */ | +int sysctl_dccp_sync_ratelimit   __read_mostly = HZ / 8; | | Why the extra spaces/tabs before __read_mostly? This is for

Re: [PATCH 0/8]: Preparatory patches for feature negotiation

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 03:23:50PM +0100, Gerrit Renker escreveu: A small set of patches to prepare feature negotion, and one miscellaneous one. I will start step by step, the patches will be put into the test tree after the last batch has been set (although this time I made sure that patch

Re: [PATCH 1/8]: Add FIXME for send_delayed_ack

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 03:29:52PM +0100, Gerrit Renker escreveu: [DCCP]: Add FIXME for send_delayed_ack This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere used in the entire DCCP/CCID code. Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has

Re: [PATCH 7/8]: Handle timestamps on Request/Response exchange separately

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 03:30:48PM +0100, Gerrit Renker escreveu: [DCCP]: Handle timestamps on Request/Response exchange separately In DCCP, timestamps can occur on packets anytime, CCID3 uses a timestamp(/echo) on the Request/Response exchange. This patch addresses the following situation:

Re: [PATCH 8/8]: Support inserting options during the 3-way handshake

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 03:30:51PM +0100, Gerrit Renker escreveu: [DCCP]: Support inserting options during the 3-way handshake This provides a separate routine to insert options during the initial handshake. The main purpose is to conduct feature negotiation, for the moment the only user

tcpdump broken wrt CsCov CsVal parsing?

2007-09-22 Thread Arnaldo Carvalho de Melo
Trying to rebuild a proper test setup, so far using just loopback for simple tests I noticed this problem: 11:57:47.463084 IP localhost.40343 localhost.5001: CCVal 0, CsCov 5, cksum 0xf52a (correct), dataack (ack=115231163474841) 11:57:47.463095 IP localhost.5001 localhost.40343: CCVal 0,

Re: [PATCH 2/5]: Fix Reset/Sync-Flood Bug

2007-09-22 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 20, 2007 at 10:55:39AM +0100, Gerrit Renker escreveu: [DCCP]: Fix Reset/Sync-Flood Bug This updates sequence number checking with regard to RFC 4340, 7.5.4. Missing in the code was an exception for sequence-invalid Reset packets, which get a Sync acknowledging GSR, instead of

Re: [PATCH 4/5]: Rate-limit DCCP-Syncs

2007-09-22 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 20, 2007 at 10:56:03AM +0100, Gerrit Renker escreveu: [DCCP]: Rate-limit DCCP-Syncs This implements a SHOULD from RFC 4340, 7.5.4: To protect against denial-of-service attacks, DCCP implementations SHOULD impose a rate limit on DCCP-Syncs sent in response to sequence-invalid

[PATCHES 0/6][DCCP]: First merge session from Gerrit's tree

2007-09-22 Thread Arnaldo Carvalho de Melo
Hi David, I'm going thru Gerrit's tree, should take a while, its a whooping 86 patches! Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24.git Best Regards, - Arnaldo - To unsubscribe from this list: send the line unsubscribe dccp in the body of a

[PATCH 1/6] [DCCP]: Reuse ktime_get_real() calls again

2007-09-22 Thread Arnaldo Carvalho de Melo
Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 39 --- 1 files changed, 16 insertions(+), 23 deletions(-) diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index e75efe7..e16f9bb

[PATCH 2/6] [DCCP]: Provide 10s of microsecond timesource

2007-09-22 Thread Arnaldo Carvalho de Melo
] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/dccp.h|2 ++ net/dccp/options.c |2 +- net/dccp/proto.c |2 ++ net/dccp/timer.c | 21 + 4 files changed, 26 insertions(+), 1 deletions(-) diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h

[PATCH 4/6] [DCCP]: Shorten variable names in dccp_check_seqno

2007-09-22 Thread Arnaldo Carvalho de Melo
, all changes are text replacement/substitution. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/input.c | 40 +--- 1 files changed, 17

[PATCH 5/6] [DCCP]: Fix Reset/Sync-Flood Bug

2007-09-22 Thread Arnaldo Carvalho de Melo
, so that in (7) the vicious circle is broken; the Reset is then enqueued and causes the socket to enter TIMEWAIT state. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/input.c | 14

[PATCH 6/6] [DCCP]: Parameter renaming

2007-09-22 Thread Arnaldo Carvalho de Melo
in dccp_transmit_skb, there are no clashes with the use of dccpd_ack_seq; no other function is using this slot at the same time. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp

Re: unchanged functions between ccid-3 and ccid-4

2007-09-21 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 20, 2007 at 11:28:52PM -0300, ツ Leandro Sales escreveu: 2007/9/20, Ian McDonald [EMAIL PROTECTED]: On 9/21/07, ツ Leandro Sales [EMAIL PROTECTED] wrote: Hello Gerrit, From now and as I was talking to Ian two days ago, after our patchset for initial code of ccid-4, I'm

Re: [PATCH 2/4] CCID4: Provides organization to the initial entries for CCID 4 to net/dccp/ccids/Makefile

2007-09-21 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 21, 2007 at 05:02:40PM +0300, Tommi Saviranta escreveu: On Thu, Sep 20, 2007 at 14:54:32 -0300, ツ Leandro Sales wrote: diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile dccp-ccid4/net/dccp/ccids/Makefile --- dccp-ccid4.base/net/dccp/ccids/Makefile 2007-09-20 11:45:30.0

Re: [PATCHv2 2/3]: Provide 10s of microsecond timesource

2007-08-23 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 23, 2007 at 04:10:08PM +0100, Gerrit Renker escreveu: I have thought this over - the solutions I came up with were all complicated and I think it is not worth making it more complicated if the issue only occurs every 11.9 hours. But added a warning note in the timer comments, so

Re: [PATCH 2/3]: Provide 10s of microsecond timesource

2007-08-22 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 22, 2007 at 09:31:13AM +0100, Gerrit Renker escreveu: Quoting Arnaldo Carvalho de Melo: | [DCCP]: Provide 10s of microsecond timesource | | This provides a timesource, conveniently used for DCCP timestamps, which | returns the elapsed time in 10s of microseconds since

Re: [PATCH 2/3]: Provide 10s of microsecond timesource

2007-08-21 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 21, 2007 at 08:00:16PM +0100, Gerrit Renker escreveu: [DCCP]: Provide 10s of microsecond timesource This provides a timesource, conveniently used for DCCP timestamps, which returns the elapsed time in 10s of microseconds since initialisation. This makes for a wrap-around time

Re: About pluggable congestion control infrastructure in DCCP

2007-08-19 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 20, 2007 at 08:53:15AM +1200, Ian McDonald escreveu: On 8/20/07, Shahiduzzaman [EMAIL PROTECTED] wrote: Hi all, This may be a redundant or very naive question - sorry in advance for that. Can anybody tell me, whether the current Linux kernel DCCP implementation is done in a

[PATCH 03/15] Convert ccid3hctx_t_ld to ktime_t

2007-08-19 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 12 +--- net/dccp/ccids/ccid3.h |3 +-- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index d0763ad..42d3dbc 100644 --- a/net/dccp

[PATCH 04/15] Convert ccid3hcrx_tstamp_last_ack to ktime_t

2007-08-19 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 22 ++ net/dccp/ccids/ccid3.h |2 +- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 42d3dbc..63051eb 100644

[PATCH 08/15] [CCID3]: Stop using dccp_timestamp

2007-08-19 Thread Arnaldo Carvalho de Melo
Now to convert the ackvec code to ktime_t so that we can get rid of dccp_timestamp and the epoch thing in dccp_sock. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/net/dccp

[PATCH 13/15] [DCCP] options: convert dccp_insert_option_timestamp to ktime_t

2007-08-19 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/options.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/net/dccp/options.c b/net/dccp/options.c index 95b75d8..439e25d 100644 --- a/net/dccp/options.c +++ b/net/dccp/options.c @@ -388,11 +388,7

Re: Backporting gerrit tree (from git) to 2.6.18. IT WAS: Backport latest (git) DCCP code to 2.6.18

2007-08-18 Thread Arnaldo Carvalho de Melo
) and with kmen_create_cache (function ccid_kmem_cache_create) but I solved them. So, what do you suggest me to do? Thank you, Leandro. 2007/8/6, Arnaldo Carvalho de Melo [EMAIL PROTECTED]: Em Mon, Aug 06, 2007 at 09:55:49AM -0300, ?$B%D Leandro Sales escreveu: Hi folks, due to wireless card

Re: [PATCH] [148/2many] MAINTAINERS - DCCP PROTOCOL

2007-08-13 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 13, 2007 at 10:58:18AM -0700, Joe Perches escreveu: On Mon, 2007-08-13 at 21:19 +1200, Ian McDonald wrote: Provided this patch series goes in then we need to add this in as well as part of DCCP subsystem: F: include/linux/tfrc.h DCCP PROTOCOL P:Arnaldo Carvalho de Melo

Re: VLC - DCCP patch uploaded

2007-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 10, 2007 at 02:22:24PM +0100, Gerrit Renker escreveu: I have uploaded a patch to support DCCP in the Video Lan Client (www.videolan.org). With that, one can stream video/audio/capture cards (those guys from VLC have done a great job, it is well worth checking out), now also

Re: [PATCH 4/5]: Always support Ack Vectors

2007-07-27 Thread Arnaldo Carvalho de Melo
On 7/27/07, Gerrit Renker [EMAIL PROTECTED] wrote: Quoting Ian McDonald: | [DCCP]: Always support Ack Vectors | | This removes CONFIG_IP_DCCP_ACKVEC for reasons of inter-operability. | | In RFC 4340 requires CCID2 as a kind of default (section 10): | A DCCP implementation

Re: [PATCH 1/1][BUG-Fix]: Allocation in atomic context

2007-06-19 Thread Arnaldo Carvalho de Melo
On 6/19/07, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID2]: Allocation in atomic context This fixes the following bug reported in syslog: [ 4039.051658] BUG: sleeping function called from invalid context at /usr/src/davem-2.6/mm/slab.c:3032 [ 4039.051668] in_atomic():1, irqs_disabled():0 [

[PATCH 0/4]: DCCP ktime_t initial work

2007-06-17 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.23 I briefed Thomas Gleixner about the new ktime_us_delta and ktime_add_us functions and he is OK with having them added to ktime.h. More work on this are going on Gerrit

[PATCH 1/4] [KTIME]: Introduce ktime_us_delta

2007-06-17 Thread Arnaldo Carvalho de Melo
This provides a reusable time difference function which returns the difference in microseconds, as often used in the DCCP code. Commiter note: renamed ktime_delta to ktime_us_delta and put it in ktime.h. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo

[PATCH 2/4] [KTIME]: Introduce ktime_add_us

2007-06-17 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/ktime.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/ktime.h b/include/linux/ktime.h index a208f9f..9800bae 100644 --- a/include/linux/ktime.h +++ b/include/linux/ktime.h

[PATCH 3/4] [CCID3]: Sending time: update to ktime_t

2007-06-17 Thread Arnaldo Carvalho de Melo
Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 33 + net/dccp/ccids/ccid3.h |5 +++-- 2 files changed, 16 insertions(+), 22 deletions(-) diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 407f10c..94b3a1a 100644 --- a/net/dccp/ccids

[PATCH 4/4] [CCID3]: Fix a bug in the send time processing

2007-06-17 Thread Arnaldo Carvalho de Melo
, the packet will have its options added and window counter updated as required. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dccp

Re: [PATCH 1/3]: Inline for time delta

2007-06-16 Thread Arnaldo Carvalho de Melo
On 6/11/07, Gerrit Renker [EMAIL PROTECTED] wrote: Quoting Ian McDonald: | --- a/net/dccp/dccp.h | +++ b/net/dccp/dccp.h | @@ -421,6 +421,11 @@ static inline suseconds_t timeval_delta( | return secs * USEC_PER_SEC + usecs; | } | | +static inline s64 ktime_delta(ktime_t later,

Re: [PATCH 1/3]: Inline for time delta

2007-06-16 Thread Arnaldo Carvalho de Melo
On 6/16/07, Gerrit Renker [EMAIL PROTECTED] wrote: Quoting Arnaldo Carvalho de Melo: | The name was chosen for consistency with timeval_delta(), which is the current | function for microsecond time differences in net/dccp/dccp.h. | | I'm going to rename ktime_delta() to ktime_us_delta

<    1   2   3   4   5   >