On 5/10/07, Ian McDonald [EMAIL PROTECTED] wrote:
On 5/11/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 5/10/07, Ian McDonald [EMAIL PROTECTED] wrote:
This is just shifting code around and involves no renames except for module
initialisation. Also add/remove static, includes
On 5/11/07, Ian McDonald [EMAIL PROTECTED] wrote:
This shifts ccid3_li_hist.
We temporarily export the symbol but remove this in later patch.
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Ian,
Finally looking at this, sorry for taking so long. But I have
some issues with this loss
On 5/28/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 5/11/07, Ian McDonald [EMAIL PROTECTED] wrote:
This shifts ccid3_li_hist.
We temporarily export the symbol but remove this in later patch.
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Ian,
Finally looking
On 6/1/07, Ian McDonald [EMAIL PROTECTED] wrote:
On 6/2/07, Patrick Andrieux [EMAIL PROTECTED] wrote:
Hi again,
I find out what was the problem. I recompile the latest 2.6.20 kernel
with Ian's patches, and my iperf client doesn't freeze anymore. So I
guess there is something wrong in Dave
On 6/5/07, Patrick Andrieux [EMAIL PROTECTED] wrote:
Hi,
I have a segfault when inserting dccp_probe module on Dave Miller's
tree *without* Ian's patches. I got it using this cmd line :
Question, does it also segfaults _with_ Ian's patches?
do_page_fault+0x436/0x509
Jun 5 12:26:55
On 6/5/07, Patrick Andrieux [EMAIL PROTECTED] wrote:
No, I only tried on my arch, not a laptop but a desktop, intel P4.
And you are right, I've the same problem with `modprobe -v tcp_probe'.
Do you think the problem could come from my 2.6.22 kernel config ?
Because it works on 2.6.20-12 kernel
On 6/7/07, Florian Westphal [EMAIL PROTECTED] wrote:
Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
While transmitting data via dccp (Linux 2.6.21) I encountered this:
BUG: scheduling while atomic: firefox-bin/0x1100/6792
[..]
Can you try with the attached patch?
I haven't been
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.23
Regards,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
When compiling with EXTRA_CFLAGS=-W notice that we have signed/unsigned issue
in dccp.h.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
---
net/dccp/dccp.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net
When compiling with EXTRA_CFLAGS=-W noticed that tstamp is not initialised
correctly in dccp_li_calc_first_li.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |2 +-
1 files changed, 1 insertions(+), 1
This is a preparatory patch for moving these loss interval functions from
net/dccp/ccids/ccid3.c to net/dccp/ccids/lib/loss_interval.c.
Based on a patch by Ian McDonald.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 62
Now ccid3_hc_rx_update_li is ready to be moved to
net/dccp/ccids/lib/loss_interval, it uses the same interface as the other
functions there.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions
Renaming it to dccp_li_update_li.
Also based on previous work by Ian McDonald.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 179 ++--
net/dccp/ccids/lib/loss_interval.c | 160
Now its only used inside the loss_interval code.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/loss_interval.c |7 +++
net/dccp/ccids/lib/loss_interval.h |3 ---
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/net/dccp/ccids/lib
Not used outside the loss_interval code anymore.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/loss_interval.c | 14 ++
net/dccp/ccids/lib/loss_interval.h | 14 --
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/net
net/dccp/ccids/lib/loss_interval.c is the only place where this struct is used.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/loss_interval.c |9 +
net/dccp/ccids/lib/loss_interval.h | 10 --
2 files changed, 9 insertions(+), 10 deletions
On 6/11/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Ian McDonald:
| --- a/net/dccp/dccp.h
| +++ b/net/dccp/dccp.h
| @@ -421,6 +421,11 @@ static inline suseconds_t timeval_delta(
| return secs * USEC_PER_SEC + usecs;
| }
|
| +static inline s64 ktime_delta(ktime_t later,
On 6/16/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| The name was chosen for consistency with timeval_delta(), which is the
current
| function for microsecond time differences in net/dccp/dccp.h.
|
| I'm going to rename ktime_delta() to ktime_us_delta
On 6/16/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Thanks for the update.
Just for information - I will be updating all my patches based on this set of
10, as I expect them to be in David Miller's tree soon.
If people would like me to resubmit the updates, please give me a shout as I
will
On 6/16/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 6/16/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| The name was chosen for consistency with timeval_delta(), which is the
current
| function for microsecond time differences in net/dccp
On 6/16/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| I am going to change that in my tree as well, since I am busy updating
with regard
| to most recent changes anyway.
|
| I just checked with Thomas Gleixner, the ktime_t guy and he is ok with
| adding
On 6/11/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Ian McDonald:
| This looks OK but...
| -static void ccid3_hc_tx_update_x(struct sock *sk, struct timeval *now)
| +static void ccid3_hc_tx_update_x(struct sock *sk, ktime_t *stamp)
|
| I don't see callers updated. Is this what you
On 6/16/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| We'll have to avoid it, I'm looking at how to do it...
|
|
| I'm just stuck with t_ld not having being converted to ktime_t, so
| I'll fix this up by...
|
| - hctx-ccid3hctx_t_ld = now;
| + hctx
On 6/11/07, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Shorten statement for updating p
This shortens the statement for updating the loss event
rate p when a feedback packet is received.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |7 ++-
1 file
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.23
I briefed Thomas Gleixner about the new ktime_us_delta and
ktime_add_us functions and he is OK with having them added to ktime.h.
More work on this are going on Gerrit
This provides a reusable time difference function which returns the difference
in
microseconds, as often used in the DCCP code.
Commiter note: renamed ktime_delta to ktime_us_delta and put it in ktime.h.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/ktime.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/ktime.h b/include/linux/ktime.h
index a208f9f..9800bae 100644
--- a/include/linux/ktime.h
+++ b/include/linux/ktime.h
Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 33 +
net/dccp/ccids/ccid3.h |5 +++--
2 files changed, 16 insertions(+), 22 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 407f10c..94b3a1a 100644
--- a/net/dccp/ccids
, the packet will have its options added
and window counter updated as required.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp
On 6/19/07, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID2]: Allocation in atomic context
This fixes the following bug reported in syslog:
[ 4039.051658] BUG: sleeping function called from invalid context at
/usr/src/davem-2.6/mm/slab.c:3032
[ 4039.051668] in_atomic():1, irqs_disabled():0
[
On 7/27/07, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Ian McDonald:
| [DCCP]: Always support Ack Vectors
|
| This removes CONFIG_IP_DCCP_ACKVEC for reasons of inter-operability.
|
| In RFC 4340 requires CCID2 as a kind of default (section 10):
| A DCCP implementation
Em Fri, Aug 10, 2007 at 02:22:24PM +0100, Gerrit Renker escreveu:
I have uploaded a patch to support DCCP in the Video Lan Client
(www.videolan.org).
With that, one can stream video/audio/capture cards (those guys from VLC have
done
a great job, it is well worth checking out), now also
Em Mon, Aug 13, 2007 at 10:58:18AM -0700, Joe Perches escreveu:
On Mon, 2007-08-13 at 21:19 +1200, Ian McDonald wrote:
Provided this patch series goes in then we need to add this in as well
as part of DCCP subsystem:
F: include/linux/tfrc.h
DCCP PROTOCOL
P:Arnaldo Carvalho de Melo
) and with
kmen_create_cache (function ccid_kmem_cache_create) but I solved them.
So, what do you suggest me to do?
Thank you,
Leandro.
2007/8/6, Arnaldo Carvalho de Melo [EMAIL PROTECTED]:
Em Mon, Aug 06, 2007 at 09:55:49AM -0300, ?$B%D Leandro Sales escreveu:
Hi folks,
due to wireless card
Em Mon, Aug 20, 2007 at 08:53:15AM +1200, Ian McDonald escreveu:
On 8/20/07, Shahiduzzaman [EMAIL PROTECTED] wrote:
Hi all,
This may be a redundant or very naive question - sorry in advance for
that. Can anybody tell me, whether the current Linux kernel DCCP
implementation is done in a
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 12 +---
net/dccp/ccids/ccid3.h |3 +--
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index d0763ad..42d3dbc 100644
--- a/net/dccp
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 22 ++
net/dccp/ccids/ccid3.h |2 +-
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 42d3dbc..63051eb 100644
Now to convert the ackvec code to ktime_t so that we can get rid of
dccp_timestamp and the epoch thing in dccp_sock.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/net/dccp
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/options.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/net/dccp/options.c b/net/dccp/options.c
index 95b75d8..439e25d 100644
--- a/net/dccp/options.c
+++ b/net/dccp/options.c
@@ -388,11 +388,7
Em Tue, Aug 21, 2007 at 08:00:16PM +0100, Gerrit Renker escreveu:
[DCCP]: Provide 10s of microsecond timesource
This provides a timesource, conveniently used for DCCP timestamps, which
returns the elapsed time in 10s of microseconds since initialisation.
This makes for a wrap-around time
Em Wed, Aug 22, 2007 at 09:31:13AM +0100, Gerrit Renker escreveu:
Quoting Arnaldo Carvalho de Melo:
| [DCCP]: Provide 10s of microsecond timesource
|
| This provides a timesource, conveniently used for DCCP timestamps, which
| returns the elapsed time in 10s of microseconds since
Em Thu, Aug 23, 2007 at 04:10:08PM +0100, Gerrit Renker escreveu:
I have thought this over - the solutions I came up with were all complicated
and I think it is not worth making it more complicated if the issue only
occurs
every 11.9 hours. But added a warning note in the timer comments, so
Em Thu, Sep 20, 2007 at 11:28:52PM -0300, ツ Leandro Sales escreveu:
2007/9/20, Ian McDonald [EMAIL PROTECTED]:
On 9/21/07, ツ Leandro Sales [EMAIL PROTECTED] wrote:
Hello Gerrit,
From now and as I was talking to Ian two days ago, after our
patchset for initial code of ccid-4, I'm
Em Fri, Sep 21, 2007 at 05:02:40PM +0300, Tommi Saviranta escreveu:
On Thu, Sep 20, 2007 at 14:54:32 -0300, ツ Leandro Sales wrote:
diff -uprN dccp-ccid4.base/net/dccp/ccids/Makefile
dccp-ccid4/net/dccp/ccids/Makefile
--- dccp-ccid4.base/net/dccp/ccids/Makefile 2007-09-20 11:45:30.0
Trying to rebuild a proper test setup, so far using just loopback for
simple tests I noticed this problem:
11:57:47.463084 IP localhost.40343 localhost.5001: CCVal 0, CsCov 5, cksum
0xf52a (correct), dataack (ack=115231163474841)
11:57:47.463095 IP localhost.5001 localhost.40343: CCVal 0,
Em Wed, Jun 20, 2007 at 10:55:39AM +0100, Gerrit Renker escreveu:
[DCCP]: Fix Reset/Sync-Flood Bug
This updates sequence number checking with regard to RFC 4340, 7.5.4.
Missing in the code was an exception for sequence-invalid Reset packets,
which get a Sync acknowledging GSR, instead of
Em Wed, Jun 20, 2007 at 10:56:03AM +0100, Gerrit Renker escreveu:
[DCCP]: Rate-limit DCCP-Syncs
This implements a SHOULD from RFC 4340, 7.5.4:
To protect against denial-of-service attacks, DCCP implementations SHOULD
impose a rate limit on DCCP-Syncs sent in response to sequence-invalid
Hi David,
I'm going thru Gerrit's tree, should take a while, its a
whooping 86 patches! Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24.git
Best Regards,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a
Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 39 ---
1 files changed, 16 insertions(+), 23 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index e75efe7..e16f9bb
]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h|2 ++
net/dccp/options.c |2 +-
net/dccp/proto.c |2 ++
net/dccp/timer.c | 21 +
4 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
, all changes are text replacement/substitution.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/input.c | 40 +---
1 files changed, 17
, so that in (7)
the vicious circle is broken; the Reset is then enqueued and causes the
socket to enter TIMEWAIT state.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/input.c | 14
in dccp_transmit_skb,
there are no clashes with the use of dccpd_ack_seq; no other function is
using this slot at the same time.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp
Em Tue, Sep 25, 2007 at 10:58:41AM +0100, Gerrit Renker escreveu:
Arnaldo -
| Algorithm is fine, just use time_after when comparing jiffies based
| timestamps, here:
Many thanks for pointing this out - it was a stupid oversight. The interdiff
to the previous patch is:
*
Em Tue, Sep 25, 2007 at 01:16:53PM +0100, Gerrit Renker escreveu:
| +/* rate-limit for syncs in reply to sequence-invalid packets; RFC 4340,
7.5.4 */
| +int sysctl_dccp_sync_ratelimit __read_mostly = HZ / 8;
|
| Why the extra spaces/tabs before __read_mostly?
This is for
Em Tue, Sep 25, 2007 at 03:23:50PM +0100, Gerrit Renker escreveu:
A small set of patches to prepare feature negotion, and one miscellaneous one.
I will start step by step, the patches will be put into the test tree after
the
last batch has been set (although this time I made sure that patch
Em Tue, Sep 25, 2007 at 03:29:52PM +0100, Gerrit Renker escreveu:
[DCCP]: Add FIXME for send_delayed_ack
This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere
used in the entire DCCP/CCID code.
Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has
Em Tue, Sep 25, 2007 at 03:30:48PM +0100, Gerrit Renker escreveu:
[DCCP]: Handle timestamps on Request/Response exchange separately
In DCCP, timestamps can occur on packets anytime, CCID3 uses a
timestamp(/echo) on the Request/Response
exchange. This patch addresses the following situation:
Em Tue, Sep 25, 2007 at 03:30:51PM +0100, Gerrit Renker escreveu:
[DCCP]: Support inserting options during the 3-way handshake
This provides a separate routine to insert options during the initial
handshake.
The main purpose is to conduct feature negotiation, for the moment the only
user
Em Wed, Sep 26, 2007 at 10:04:22AM +0100, Gerrit Renker escreveu:
Quoting Arnaldo Carvalho de Melo:
| --- a/net/dccp/options.c
| +++ b/net/dccp/options.c
| @@ -160,7 +160,7 @@ int dccp_parse_options(struct sock *sk,
| if (len != 4
Em Wed, Sep 26, 2007 at 10:19:48AM -0300, ツ Leandro Sales escreveu:
Hi,
according to ccid-4 internet draft, the estimated header size on
data packets is 36 bytes (20 bytes for the IP header and 16 bytes for
the DCCP-data header with 48-bit sequence numbers). The header size
would be 32
Em Tue, Sep 25, 2007 at 09:08:29AM +0100, Gerrit Renker escreveu:
| On 9/23/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
| Trying to rebuild a proper test setup, so far using just loopback for
| simple tests I noticed this problem:
|
| Who was the last person to touch
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24
Best Regards,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/input.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/dccp/input.c b/net/dccp/input.c
index cde0e70..86ad3ba 100644
--- a/net/dccp/input.c
+++ b/net/dccp/input.c
@@ -540,11 +540,6 @@ int dccp_rcv_state_process
think leaving the function in is good, in case someone wants to implement
this.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |1 -
net/dccp/output.c |1 +
2 files changed, 1 insertions(+), 1 deletions(-)
diff
errors.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h | 14 ++
net/dccp/dccp.h | 14 +-
2 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/include/linux/dccp.h b
.
The only thing that has been removed is the call to dst_clone(dst), since
the queue_xmit functions use sk_dst_cache anyway.
I wasn't sure which purpose inet_sk_rebuild_header served, so I left it in.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL
sending a sync.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
Documentation/networking/dccp.txt |5 +
include/linux/dccp.h |2 ++
net/dccp/dccp.h
This replaces normal addition with mod-48 addition so that sequence number
wraparound is respected.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ipv4.c |2 +-
net/dccp/ipv6
;
* Code 2, Aborted;
* Code 11, Aggression Penalty (12.3).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |2 ++
net/dccp/ipv4.c | 38 +-
net/dccp/ipv6.c | 39
Em Wed, Sep 26, 2007 at 02:08:37PM -0700, David Miller escreveu:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Wed, 26 Sep 2007 15:39:00 -0300
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24
Pulled, but I'd
Hi,
Dave merged more 8 patches today, so I'm making progress on
merging all the pending work, yay! I plan to continue working on
the non-ccid patches that are easier to merge at this stage.
Gerrit, so I think that right now for you the best is to continue
working on your codebase, as
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.24
Thanks,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
also added.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/output.c | 34 +++---
1 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/net
Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
Documentation/networking/dccp.txt |3 +++
include/linux/dccp.h |1 +
net/dccp/proto.c |4
3 files changed, 8 insertions
This just sets the parameter to bool, since debugging messages
are either on or off.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c |2 +-
net/dccp/ccids/ccid3.c
This adds documentation on the use of service codes on
client and server.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
Documentation/networking/dccp.txt |8 +---
1 files changed
), but that requires
more complicated changes to the algorithm; thus a `FIXME' has been added.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions
skb's passed to ccid2_hc_tx_send_packet() are headerless, the
packet type is decided later, in dccp_write_xmit(). Therefore
the first test of the switch/case block is always true, the
others are never reached.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo
the incremented ccid2hctx_rpseq == seqno, used assignment instead.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/dccp/ccids
PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h |1 -
net/dccp/minisocks.c | 10 ++
net/dccp/options.c | 10 --
3 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/include/linux/dccp.h b/include/linux/dccp.h
index
the behaviour here also (not
done by this patch).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ipv4.c | 11 ---
net/dccp/ipv6.c |7 +++
2 files changed, 7
Em Sat, Sep 29, 2007 at 05:24:18PM +0100, Gerrit Renker escreveu:
Quoting Arnaldo Carvalho de Melo:
| +static u8 builtin_ccids[] = {
| + DCCPC_CCID2,/* CCID2 is supported by default */
| +#if defined(CONFIG_IP_DCCP_CCID3) ||
defined(CONFIG_IP_DCCP_CCID3_MODULE
Em Thu, Jul 12, 2007 at 03:23:39PM +0100, Gerrit Renker escreveu:
[DCCP]: Dedicated auxiliary states to support passive-close
This adds two auxiliary states to deal with passive closes:
* PASSIVE_1 (reached from OPEN via reception of Close) and
* PASSIVE_2 (reached from OPEN via
Em Mon, Oct 01, 2007 at 03:18:11PM +0100, Gerrit Renker escreveu:
[DCCP]: Auxiliary function for smallest-fit option lengths
This introduces a function to determine the smallest-fit data type to carry
options,
which is used by the feature-negotiation code to insert option values.
While
Em Tue, Oct 02, 2007 at 09:07:24AM +1300, Ian McDonald escreveu:
On 10/2/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
He used a designated initializer, i.e. he said at which index in the
array it the value is to be set. So it really doesn't matter the order.
And when checking
Em Tue, Oct 02, 2007 at 01:06:55PM +0100, Gerrit Renker escreveu:
Reworked patch thanks to suggestions by Ian. Changes:
* removed on/off constants
* used reserved feature number instead of reserved pointer value (NULL)
to mark the end of table; marked this in the commit message
* all
solution is planned.
I'd need to know so that I can rework the patches and resubmit them
accordingly.
Quoting Gerrit Renker:
| Quoting Arnaldo Carvalho de Melo:
| | I suggest it to become:
| |
| | [EMAIL PROTECTED] net-2.6.24]$ pahole -C dccp_request_sock
net/dccp/minisocks.o
Em Sat, Oct 20, 2007 at 07:03:49PM -0200, Arnaldo Carvalho de Melo escreveu:
Em Sat, Oct 20, 2007 at 04:54:35PM +0100, Gerrit Renker escreveu:
I have a question/suggestion for DCCP/CCID field names, which have a
tendency to grow
into really_quite_long_strings. The convention for field
Em Sat, Oct 20, 2007 at 04:54:35PM +0100, Gerrit Renker escreveu:
I have a question/suggestion for DCCP/CCID field names, which have a tendency
to grow
into really_quite_long_strings. The convention for field members seems to be
x-x_fieldname
Examples are in particular
*
CCing dccp@vger.kernel.org, since I wrote a nice description about
this new toy :)
Em Mon, Oct 22, 2007 at 03:24:41PM +0100, Gerrit Renker escreveu:
| perhaps one that could understand types and then could allow developers
| to ask questions like show me all the places where the field foo of
Just like UDP.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED]
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index cc9bf1c..723c29e 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -26,6 +26,7 @@
#include net/sock.h
PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h |2 ++
net/dccp/input.c | 48 +++-
2 files changed, 41 insertions(+), 9 deletions(-)
diff --git a/include/linux
/0x880 [dccp]
by using the get_unaligned macro for parsing options.
Commiter note: Preserved the sparse __be{16,32} annotations.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids
I have no problems with this one. Shortens the namespace while keeping
it.
- Arnaldo
Em Wed, Oct 24, 2007 at 01:31:05PM +0100, Gerrit Renker escreveu:
Arnaldo can you please indicate if you are ok with this - there are other Ack
Vector
patches in the pipeline, and I would change them
Em Wed, Oct 24, 2007 at 02:35:42PM +0100, Gerrit Renker escreveu:
Quoting Arnaldo Carvalho de Melo:
| I think that dccpprobe.c is the wrong name ... it should really be
called ccid3_probe.c ...
| I have been working on printing entries for CCID2, since in ccid2.c
there is no probe
Em Wed, Oct 24, 2007 at 04:26:44PM +0100, Gerrit Renker escreveu:
After discussion with Arnaldo, I have decided to remove the following patch
from the test tree
--
[DCCP]: Collect all scattered sysctl
Em Thu, Oct 25, 2007 at 03:03:55PM +0100, Gerrit Renker escreveu:
| The full sources for the tapsets used (for things like
ccid3_hc_tx_sk_rtt(), etc) are at:
|
| http://oops.ghostprotocols.net:81/acme/nettaps.tar.bz2
|
This is awesome. Is all that is needed to run these a new
Em Wed, Oct 31, 2007 at 09:59:14AM +, Gerrit Renker escreveu:
I have a suggestion regarding types, names, and things shared between
CCID3 and CCID4 via dccp_tfrc_lib:
I think it would be best to name all such shared structures / names,
when they are to appear in the dccp_tfrc_lib, as
Em Wed, Oct 31, 2007 at 09:31:40PM -0300, Leandro escreveu:
[CCID-4] Basic implementation for ccid-4 dropped packet option as per ccid-4
draft
Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED]
Index: leandro.new/net/dccp/ccids/lib/tfrc_ccids.h
201 - 300 of 422 matches
Mail list logo
